From nobody Sun May 19 10:57:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=aol.com ARC-Seal: i=1; a=rsa-sha256; t=1673305744; cv=none; d=zohomail.com; s=zohoarc; b=cEDU6PZuNh2xHASFIYxU/8OsWJINmQw2OHTSxFaBJ9EW5X4xLKamyKzuVO+nEAdFt0JOHeN+50LwAb6s3Un5hUgpldKt2txGpszddYN1bcdceDQ1r8SZfshdM+1B4e4J71WyNlRwm1Na+XI5C8EQYkIcaHfmyJIBylCzYS7GulA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673305744; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PUsS/L6kSgEs9TSDYOSdibVZnoomFtUQ/2FTOn4ShZk=; b=TKK8j3owc/s6BiusuvA7zajfvs4Qvt4ejcKrV7XAFfrnljrGT+Lw7pI+KwIsq4O4W9axKxifQy3z4X7cqfbItzRjvvadQPs1n4YfYzz6p9Z2sOhSoC3L9QrkfvrwHhjwmVEeHqcoPjvcJ1KjiLxqiVyIFMv/0Q5ITUaSCB99gfw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 16733057444210.11871086874646153; Mon, 9 Jan 2023 15:09:04 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.474080.735000 (Exim 4.92) (envelope-from ) id 1pF1Fu-0008Eu-4v; Mon, 09 Jan 2023 23:08:38 +0000 Received: by outflank-mailman (output) from mailman id 474080.735000; Mon, 09 Jan 2023 23:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fu-0008En-1S; Mon, 09 Jan 2023 23:08:38 +0000 Received: by outflank-mailman (input) for mailman id 474080; Mon, 09 Jan 2023 23:08:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fs-0008EZ-Aa for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:08:36 +0000 Received: from sonic313-20.consmr.mail.gq1.yahoo.com (sonic313-20.consmr.mail.gq1.yahoo.com [98.137.65.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 897301bb-9072-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 00:08:34 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 23:08:31 +0000 Received: by hermes--production-ne1-7b69748c4d-bgkrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 21a3ec8339abfccbadeaea4f5ef812e7; Mon, 09 Jan 2023 23:08:29 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 897301bb-9072-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673305711; bh=PUsS/L6kSgEs9TSDYOSdibVZnoomFtUQ/2FTOn4ShZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=elXzfvBDLs+x3PQygRw4UOuVqtKHJNztSmeANXFZPKbkjXODD9HVpM6UngsfZNCsUNy2JDgYBHu+ln6Crtg2AcIwICBkBig4MOQJgkIIALddShN1H8ppOWXhxpZFtNqAuktS00wFZqfg6lJ6O7PfrQUbnQy0ZmqYChoK6Pm/JDcuDg8YuX85J6rdPWZxmc4dFbvcBTZ8lNd98XtbK9IBE9yBkNvF1HtzZ7S1SL46zDEXLUHwWJPNfgXiTkS5gbbxVINtGupzdxS50bsCoBeI//O5rV9YHJX+IKfI4jk4NELWBvL+SQWSxj+i/SA3aO3s1dV/gFfSo1b5xBUMVvwpEg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673305711; bh=Du1eQd5e3lE/n5cyxqbZF1SqsJq9/TIrud4RmL1t+rv=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=EqV1L9DzWBpmfjNT6DFmkvoslb9Tg0hh8943F8fvkbDYhCgCHBpJqoQVumBZeY08ibePhnHlkXpveZRSrdMUqytQo4u9kfYqyZ4+ckXTdRhBMZv7gbcYA4SVCYJzBsWUZrnkJqGHd6LaUdQljLqlh2ca1JDIcwOebu/Q4QCMXuclPnkF3S/gfpmaGRd47J7SkG26zqaQs1o0fFU4LOtcyjB+qFZU4ihv2pYSF+teGpMfou11wxdiAS3urJWtN5XJDa2ihQFKWPTaP7N/OnZLYjGVSxtdtH1+jBssGCcUyUE5/mA2qT3gnDHnEU2swYrLfP09hCiITR5uyu9QWabHzw== X-YMail-OSG: PJkcDlwVM1lwBDfcA1m84Ixzd3yJi0Uf9wXfCxi14xWsP7d2Dz_7xD4xwfXISN0 S4FRMFHbwmhIgyW8dmdIzZoWOsKWjLgoF26iGIv8uIDAfyJvT1rFijVrMyqxzUy5akZQJUkz9Fw0 HCaX84s2BoEsxvktlpclY_yQ5h0JUyqRm4UCim69OvADBtF69i8Ab8cUEg6JUDTA6QqU_3JyEMWB Zs3v48oGLjN72Ais3RueIiHIVLjJZ3LYIE6Ekv_jUimru4MItuEzesvjXWCtFnHBTHS8QnXCa2Mt 6MyniOP7xTFs6nrXWMdJBSOHjYKIIYlYI4iLRR7NwXDKQRq1MSLfDazgHluwHu1B.XrcdZTg6kbW nUVvV7KmS43Ut6hhA_pdqxx7O7HVOZU_8.On6FPb.sA4OpM1YPV.8LNMmvGKIIv25KGoPBTjOCw0 Hhf5aAFSYxXr2.dLa6Ibdl5tCW4IRpnl.Wr_Uj69kG561wt_ZpuvMgwx.t4iz5kj9w8nY8lMB_sh 7ehNLAskNXHSfN7.vbPVIP4Nf6P6xvoBHUkyY8RrmWOm8uZz0IXmTm5dk37fE.M8RMreIizdqhYA 8wmnK.xMHeuQqWTp6fySym01Oi95JDpuRyGzB5sUVkV7CbFj.B_0oIkQuvyyvu714Gps1rPQ8ghE _Jp4XciK2Yd9LAkcBG2us9uscEWVU.dnKOnOIovxJjy.2RE4M5qKGqJY_owlS5Aov8Qn9gS2H_Gc 6sMfwa1K0P_uIS00zid89Vz8EkSL_Pz9z84DQkGGaTxHIXTAWgdP10mprFJEedPpJK1klo4_ZOpq 152jGan8ZavdZkAlnUSh8OcsU32EWsJZ3giSDVzIR9doWzfk1WG4Ds7poOWoYmYSwWPWqquP1p0u 235z7EbNoLQNSoWKkcc9F1sbc9NwrQ9y.Z2Fl.FNKLi0tvy7gv70wEO10DBnxi5FIGjxFOVlwYuj U4m0kPQ5xMyxWJyIOk.SyXGqQZykyPO05HpBCe2qefOU.PC7hWAYIHUPesan24nndXEPjHrq7OSh 5xq6bsijRSCjG3kUkBKvBrRwJslhnVQihmIO8Pf4M69MbR8qWYF0Oo6_v3SQdRym6nXSne0vcekx xn0DQFqdBWWNp1qY2zq5hJR33nq88w.xlyLsGeo95aw5Zmybm_BjKH8PF7kpbPcGP7LKEgJ44EZq vK06TfWuqMhOFc5C9vVQNgWF.6C2LP6Fx9ROsICTEwwNvbFedYHHfoUX1Fp_KWk0oWATok7Hi9wt TpCCR1WKnKZiFj.mdJ6V0EFtC7xuhySoRzISE3offXLCjfA3GUAyJz2kwaFi2_Ktx1QBDNqBM4OY LzSh40kEefxWiQKIeWgtJEIwlHHRtFVd3OQN8CAsKQNqzKrUo6iXweRhLtebWryw9SW72ZMDIZ0x qPQI80yamRENR5vvAbn9jc1ZB.2fT9pVrvkHekVkctLUnykNHZIK5zRzqn5t3KesTAAbagjFvGAj .sVXeSTT1p1CWJ_EaVxHi76Vu5.5SuD.QCMOHnZKhzYydG0QVA8hTMSzAv8.FrVFubj1zAsvzhc4 Wv7evMcbCTkZVnQIKLUvfFiWUYcTATWbTYB72kTqwuiag34m9DTdF3TGv3usYpNCufF8L.PSXZbu YG7onspgwGcxqrBYJ72t_xZ07YyzgZX2ao1yl1U.dcUkbbHYPdtr.ThkapBpFfuTLoxxfqU70ug2 cHmSgF9Ftgxb8tXIQsWjGJFt8F5pZJukq8h3ymGMywD35Ga1SFcxNLjwDmuZufEXJfsm4qlF_8gy FMZTnw80uNNLhAKM0XqaZpO2LuFC5JicviG0wilgsRH9kepIKWlwy3JqfUJtk2Ppsvqei0yumIhk ixUKrFiSOAEDyutmFkY6_VHIDLSoiC6CWmwyB5cYSPLLeL0oPpg0JBiU8lEi.PTkvvrndoMMkcNT FKNq3xtVB9mbkLGjx8sAacZ2EKKgW7CWr00ZiKJ4i1HAr07bBOr3_XHixAPdjvatOjV2v7gZx0Ck aZFUySehhNN1lNz5X8EswtAZFZq5T2lH9HLQ2S4i75t4Q2cNs7ODtY.g3jKIMDhqLn4A9_yKNiGJ XMeJayOJhqZPcG5XrpWz4z9UXG58tS9o_Ya_Dtfa.34.FheRV02vFB6U5PxAmgzQDh8uiUwNSxag oaut6Sy1dy9cuOPNcK6SsGMswTpB5v9zuBBiHSObxx9i.GtyqTuPLrMU5Jvv4un9CeKPy X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH 1/3] libxl/dm: Use "pc" machine type for Intel IGD passthrough Date: Mon, 9 Jan 2023 18:08:11 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Length: 4646 X-ZohoMail-DKIM: pass (identity @aol.com) X-ZM-MESSAGEID: 1673305746722100005 Content-Type: text/plain; charset="utf-8" The default qemu upstream "xenfv" machine type that is used when an HVM guest is configured for Intel IGD passthrough assigns slot 2 to the xen platform pci device. It is a requirement that slot 2 be assigned to the Intel IGD when it is passed through as the primary graphics adapter. Using the "pc" machine type instead of the "xenfv" machine type in that case makes it possible for qemu upstream to assign slot 2 to the IGD. Using the qemu "pc" machine and adding the xen platform device on the qemu command line instead of using the qemu "xenfv" machine which automatically adds the xen platform device earlier in the guest creation process does come with some degredation of startup performance: startup is slower and some vga drivers in use during early boot are unable to display the screen at the native resolution of the monitor, but once the guest operating system (Windows or Linux) is fully loaded, there is no noticeable difference in the performance of the guest when using the "pc" machine type instead of the "xenfv" machine type. With this patch, libxl continues to use default "xenfv" machine type with the default settings of xen_platform_pci enabled and igd gfx_passthru disabled. The patch only affects machines configured with gfx_passthru enabled. Signed-off-by: Chuck Zmudzinski --- Reviewers might find this patch easier to review by looking at the resulting code in the patched file instead of looking at the diff because it is hard to follow the logical flow of the resulting code in the diff because the patch moves the check for igd gfx_passthru before the check for disabling the xen platform device. That change was made because it results in a more simplified logical flow in the resulting code. tools/libs/light/libxl_dm.c | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index fc264a3a13..2048815611 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1809,7 +1809,26 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, flexarray_append(dm_args, b_info->extra_pv[i]); break; case LIBXL_DOMAIN_TYPE_HVM: - if (!libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { + if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { + enum libxl_gfx_passthru_kind gfx_passthru_kind =3D + libxl__detect_gfx_passthru_kind(gc, guest_conf= ig); + switch (gfx_passthru_kind) { + case LIBXL_GFX_PASSTHRU_KIND_IGD: + /* + * Using the machine "pc" because with the default machine= "xenfv" + * the xen-platform device will be assigned to slot 2, but= with + * GFX_PASSTHRU_KIND_IGD, slot 2 needs to be reserved for = the Intel IGD. + */ + machinearg =3D libxl__strdup(gc, "pc,accel=3Dxen,suppress-= vmdesc=3Don,igd-passthru=3Don"); + break; + case LIBXL_GFX_PASSTHRU_KIND_DEFAULT: + LOGD(ERROR, guest_domid, "unable to detect required gfx_pa= ssthru_kind"); + return ERROR_FAIL; + default: + LOGD(ERROR, guest_domid, "invalid value for gfx_passthru_k= ind"); + return ERROR_INVAL; + } + } else if (!libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { /* Switching here to the machine "pc" which does not add * the xen-platform device instead of the default "xenfv" mach= ine. */ @@ -1831,22 +1850,6 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, } } =20 - if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { - enum libxl_gfx_passthru_kind gfx_passthru_kind =3D - libxl__detect_gfx_passthru_kind(gc, guest_conf= ig); - switch (gfx_passthru_kind) { - case LIBXL_GFX_PASSTHRU_KIND_IGD: - machinearg =3D GCSPRINTF("%s,igd-passthru=3Don", machinear= g); - break; - case LIBXL_GFX_PASSTHRU_KIND_DEFAULT: - LOGD(ERROR, guest_domid, "unable to detect required gfx_pa= ssthru_kind"); - return ERROR_FAIL; - default: - LOGD(ERROR, guest_domid, "invalid value for gfx_passthru_k= ind"); - return ERROR_INVAL; - } - } - flexarray_append(dm_args, machinearg); for (i =3D 0; b_info->extra_hvm && b_info->extra_hvm[i] !=3D NULL;= i++) flexarray_append(dm_args, b_info->extra_hvm[i]); --=20 2.39.0 From nobody Sun May 19 10:57:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=aol.com ARC-Seal: i=1; a=rsa-sha256; t=1673305744; cv=none; d=zohomail.com; s=zohoarc; b=JfU288zJ+UZ1AKMDfIYVSSZFQmktg712MYsZfHkwhp01fTbMwosNE/tBIcpyntKfObiqksqSFVfyD60BN3fXcHB5YPNBjqDi7mH0lO1GTZVG94MfFNWJaiYYuxckHTCXAM8zS1OHjdKQUlTBGSwG2mTQNAbwRs94WVC0dkupkRw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673305744; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6KQQVKXjX5bPI5/yTS20Ov1Ty8T7qISVmf3UrSeOprM=; b=SAVsuUtbDzuAyVppW7c3hm4F6RrBeVEkqwmxV7TJiA+P8ITlyE8loh/wkm8qdVpomITF9qZEnt4beRH3IsBDcVbyXv4zy+5v5O7mySqvzZp1MvzufcUQ4PTa02f5l8PTBQhh9qeKq9POVjtrpmeQzSOrUB6gK8YoIem3e9Ov3o0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1673305744670660.7945157516795; Mon, 9 Jan 2023 15:09:04 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.474082.735022 (Exim 4.92) (envelope-from ) id 1pF1Fx-0000KR-U2; Mon, 09 Jan 2023 23:08:41 +0000 Received: by outflank-mailman (output) from mailman id 474082.735022; Mon, 09 Jan 2023 23:08:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fx-0000KE-P5; Mon, 09 Jan 2023 23:08:41 +0000 Received: by outflank-mailman (input) for mailman id 474082; Mon, 09 Jan 2023 23:08:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fx-0000Gp-3m for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:08:41 +0000 Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b4624a4-9072-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 00:08:37 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 23:08:34 +0000 Received: by hermes--production-ne1-7b69748c4d-bgkrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 21a3ec8339abfccbadeaea4f5ef812e7; Mon, 09 Jan 2023 23:08:30 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b4624a4-9072-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673305714; bh=6KQQVKXjX5bPI5/yTS20Ov1Ty8T7qISVmf3UrSeOprM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=PEM0aNGEXQPaqvoOKMU9QyD96JQr5zHZqkD3XdTeUDsr8UOaeO2eUCcfQC8eUzj6YvlHwhREB8BQeTAA/fQhhnLV0bKpwkosy3XaDR0++D6Wq93pLvBsp+lRLNsFhCuWe3S83y3GIsiZEoApYIhP38XFQgkU+V+71RWck/3sk4kRGGMqtlH6sKiY363PxXu0Pp6blaUbHk86dzsEIsJFAniHkUC4t6o9EUP0FenDRBc96qq8e1/py4lFl3kNKV8Uqbxi+kTSq/tFpbRpA7+M1GnZe1jb8gvYAevKFVGgBhSszHjhIDGF8HSfj4sU+V0J9DwCKKpmQ016z3jZHkau7Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673305714; bh=TWHL1z/CiE8ohTN0zQTQknjD74chjKnA+HPUBhabmew=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=I437GwK+vEuJyjpv7CsRTSm8h0S7JdolI9aSALXd3nUkdhdF0+9Rw+S3/c17bfn02+Y5ASvsOvQtH3sCGgDN5YQui32Fwk2uF4YB7bwAHB5oBhaYbLqJSIIWY+tf527R72vhgT8WtiEXzgFI/fBkgXYzw7oQtnd6Ol627Da5KIO5w23DDfeK6CIGwR1BWaFCoRVXVV/6MZjS+vVeyk9rYAAcDUKK1iWBX2HbRAFODD0C3RbeKWslcXDmab4ENB9jJ3WKua2B4tKlT9787hAHNbi3rANRTgSvQ+DU7jxNLxMtocnfpavdKqWTUA+PNkNwUZZMttoQXtgD9tHKNa8sqg== X-YMail-OSG: TbIfoPMVM1nDGed1NwkTCQurEHl4PZPKruQylL5Hfy_lsaQ34xXGdbcXGGcz8am 8KJ3zw1NlRjxXHSr1eJ2CCCcc8cQXw9nuJOxp.Y4tDdG9CilO4rrYXGde8Dfq1reHiJI_i.yqRCx XH6.YOOuxme2R5T.xbG0cSV.Tumu_kxNn9.WFFwc.TSc.29n0butPjuBbKl3.txxAnvr4sDB62h2 3C7eLySTsMLflK5qUt.kXrUVnHscxQP5tuInMo3Va6QDqqaL6I2O9pP8kZmLQg8NHETXfDmfNsyE NoMlZ2bInDyLN83vRWmC.fjInk6BU6f7eIsBe0OimYgnJEDZr8rv8VSTdi4rZspZNKQ9pX8P7Vjd d26N6Eoq4q_SvEgRukC4zGKG3w4.0pwgDOGAm73WrglGtDStfxu1jIH.G0zlp.IK_6JT6d6ScOxA qBCDD2crReqSBoNN_TzI6kWyaOdFEzEsMb.8gSrdmllucEwAIQ.fPLAgG262ujb6dOR84CwPygqX XjGFubEyFEWcmqiCADQ1FNwfWatojDAkTExNRDXdUxzb.Xlxnd_sXWRaukLy9MFuKN5SeKlGta85 KsHUJtjeC6azaYF2f0UpwaQCgunfxGsKdWgIeSTfBOp0mv.laMaeWZIpyrHsKJMbMzRdmAZDPkK6 tetP.YQw0kFRdANd_dr.._hfKRwQNDMvcA9QpL6Fs2elpdZb5iOLD7yZKa2rGIjhUwdLP.ctmqXB pIVDGknG5jbjwWtkJ9eHu5vImPnyYrRosnL.bv6KYZ10UbhQvOis2r14LSOmYG9QGg8crk4DCX0J YpU6RQlIDSb9rYQfrZ1.47Al3y7xSUPJjGZNxBdwF6NvpbbxM_v3N8ke2r_HEDuLqw9xxbmV3bfk Lj1N7rit_LaGiBkEJ.fVR5leLuFP.3bhp35g3PErXf_3ZkQcsu3mMjHbr0JXPCuOIkc4rhha4yBj 08LJUWfGhkWbtunQ6sEroWoB6QksKPI9ONH6y7e9btZE0dkzcXylmSFec8Y22Rm0d.kM0aJzd0yH wpyq.aNkTmKVyu394N17gULzDAHnO23jRsss6c5BN6AVZyrnxnYn._HJItmMaW5BrOSiebL4mlFa rs4zckGkbgNP8tfoc1ox6fSKVqB3ss9r8aW4OpXTgviIfLtQOda85apY02DCIq_lgukBHdNocZKC WM2fw8XlHdgm.vOTjHZGqmXbOPL27Mdw7HdyxGRHZMHIDpSRFhrH8JuFdJ_L.nc8kIFaBponEOAV OLbC_jieWUmMdKXlWv7j1bJnl84nPcawtY6T4ajxMdnBOtEy6QfBF.dNM1mHTeZdKm4xUtevFTec ntLNdcVkRs1SFJH6S5KjAiIFQbgSUSdSJ14FN2H9PyeYUGgHTddjB6pQ27KfnR5z1gupN8WN.esE UCY098ePhnithkcajn.c_tABPP4HIe_jNXZXH0PDLDEEVeQS95xIsEPIzyxfYizHF56kuq60KYe4 h9WcjhSXPLtidm_fyK0dbdKhiimScIsrirgxSy6WZ8sHYFJ0IX1SsjYiMeq7lox.lNEk8CREHM92 bgcOG88uyw.KsK2cFD.lj0TFlfG2Rpb2s0UJwrco7Nnpr.lCpn.ByvGSr.C6HVRCT530cLhI_vUs EqdwmNCasN.zcYmqUVH4LD7_zM07vZju7CkxHfP__3pWP.Q8bcX4oRWUgTxlZOQuK5e9iVzPElLO bzTHZzlbLc.0v7dX5dV95Zba9M395Yo0HdgyKGR7NUnF1VGd7Y0qFlC5tJ7ei5c_vkq6fGvP6E04 s2b7n7IgIMZgq_WJ2_kFQ1i5t7tmpqNjOsqn5.yQz3KL1d555sYEuku.aqF1sbBwDQNF9M.Tfjkw UsW1h6xASufEA_XmYbd4eQuRz3UJF551d.qvx.DiWZyXxP39hJhXnk_IGsArpAsI2MGxd_CngflA o8b4LEfjVUjev696HkHyZD0UG_Ydm.58C8_5km2VzkCOdKQM8Ula61X.ld84oFv83N3Gxcf82MXW mN0lwv9_y8DoWZoL6Kq5AtcAEjx5CNQRD2vz2GFNd8D5XgsxqZrV3JaR0B6RAG84OKk1v4.6FVvT EDyCdVXuhrqTy7RWME1YAyMfWQHxrhOqZ4dpxw7uTBG367fnglB1.JdIKvdS6C9EC3wXmBolmi1y XEwACp5xf8ktCagD_XZauILSdQ7gL46G_f2W3EDrW9EcleRLg083XsJAc6sxAYSNMy5yKEanA3rc - X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH 2/3] libxl/dm: Manage pci slot assignment for Intel IGD passthrough Date: Mon, 9 Jan 2023 18:08:12 -0500 Message-Id: <76d06f5d01e01df316230def4f31037695f11c1a.1673300848.git.brchuckz@aol.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Length: 15128 X-ZohoMail-DKIM: pass (identity @aol.com) X-ZM-MESSAGEID: 1673305746539100003 Content-Type: text/plain; charset="utf-8" By default, except for the ich9-usb-uhci device which libxl assigns to slot 29 (0xid), libxl defers to qemu upstream's automatic slot assignment process, which is simply to assign each emulated device to the next available slot on the pci bus. With this default behavior, libxl and qemu will not configure the Intel IGD correctly. Specifically, the Intel IGD must be assigned to slot 2, but the current default behavior is to assign one of the emulated devices to slot 2. With this patch libxl uses qemu command line options to specify the slot address of each pci device in the guest when gfx_passthru is enabled for the Intel IGD. It uses the same simple algorithm of assigning the next available slot, except that it starts with slot 3 instead of slot 2 for the emulated devices. This process of slot assignment aims to simulate the behavior of existing machines as much as possible. The default behavior (when igd gfx_passthru is disabled) of letting qemu manage the slot addresses of emulated pci devices is preserved. The patch also preserves the special treatment for the ich9 usb2 controller (ich9-usb-ehci1) that libxl currently assigns to slot.function 29.7 and the associated ich9-usb-uhciN devices to slot 29 (0x1d). For future maintainance of this code, it is important that pci devices that are managed by the libxl__build_device_model_args_new function follow the logic of this patch and use the new local counter next_slot to assign the slot address instead of letting upstream qemu assign the slot if the guest is configured for Intel IGD passthrough, and preserve the current behavior of letting qemu assign the slot address otherwise. Signed-off-by: Chuck Zmudzinski --- The diff of this patch is easier to review if it is generated using the -b (aka --ignore-space-change) option of diff/git-diff to filter out some of the changes that are only due to white space. This patch is difficult to verify for correctness without testing all the devices that could be added by the libxl__build_device_model_args_new function. There are 12 places where the addr=3D%x option needed to be added to the arguments of the "-device" qemu option that adds an emulated pci device which corresponds to at least 12 different devices that could be affected by this patch if the patch contains mistakes that the compiler did not notice. One mistake the compiler would not notice is a missing next_slot++; statement that would result in qemu trying to assign a device to a slot that is already assigned, which is an error in qemu. I did enough tests to find some mistakes in the patch which of course I fixed before submitting the patch. So I cannot guarantee that there are not any other mistakes in the patch because I don't have the resources to do the necessary testing of the many possible configurations that could be affected by this patch. tools/libs/light/libxl_dm.c | 168 ++++++++++++++++++++++++++++++------ 1 file changed, 141 insertions(+), 27 deletions(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 2048815611..2720b5d4d0 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1205,6 +1205,20 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, const char *path, *chardev; bool is_stubdom =3D libxl_defbool_val(b_info->device_model_stubdomain); int rc; + int next_slot; + bool configure_pci_for_igd =3D false; + /* + * next_slot is only used when we need to configure the pci + * slots for the Intel IGD. Slot 2 will be for the Intel IGD. + */ + next_slot =3D 3; + if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { + enum libxl_gfx_passthru_kind gfx_passthru_kind =3D + libxl__detect_gfx_passthru_kind(gc, guest_config); + if (gfx_passthru_kind =3D=3D LIBXL_GFX_PASSTHRU_KIND_IGD) { + configure_pci_for_igd =3D true; + } + } =20 dm_args =3D flexarray_make(gc, 16, 1); dm_envs =3D flexarray_make(gc, 16, 1); @@ -1372,6 +1386,20 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, =20 if (b_info->cmdline) flexarray_vappend(dm_args, "-append", b_info->cmdline, NULL); + /* + * When the Intel IGD is configured for primary graphics + * passthrough, we need to manually add the xen platform + * device because the QEMU machine type is "pc". Add it first to + * simulate the behavior of the "xenfv" QEMU machine type which + * always adds the xen platform device first. But in this case it + * will be at slot 3 because we are reserving slot 2 for the IGD. + */ + if (configure_pci_for_igd && + libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("xen-platform,addr=3D%x", next_slot)); + next_slot++; + } =20 /* Find out early if one of the disk is on the scsi bus and add a = scsi * controller. This is done ahead to keep the same behavior as pre= vious @@ -1381,7 +1409,14 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, continue; } if (strncmp(disks[i].vdev, "sd", 2) =3D=3D 0) { - flexarray_vappend(dm_args, "-device", "lsi53c895a", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("lsi53c895a,addr=3D%x", next_slot), NULL= ); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "lsi53c895a", + NULL); + } break; } } @@ -1436,31 +1471,67 @@ static int libxl__build_device_model_args_new(libxl= __gc *gc, flexarray_append(dm_args, "-spice"); flexarray_append(dm_args, spiceoptions); if (libxl_defbool_val(b_info->u.hvm.spice.vdagent)) { - flexarray_vappend(dm_args, "-device", "virtio-serial", - "-chardev", "spicevmc,id=3Dvdagent,name=3Dvdagent", "-= device", - "virtserialport,chardev=3Dvdagent,name=3Dcom.redhat.sp= ice.0", - NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("virtio-serial,addr=3D%x", next_slot), + "-chardev", "spicevmc,id=3Dvdagent,name=3Dvdagent", + "-device", + "virtserialport,chardev=3Dvdagent,name=3Dcom.redha= t.spice.0", + NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "virtio-serial", + "-chardev", "spicevmc,id=3Dvdagent,name=3Dvdagent", + "-device", + "virtserialport,chardev=3Dvdagent,name=3Dcom.redha= t.spice.0", + NULL); + } } } =20 switch (b_info->u.hvm.vga.kind) { case LIBXL_VGA_INTERFACE_TYPE_STD: - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("VGA,vgamem_mb=3D%d", - libxl__sizekb_to_mb(b_info->video_memkb))); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("VGA,addr=3D%x,vgamem_mb=3D%d", next_slot, + libxl__sizekb_to_mb(b_info->video_memkb))); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("VGA,vgamem_mb=3D%d", + libxl__sizekb_to_mb(b_info->video_memkb))); + } break; case LIBXL_VGA_INTERFACE_TYPE_CIRRUS: - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("cirrus-vga,vgamem_mb=3D%d", - libxl__sizekb_to_mb(b_info->video_memkb))); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("cirrus-vga,addr=3D%x,vgamem_mb=3D%d", next_= slot, + libxl__sizekb_to_mb(b_info->video_memkb))); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("cirrus-vga,vgamem_mb=3D%d", + libxl__sizekb_to_mb(b_info->video_memkb))); + } break; case LIBXL_VGA_INTERFACE_TYPE_NONE: break; case LIBXL_VGA_INTERFACE_TYPE_QXL: /* QXL have 2 ram regions, ram and vram */ - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("qxl-vga,vram_size_mb=3D%"PRIu64",ram_size_mb=3D= %"PRIu64, - (b_info->video_memkb/2/1024), (b_info->video_memkb/2/1024)= ) ); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("qxl-vga,addr=3D%x,vram_size_mb=3D%"PRIu64 + ",ram_size_mb=3D%"PRIu64, next_slot, + (b_info->video_memkb/2/1024), + (b_info->video_memkb/2/1024) ) ); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("qxl-vga,vram_size_mb=3D%"PRIu64 + ",ram_size_mb=3D%"PRIu64, + (b_info->video_memkb/2/1024), + (b_info->video_memkb/2/1024) ) ); + } break; default: LOGD(ERROR, guest_domid, "Invalid emulated video card specifie= d"); @@ -1496,8 +1567,15 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, } else if (b_info->u.hvm.usbversion) { switch (b_info->u.hvm.usbversion) { case 1: - flexarray_vappend(dm_args, - "-device", "piix3-usb-uhci,id=3Dusb", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("piix3-usb-uhci,addr=3D%x,id=3Dusb", + next_slot), NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, + "-device", "piix3-usb-uhci,id=3Dusb", NULL); + } break; case 2: flexarray_append_pair(dm_args, "-device", @@ -1509,8 +1587,15 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, i, 2*(i-1), i-1)); break; case 3: - flexarray_vappend(dm_args, - "-device", "nec-usb-xhci,id=3Dusb", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("nec-usb-xhci,addr=3D%x,id=3Dusb", + next_slot), NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, + "-device", "nec-usb-xhci,id=3Dusb", NULL); + } break; default: LOGD(ERROR, guest_domid, "usbversion parameter is invalid,= " @@ -1542,8 +1627,15 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, =20 switch (soundhw) { case LIBXL__QEMU_SOUNDHW_HDA: - flexarray_vappend(dm_args, "-device", "intel-hda", - "-device", "hda-duplex", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("intel-hda,addr=3D%x", next_slot), + "-device", "hda-duplex", NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "intel-hda", + "-device", "hda-duplex", NULL); + } break; default: flexarray_append_pair(dm_args, "-device", @@ -1573,10 +1665,18 @@ static int libxl__build_device_model_args_new(libxl= __gc *gc, guest_domid, nics[i].devid, LIBXL_NIC_TYPE_VIF_IOEMU); flexarray_append(dm_args, "-device"); - flexarray_append(dm_args, - GCSPRINTF("%s,id=3Dnic%d,netdev=3Dnet%d,mac=3D%s", - nics[i].model, nics[i].devid, - nics[i].devid, smac)); + if (configure_pci_for_igd) { + flexarray_append(dm_args, + GCSPRINTF("%s,addr=3D%x,id=3Dnic%d,netdev=3Dnet%d,= mac=3D%s", + nics[i].model, next_slot, nics[i].devid, + nics[i].devid, smac)); + next_slot++; + } else { + flexarray_append(dm_args, + GCSPRINTF("%s,id=3Dnic%d,netdev=3Dnet%d,mac=3D%s", + nics[i].model, nics[i].devid, + nics[i].devid, smac)); + } flexarray_append(dm_args, "-netdev"); flexarray_append(dm_args, GCSPRINTF("type=3Dtap,id=3Dnet%d,ifname= =3D%s," @@ -1865,8 +1965,15 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, if (b_info->type =3D=3D LIBXL_DOMAIN_TYPE_HVM) { flexarray_append_pair(dm_envs, "XEN_DOMAIN_ID", GCSPRINTF("%d", gu= est_domid)); =20 - if (b_info->u.hvm.hdtype =3D=3D LIBXL_HDTYPE_AHCI) - flexarray_append_pair(dm_args, "-device", "ahci,id=3Dahci0"); + if (b_info->u.hvm.hdtype =3D=3D LIBXL_HDTYPE_AHCI) { + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("ahci,addr=3D%x,id=3Dahci0", next_sl= ot)); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", "ahci,id=3Dahci0= "); + } + } for (i =3D 0; i < num_disks; i++) { int disk, part; int dev_number =3D @@ -2043,7 +2150,14 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, switch (b_info->u.hvm.vendor_device) { case LIBXL_VENDOR_DEVICE_XENSERVER: flexarray_append(dm_args, "-device"); - flexarray_append(dm_args, "xen-pvdevice,device-id=3D0xc000"); + if (configure_pci_for_igd) { + flexarray_append(dm_args, + GCSPRINTF("xen-pvdevice,addr=3D%x,device-id=3D0xc000", + next_slot)); + next_slot++; + } else { + flexarray_append(dm_args, "xen-pvdevice,device-id=3D0xc000= "); + } break; default: break; --=20 2.39.0 From nobody Sun May 19 10:57:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=aol.com ARC-Seal: i=1; a=rsa-sha256; t=1673305739; cv=none; d=zohomail.com; s=zohoarc; b=LOpGwzCKYzrlSfYnZscKJdUnBbe8hRircxWfxUIB3Ufr2pEp05OmJMaGJ7wG+6qPTxEZ8ARx8Vrtk2/NA9+7GAJpE/hUMHnh02tRssR//sgHO8fUFUyZbl0apE6jKNmQYKnK4Wzo8+LKlLKqdmVu+ZPX9QSYE3MUOMTek20zKUk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673305739; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ywgbO8lubWpnCassvIu6bBFzCJ/Z2sgLUfL80HdpzLE=; b=XBiu0SBq1aDlV+a6E/jLn8PV7dtKgq34EExdI/euvlOxqKgOADMn2zoFWspAmUZW8SoNNpWPvtDI223WUsxtzCyRNykk6So2DwJKCygzDTGOMyuHzVoTQ1cbxaefNyZX7ECAzH22ETWvn2sze4fOLV43CeHEkV06SFHmJuu25kw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167330573957541.85193720711891; Mon, 9 Jan 2023 15:08:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pF1Fx-0008Jp-W4; Mon, 09 Jan 2023 18:08:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pF1Fw-0008Il-7q for qemu-devel@nongnu.org; Mon, 09 Jan 2023 18:08:40 -0500 Received: from sonic308-8.consmr.mail.gq1.yahoo.com ([98.137.68.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pF1Fu-0003dW-Fj for qemu-devel@nongnu.org; Mon, 09 Jan 2023 18:08:40 -0500 Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 23:08:35 +0000 Received: by hermes--production-ne1-7b69748c4d-bgkrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 21a3ec8339abfccbadeaea4f5ef812e7; Mon, 09 Jan 2023 23:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673305715; bh=ywgbO8lubWpnCassvIu6bBFzCJ/Z2sgLUfL80HdpzLE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=pxzV/H1HM06MpAMRVFL0ssYCJXP59bXc5GrKUx/QcQJz7S71dqm4BINX2rzahxX81MtJ3y6CVWoFA+Z+Yvgmo6ZVoj16k+n0jLXlMLmUGbVqJE84JQ4p85+kGNkvkZ+CV3G3IVhDqZXv8Dr2rU0tVBF9iP1z0HwzRVp6x8KAHGEMS7q2ZCfeFIysV2I3RHAkuX8M4I5xj4vKnkI7rl/dsIfHsF+8921Wr5K1wPt2gMyHI+eTg8B2Lwfenjxuz9UX2sw8CglGE+K7lJLFfjSPx6RSsEPaGgY5LceZhom1Eg4fk0O1PK2D4Q/HnAm9NnGscRgslm01AHt6AiaU1UA4ZQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673305715; bh=keMjmw88+NB73GNZ0YN7HfypUkwkByV4+3fnszfn8CF=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=o5oc++gedcFxnVQru4ndLDTH+4PHQV48uZlZYgPEpbc9FMkTUtRJaY8ZIkTBLQ9efm7MNUoNRoYQnfOqkxARaYxTn/ztbDwwrODbc224H2IWyAX+TBSF1kLYjVlyGY6omgdm0a7VCaxl0USk+DiuFfy7uCVCauu1/xE9QsAb+cGlcbD+60pewrrq1aKWcKGuCZ2nPcelXtbFD9hyDybbZ/tCH1FtccsiuUBwWONs0gVITU8DORaBTRcDW9rQNQ5RCGYm5So2t35HzP30oAv5CjIuBFRrupoQ9UF26cgAB8YIBmCnsldzZZipBmKZq9RxiDZGaXsJ9YEBnZ0/lwvPCQ== X-YMail-OSG: vQZpqCcVM1mUk8i0Yg6trsInc6cIWbw5_m7__7CkDb5NTL8YxNrrPG2YebLlzam cbBzvm1Qfug0CdK_EKzy9o7NDqNQ.oDx1dGzXpsW1UizBPvq8F5GwcOBS.9eepfelo2Hc068dSZg PFRNQRvtTcgxfA9dR.lOLBFOP25MpPq4pTWjtTC5DdLdlcdEDFg14WJHM_ruSYuLeOJMwtm8r6c9 t0_IxRGikpcmywJ8l0GYmNert7SRfUAh_TwQKxpjYgoh0C5DBiJs.sXBqpZqmoCfw98iOO8F0B1v BDe8VwfbQ9LyLe6R9qNFsHW_4CylMgaDyfi6F1L6YUuHVzkGTL.zvCPjrPxZo1JhUkI9pbrlEjVq QZ07JAl9zztA3m_F9mdSrNIShZML8F7D8biOje2C.zDIdxp.wOwCMXbp5TAahcygh2q9AmJfItAd w3krBHXcXWT5UrE00TTFA_MVSoqQhqomFTu3x5VWZUSJGjXc4BEXiMxf.K_yT7uX4jtA.k0rAdHX jWw1b7zXKomaPLHmV3Hjg576CP0BeS.v2Owvv1ymlnWXvQNeWFVj10av1tH_9FXoT5BkGhNtGaxK q6aRWbSlcpT6lACd8EXQjUig6HuYvzGGYDIpm_L8R3wA_XKdCuzSxpFfHJ9oqaNyp0F_mNPQ7xfY H_OMYWsTwp0wIRtnUE3epufHf_ZwrqgVz7E.CVtvi_lQWBBMCO6zQsaaRWzver3NRHhDqJKzdllU Ki9Q6ypU1sKtHeCDN6uQivu0LUl3m3kXOLrDa8fIz4Hx23rrvtZ2y5feJ7mvXxEEqBRLjxBrSqBH usd0r_3usqyCBDIXyEU6yCm4G9lr8R1bhjdcdGEVxYbnGcQ22yqgQkisyrCjJhk2wlm1BnXFibeM bVIm6sis5av5BHgjo6FZkg02DT34K56H725bfkaGTGSm6hIsHYSTKa5TLoD3uLUtj.tObqcSdYuT mI4qH.3ADGN8fWZHaSnbmWl.S_5JucXWDsQrX.6eXSFhBX_anNtCFkCbUkihkXZV1Sva8EmqHs3R DBHRUidj68bGpq6rC6HGpakt55ONoI1_iiQGSAklpsBEaXB8GTqrBWQyEgy8mKdMHQn9.cDBkhn4 YQQ8GIjjyzmbNWkNkTZmUw7F6lZ8Rsi8P4_RX1Cmg0h3AZ2o3DldWH8NUIIjzxVSAydONH8cYVCi _KCuEbj6K9MtQJtiAi8mWVIAHZMtngEcXb4vetP6QXoa3bscDARG8c3DrlrKeV0xWJh9IsPn_fO6 lCKp7_j6NqmTG3oNlVhfZCpwNXDsWWmkw0zCBwxMxX_C0kDjoHK42ePacU4DtKyU5ggLQzPjoBZR 8MIjGW9HtAzBnQyXoNK5iHTMx6hk8mDXEGvucUmkG6bSOk5iHb4bZuaDyibxfjnn1gu2vErd._91 k8GmjuSozC_fApfkJ.yolqbPpOWW2dKb2vtwl3q78PlTqTbFzMGVVg.p_Zx8kt1ePl7x97FNTy1L YU5t77MmDasd5dfcapCgontTo.7eKb6EtANIjKOZF.IGxD0FSSPTKtRJiraMZrW1xThL3pjzBXy_ idlDgeBz4V_.RbOd1GpUGTiZkTKP34mpwQ8aLNPXsEFSuX7yz4gPbrVSsRowIaus2sJxQnvbkQlf hG7JcMfmePc.u4hu7clkU23J3HU3KRyV8Zc3nJZLYXG8LFtWGYqdAdBDgjm0LV_KByE36kM3YgCW vrrmyF3IateQLwYucxGimj5zcjl8t9bAYDcEtIsZSg8DPWjty1LbAmJdxoj2WPbquYvnktxGBfdg 0QznWRWZGIrkjLNC2QloR.OOMnb09ahDk9nJ9q9xtJ4voF05Q8c2Jvzg0FvkezRWl8LK2VhYpFs9 W4M631i9xLc6yU5aZnWRrsB7joBr4FEDvkSxCzU_cBhRAjHfUTyoByUkBxTxMb9yt6ZM2ghZoX7M 4X44tPVu604f.o9ZuWAJy7zhT2IAzwp1aYlqfKywOZ8iwK89zwurgxNux8odcJGe8wTK_NaFL1kI 4UFtlTJ3XYeRL6fjGS6415Z5PVgwMpQ9qwVDnoW7fmctSGop.iWJO6ImljqeBecgMRDO0UFB.hbn rpzFDd3it6GvDxcNBoCdQDUkXIw_RwrNeqgzjAP2cKVqLBVt7Ft1u.ciEP9bWBj0_nhtGG.lPkDG y9c_Poj1g_5DWY9FwycTRu2KCaslyzwI2.DyIuP23TmQA0qm41xKWUkKkiK6wucoCyxzfS8lCYQ- - X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH 3/3] libxl/dm: Assign slot 2 by default for Intel IGD passthrough Date: Mon, 9 Jan 2023 18:08:13 -0500 Message-Id: <27bb3979f234c8de6b51be7bb8195e3cacb5181c.1673300848.git.brchuckz@aol.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Length: 2518 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=98.137.68.32; envelope-from=brchuckz@aim.com; helo=sonic308-8.consmr.mail.gq1.yahoo.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.096, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aol.com) X-ZM-MESSAGEID: 1673305740702100002 Content-Type: text/plain; charset="utf-8" It is possible for the administrator to manually specify the virtual slot addresses of passed through pci devices on the guest's pci bus using the @VSLOT parameter in xl.cfg. With this patch, libxl will by default assign the Intel IGD to slot 2 when gfx_passthru is configured for the Intel IGD so it will no longer be necessary to use the @VSLOT setting to configure the IGD correctly. Also, with this patch, libxl will not override explicit @VSLOT settings by the administrator so in that case the patch will have no effect on guest behavior. The default behavior of letting qemu manage the slot addresses of passed through pci devices when gfx_passthru is disabled and the administrator does not set @VSLOT for passed through pci devices is also preserved. Signed-off-by: Chuck Zmudzinski --- tools/libs/light/libxl_dm.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 2720b5d4d0..b51ebae643 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1207,6 +1207,7 @@ static int libxl__build_device_model_args_new(libxl__= gc *gc, int rc; int next_slot; bool configure_pci_for_igd =3D false; + const int igd_slot =3D 2; /* * next_slot is only used when we need to configure the pci * slots for the Intel IGD. Slot 2 will be for the Intel IGD. @@ -2173,6 +2174,27 @@ static int libxl__build_device_model_args_new(libxl_= _gc *gc, flexarray_append(dm_envs, NULL); if (envs) *envs =3D (char **) flexarray_contents(dm_envs); + if (configure_pci_for_igd) { + libxl_device_pci *pci =3D NULL; + for (i =3D 0; i < guest_config->num_pcidevs; i++) { + pci =3D &guest_config->pcidevs[i]; + if (!pci->vdevfn) { + /* + * Find the Intel IGD and configure it for slot 2. + * Configure any other devices for slot next_slot. + * Since the guest is configured for IGD passthrough, + * assume the device on the host at slot 2 is the IGD. + */ + if (pci->domain =3D=3D 0 && pci->bus =3D=3D 0 && + pci->dev =3D=3D igd_slot && pci->func =3D=3D 0) { + pci->vdevfn =3D PCI_DEVFN(igd_slot, 0); + } else { + pci->vdevfn =3D PCI_DEVFN(next_slot, 0); + next_slot++; + } + } + } + } return 0; } =20 --=20 2.39.0