[Qemu-devel] [PATCH v4 00/11] Misc sam460ex improvements

BALATON Zoltan posted 11 patches 5 years, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
MAINTAINERS                        |   1 +
default-configs/ppc-softmmu.mak    |   3 +
default-configs/ppcemb-softmmu.mak |   2 +
default-configs/sh4-softmmu.mak    |   1 +
default-configs/sh4eb-softmmu.mak  |   1 +
hw/display/sm501.c                 | 166 ++++++++++++++++++++++--
hw/i2c/ppc4xx_i2c.c                | 252 ++++++++++++++++++-------------------
hw/ppc/sam460ex.c                  |   1 +
hw/timer/Makefile.objs             |   1 +
hw/timer/m41t80.c                  | 117 +++++++++++++++++
include/hw/i2c/ppc4xx_i2c.h        |  11 +-
target/ppc/translate.c             |   2 +
12 files changed, 415 insertions(+), 143 deletions(-)
create mode 100644 hw/timer/m41t80.c
[Qemu-devel] [PATCH v4 00/11] Misc sam460ex improvements
Posted by BALATON Zoltan 5 years, 9 months ago
Next spin of sam460ex pathces with changes according to review and
some new patches.

BALATON Zoltan (8):
  ppc4xx_i2c: Remove unimplemented sdata and intr registers
  ppc4xx_i2c: Implement directcntl register
  ppc4xx_i2c: Rewrite to model hardware more closely
  hw/timer: Add basic M41T80 emulation
  sam460ex: Add RTC device
  target/ppc: Add missing opcode for icbt on PPC440
  sm501: Implement i2c part for reading monitor EDID
  sm501: Set updated region dirty after 2D operation
  sm501: Fix support for non-zero frame buffer start address

Sebastian Bauer (3):
  sm501: Perform a full update after palette change
  sm501: Use values from the pitch register for 2d operations.

 MAINTAINERS                        |   1 +
 default-configs/ppc-softmmu.mak    |   3 +
 default-configs/ppcemb-softmmu.mak |   2 +
 default-configs/sh4-softmmu.mak    |   1 +
 default-configs/sh4eb-softmmu.mak  |   1 +
 hw/display/sm501.c                 | 166 ++++++++++++++++++++++--
 hw/i2c/ppc4xx_i2c.c                | 252 ++++++++++++++++++-------------------
 hw/ppc/sam460ex.c                  |   1 +
 hw/timer/Makefile.objs             |   1 +
 hw/timer/m41t80.c                  | 117 +++++++++++++++++
 include/hw/i2c/ppc4xx_i2c.h        |  11 +-
 target/ppc/translate.c             |   2 +
 12 files changed, 415 insertions(+), 143 deletions(-)
 create mode 100644 hw/timer/m41t80.c

-- 
2.7.6


Re: [Qemu-devel] [PATCH v4 00/11] Misc sam460ex improvements
Posted by David Gibson 5 years, 9 months ago
On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote:
> 
> Next spin of sam460ex pathces with changes according to review and
> some new patches.

So, the sm501 patches I don't really have the technical knowledge to
review, and I'm a little uncomfortable taking them through my tree,
since they aren't strictly related to ppc.

It looks like you're the only person that's made substantive changes
to sm501 lately, though.  So, given I haven't heard screaming, I think
it's fair to assume that either you know what you're doing, or you're
the only person that cares about sm501 anyway.

So, I think we should make you sm501 maintainer.

Specifically I think you should:
  * Fix the compile breakage I pointed out elsewhere
  * Split out your sm501 patches
  * Prepend a patch adding it to MAINTAINERS with yourself as
    maintainer (whether you call it "Maintained" or "Odd Fixes" is up
    to your level of dedication)
  * Send this new series direct to Peter Maydell, CC me, Gerd Hoffman
    <kraxel@redhat.com> and the SH maintainer(s) (as well as the lists
    and whoever else you think's appropriate)
  * I'll reply, making the case above to Peter for your
    maintainership.

With any luck, from there on you'll be able to send sm501 pull
requests directly.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [PATCH v4 00/11] Misc sam460ex improvements
Posted by BALATON Zoltan 5 years, 9 months ago
Hello,

On Wed, 20 Jun 2018, David Gibson wrote:
> On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote:
>> Next spin of sam460ex pathces with changes according to review and
>> some new patches.
>
> So, the sm501 patches I don't really have the technical knowledge to
> review, and I'm a little uncomfortable taking them through my tree,
> since they aren't strictly related to ppc.

OK, since the sm501 is also used on SH it's not PPC only so I think you 
can ignore them for now and just take the other patches and I can submit 
the sm501 related patches as a separate series (although all these changes 
are to improve sam460ex emulation).

> It looks like you're the only person that's made substantive changes
> to sm501 lately, though.  So, given I haven't heard screaming, I think
> it's fair to assume that either you know what you're doing, or you're
> the only person that cares about sm501 anyway.
>
> So, I think we should make you sm501 maintainer.

I don't feel confident enough to take on maintainership of this device but 
hope maybe Peter could help as he did before to get the patches in not 
involving your tree.

> Specifically I think you should:
>  * Fix the compile breakage I pointed out elsewhere

Thanks, I'll check and fix this.

>  * Split out your sm501 patches

OK, as above I'll send these as separate series, you can ignore all sm501: 
prefixed patches from this v4 series.

>  * Prepend a patch adding it to MAINTAINERS with yourself as
>    maintainer (whether you call it "Maintained" or "Odd Fixes" is up
>    to your level of dedication)
>  * Send this new series direct to Peter Maydell, CC me, Gerd Hoffman
>    <kraxel@redhat.com> and the SH maintainer(s) (as well as the lists
>    and whoever else you think's appropriate)
>  * I'll reply, making the case above to Peter for your
>    maintainership.
>
> With any luck, from there on you'll be able to send sm501 pull
> requests directly.

But if there's an other way I'd rather cc those people for review and to 
take care of pull requests without me becoming maintainer as I don't have 
any experience with that.

Regards,
BALATON Zoltan