drivers/crypto/virtio/virtio_crypto_algs.c | 112 ++++++++++++++++++--------- drivers/crypto/virtio/virtio_crypto_common.h | 25 +++++- drivers/crypto/virtio/virtio_crypto_core.c | 29 +++++++ drivers/crypto/virtio/virtio_crypto_mgr.c | 81 +++++++++++++++++-- 4 files changed, 202 insertions(+), 45 deletions(-)
Hi, Currently the Linux virtio-crypto driver registers the crypto algorithm without verifying if the backend actually supports the algorithm. This kernel patch series adds support for registering algorithm with Linux crypto layer, only if the algorithm is supported by the backend device. This also makes the driver more compliant with the virtio-crypto spec [1]. I would appreciate any feedback or comments on this. Thank you Farhan Reference --------- [1] Virtio crypto spec proposal https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00816.html ChangeLog --------- v1 -> v2 - Modify comment as suggested by Arei (patch 1) - Modify error message as suggested by Arei (patch 2) Farhan Ali (2): crypto/virtio-crypto: Read crypto services and algorithm masks crypto/virtio-crypto: Register an algo only if it's supported drivers/crypto/virtio/virtio_crypto_algs.c | 112 ++++++++++++++++++--------- drivers/crypto/virtio/virtio_crypto_common.h | 25 +++++- drivers/crypto/virtio/virtio_crypto_core.c | 29 +++++++ drivers/crypto/virtio/virtio_crypto_mgr.c | 81 +++++++++++++++++-- 4 files changed, 202 insertions(+), 45 deletions(-) -- 2.7.4
A polite ping :) If no one has any more comments/feedback then I would like to how to merge these patches to the mainline kernel tree. Thanks Farhan On 06/13/2018 04:38 PM, Farhan Ali wrote: > Hi, > > Currently the Linux virtio-crypto driver registers the crypto > algorithm without verifying if the backend actually supports the > algorithm. > > This kernel patch series adds support for registering algorithm > with Linux crypto layer, only if the algorithm is supported by > the backend device. This also makes the driver more compliant with > the virtio-crypto spec [1]. > > I would appreciate any feedback or comments on this. > > Thank you > Farhan > > Reference > --------- > [1] Virtio crypto spec proposal https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00816.html > > ChangeLog > --------- > v1 -> v2 > - Modify comment as suggested by Arei (patch 1) > - Modify error message as suggested by Arei (patch 2) > > > Farhan Ali (2): > crypto/virtio-crypto: Read crypto services and algorithm masks > crypto/virtio-crypto: Register an algo only if it's supported > > drivers/crypto/virtio/virtio_crypto_algs.c | 112 ++++++++++++++++++--------- > drivers/crypto/virtio/virtio_crypto_common.h | 25 +++++- > drivers/crypto/virtio/virtio_crypto_core.c | 29 +++++++ > drivers/crypto/virtio/virtio_crypto_mgr.c | 81 +++++++++++++++++-- > 4 files changed, 202 insertions(+), 45 deletions(-) >
On 06/19/2018 03:26 PM, Farhan Ali wrote: > A polite ping :) > > If no one has any more comments/feedback then I would like to how to merge these patches to the mainline kernel tree. I think it should go via Michael Tsirkin or Jason Wang (Adding Jason). Also adding Herbert Xu as FYI. I have not looked into the details of the patch, but I like the idea. Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> > > Thanks > Farhan > > On 06/13/2018 04:38 PM, Farhan Ali wrote: >> Hi, >> >> Currently the Linux virtio-crypto driver registers the crypto >> algorithm without verifying if the backend actually supports the >> algorithm. >> >> This kernel patch series adds support for registering algorithm >> with Linux crypto layer, only if the algorithm is supported by >> the backend device. This also makes the driver more compliant with >> the virtio-crypto spec [1]. >> >> I would appreciate any feedback or comments on this. >> >> Thank you >> Farhan >> >> Reference >> --------- >> [1] Virtio crypto spec proposal https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00816.html >> >> ChangeLog >> --------- >> v1 -> v2 >> - Modify comment as suggested by Arei (patch 1) >> - Modify error message as suggested by Arei (patch 2) >> >> >> Farhan Ali (2): >> crypto/virtio-crypto: Read crypto services and algorithm masks >> crypto/virtio-crypto: Register an algo only if it's supported >> >> drivers/crypto/virtio/virtio_crypto_algs.c | 112 ++++++++++++++++++--------- >> drivers/crypto/virtio/virtio_crypto_common.h | 25 +++++- >> drivers/crypto/virtio/virtio_crypto_core.c | 29 +++++++ >> drivers/crypto/virtio/virtio_crypto_mgr.c | 81 +++++++++++++++++-- >> 4 files changed, 202 insertions(+), 45 deletions(-) >> >
On Tue, Jun 19, 2018 at 04:08:05PM +0200, Christian Borntraeger wrote: > On 06/19/2018 03:26 PM, Farhan Ali wrote: > > A polite ping :) > > > > If no one has any more comments/feedback then I would like to how to merge these patches to the mainline kernel tree. > > I think it should go via Michael Tsirkin or Jason Wang (Adding Jason). > Also adding Herbert Xu as FYI. > > > I have not looked into the details of the patch, but I like the idea. > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Please post crypto patches to linux-crypto. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On 06/19/2018 10:32 AM, Herbert Xu wrote: > On Tue, Jun 19, 2018 at 04:08:05PM +0200, Christian Borntraeger wrote: >> On 06/19/2018 03:26 PM, Farhan Ali wrote: >>> A polite ping :) >>> >>> If no one has any more comments/feedback then I would like to how to merge these patches to the mainline kernel tree. >> >> I think it should go via Michael Tsirkin or Jason Wang (Adding Jason). >> Also adding Herbert Xu as FYI. >> >> >> I have not looked into the details of the patch, but I like the idea. >> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> > > Please post crypto patches to linux-crypto. > > Thanks, > I have cc'ed linux-crypto folks. Sorry I missed them Thanks Farhan
On Tue, Jun 19, 2018 at 10:57:54AM -0400, Farhan Ali wrote: > > > On 06/19/2018 10:32 AM, Herbert Xu wrote: > > On Tue, Jun 19, 2018 at 04:08:05PM +0200, Christian Borntraeger wrote: > > > On 06/19/2018 03:26 PM, Farhan Ali wrote: > > > > A polite ping :) > > > > > > > > If no one has any more comments/feedback then I would like to how to merge these patches to the mainline kernel tree. > > > > > > I think it should go via Michael Tsirkin or Jason Wang (Adding Jason). > > > Also adding Herbert Xu as FYI. > > > > > > > > > I have not looked into the details of the patch, but I like the idea. > > > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> > > > > Please post crypto patches to linux-crypto. > > > > Thanks, > > > > I have cc'ed linux-crypto folks. Sorry I missed them > > Thanks > Farhan Yes but not just the header. you want to repost the whole patchset.
© 2016 - 2024 Red Hat, Inc.