[v6] cryptodev: add vhost support

[Qemu-devel] [PATCH v6 0/4] cryptodev: add vhost support

Posted by Jay Zhou 6 years, 2 months ago

From: Gonglei <arei.gonglei@huawei.com>

I posted the RFC verion a few months ago for DPDK
vhost-crypto implmention, and now it's time to send
the formal version. Because we need an user space scheme
for better performance.

The vhost user crypto server side patches had been
sent to DPDK community, pls see

[RFC PATCH 0/6] lib/librte_vhost: introduce new vhost_user crypto backend
support
http://dpdk.org/ml/archives/dev/2017-November/081048.html

You also can get virtio-crypto polling mode driver from:

[PATCH] virtio: add new driver for crypto devices
http://dpdk.org/ml/archives/dev/2017-November/081985.html

v5 -> v6:
  Fix compile error about backends/cryptodev-vhost-user.o and rebase on
  the master
v4 -> v5:
  squash [PATCH v4 5/5] into previous patches [Michael]
v3 -> v4:
  "[PATCH v4 5/5] cryptodev-vhost-user: depend on CONFIG_VHOST_CRYPTO
  and CONFIG_VHOST_USER" newly added to fix compilation dependency [Michael]
v2 -> v3:
  New added vhost user messages should be sent only when feature
  has been successfully negotiated [Michael]
v1 -> v2:
  Fix compile error on mingw32

Gonglei (4):
  cryptodev: add vhost-user as a new cryptodev backend
  cryptodev: add vhost support
  cryptodev-vhost-user: add crypto session handler
  cryptodev-vhost-user: set the key length

 backends/Makefile.objs                |   6 +
 backends/cryptodev-builtin.c          |   1 +
 backends/cryptodev-vhost-user.c       | 379 ++++++++++++++++++++++++++++++++++
 backends/cryptodev-vhost.c            | 347 +++++++++++++++++++++++++++++++
 configure                             |  15 ++
 docs/interop/vhost-user.txt           |  26 +++
 hw/virtio/Makefile.objs               |   2 +-
 hw/virtio/vhost-user.c                | 104 ++++++++++
 hw/virtio/virtio-crypto.c             |  70 +++++++
 include/hw/virtio/vhost-backend.h     |   8 +
 include/hw/virtio/virtio-crypto.h     |   1 +
 include/sysemu/cryptodev-vhost-user.h |  47 +++++
 include/sysemu/cryptodev-vhost.h      | 154 ++++++++++++++
 include/sysemu/cryptodev.h            |   8 +
 qemu-options.hx                       |  21 ++
 vl.c                                  |   6 +
 16 files changed, 1194 insertions(+), 1 deletion(-)
 create mode 100644 backends/cryptodev-vhost-user.c
 create mode 100644 backends/cryptodev-vhost.c
 create mode 100644 include/sysemu/cryptodev-vhost-user.h
 create mode 100644 include/sysemu/cryptodev-vhost.h

--
1.8.3.1

Re: [Qemu-devel] [PATCH v6 0/4] cryptodev: add vhost support

Posted by Zhoujian (jay) 6 years, 2 months ago

Hi Michael,
I am wondering whether this version is OK for you?
Any comment will be appreciated, thanks.

Regards,
Jay

> -----Original Message-----
> From: Zhoujian (jay)
> Sent: Sunday, January 21, 2018 8:55 PM
> To: qemu-devel@nongnu.org
> Cc: mst@redhat.com; pbonzini@redhat.com; Huangweidong (C)
> <weidong.huang@huawei.com>; stefanha@redhat.com; Zhoujian (jay)
> <jianjay.zhou@huawei.com>; pasic@linux.vnet.ibm.com; longpeng
> <longpeng2@huawei.com>; xin.zeng@intel.com; roy.fan.zhang@intel.com; Gonglei
> (Arei) <arei.gonglei@huawei.com>; wangxin (U) <wangxinxin.wang@huawei.com>
> Subject: [PATCH v6 0/4] cryptodev: add vhost support
> 
> From: Gonglei <arei.gonglei@huawei.com>
> 
> I posted the RFC verion a few months ago for DPDK vhost-crypto implmention,
> and now it's time to send the formal version. Because we need an user space
> scheme for better performance.
> 
> The vhost user crypto server side patches had been sent to DPDK community,
> pls see
> 
> [RFC PATCH 0/6] lib/librte_vhost: introduce new vhost_user crypto backend
> support http://dpdk.org/ml/archives/dev/2017-November/081048.html
> 
> You also can get virtio-crypto polling mode driver from:
> 
> [PATCH] virtio: add new driver for crypto devices
> http://dpdk.org/ml/archives/dev/2017-November/081985.html
> 
> v5 -> v6:
>   Fix compile error about backends/cryptodev-vhost-user.o and rebase on
>   the master
> v4 -> v5:
>   squash [PATCH v4 5/5] into previous patches [Michael]
> v3 -> v4:
>   "[PATCH v4 5/5] cryptodev-vhost-user: depend on CONFIG_VHOST_CRYPTO
>   and CONFIG_VHOST_USER" newly added to fix compilation dependency [Michael]
> v2 -> v3:
>   New added vhost user messages should be sent only when feature
>   has been successfully negotiated [Michael]
> v1 -> v2:
>   Fix compile error on mingw32
> 
> Gonglei (4):
>   cryptodev: add vhost-user as a new cryptodev backend
>   cryptodev: add vhost support
>   cryptodev-vhost-user: add crypto session handler
>   cryptodev-vhost-user: set the key length
> 
>  backends/Makefile.objs                |   6 +
>  backends/cryptodev-builtin.c          |   1 +
>  backends/cryptodev-vhost-user.c       | 379
> ++++++++++++++++++++++++++++++++++
>  backends/cryptodev-vhost.c            | 347 +++++++++++++++++++++++++++++++
>  configure                             |  15 ++
>  docs/interop/vhost-user.txt           |  26 +++
>  hw/virtio/Makefile.objs               |   2 +-
>  hw/virtio/vhost-user.c                | 104 ++++++++++
>  hw/virtio/virtio-crypto.c             |  70 +++++++
>  include/hw/virtio/vhost-backend.h     |   8 +
>  include/hw/virtio/virtio-crypto.h     |   1 +
>  include/sysemu/cryptodev-vhost-user.h |  47 +++++
>  include/sysemu/cryptodev-vhost.h      | 154 ++++++++++++++
>  include/sysemu/cryptodev.h            |   8 +
>  qemu-options.hx                       |  21 ++
>  vl.c                                  |   6 +
>  16 files changed, 1194 insertions(+), 1 deletion(-)  create mode 100644
> backends/cryptodev-vhost-user.c  create mode 100644 backends/cryptodev-
> vhost.c  create mode 100644 include/sysemu/cryptodev-vhost-user.h
>  create mode 100644 include/sysemu/cryptodev-vhost.h
> 
> --
> 1.8.3.1
>

Re: [Qemu-devel] [PATCH v6 0/4] cryptodev: add vhost support

Posted by Michael S. Tsirkin 6 years, 2 months ago

Yes, I plan to merge it in the next pull.
Pls don't assume anything until it's merged upstream though,
some issues surface late.

On Thu, Feb 01, 2018 at 11:29:15AM +0000, Zhoujian (jay) wrote:
> Hi Michael,
> I am wondering whether this version is OK for you?
> Any comment will be appreciated, thanks.
> 
> Regards,
> Jay
> 
> > -----Original Message-----
> > From: Zhoujian (jay)
> > Sent: Sunday, January 21, 2018 8:55 PM
> > To: qemu-devel@nongnu.org
> > Cc: mst@redhat.com; pbonzini@redhat.com; Huangweidong (C)
> > <weidong.huang@huawei.com>; stefanha@redhat.com; Zhoujian (jay)
> > <jianjay.zhou@huawei.com>; pasic@linux.vnet.ibm.com; longpeng
> > <longpeng2@huawei.com>; xin.zeng@intel.com; roy.fan.zhang@intel.com; Gonglei
> > (Arei) <arei.gonglei@huawei.com>; wangxin (U) <wangxinxin.wang@huawei.com>
> > Subject: [PATCH v6 0/4] cryptodev: add vhost support
> > 
> > From: Gonglei <arei.gonglei@huawei.com>
> > 
> > I posted the RFC verion a few months ago for DPDK vhost-crypto implmention,
> > and now it's time to send the formal version. Because we need an user space
> > scheme for better performance.
> > 
> > The vhost user crypto server side patches had been sent to DPDK community,
> > pls see
> > 
> > [RFC PATCH 0/6] lib/librte_vhost: introduce new vhost_user crypto backend
> > support http://dpdk.org/ml/archives/dev/2017-November/081048.html
> > 
> > You also can get virtio-crypto polling mode driver from:
> > 
> > [PATCH] virtio: add new driver for crypto devices
> > http://dpdk.org/ml/archives/dev/2017-November/081985.html
> > 
> > v5 -> v6:
> >   Fix compile error about backends/cryptodev-vhost-user.o and rebase on
> >   the master
> > v4 -> v5:
> >   squash [PATCH v4 5/5] into previous patches [Michael]
> > v3 -> v4:
> >   "[PATCH v4 5/5] cryptodev-vhost-user: depend on CONFIG_VHOST_CRYPTO
> >   and CONFIG_VHOST_USER" newly added to fix compilation dependency [Michael]
> > v2 -> v3:
> >   New added vhost user messages should be sent only when feature
> >   has been successfully negotiated [Michael]
> > v1 -> v2:
> >   Fix compile error on mingw32
> > 
> > Gonglei (4):
> >   cryptodev: add vhost-user as a new cryptodev backend
> >   cryptodev: add vhost support
> >   cryptodev-vhost-user: add crypto session handler
> >   cryptodev-vhost-user: set the key length
> > 
> >  backends/Makefile.objs                |   6 +
> >  backends/cryptodev-builtin.c          |   1 +
> >  backends/cryptodev-vhost-user.c       | 379
> > ++++++++++++++++++++++++++++++++++
> >  backends/cryptodev-vhost.c            | 347 +++++++++++++++++++++++++++++++
> >  configure                             |  15 ++
> >  docs/interop/vhost-user.txt           |  26 +++
> >  hw/virtio/Makefile.objs               |   2 +-
> >  hw/virtio/vhost-user.c                | 104 ++++++++++
> >  hw/virtio/virtio-crypto.c             |  70 +++++++
> >  include/hw/virtio/vhost-backend.h     |   8 +
> >  include/hw/virtio/virtio-crypto.h     |   1 +
> >  include/sysemu/cryptodev-vhost-user.h |  47 +++++
> >  include/sysemu/cryptodev-vhost.h      | 154 ++++++++++++++
> >  include/sysemu/cryptodev.h            |   8 +
> >  qemu-options.hx                       |  21 ++
> >  vl.c                                  |   6 +
> >  16 files changed, 1194 insertions(+), 1 deletion(-)  create mode 100644
> > backends/cryptodev-vhost-user.c  create mode 100644 backends/cryptodev-
> > vhost.c  create mode 100644 include/sysemu/cryptodev-vhost-user.h
> >  create mode 100644 include/sysemu/cryptodev-vhost.h
> > 
> > --
> > 1.8.3.1
> >

Re: [Qemu-devel] [PATCH v6 0/4] cryptodev: add vhost support

Posted by Jay Zhou 6 years, 2 months ago

On 2018/2/2 1:06, Michael S. Tsirkin wrote:
> Yes, I plan to merge it in the next pull.
> Pls don't assume anything until it's merged upstream though,
> some issues surface late.
>

Okay, I see. Thanks for reviewing!

Regards,
Jay

> On Thu, Feb 01, 2018 at 11:29:15AM +0000, Zhoujian (jay) wrote:
>> Hi Michael,
>> I am wondering whether this version is OK for you?
>> Any comment will be appreciated, thanks.
>>
>> Regards,
>> Jay
>>
>>> -----Original Message-----
>>> From: Zhoujian (jay)
>>> Sent: Sunday, January 21, 2018 8:55 PM
>>> To: qemu-devel@nongnu.org
>>> Cc: mst@redhat.com; pbonzini@redhat.com; Huangweidong (C)
>>> <weidong.huang@huawei.com>; stefanha@redhat.com; Zhoujian (jay)
>>> <jianjay.zhou@huawei.com>; pasic@linux.vnet.ibm.com; longpeng
>>> <longpeng2@huawei.com>; xin.zeng@intel.com; roy.fan.zhang@intel.com; Gonglei
>>> (Arei) <arei.gonglei@huawei.com>; wangxin (U) <wangxinxin.wang@huawei.com>
>>> Subject: [PATCH v6 0/4] cryptodev: add vhost support
>>>
>>> From: Gonglei <arei.gonglei@huawei.com>
>>>
>>> I posted the RFC verion a few months ago for DPDK vhost-crypto implmention,
>>> and now it's time to send the formal version. Because we need an user space
>>> scheme for better performance.
>>>
>>> The vhost user crypto server side patches had been sent to DPDK community,
>>> pls see
>>>
>>> [RFC PATCH 0/6] lib/librte_vhost: introduce new vhost_user crypto backend
>>> support http://dpdk.org/ml/archives/dev/2017-November/081048.html
>>>
>>> You also can get virtio-crypto polling mode driver from:
>>>
>>> [PATCH] virtio: add new driver for crypto devices
>>> http://dpdk.org/ml/archives/dev/2017-November/081985.html
>>>
>>> v5 -> v6:
>>>    Fix compile error about backends/cryptodev-vhost-user.o and rebase on
>>>    the master
>>> v4 -> v5:
>>>    squash [PATCH v4 5/5] into previous patches [Michael]
>>> v3 -> v4:
>>>    "[PATCH v4 5/5] cryptodev-vhost-user: depend on CONFIG_VHOST_CRYPTO
>>>    and CONFIG_VHOST_USER" newly added to fix compilation dependency [Michael]
>>> v2 -> v3:
>>>    New added vhost user messages should be sent only when feature
>>>    has been successfully negotiated [Michael]
>>> v1 -> v2:
>>>    Fix compile error on mingw32
>>>
>>> Gonglei (4):
>>>    cryptodev: add vhost-user as a new cryptodev backend
>>>    cryptodev: add vhost support
>>>    cryptodev-vhost-user: add crypto session handler
>>>    cryptodev-vhost-user: set the key length
>>>
>>>   backends/Makefile.objs                |   6 +
>>>   backends/cryptodev-builtin.c          |   1 +
>>>   backends/cryptodev-vhost-user.c       | 379
>>> ++++++++++++++++++++++++++++++++++
>>>   backends/cryptodev-vhost.c            | 347 +++++++++++++++++++++++++++++++
>>>   configure                             |  15 ++
>>>   docs/interop/vhost-user.txt           |  26 +++
>>>   hw/virtio/Makefile.objs               |   2 +-
>>>   hw/virtio/vhost-user.c                | 104 ++++++++++
>>>   hw/virtio/virtio-crypto.c             |  70 +++++++
>>>   include/hw/virtio/vhost-backend.h     |   8 +
>>>   include/hw/virtio/virtio-crypto.h     |   1 +
>>>   include/sysemu/cryptodev-vhost-user.h |  47 +++++
>>>   include/sysemu/cryptodev-vhost.h      | 154 ++++++++++++++
>>>   include/sysemu/cryptodev.h            |   8 +
>>>   qemu-options.hx                       |  21 ++
>>>   vl.c                                  |   6 +
>>>   16 files changed, 1194 insertions(+), 1 deletion(-)  create mode 100644
>>> backends/cryptodev-vhost-user.c  create mode 100644 backends/cryptodev-
>>> vhost.c  create mode 100644 include/sysemu/cryptodev-vhost-user.h
>>>   create mode 100644 include/sysemu/cryptodev-vhost.h
>>>
>>> --
>>> 1.8.3.1
>>>
>
> .
>

Re: [Qemu-devel] [PATCH v6 0/4] cryptodev: add vhost support

Posted by Michael S. Tsirkin 6 years, 2 months ago

On Sun, Jan 21, 2018 at 08:54:46PM +0800, Jay Zhou wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> I posted the RFC verion a few months ago for DPDK
> vhost-crypto implmention, and now it's time to send
> the formal version. Because we need an user space scheme
> for better performance.
> 
> The vhost user crypto server side patches had been
> sent to DPDK community, pls see

I dropped the patchset from the latest pull request.
Please address the issues found, test stop path some more
and resumit.

Thanks!

> [RFC PATCH 0/6] lib/librte_vhost: introduce new vhost_user crypto backend
> support
> http://dpdk.org/ml/archives/dev/2017-November/081048.html
> 
> You also can get virtio-crypto polling mode driver from:
> 
> [PATCH] virtio: add new driver for crypto devices
> http://dpdk.org/ml/archives/dev/2017-November/081985.html
> 
> v5 -> v6:
>   Fix compile error about backends/cryptodev-vhost-user.o and rebase on
>   the master
> v4 -> v5:
>   squash [PATCH v4 5/5] into previous patches [Michael]
> v3 -> v4:
>   "[PATCH v4 5/5] cryptodev-vhost-user: depend on CONFIG_VHOST_CRYPTO
>   and CONFIG_VHOST_USER" newly added to fix compilation dependency [Michael]
> v2 -> v3:
>   New added vhost user messages should be sent only when feature
>   has been successfully negotiated [Michael]
> v1 -> v2:
>   Fix compile error on mingw32
> 
> Gonglei (4):
>   cryptodev: add vhost-user as a new cryptodev backend
>   cryptodev: add vhost support
>   cryptodev-vhost-user: add crypto session handler
>   cryptodev-vhost-user: set the key length
> 
>  backends/Makefile.objs                |   6 +
>  backends/cryptodev-builtin.c          |   1 +
>  backends/cryptodev-vhost-user.c       | 379 ++++++++++++++++++++++++++++++++++
>  backends/cryptodev-vhost.c            | 347 +++++++++++++++++++++++++++++++
>  configure                             |  15 ++
>  docs/interop/vhost-user.txt           |  26 +++
>  hw/virtio/Makefile.objs               |   2 +-
>  hw/virtio/vhost-user.c                | 104 ++++++++++
>  hw/virtio/virtio-crypto.c             |  70 +++++++
>  include/hw/virtio/vhost-backend.h     |   8 +
>  include/hw/virtio/virtio-crypto.h     |   1 +
>  include/sysemu/cryptodev-vhost-user.h |  47 +++++
>  include/sysemu/cryptodev-vhost.h      | 154 ++++++++++++++
>  include/sysemu/cryptodev.h            |   8 +
>  qemu-options.hx                       |  21 ++
>  vl.c                                  |   6 +
>  16 files changed, 1194 insertions(+), 1 deletion(-)
>  create mode 100644 backends/cryptodev-vhost-user.c
>  create mode 100644 backends/cryptodev-vhost.c
>  create mode 100644 include/sysemu/cryptodev-vhost-user.h
>  create mode 100644 include/sysemu/cryptodev-vhost.h
> 
> --
> 1.8.3.1
>

Re: [Qemu-devel] [PATCH v6 0/4] cryptodev: add vhost support

Posted by Zhoujian (jay) 6 years, 2 months ago

> -----Original Message-----
> From: Michael S. Tsirkin [mailto:mst@redhat.com]
> Sent: Wednesday, February 14, 2018 12:47 AM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>
> Cc: qemu-devel@nongnu.org; pbonzini@redhat.com; Huangweidong (C)
> <weidong.huang@huawei.com>; stefanha@redhat.com; pasic@linux.vnet.ibm.com;
> longpeng <longpeng2@huawei.com>; xin.zeng@intel.com; roy.fan.zhang@intel.com;
> Gonglei (Arei) <arei.gonglei@huawei.com>; wangxin (U)
> <wangxinxin.wang@huawei.com>
> Subject: Re: [PATCH v6 0/4] cryptodev: add vhost support
> 
> On Sun, Jan 21, 2018 at 08:54:46PM +0800, Jay Zhou wrote:
> > From: Gonglei <arei.gonglei@huawei.com>
> >
> > I posted the RFC verion a few months ago for DPDK vhost-crypto
> > implmention, and now it's time to send the formal version. Because we
> > need an user space scheme for better performance.
> >
> > The vhost user crypto server side patches had been sent to DPDK
> > community, pls see
> 
> I dropped the patchset from the latest pull request.
> Please address the issues found, test stop path some more and resumit.

Hi Michael,
Thanks for your help, I'll respin this patchset when the issues are solved.

Regards,
Jay

> 
> Thanks!
> 
> > [RFC PATCH 0/6] lib/librte_vhost: introduce new vhost_user crypto
> > backend support
> > http://dpdk.org/ml/archives/dev/2017-November/081048.html
> >
> > You also can get virtio-crypto polling mode driver from:
> >
> > [PATCH] virtio: add new driver for crypto devices
> > http://dpdk.org/ml/archives/dev/2017-November/081985.html
> >
> > v5 -> v6:
> >   Fix compile error about backends/cryptodev-vhost-user.o and rebase on
> >   the master
> > v4 -> v5:
> >   squash [PATCH v4 5/5] into previous patches [Michael]
> > v3 -> v4:
> >   "[PATCH v4 5/5] cryptodev-vhost-user: depend on CONFIG_VHOST_CRYPTO
> >   and CONFIG_VHOST_USER" newly added to fix compilation dependency
> > [Michael]
> > v2 -> v3:
> >   New added vhost user messages should be sent only when feature
> >   has been successfully negotiated [Michael]
> > v1 -> v2:
> >   Fix compile error on mingw32
> >
> > Gonglei (4):
> >   cryptodev: add vhost-user as a new cryptodev backend
> >   cryptodev: add vhost support
> >   cryptodev-vhost-user: add crypto session handler
> >   cryptodev-vhost-user: set the key length
> >
> >  backends/Makefile.objs                |   6 +
> >  backends/cryptodev-builtin.c          |   1 +
> >  backends/cryptodev-vhost-user.c       | 379
> ++++++++++++++++++++++++++++++++++
> >  backends/cryptodev-vhost.c            | 347
> +++++++++++++++++++++++++++++++
> >  configure                             |  15 ++
> >  docs/interop/vhost-user.txt           |  26 +++
> >  hw/virtio/Makefile.objs               |   2 +-
> >  hw/virtio/vhost-user.c                | 104 ++++++++++
> >  hw/virtio/virtio-crypto.c             |  70 +++++++
> >  include/hw/virtio/vhost-backend.h     |   8 +
> >  include/hw/virtio/virtio-crypto.h     |   1 +
> >  include/sysemu/cryptodev-vhost-user.h |  47 +++++
> >  include/sysemu/cryptodev-vhost.h      | 154 ++++++++++++++
> >  include/sysemu/cryptodev.h            |   8 +
> >  qemu-options.hx                       |  21 ++
> >  vl.c                                  |   6 +
> >  16 files changed, 1194 insertions(+), 1 deletion(-)  create mode
> > 100644 backends/cryptodev-vhost-user.c  create mode 100644
> > backends/cryptodev-vhost.c  create mode 100644
> > include/sysemu/cryptodev-vhost-user.h
> >  create mode 100644 include/sysemu/cryptodev-vhost.h
> >
> > --
> > 1.8.3.1
> >