[Qemu-devel] [PATCH v1 0/2] Remove libqemustub.a in order to improve error

Alistair Francis posted 2 patches 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1503077821.git.alistair.francis@xilinx.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
Makefile                    |  7 +++----
Makefile.target             |  2 +-
docs/devel/build-system.txt | 14 +++++---------
tests/Makefile.include      |  8 ++++----
util/cutils.c               |  3 ++-
5 files changed, 15 insertions(+), 19 deletions(-)
[Qemu-devel] [PATCH v1 0/2] Remove libqemustub.a in order to improve error
Posted by Alistair Francis 6 years, 8 months ago
As discussed with Paolo and Markus let's combine libqemustub.a into
libqemuutil.a to avoid circular dependencies.

Alistair Francis (2):
  Makefile: Remove libqemustub.a
  Convert remaining single line fprintf() to warn_report()

 Makefile                    |  7 +++----
 Makefile.target             |  2 +-
 docs/devel/build-system.txt | 14 +++++---------
 tests/Makefile.include      |  8 ++++----
 util/cutils.c               |  3 ++-
 5 files changed, 15 insertions(+), 19 deletions(-)

-- 
2.11.0


Re: [Qemu-devel] [PATCH v1 0/2] Remove libqemustub.a in order to improve error
Posted by Paolo Bonzini 6 years, 7 months ago
On 18/08/2017 20:47, Alistair Francis wrote:
> As discussed with Paolo and Markus let's combine libqemustub.a into
> libqemuutil.a to avoid circular dependencies.
> 
> Alistair Francis (2):
>   Makefile: Remove libqemustub.a
>   Convert remaining single line fprintf() to warn_report()
> 
>  Makefile                    |  7 +++----
>  Makefile.target             |  2 +-
>  docs/devel/build-system.txt | 14 +++++---------
>  tests/Makefile.include      |  8 ++++----
>  util/cutils.c               |  3 ++-
>  5 files changed, 15 insertions(+), 19 deletions(-)
> 

Queued, thanks (with Philippe's adjustments to the comments).

Paolo

Re: [Qemu-devel] [PATCH v1 0/2] Remove libqemustub.a in order to improve error
Posted by Alistair Francis 6 years, 7 months ago
On Mon, Sep 11, 2017 at 2:57 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 18/08/2017 20:47, Alistair Francis wrote:
>> As discussed with Paolo and Markus let's combine libqemustub.a into
>> libqemuutil.a to avoid circular dependencies.
>>
>> Alistair Francis (2):
>>   Makefile: Remove libqemustub.a
>>   Convert remaining single line fprintf() to warn_report()
>>
>>  Makefile                    |  7 +++----
>>  Makefile.target             |  2 +-
>>  docs/devel/build-system.txt | 14 +++++---------
>>  tests/Makefile.include      |  8 ++++----
>>  util/cutils.c               |  3 ++-
>>  5 files changed, 15 insertions(+), 19 deletions(-)
>>
>
> Queued, thanks (with Philippe's adjustments to the comments).

Thanks Paolo.

I actually sent a new version with Philippe's comments, it's included
as part of the "More warning reporting fixed" series.

Version 5 of that has been reviewed by Markus, I will send it out
today. Can you take that instead?

Thanks,
Alistair

>
> Paolo

Re: [Qemu-devel] [PATCH v1 0/2] Remove libqemustub.a in order to improve error
Posted by Alistair Francis 6 years, 7 months ago
On Mon, Sep 11, 2017 at 9:36 AM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> On Mon, Sep 11, 2017 at 2:57 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 18/08/2017 20:47, Alistair Francis wrote:
>>> As discussed with Paolo and Markus let's combine libqemustub.a into
>>> libqemuutil.a to avoid circular dependencies.
>>>
>>> Alistair Francis (2):
>>>   Makefile: Remove libqemustub.a
>>>   Convert remaining single line fprintf() to warn_report()
>>>
>>>  Makefile                    |  7 +++----
>>>  Makefile.target             |  2 +-
>>>  docs/devel/build-system.txt | 14 +++++---------
>>>  tests/Makefile.include      |  8 ++++----
>>>  util/cutils.c               |  3 ++-
>>>  5 files changed, 15 insertions(+), 19 deletions(-)
>>>
>>
>> Queued, thanks (with Philippe's adjustments to the comments).
>
> Thanks Paolo.
>
> I actually sent a new version with Philippe's comments, it's included
> as part of the "More warning reporting fixed" series.
>
> Version 5 of that has been reviewed by Markus, I will send it out
> today. Can you take that instead?

Ah, I meant version 4.

The series should be very close to being merged. If you want that
whole series can go in or you can take this and I can rebase the
larger series. Whatever is easiest for you.

Thanks,
Alistair

>
> Thanks,
> Alistair
>
>>
>> Paolo