From nobody Fri Mar 29 14:40:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1502475910242374.9802013662345; Fri, 11 Aug 2017 11:25:10 -0700 (PDT) Received: from localhost ([::1]:35374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgEcO-0001a8-KM for importer@patchew.org; Fri, 11 Aug 2017 14:25:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgEaN-0000Ca-8b for qemu-devel@nongnu.org; Fri, 11 Aug 2017 14:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgEaM-0007Tz-7L for qemu-devel@nongnu.org; Fri, 11 Aug 2017 14:23:03 -0400 Received: from mail-cys01nam02on0053.outbound.protection.outlook.com ([104.47.37.53]:12640 helo=NAM02-CY1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgEaG-0007Qj-Ce; Fri, 11 Aug 2017 14:22:56 -0400 Received: from BN6PR02CA0041.namprd02.prod.outlook.com (10.173.146.155) by BN6PR02MB2465.namprd02.prod.outlook.com (10.173.141.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Fri, 11 Aug 2017 18:22:54 +0000 Received: from CY1NAM02FT003.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::203) by BN6PR02CA0041.outlook.office365.com (2603:10b6:404:5f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.17 via Frontend Transport; Fri, 11 Aug 2017 18:22:53 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT003.mail.protection.outlook.com (10.152.74.151) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1304.16 via Frontend Transport; Fri, 11 Aug 2017 18:22:52 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1dgEaC-0003WT-Dr; Fri, 11 Aug 2017 11:22:52 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dgEaC-0006VW-B3; Fri, 11 Aug 2017 11:22:52 -0700 Received: from xsj-pvapsmtp01 (mailhost.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v7BIMgoa013545; Fri, 11 Aug 2017 11:22:43 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dgEa2-0006Rc-Re; Fri, 11 Aug 2017 11:22:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ovB9TA0nLW1ng2eIUVOYyp3ULaSgl4GBiIe4T230fgA=; b=floJKfDIUMuCUr/Md+u026CukPhutUpA1VISw0iMVRMERvTBag5F31AeAeRQWhH9KTaepZ8ezLSj2Hn/7o8zsXdGz4SBYK2EKOIIhSUavQnZ/UXJM/EhKjUJHWzo7jYGmLldKAcUs9BG8u1KwxQqB6G581P91H0IdeFdgyZWoYk= Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; From: Alistair Francis To: , Date: Fri, 11 Aug 2017 11:19:19 -0700 Message-ID: <20b283f7eaf100783b291de3830dd226ec286b6a.1502474835.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23250.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(189002)(199003)(8676002)(2950100002)(2906002)(33646002)(4326008)(36756003)(54906002)(77096006)(81166006)(81156014)(356003)(5003940100001)(8936002)(50226002)(36386004)(5660300001)(9786002)(189998001)(478600001)(15650500001)(76176999)(50986999)(6666003)(118296001)(106466001)(63266004)(305945005)(626005)(39060400002)(47776003)(48376002)(50466002)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR02MB2465; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT003; 1:XSJlpIHe5pDRvlrpaXkJ8f565gokAp1iSbkJsDqiJBIavYCHLhxLUrQpK+IJ8FxgXFty6m+lGndHir1njOU7QlAqS9Oq8K0ptGdKzfu70oxRYETC5TBbNXJLu9iFINTF+yy7c7PeSW5PMVMBKLW0CH39hN2iKmc8ENzXyrO5cxUeLdfguB2Ooj4nfJl6Yk/iAwKKTHM0RsMbmCtOxgEls2fFnxha+6SktNM8P00Dg6VQRDOJd52I2QBzUGQ+vr7MHF9S7OSGQJxJWjvYHBlQyIXEUT/0BJ+HsoAT8iH7vfi0sw3iFrsq2QpFwcq8oer5QrQo0nYbHz9NG7KbmyotS0NM+5IPNb22uE+BUFRIgZC+B1A0YQ49HW+4t8rXIXp6uPuYDKdszwm5OGk72zR7ENONwKGff7z33dWt/GLM0o79L9cQKoKoeWxNRFccW88/NMy0c0ueP4+3ELg4+3ln9I+NMlJPcOa5+z/+XHf16odLB1+DwQdgDj73YFddO/5b9c+78ZnG4G+aEaUWq+5FdHX/DVYT3n1M0VvRQnbPbMWedGqRHuVsCY11caIoEIHOUcPHu+TX/R3BpEUb1zHXi+H7KaJPDlTJ0JEs24UY5D76xmxyh9XcGLWkQM7FmW+UwGY0UAPhhM5Qnu3WFVIWdKdgBDMuih1IF64PGMKSjFKrMvfcJg4tdXk3CxQbqwQWwV1mRsKQ2ZGShNQJcvPM+EfJM01B423wPsyU5XK65VKApzX1Ig4NzHTK9PjDRjbUxpfPrGJKOR+e84BQSZqicBP3kNY8OwXBvg/uhMcN+msEXQ/5OjXnv5nBXRVIkXeW/n6vAAELRM1jkY1Dw0/D4w== MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9607ff11-97d2-474d-bdb9-08d4e0e5fb3f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR02MB2465; X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2465; 3:g2iQLX1h+r+2/j4MyXKubXFvC0pTwNcZiBjbBg0VPRLMZ1YepH132MPO2OJXNNGw5JRQXD13qmxmXPnRhc2OR9dLzUCHUjSd3aDTawVRPoggZ9SgzYCNxFFN4fQP3+LEimyHZ1AGEl7Z54c1BF6gR4XGKSU7whbO1rWwVC7gRoFKURKJznVB5wz+MagVgLgKhT4GI/HL1lu1wgGhLgPNWiLok/Fw15rqI7dWzp2twXGxyTHdEYzaULHLbWNFWS9pB0mN+s4yYEe31kbYbnt3WWqC1VovoqCykNOwjqk/588lWVZ5Jgi2HxDKQvmFUqlQGQBx+AZNCQNvQCLY+xRoupt+CaR/WLTGQqtu7JWap8M=; 25:0xYXpCwIJRpwNm+My9vbJo1BqNW7eoekaDsSoRoGa2HdHDxKr5/4PagYHfrFTcr4Sjj37nvofcI4/ADiybxNQ7ncDi/dQAgWAylwJsqLSGFatRSXzkrg8ENI5ZQwL3A6G0Rhi8Trhuld1Kjftw+EyI9PB+HHO7Kj7Wyq97sY/5qg47TXtkd7c6XfohM9Q4VcSRvpWjFzUn8RvK1Q7djjqNgg7TS+pIKVJe1B4atsjmc0/aLYyyJ0hOMtUqK7xiI+t3QdO5Kw4Q9hGvlM5VmXw2AetceDBkqwt0NesetCjyLHLCZ0rhRQrQDX0vxXEURfrtU96p9OpGcYn6PDq0Y5/g== X-MS-TrafficTypeDiagnostic: BN6PR02MB2465: X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2465; 31:jRVP0dAVrm8xCmHzCeM4sXPQxutoE0bw8lpKHOFd7MKgQ+y/Q5h1RbUUP8GOd4ad3cUTMhyP1KmSPdGqmsezMYA+HeXG47c/jVO20reN5U3MC1EF7wJQQBcbqtI3NE+fAYPp6k2/+qA7mXATHnO3tpM0gmP730BPdgRXHJls9Q71OnKBy2w/WmTvBxxSx0ylXvH5BqFw3H2zYmk8YneA6n6J6aid0QQ/+4/7xShYl5U=; 20:7ITQPloP2ZAJ1tZVdmVQjYQVyIYyQrEMIPHGnc1AM1jOWYNBbvfrh+G2eHmi63jL8JPW0/8lirmwXyfXM158cwjHMm8qxhP6UfL3eVGs506cXcLEl0FK1r+rTw9cAncrm9XJItFn6XdPJuCsUc4BVucvFXCd0iojRT3LR7p6etQ7oDvb/nl30pWVFpDpAmEzXVoGflnPZdIQzoKu+Vvno2C9TkFxb7hvYdXd8o0Xh3bSu3zEg+ad8qytPSY8hm9yLw79lci2yRqR+/PDGr3AIKS4VFdIMsP8dWF3T55p18wC4DSaDyVzumFVjdH2fZDrDs2Fj+aJLJ8Wi1gvrDWeRWyGEaSgHnyf1VWFDamxRTOVwmURvhJuBFcyPg0vgNXGMx17wusPqMW3rZECcvYt/r6g7xbCKBngOZEo/ZZ1sD25H/EqlR4vDeNz/Yy8TWCMp0jYdr5IIcNVCsCwwMYlaFo6Gi1Y9aIxaowdP/y7od0JzQbhAnYt46v46M4lTeDx X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(13016025)(13018025)(8121501046)(93006095)(93004095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR02MB2465; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR02MB2465; X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2465; 4:kJwsXM0xu59Ky4klNskVX443uBfThQjcYFWLvuCGLGWRptHAqOVXb7mRDBNDcU57aXTOgo0ys9zr+/odaEV16cVQ7VN1d4MpSPCGDiiVS0bmk9IFYsDnflVpRYRwR63IxLVCYMRyAd9LCRkeL2VFrgzkB6NNj3D4hA2RlqPSctqJV2R2FHf0DxuHc9lkkLkz9cO0YPm7VvWS5bIokEsimRFGMVq1q8YtVRLKrCZZY+/eo3u70Htub3K3a7eLKnJrvksd8qTPxBUPJJdVmS/ExAyR6WdRKcTMZ3Kt4zLrowk= X-Forefront-PRVS: 03965EFC76 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR02MB2465; 23:HpPJXtAoJhDdDWPWtHd45aqpl6WsYG0Nov7oO9dST?= =?us-ascii?Q?i+Hh5SEZCykxbs7Nwsct6srDifgYqfKGzINPE/NM3phkyMBTdk8HFVenR16i?= =?us-ascii?Q?ef8me278ZsVXXs4vFdCqIQqASirViwEYak5fUPFjKcPAXdVlHQ446d8N8suP?= =?us-ascii?Q?dBeZ6r++Yke907JERaDjbWhL0etmbXHzL34/lEyKkV3qsIvKcQvXBvt8YkFY?= =?us-ascii?Q?1+6x7inCPzTsOkJcmvkAXqGHMyhvrHqbCj1BOIBL2xtgDEZ+WVMCxLfUnI4I?= =?us-ascii?Q?RxVGDIp0PdCF1cwolbuCjrSCu+oFCSdhTHXtAsnNGdvQJw+rI5N4UUf6ym4R?= =?us-ascii?Q?lr++1BsD9FGtbiRsiRou5jLHYQb3jE+/umiAH8w9do0IUhAgzNUn+0X700pS?= =?us-ascii?Q?lsM5Hl/zJNX+TPMNWOyLFGziBmWUR70yBwuhnjWudDk3rcrbNAbyXYdZMgaJ?= =?us-ascii?Q?TlUpah/W1vM93i96vXVVFlcziR6ZcZlSyBdGvRkCE9IyrNzWAg5fF2O8H/4Y?= =?us-ascii?Q?999hxy/jD2+iQx1mpvAdTtvJBcKCj6J7uOf1aOPJTaiK2ActixLj5qPJK8jr?= =?us-ascii?Q?2WtEcugq81CrZlRfSYeHYfCUk6egxsryOg9M+kq8ez0gvkSyzrPVWJ51Nao7?= =?us-ascii?Q?yH9JI3gGHEYx0YiaN3H05Ylw2cdopUefjrDng+IgyOKaWDVLSH5oRBNI63Aa?= =?us-ascii?Q?ycvF89ZQxa5smH83/tjZTw+w7LhX7C5dtYBWBXatkMm32zGmF2eH+QGQHjyq?= =?us-ascii?Q?+y6+s1pZ9Mw5gENE3CUFar3TJ9VqgU47O/r6wZLGMdjDsZC4vT2hX5zrJUke?= =?us-ascii?Q?mMjTmsovqclVvDtL/OxewVQXHOjJPfp+6fjN/jEiRRQdKtpeIjK1IC3dAg3J?= =?us-ascii?Q?sFH2zirGy15JCCYuj9ZLcRqSGOB35RSsgkZ3P+L1Og7RQncw6apqg9za2Prv?= =?us-ascii?Q?phiQD3zAXApqr4oUzBeZuQuB/ITJ77tnjcmMeztFQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2465; 6:3x3ZqWvGfDtx2MCiZwd3RNCDN4Xi4KAfaxcpkdqERgDz5bBQHwjiSGaamj1DN28u9+hrJ27muoKlCy/yhShM041WN6/IdMmem4/a2kDdt+XgL3hgRtRzl9UgeI9Sh9KooD6wllD03wZvxx74ZlVqbUe21S3LhIK5zmv9g6mB3mlGaB/nBdFXnsYrnGjVkdxdFKZQtlN8UItDlAbPKOajI4ljgOG/s2ln/PXzYAWqULVR7d8zuRXFCBm/e+6xcqA2RHebwr13m2mNEGfHZX6jJmBDBrXlaigYkE2nJ2QkJ5DmBPTPRJn+Iiop3E8rYshwDrRVRAJflt9zEWOSNvNThA==; 5:/hmmM4PW/mRT1WVrIddK+bTtO6s+PqNDnAfoUIL5IiuISL4WhQMEAJk4cVmcVFVRe71qTqMbyJQn/OBBuAYb4WPWNgBmHlXVfd3HP6V0zXeQagUU4ls8ikhjKYzfR827Wid1pWtJx7aVlG+IZk8tgg==; 24:bLnuQGiGjsqaPMSYXHgyYP+mgBx5kg+inlm+xgS6zAt6X7DKWuLheCspOfMlNksGKmoJAH1QctfuwFWLOKVT+Y4WTRW+Y+IqRcAP8z4zyM8=; 7:DwziNVYcUVAbu3FRvm7BqKIOoCzrd4fhNZzSfc0lWYiGYzt5rlnEh1zLig1MyuRolx/xqs2TVxDLXNkul7fmhVbW59tBjVKeY1V5nAdCX5WsCDw73YuZ3isqq7y6ocE4HocHH3d8QR3HxE8LQglCZZ1L1lt0hgKCsBBfqxog2QQ6vLi54Lli3PBBDSNCDVkh8jTaRn8GJapTthdJr3Tw96WzkbrkqK6rEirHHD4zINY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2017 18:22:52.9723 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2465 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.37.53 Subject: [Qemu-devel] [RFC v1 1/3] target/arm: Update the memops for exclusive load X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, alistair23@gmail.com, qemu-arm@nongnu.org, edgar.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update the memops used for the load to match that of the store. This adds the alignment requirement to the memops. Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 58ed4c6d05..245175e2f1 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -1854,7 +1854,7 @@ static void gen_load_exclusive(DisasContext *s, int r= t, int rt2, TCGv_i64 addr, int size, bool is_pair) { TCGv_i64 tmp =3D tcg_temp_new_i64(); - TCGMemOp memop =3D s->be_data + size; + TCGMemOp memop =3D size | MO_ALIGN | s->be_data; =20 g_assert(size <=3D 3); tcg_gen_qemu_ld_i64(tmp, addr, get_mem_index(s), memop); --=20 2.11.0 From nobody Fri Mar 29 14:40:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1502476043173824.4511940519616; Fri, 11 Aug 2017 11:27:23 -0700 (PDT) Received: from localhost ([::1]:35565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgEeX-0003sz-UC for importer@patchew.org; Fri, 11 Aug 2017 14:27:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgEaN-0000Ch-Bz for qemu-devel@nongnu.org; Fri, 11 Aug 2017 14:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgEaM-0007Tu-63 for qemu-devel@nongnu.org; Fri, 11 Aug 2017 14:23:03 -0400 Received: from mail-by2nam01on0040.outbound.protection.outlook.com ([104.47.34.40]:44416 helo=NAM01-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgEaG-0007Qo-TP; Fri, 11 Aug 2017 14:22:57 -0400 Received: from CY4PR02CA0031.namprd02.prod.outlook.com (10.175.57.145) by DM5PR02MB2251.namprd02.prod.outlook.com (10.168.174.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Fri, 11 Aug 2017 18:22:53 +0000 Received: from CY1NAM02FT020.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::203) by CY4PR02CA0031.outlook.office365.com (2603:10b6:903:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.17 via Frontend Transport; Fri, 11 Aug 2017 18:22:53 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT020.mail.protection.outlook.com (10.152.75.191) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1304.16 via Frontend Transport; Fri, 11 Aug 2017 18:22:53 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1dgEaC-0003WM-Aq; Fri, 11 Aug 2017 11:22:52 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dgEaC-0006VW-6C; Fri, 11 Aug 2017 11:22:52 -0700 Received: from xsj-pvapsmtp01 (xsj-pvapsmtp01.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v7BIMjIL013571; Fri, 11 Aug 2017 11:22:45 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dgEa5-0006SY-9O; Fri, 11 Aug 2017 11:22:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tldvQFohEuKv7OjhYtXyi560FseoCDzU6p6cAJ2felE=; b=vLIn9DXOYo3mBWLxBHhm945coyuiv+looIeTY5VyeUq4ySTktS4dt4ayngWWEQWiVEjS5xjOHHtDMgkBDC9JVCzzgpqBHH6KsOw0dEbiyZ+Nd4D9sZ+ZcQnKG+c0r+O0A+JqwMUAtWE6ttjUFLWq3KkvnORIlS7pSN+FCWStQrM= Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; From: Alistair Francis To: , Date: Fri, 11 Aug 2017 11:19:22 -0700 Message-ID: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23250.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(199003)(189002)(8936002)(50226002)(2950100002)(6666003)(189998001)(36756003)(81156014)(81166006)(8676002)(48376002)(106466001)(2906002)(50466002)(118296001)(5660300001)(33646002)(54906002)(63266004)(478600001)(4326008)(39060400002)(626005)(9786002)(77096006)(356003)(47776003)(76176999)(50986999)(5003940100001)(305945005)(36386004)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR02MB2251; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT020; 1:j5RfC7+JRgty/aYp5EH4Nzp+vV1OYccZihyvuJL6Axrhk59zpFKiQm4WisXAB02QMJeWsyTCNFO6l3DXRbbgNJUEG9PGgAnGtYBQsuVUjMIVBXmpxwEWTqnD7tc/ApAepn1leQs+8qQt+vDyr3O/WqOTfPEjB/ljlOSwrsFGax6rSkkXc8/+0t4RWdcwICIHb0QJ9s86tMm17hp1ml/m907QKzGaj+PLzbndh/+HqcMCzdoAmpwSmPo/XyLNuwQai8Jt2OMxp1jiswr4NS81ZL2YWYl9vMOEjitdoNrMmPyXgl1Wg8FcoVM6ws0xEFJEQFiB6a8LmrVuglE4Fwcq65QVivokM83+BtH1087xqQMdmXfqY4WKYR/Vp2aawTzUU+ee4zx+903J3Y+eMFvwFP0VFZ5tAekE6oxzmyDQH5ehhdm7HFisUR9ikT5IZmtu4wC6fhqv3iZCh2+3oz37PAPN+pzfhRyzNtv76ITXGtuiYwcdR0qFaYQasBsdqekba+CmAQzPYMCHfT+M8edJA25HPzAHBfbIrrFh30DWspvVRtPXJBsnRnaOD2upOZbFTzsCWVscyeSgwZ8FrHapTTBIhFpwGfIibxlAWbSkP4tONtaFccrsVlNYD9rl+rQ/jGPu3IRtZdnMiV0cTGcjnyOw4uCmd8aNbu5iaQZM+FLguFau72h9NAA9Y9FKqQ0kG7L28PUJoWXbaoLue4yc+kctKSBDZOiD0q+i/iu6Sh7rKRR5AxNGdWnm1zqdh8v3NswY2YrLnOpyvtItwzQYseAN0NNF7lVU5RKVv5ivHaHVesjB4mMtdy1ob/KyqTJnOAx2A5YJSXoyhi2g3xsBXA== MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89590639-8a29-4ed1-6266-08d4e0e5fb84 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR02MB2251; X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2251; 3:fcRVcGLHyTu91mW4qY+Tpx7Sek7UwIGDhVd49Qj8bFFlO4CW72SZWKbTSFIzrAXNk78a2VmEGQnBNRibUFCwhHE942kqeui9gHE7qGKJXc/WReYNKcSxRcZR4mUU3kfqnEasbnlynu/4WguoS/OG9PD6KX4B+ZLQVYw3++tzLlUnINGDBZ2uK7CKrLDZweRnGO5g0Rg6dQsag6ugbmxkgLpJ976kUKabhHSt2XUZI3CEwW3o+dCI78fptaOivA5vcw9NvpHuZd7KkdcWYiaz5o7ALtIvxI7YR6Vp6YnnvDjkDXxWfVKGpqQWmYYUFpiStZdKck4f7n08WjBNGCVBbAO5CqroDbHrziotYkxk2LY=; 25:hQ1X0vPyFz+y7g1QptSB+RwHoA9NW7/FoG4kgGdxbgsIOOK/3q6vfzZBtxN8D9q2CctNoYrEz4vyCtjO/1ebdKjfpjnL2ZURdN+qfjhsNq04JL8v7imtWheM7VbInaqiMY0RmLZoAR1s1hkpI//Zl34/wlxWzULCJozf7JFCDfLpi0OIo4lTDuuRavf03xpVuF2Bf8fZeP8/5Oo1J0Do1RnzcWnZ0bZN1M361s5Lzim8wp9xUamrqAgrGcwXhWlodqwe+eenK6UylNeFK82sR0mD0lu708CUpaMd8WVemDu6BVbU5MeK296AEZMLJ6JelwfIaqpjNhyObHuw5+79Uw== X-MS-TrafficTypeDiagnostic: DM5PR02MB2251: X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2251; 31:xSZ7SLxuFQfcjOXXJKawFnn7u6qxn/HzNF5py0xmfSEHb2AV+ltpQOiK2GcPlsA37mfwzrTHvmhURkmbld7uq5d5QMsnyRDDyuM2AFAWbxXm5Z97pMQVjdNN4uHu+R80pMzYN2K9n04C7Lz0FavJWCDPFCwax5TWfRh/Mwys50en4Awd1Qm/b5xvyJpJHoFZN3lXgVVmKMp7XMIO+INfW/fQHXTAczpgVN+SqxmFClc=; 20:skT8GuaIvGjKdcBlYZdOGFR8/695K4TmvpZv98fFz9mR5IB569v1pgN/QKKsqeWWozY3bDhQbcOK9OMmvAKItL0xfUnGtZFnObuEQ4oFERw/hm1xcfBV7pwkrLUnHEfdofA17wZlRCltvzbMsGZfWTa3Gw4Rg3zfn6K+DP6zOohmwra7HAqhkAF2mb6aa+fsspCW2hsjiYkPg8tbSPG1X0fZySB+CH8crBO2LybYbxsF2Ey+3eEecHW4Adl/PUWzWnPpIfAUaLdiSPb22tO2klIhi8XLtLXujMHGzF9raj8eIkMj3lIDDPPjp2FUs6QrVziHPtl2quYkl9fpLGr0BqJWvbpghICAABN4Zn0219EBHDdXGhP7cVGY7bcL36aTWLzjoRVOUTlmf3LMAu/PIzBiDZelzZLDWuWS0ENTxErM7K3zT9O/YpCheULaGHm422xEwlQTRE7QbRhy0EIUs38VIzpl6IEmAk0+sDZGkQeOfyD3KML8ypTH+++Uuqfd X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(13016025)(13018025)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93004095)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR02MB2251; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR02MB2251; X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2251; 4:LqlqqEBdAxKeUF/StIAaY6O54HxLx6xNTAXd29Vk/t4jCeIMYTw7xJcWTs+nGgFpfL1r7tzOU7VkEjfSbIcv8Jlk96nuplWJdH/IM3qv2fGkL974tnw7LZ/KquAz8ED3QQTUiAakKq3b5Nz5xdYeHoUUtJLrPziM6A4laVXk/ZOMBbTw23+oKyGbBfQ+dVE0a+e1KDLLYxH0selMTgo1DwN5d7fXZcojy1yS4NW9ydqoVyFUCeZIf/joeDN5+bV9WE+AQc80vwTq2AmishjYakH54bgr6n7dxUGv+IT5tCs= X-Forefront-PRVS: 03965EFC76 X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2251; 23:N8Uu7BnaOfeOCxhxSrQIB1TN2R94tcQ9wMwbyvW8YAjE/6Hr+REi3Y72v1lO8eaC0Zo85dEdakMTPRrOEfTWUlovqtBd9rlmb+ezoaAXjzneswm828jBzBUkO/kdsBJq/I2+MODa4SdvM/IgJb4saoPvEi/yd9U3efPNSk/9jW5Zn4Pv9SfCxzdax6YzH4KHYVlElMGvy6f/XoD2jgryNYwBNgq6bp2/wUxoscbcsJM62QCfF2z31fupWSBg6RiTj8eAZYUKENyler3YKAJqlW1IrIF+r6ugnnwZHG+3hjkFmcAUbsvSmK6LMU+sHW5GnpZL7XoegSKhJuLJfKLjmuZiZ0lsY4pMxEkKg6jqNGe2Q1X+yGLE0v2zp8j7BKFRbMP8qavcJ2I86GCBBkIBW3eDbb1Le3h7oRtiHIGYX7qnPw+A3QSjko8Xde66+/KJ62wT68JeVSjbciUfKoEGvX0PfvaKNS3sK7newFviBpsChOMn/NEzjKkUrxJjDjYLqqYviPOTup/jqwaSck7J7PDun9p+7KUMGPUnemMFqajbGX8E675AHABEp2Q8pfQlw6NBfX8mew4UHZ+571jw6C+tgBPqlVKsrRJqaBOdiwWlag2rwcKPfVuicRhRC0KM/U/fqfRLG+IjLQGP9b04NKv7cEqchm14nx9uob252HaCUIvqKC/tydQPfz+P+/wlyUmc2qeqACAmCkPy7zTSceTu8GOi7c26le9iNWgf8tFsFBtJFVaQwJFCneTnI9AYcsJw5rPeEYvq66Ak4PVlUv9ItsDalUiAXaGp9umtzOCpj7JFS2SqZHRDK8lU9ERzitkD+dPfyOcRNSvGlyqiY47AMttQZYR8T1uMx2XunyzABIrzWEwBekx8b47dDcwQIgghupn35X4iKNhKLLp9DR17ET+T/XB5euasbqdmTPgT2adDuiWQ0ekpmEJ9MqT0 X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2251; 6:dryNN/TE7/5xh/ovB/qqG+C8BZHVOxulYFOshnA1Fx1cM4MGz6bA1Skxd6mJ7W1pVc//Nm7bfSsjlwTFbgoRgs4iu93/oNEg9c4Z3nic585pi3EJzVl4QIaMCkMY1nr5342sn4R4mX+7SUnzjvf+VIbx1mKkw6nnA/sgL9UYuCgofFbdGZrIrBOEE3BYTPze8BuBVNOQlFq6H1cvbtfQC2AhYud+CNi2xQJFpxx6H2YsJptjtbTys19Cn5T1+CH+q81fu1jPwtcR7YWmS5evv/4j2x3Y6YI3d9ciRtJ+qvE/HeIiXQ6E+skRw2jQb0srOe/YRkNal4fwJnewCCb2cg==; 5:ND1l2BXIrWBIFveg5q3N/ifgkt0Mxc0P8qlcP9OTJ5G02wZ7+ma76wYnA/qNqgo2FSO9SnsfAlUB4y6mWTgaTF1IcyKT6CbZxPvrWj6n70PTaOCX37IrfgF70AuxoPpxa2K0zZeDCl7LqB9dxfAcKg==; 24:5AkBpdWnpsPCqyfUEnPSB43t0AJ1GWpv2dJq7v8Rc7AUsTklH57HQh8jZL3vzLW4GhR7A14b3RM5/2VYhBFYiv5/61Oek8VglW+C2QyKl8g=; 7:tSCYdctVFsSpTWY3npApAjglFA1jx620XhsthMzxa9PCzafgrNXlc921VFrJ+X0E9w3t8SGWg6KK+udRA+r7GPKdtjMRWxRddt+VwI/CLxcDAIHhfxhOd8r7j7oX554K2lY1W1sMQGXY3OyyNqj77haZ223QEKQkbHijIvBM2BYgzBkbgFHWeszEY2qSLUtXzhB0eC7GTPm5o3k23EtU1ENRMs21cIrnVAbhiLVSKrg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2017 18:22:53.4847 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2251 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.34.40 Subject: [Qemu-devel] [RFC v1 2/3] tcg/tcg-op: Expose the tcg_gen_ext_i* functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, alistair23@gmail.com, qemu-arm@nongnu.org, edgar.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Expose the tcg_gen_ext_i32() and tcg_gen_ext_i64() functions as we are going to use them later. Signed-off-by: Alistair Francis Reviewed-by: Richard Henderson --- tcg/tcg-op.c | 4 ++-- tcg/tcg-op.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 87f673ef49..d25e3003ef 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -2709,7 +2709,7 @@ void tcg_gen_qemu_st_i64(TCGv_i64 val, TCGv addr, TCG= Arg idx, TCGMemOp memop) gen_ldst_i64(INDEX_op_qemu_st_i64, val, addr, memop, idx); } =20 -static void tcg_gen_ext_i32(TCGv_i32 ret, TCGv_i32 val, TCGMemOp opc) +void tcg_gen_ext_i32(TCGv_i32 ret, TCGv_i32 val, TCGMemOp opc) { switch (opc & MO_SSIZE) { case MO_SB: @@ -2730,7 +2730,7 @@ static void tcg_gen_ext_i32(TCGv_i32 ret, TCGv_i32 va= l, TCGMemOp opc) } } =20 -static void tcg_gen_ext_i64(TCGv_i64 ret, TCGv_i64 val, TCGMemOp opc) +void tcg_gen_ext_i64(TCGv_i64 ret, TCGv_i64 val, TCGMemOp opc) { switch (opc & MO_SSIZE) { case MO_SB: diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 5d3278f243..8c45b79a92 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -835,6 +835,8 @@ void tcg_gen_qemu_ld_i32(TCGv_i32, TCGv, TCGArg, TCGMem= Op); void tcg_gen_qemu_st_i32(TCGv_i32, TCGv, TCGArg, TCGMemOp); void tcg_gen_qemu_ld_i64(TCGv_i64, TCGv, TCGArg, TCGMemOp); void tcg_gen_qemu_st_i64(TCGv_i64, TCGv, TCGArg, TCGMemOp); +void tcg_gen_ext_i32(TCGv_i32 ret, TCGv_i32 val, TCGMemOp opc); +void tcg_gen_ext_i64(TCGv_i64 ret, TCGv_i64 val, TCGMemOp opc); =20 static inline void tcg_gen_qemu_ld8u(TCGv ret, TCGv addr, int mem_index) { --=20 2.11.0 From nobody Fri Mar 29 14:40:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1502475901151973.0338375200553; Fri, 11 Aug 2017 11:25:01 -0700 (PDT) Received: from localhost ([::1]:35368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgEcF-0001Oz-IE for importer@patchew.org; Fri, 11 Aug 2017 14:24:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgEaN-0000Cz-MB for qemu-devel@nongnu.org; Fri, 11 Aug 2017 14:23:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgEaM-0007UI-D5 for qemu-devel@nongnu.org; Fri, 11 Aug 2017 14:23:03 -0400 Received: from mail-co1nam03on0080.outbound.protection.outlook.com ([104.47.40.80]:36672 helo=NAM03-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgEaH-0007Qx-C1; Fri, 11 Aug 2017 14:22:57 -0400 Received: from MWHPR02CA0056.namprd02.prod.outlook.com (10.164.133.45) by DM5PR02MB2250.namprd02.prod.outlook.com (10.168.174.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Fri, 11 Aug 2017 18:22:54 +0000 Received: from CY1NAM02FT017.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::201) by MWHPR02CA0056.outlook.office365.com (2603:10b6:301:60::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.17 via Frontend Transport; Fri, 11 Aug 2017 18:22:54 +0000 Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT017.mail.protection.outlook.com (10.152.75.181) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1304.16 via Frontend Transport; Fri, 11 Aug 2017 18:22:52 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:55456 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1dgEaC-000418-Gw; Fri, 11 Aug 2017 11:22:52 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dgEaC-0006VW-EJ; Fri, 11 Aug 2017 11:22:52 -0700 Received: from xsj-pvapsmtp01 (mailhub.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v7BIMlVB013583; Fri, 11 Aug 2017 11:22:47 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dgEa7-0006TI-Lg; Fri, 11 Aug 2017 11:22:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aRyV4m8aNjrkGbTjm7ghD+WumYVX8a1P5VkfN1fzym8=; b=pRUaIPXL6PB5Fci7T4xzoyU18r3654FTrnywes/xHzZ5SNPTGUp4GxZGJdkvEBGuxMNlY2PUjl2z9Dkkza0LZNQcrN1+4vwh8stQ9lpstLqvwsemgipRUQz3UrLuWlb5ovMWN283AemkXxqWWo6NEZh3p3YTycz0waYlTlhmuH0= Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; From: Alistair Francis To: , Date: Fri, 11 Aug 2017 11:19:24 -0700 Message-ID: <2fbcf76e4ff63d8527edd3662342948276e2cd37.1502474835.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23250.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(199003)(189002)(189998001)(36386004)(77096006)(47776003)(76176999)(50986999)(478600001)(2906002)(5003940100001)(9786002)(36756003)(48376002)(2950100002)(6666003)(50466002)(33646002)(81156014)(81166006)(8676002)(8936002)(118296001)(50226002)(5660300001)(54906002)(39060400002)(305945005)(63266004)(356003)(106466001)(4326008)(626005)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR02MB2250; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT017; 1:t7usNNjUzHU1vIJYakSt/jDgYvFEZuhmP+084K1DHmpK00BOqB0KnXE6BcNcunkQIhhetfZGTz+CJwvgsoCbSIQCXNUEbdJAfM/UzgjepZiWRCPwTDxap++3tiHK8AKsF+LUzJ+akGHJwk2Ge3Ms2d5O1lc5T4CAqtFxtRbhkt9wdIwhFPxp2IhtnkZBRt5zc6AyxJ6xWW/jnH8y8aLZJj8KwHO+3ozP2rCVog2F2FcRHQ/em15/8g2FUfbPUSlvNDRr+GhJ5c1OFL+j4uNIJqx+pHzdz59S202YWmBpuKS+egRKKPTVvVWTsk53eGy/wSveqe7idn6Vy25v9CWTMPJLa6F6bEilrgla4vVZ0w1I3SijnzKp8dxpAWPM3DIDSabaUJ8FKty3ogk+VV2R4kDPaNpcHIZE10DtFNdfQCZjT/8LgPaIuRFbTlqGD3cLn8vsVKrF6lnp7tWihsDnomlLJ2rDW3/I+8hsRIvMFhnry0A1blHa5qsf/qyYPoTsDGsyMn6HvBAPFQn/fRETNAPWbO/uvWKBVuPgWdibIJedG15FIj/7hFV0GQCQZKZixl7Hn6tHmrGSlu9CL/jjXa1iC+P71fxFdR0C/oew590nfTOEr8V34i1gwMISFHjJFuB/nWSUplkjV98sGBqV0kT+RlOFV+hOMtub8qoARtVTrjP07iVymsmLkrB+tgXC7J71vCTuVEMxQmH0m2/2LlATQmlQydk0ACRYROU9dORvo38kpES2Vz30vaeApcd/qvtzdoV+Pt0L1/mBUc9ZQTWBixf++wGy8A9wOAxpKIqZSUlCTFd4sb0Q3REFkvaBRhIffqFS04BPXBnf22Lzlw== MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9abd612e-e6fa-43c9-b5d7-08d4e0e5fb46 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR02MB2250; X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2250; 3:a1KTqd3jD+L10/E57EiF3vz6dl7Md++IX98Zi1rZR7jp68C3Dm0cbB+bkyU/qqq5AOtIF8MldutHIjxULR/cMVy/y8JUZz7M+oid/d26LSHIpcqqQ1a5wFgNbh4k4Zt/y1clrCrTdeBDmJUi8WqcD73YeNY4HvJiaWuAOYBLK+aaR8X0sIoYz2vb1fVzCtGP+RG8c6x2Xo4ohqnbsKNtRinZy1N2OZNA8LYnQrubGX0SOOf1K56iKREIapI+7mtHfIQLir9y3vkxXW0StOuuGew/2OgFtlES3u7Y55MDAzJHPExteDKCMpXn+C2cHjCsu4EeiWmJqQb2hCt4ytMhWQM+/4ke4QZoZygnbrZq0YI=; 25:lZMEFYw2zgFHPcnkkXmlDRw2Rj727o7ymw1nDG1r9dfNJiwWHILTCwxAgkgq4RnWFvowVk7vPg2gBD1WkzQbi+U0/mMGgu4uRztUBJH1rOtMHGxRAEfz4uEfD0sQDEh2So2IDe1GPSnFuCQO6vbq2as0dU6pMHuijmIMt5DKTHSc0e0VkhZLMLAb6oUKB+1QhPLkhv39BmKiUUd1tBUhqGlmxWN4G4MH+bEWQ4Ds2Fm1Y1CgB3SI+gWkKfgkHutfWBaPaYZDPF8xk8XnwAECBlbK0Yb1u7CwLt3/9JlkP9l+xfqdrCKPmcn2mnmxX0yrBYMiwRAX5oCRtdb+WtLFxQ== X-MS-TrafficTypeDiagnostic: DM5PR02MB2250: X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2250; 31:VU7PIhyjpsNq/CigX1VLlzX/h9lpK9QibHhOPnJ8agvjW192CQYkvPtWajHFsgfO8bftX7Sa4TB5q0MHEIPWQ0uXWT1KFy//+FrzllNpCfRLnSA1Uo1FhBz2qVCDiCRK2O2/wVTIHU4LrHM8To1+OMA9UJJwiFseaw49sGsXsfzeMzxIPPFxJtpGz52kG56FoXsIalEEZR1zBy8ISpgESCw9EZnfQSc7xax5/1WE3YY=; 20:nlrUC3P5iKZGjh2U8oNueYmOZ512KHiBdm4/3qihHygxQEFNWt+WAs7VzXrZL7xGMjaB4Zl4r4+SD61emeibogDltvizP+HRCm3Bd4u7PxLHAo6j5YCfXthT5D3jaIPrLMZ74tf+JcaFDVBZ3UrXxT/VuVkeFByI1YCHQP+kkEIuwB/fomE7x7DAlusm8NOTD3I1HoAIplJXjLFntBSJtMbfD2rWJNscO7q3TWb1aWW0LE2P6mvSWQDodzTbexReH4SjQeCKBegeiwMeAeabb8KVCvo61pYqGiOo19ZlnEBW0/z12MxoT++2kLKHwP33EeQ1kat5w/wJPjCUrSNVrTLG3MyfQJG1nh3L7kLqDwuZtEod0at1xn04OOJVctfZVGziVREn1gp4TNfFDhOr06EnE5hlzX6UplQvRf4REFL/VOAj5C80+pol2cMJ2mOGOPIQZ4uQC2YE/Cqf6AjmCweNKoLFbOHn/+4jScP5a8Gz0plB4X/dvoPEUCUzUY5O X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(13016025)(13018025)(8121501046)(93006095)(93004095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR02MB2250; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR02MB2250; X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2250; 4:7tOShZef+HSNwu+VlM6HjIg4TAiVxaH17DOpEDFy0elb4Plhv7KP1K7elC7CrS15+t363hSvKOO7pa6QCos+yHmCIltt6gdx2675qSsS0MYFZgtABPC/0stk5Ew8Ulw3ZkV09HyrgHJ/nMVEGdaebvLRoTw6CehUArNYl4FhZ/bCyqAMY3LM2cXCTFoij1RqUvvtstnofATvpdicFEb5rx3NZgL/A1szB6feZhs7JKj0+Lp8eLPnPdb574ypc8HvHoRs3N73Nw7fHix166qCwHP0JNhrVt62dtFrjZJGYTM= X-Forefront-PRVS: 03965EFC76 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR02MB2250; 23:eZnwBE2492PKaqBJiFKtQRpvOvlN6+GKngB61nGrW?= =?us-ascii?Q?2WMnc2JnJvfgJQnvjfP7vkoQL9+8qWqz/Fl1Dx5Ok+VmBspL9yf0X6u7c8Fu?= =?us-ascii?Q?/yTDtI480aQIL/9iUIrXTtzWdgqON6mH0N/x/9Iba1Yp1lXAlxzeIBSGtyOG?= =?us-ascii?Q?gzX/huO8e6AGQJB4yfY1q60wfzXglVkphh4zocpeVc4pDLfKjZEcCAe/t2R/?= =?us-ascii?Q?4IM2BZkf909lyhN6f2bRDRWqzpA0xEV7R8iVJVko19S9xnV3/4DbfNtCFmKu?= =?us-ascii?Q?5Tt7T7lEC503DomgjBeL1kyaybBWVGyqxmVNgljaMyPCaU982o/uQvaVccG8?= =?us-ascii?Q?6d20ETbdw2OMXWVSZ38IKRLtVRARYI0XpbYvV38ir6oC0YKJXOWfpcpczmGa?= =?us-ascii?Q?y7z2zI5DWY7g2z3dFkDn6W/7ceN//Lxtz3BL28AbO80FueVui5+pZF+uWamE?= =?us-ascii?Q?25xioqlLL+68rpfF5+JOHiircJWymTj2dgK3t7dxCR6z/rdAgKmSLBtT2BE/?= =?us-ascii?Q?haVSHlhNmoAzNeEHwGoae8vhlnvspqddxAXMTr1V7JPI3rM4JnaoDbWG0/du?= =?us-ascii?Q?qF0lM/2NHOBEkMJSCIjVXt6U2TrbIXdbWjh+L/SfAa/hFW8pv9+ZctqePAnB?= =?us-ascii?Q?nuKwERTiJB6GLp6OlVmMVrPSxrU3GTjJDVOJfRWP3muFDzXz80yUXx3aRFw+?= =?us-ascii?Q?qvFyizshec9BK23Ln9BBwLGZpT7iWxCxGB8B99sEON6J3QzKArHQrmIN2mjr?= =?us-ascii?Q?x4USAMo7zzXSRIdDAnoSS9AQsflUAVguIHdOdMqqdH+RHHxbusPiMBccfwRD?= =?us-ascii?Q?JVQFOhQo6mV1sQ2sHiq0P1P8fKvtZe3DHGocc3pNOwaPKW6Oq1Jk+yTB/25H?= =?us-ascii?Q?Z/wQIr1OEuCJ9F3ziqPr3aQHJQqLnltCjtylRkSgMi5VjVP4hrP3z9zlaUdD?= =?us-ascii?Q?FdZWIdO4bstVk0Eo/iuY/JhkCpboKncyHPcu/pTRw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB2250; 6:kRhqkDQ3yulNc2V95LKmWGypMpgPMJl8MSKwkOxFCTGFSES7WYvArjpGB9o6z66Tp9+EIWwqoJWdMk7trbqdUnyBGJdDpFsj2ND/by4yY9mqULjqHP1N6L69cFiTc7uv+KknVQBn2CpG8HqZ7ccJJl1fz+gzMTmu+1brZkFLzrx5HYRH9/L4jbkIZF3dOGOWhdl7cOE2lBplpPCSvHC+uXwCD5de7QrmWocVHEOAsMau7fmNmxawRg5rBNIY7xm5RKJOdoocTGY9oqMjwsbX59/Pwyg8JERbSWOPfJmNgeCg5w3HsdyXH/aeWx1YR8aeux39OKQvBRj2NIUR9JkFfQ==; 5:wD+aan/sHpRpUyleVW+MQuuQGUxJTIN3q8zGop3naRpFiU6S9ME+IwDiS8WaF+iBFPGFTTir5Ooclus/21mC0PRaCIjxsfBCu7IPtB1XJoRTKFVR6EUyEE+h+s+DXZsg4921R4B1K7L2IPSnRiJZgw==; 24:P4sF203vS+8CkNdnsJkpliq0JDtw/3cejpyIGUIyjLKsMYWeer80/CedFrrC0GHEQw6rkDvbeEDooKbkn8JDvCaX/PFKAIdi1ECK34UPhjI=; 7:LGUee5ZklgPxa2iHlulA1JSQ4ugX4i7aYaLew7yk7SXSlBSjOQkhPgIuwrR/DyBG1W4kkT7kmp1BnH01y9wrCE3a1P4BKlpeOakPFVlefviScNezvYrqafeabL1Wy8r8jXy46kXomK4ND9xPPpGBgOo8lQA5jaBE3yP6lauKJxROmvvTDsKEdeeEC5ZhEeunrfLdRBc+B7rzrYRV1d6leX0qYNc+AnWTDNxdhgMezLI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2017 18:22:52.9555 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2250 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.40.80 Subject: [Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, alistair23@gmail.com, qemu-arm@nongnu.org, edgar.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The exclusive store operation should return 0 if the operation updates memory and 1 if it doesn't. This means that storing tmp in the rd register is incorrect. This patch updates the succesful opertion to store 0 into the rd register instead of tmp. It also adds a branch to fail if the memory isn't updated. In order to add a branch for the pair case when size equals 2 we first need to apply the same memory operation on the exclusive value in order for the comparison to work. There is still no value checks added if we are doing a 64-bit store with pairs. Signed-off-by: Alistair Francis --- This was caught with an internal fuzzy tester. These patches fix the Xilinx 2.10-rc2 tree. I tested with the fuzzy tester (single CPU) and Linux boot (4 CPUs) on the Xilinx tree. I don't have a good test case to run on mainline at the moment, but I'm working on getting one. Also linux-user is fully untested. All tests were with MTTCG enabled. target/arm/translate-a64.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 245175e2f1..ea7c61bc6f 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -1894,10 +1894,11 @@ static void gen_store_exclusive(DisasContext *s, in= t rd, int rt, int rt2, * } * env->exclusive_addr =3D -1; */ + TCGMemOp memop =3D size | MO_ALIGN | s->be_data; TCGLabel *fail_label =3D gen_new_label(); TCGLabel *done_label =3D gen_new_label(); TCGv_i64 addr =3D tcg_temp_local_new_i64(); - TCGv_i64 tmp; + TCGv_i64 tmp, val; =20 /* Copy input into a local temp so it is not trashed when the * basic block ends at the branch insn. @@ -1907,15 +1908,15 @@ static void gen_store_exclusive(DisasContext *s, in= t rd, int rt, int rt2, =20 tmp =3D tcg_temp_new_i64(); if (is_pair) { + val =3D tcg_temp_new_i64(); if (size =3D=3D 2) { - TCGv_i64 val =3D tcg_temp_new_i64(); tcg_gen_concat32_i64(tmp, cpu_reg(s, rt), cpu_reg(s, rt2)); tcg_gen_concat32_i64(val, cpu_exclusive_val, cpu_exclusive_hig= h); tcg_gen_atomic_cmpxchg_i64(tmp, addr, val, tmp, get_mem_index(s), - size | MO_ALIGN | s->be_data); - tcg_gen_setcond_i64(TCG_COND_NE, tmp, tmp, val); - tcg_temp_free_i64(val); + memop); + tcg_gen_ext_i64(val, val, memop); + tcg_gen_brcond_i64(TCG_COND_NE, tmp, val, fail_label); } else if (s->be_data =3D=3D MO_LE) { gen_helper_paired_cmpxchg64_le(tmp, cpu_env, addr, cpu_reg(s, = rt), cpu_reg(s, rt2)); @@ -1924,22 +1925,23 @@ static void gen_store_exclusive(DisasContext *s, in= t rd, int rt, int rt2, cpu_reg(s, rt2)); } } else { - TCGv_i64 val =3D cpu_reg(s, rt); + val =3D cpu_reg(s, rt); tcg_gen_atomic_cmpxchg_i64(tmp, addr, cpu_exclusive_val, val, get_mem_index(s), - size | MO_ALIGN | s->be_data); - tcg_gen_setcond_i64(TCG_COND_NE, tmp, tmp, cpu_exclusive_val); + memop); + tcg_gen_brcond_i64(TCG_COND_NE, tmp, cpu_exclusive_val, fail_label= ); } =20 tcg_temp_free_i64(addr); =20 - tcg_gen_mov_i64(cpu_reg(s, rd), tmp); - tcg_temp_free_i64(tmp); + tcg_gen_movi_i64(cpu_reg(s, rd), 0); tcg_gen_br(done_label); =20 gen_set_label(fail_label); tcg_gen_movi_i64(cpu_reg(s, rd), 1); gen_set_label(done_label); + tcg_temp_free_i64(tmp); + tcg_temp_free_i64(val); tcg_gen_movi_i64(cpu_exclusive_addr, -1); } =20 --=20 2.11.0