[Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling

Mao Zhongyi posted 4 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1495508197.git.maozy.fnst@cn.fujitsu.com
Test checkpatch passed
Test docker passed
Test s390x passed
hw/net/rocker/rocker.c        | 93 ++++++++++---------------------------------
hw/net/rocker/rocker_desc.c   | 10 -----
hw/net/rocker/rocker_fp.c     |  4 --
hw/net/rocker/rocker_of_dpa.c | 20 ----------
hw/net/rocker/rocker_world.c  | 12 +++---
5 files changed, 27 insertions(+), 112 deletions(-)
[Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling
Posted by Mao Zhongyi 6 years, 11 months ago
v5:
* Patch 1 removed the dead error handling that was previously missing.
* Patch 2 and 3 has not changed.
* Patch 4 is a new patch to fix the unusual macro name.

v4:
* Patch 1 is following Markus's suggestion that remove the dead error
  handling.
* Patch 2 is separate from patch 1 to plug the memory leak in the v3.
* Patch 3 is based on the patch 1 in the v3. Meanwhile, dorp the superfluous
  prefix "rocker:" and adjust the commit message.

v3:
* Following Jason's suggstion that add suitable error message to 
  each error site.
* Modified the commit message to make it easier to read.

v2:
* Following Philippe's suggestion that shorten the patch subject 
  "hw/net/rocker/rocker" to "net/rocker". 
* Use a consistent log format to report error message.
* Add a specific goto label "err_name_too_long" to make a correct
  cleanup.

Mao Zhongyi (4):
  net/rocker: Remove the dead error handling
  net/rocker: Plug memory leak in pci_rocker_init()
  net/rocker: Convert to realize()
  net/rocker: Fix the unusual macro name

 hw/net/rocker/rocker.c        | 93 ++++++++++---------------------------------
 hw/net/rocker/rocker_desc.c   | 10 -----
 hw/net/rocker/rocker_fp.c     |  4 --
 hw/net/rocker/rocker_of_dpa.c | 20 ----------
 hw/net/rocker/rocker_world.c  | 12 +++---
 5 files changed, 27 insertions(+), 112 deletions(-)

-- 
2.9.3




Re: [Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling
Posted by Mao Zhongyi 6 years, 8 months ago
Hi, Jason

This was posted over 2 months ago with two R-Bs(Markus & Philippe),
did it get merged or dropped?

Thanks,
Mao

On 05/23/2017 12:04 PM, Mao Zhongyi wrote:
> v5:
> * Patch 1 removed the dead error handling that was previously missing.
> * Patch 2 and 3 has not changed.
> * Patch 4 is a new patch to fix the unusual macro name.
>
> v4:
> * Patch 1 is following Markus's suggestion that remove the dead error
>   handling.
> * Patch 2 is separate from patch 1 to plug the memory leak in the v3.
> * Patch 3 is based on the patch 1 in the v3. Meanwhile, dorp the superfluous
>   prefix "rocker:" and adjust the commit message.
>
> v3:
> * Following Jason's suggstion that add suitable error message to
>   each error site.
> * Modified the commit message to make it easier to read.
>
> v2:
> * Following Philippe's suggestion that shorten the patch subject
>   "hw/net/rocker/rocker" to "net/rocker".
> * Use a consistent log format to report error message.
> * Add a specific goto label "err_name_too_long" to make a correct
>   cleanup.
>
> Mao Zhongyi (4):
>   net/rocker: Remove the dead error handling
>   net/rocker: Plug memory leak in pci_rocker_init()
>   net/rocker: Convert to realize()
>   net/rocker: Fix the unusual macro name
>
>  hw/net/rocker/rocker.c        | 93 ++++++++++---------------------------------
>  hw/net/rocker/rocker_desc.c   | 10 -----
>  hw/net/rocker/rocker_fp.c     |  4 --
>  hw/net/rocker/rocker_of_dpa.c | 20 ----------
>  hw/net/rocker/rocker_world.c  | 12 +++---
>  5 files changed, 27 insertions(+), 112 deletions(-)
>



Re: [Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling
Posted by Jason Wang 6 years, 8 months ago

On 2017年07月26日 11:45, Mao Zhongyi wrote:
> Hi, Jason
>
> This was posted over 2 months ago with two R-Bs(Markus & Philippe),
> did it get merged or dropped?
>
> Thanks,
> Mao

Hi:

Want to merge but it does not apply cleanly on HEAD. Could you please 
rebase and post a V6?

Thanks


Re: [Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling
Posted by Mao Zhongyi 6 years, 8 months ago

On 07/26/2017 12:09 PM, Jason Wang wrote:
>
>
> On 2017年07月26日 11:45, Mao Zhongyi wrote:
>> Hi, Jason
>>
>> This was posted over 2 months ago with two R-Bs(Markus & Philippe),
>> did it get merged or dropped?
>>
>> Thanks,
>> Mao
>
> Hi:
>
> Want to merge but it does not apply cleanly on HEAD. Could you please rebase and post a V6?
>

OK, I will

Thanks :)


> Thanks
>
>
>
>