[Qemu-devel] [PATCH 00/10] Improvements for sm501 display controller emulation

BALATON Zoltan posted 10 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1487522123.git.balaton@eik.bme.hu
Test checkpatch passed
Test docker passed
Test s390x passed
default-configs/ppc-softmmu.mak    |    1 +
default-configs/ppcemb-softmmu.mak |    1 +
hw/display/sm501.c                 | 1546 ++++++++++++++++++++----------------
hw/display/sm501_template.h        |   92 +--
hw/sh4/r2d.c                       |   11 +-
include/hw/devices.h               |    5 -
6 files changed, 920 insertions(+), 736 deletions(-)
[Qemu-devel] [PATCH 00/10] Improvements for sm501 display controller emulation
Posted by BALATON Zoltan 7 years, 1 month ago
This series improves the sm501 display controller emulation fixing
endianness problems that caused mixed up colors in LE hosts, fix hardware
cursor and adding panel layer support and some missing registers. The
first few patches update the code style and QOMify the device before
changes are made to it in subsequent patches.

Including qemu-trivial list as well, both because some of the patches
are trivial and also I'm not sure how actively maintained this part is
so that also may need attention from the trivial list to get this merged.

The changes were tested with sh4 image at
https://people.debian.org/~aurel32/qemu/sh4/
which accepts video= kernel parameter to excercise different screen modes.

BALATON Zoltan (10):
  sm501: Fixed code style and a few typos in comments
  sm501: Use defines instead of constants where available
  sm501: QOMify
  sm501: Add emulation of chip connected via PCI
  sm501: Add missing arbitration control register
  sm501: Fix device endianness
  sm501: Fix hardware cursor
  sm501: Add support for panel layer
  sm501: Add some more missing registers
  ppc: Add SM501 device in config for ppc and ppcemb targets

 default-configs/ppc-softmmu.mak    |    1 +
 default-configs/ppcemb-softmmu.mak |    1 +
 hw/display/sm501.c                 | 1546 ++++++++++++++++++++----------------
 hw/display/sm501_template.h        |   92 +--
 hw/sh4/r2d.c                       |   11 +-
 include/hw/devices.h               |    5 -
 6 files changed, 920 insertions(+), 736 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH 00/10] Improvements for sm501 display controller emulation
Posted by BALATON Zoltan 7 years, 1 month ago
On Sun, 19 Feb 2017, BALATON Zoltan wrote:
> This series improves the sm501 display controller emulation fixing
> endianness problems that caused mixed up colors in LE hosts, fix hardware
> cursor and adding panel layer support and some missing registers. The
> first few patches update the code style and QOMify the device before
> changes are made to it in subsequent patches.
>
> Including qemu-trivial list as well, both because some of the patches
> are trivial and also I'm not sure how actively maintained this part is
> so that also may need attention from the trivial list to get this merged.
>
> The changes were tested with sh4 image at
> https://people.debian.org/~aurel32/qemu/sh4/
> which accepts video= kernel parameter to excercise different screen modes.
>
> BALATON Zoltan (10):
>  sm501: Fixed code style and a few typos in comments
>  sm501: Use defines instead of constants where available
>  sm501: QOMify
>  sm501: Add emulation of chip connected via PCI
>  sm501: Add missing arbitration control register
>  sm501: Fix device endianness
>  sm501: Fix hardware cursor
>  sm501: Add support for panel layer
>  sm501: Add some more missing registers
>  ppc: Add SM501 device in config for ppc and ppcemb targets
>
> default-configs/ppc-softmmu.mak    |    1 +
> default-configs/ppcemb-softmmu.mak |    1 +
> hw/display/sm501.c                 | 1546 ++++++++++++++++++++----------------
> hw/display/sm501_template.h        |   92 +--
> hw/sh4/r2d.c                       |   11 +-
> include/hw/devices.h               |    5 -
> 6 files changed, 920 insertions(+), 736 deletions(-)

Ping? Is there anyone who could take a look and merge this? It could get 
tested more during the freeze and could be reverted any time if found to 
cause any problems but if it's not merged now it may get delayed for 
months until the next opportunity.
Patchwork links:

http://patchwork.ozlabs.org/patch/729575/
http://patchwork.ozlabs.org/patch/729570/
http://patchwork.ozlabs.org/patch/729571/
http://patchwork.ozlabs.org/patch/729574/
http://patchwork.ozlabs.org/patch/729576/
http://patchwork.ozlabs.org/patch/729577/
http://patchwork.ozlabs.org/patch/729572/
http://patchwork.ozlabs.org/patch/729573/
http://patchwork.ozlabs.org/patch/729569/
http://patchwork.ozlabs.org/patch/729568/