From nobody Tue May 14 17:07:42 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yadro.com ARC-Seal: i=1; a=rsa-sha256; t=1688401096; cv=none; d=zohomail.com; s=zohoarc; b=eOwxACeZdOgNHDOGw2SSf2aqn8MnhCnq+HmeqVWxJo4SKMlx20I/CiH5IKM3sPGdb9jltbcjuX+RNAzLdBzkWgB/Xj7HhzarUuXR2tv3fwbb+4hp3iw2fHc4BfirQbzhVznjacqYoglWvxfy14vmMG3wqdb34TZfFMepFG6ZFG0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688401096; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=XJ2pcR4ZiCVxAjNKvHdeTUYjxJU1n/ZoU/wgyGxAYLE=; b=Ga8eVcjFNY5QS7fNehbTUX1Y8ppFF1F31b9I5tI+vczZbhFYWzBhO9SCOvme0DY+I+BDV03CUu/k+ZJt59EeM0FD6bXUNmNT9oD+nIOqx01bYrGOA1RxHQ0XPN5/EXtZvcVsZTJ2HhtKbC3K7JMnDg8TzUvimBdgfgGG0mU3e1w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1688401096113841.0532682606973; Mon, 3 Jul 2023 09:18:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGMF1-00049y-08; Mon, 03 Jul 2023 12:17:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGMEt-00049f-Sc for qemu-devel@nongnu.org; Mon, 03 Jul 2023 12:17:29 -0400 Received: from mta-04.yadro.com ([89.207.88.248]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGMEq-0002TL-Oz for qemu-devel@nongnu.org; Mon, 03 Jul 2023 12:17:23 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 mta-04.yadro.com 17751C0002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yadro.com; s=mta-04; t=1688401032; bh=XJ2pcR4ZiCVxAjNKvHdeTUYjxJU1n/ZoU/wgyGxAYLE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Content-Type:From; b=I5zy5ZH0hqAXS+QNExB3jfDjRrgKQFFGo41PD5dFguRu5YkxCHkE3uXjH1NqI7mhM LmuvypfOqrnfon/gkzxuyThYmDVMXyLXOqB4klfnjN9HHwlj3L0L/KWap/O4btbcpi Mbui7rKPWh+1JTnHcUFc81uw0tS9wt8droJ3AhDGyHCzH9A3+8y3+qPxVJdS1BSwpa HlseV12y4J7BuJRKmqVV0YB8H96PZV9YZyQsGsFkvOi9d2tvHv3O2gERQnDruqK+mM SKIdtNIVY74lP6xDd92iHsWmaYHZwuRVPtgPzTMUMdtWX6b1rxwVXyq2FAoOHJNhtN CW3Y7WyZmwAxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yadro.com; s=mta-03; t=1688401032; bh=XJ2pcR4ZiCVxAjNKvHdeTUYjxJU1n/ZoU/wgyGxAYLE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Content-Type:From; b=AMKAygRE1uFY+/dse2AEqkWP9YjsKPn9YqBiarXUwlQ4Zkfg7YzG2G0mMsbtp+tda 29mayfcPDNjhgw8Ema+z/KhxSowis6qjb2Go3qiQYNPzRa2jqe+fUn97WLKzgzszWL 1Y+y/eq6oNOD/KY263/D88zoXIqpRiHFJPhHP6BX88sPxywPkrKVptCOKOKVh34HZZ OqWMFCv1SwlKRnQex/FcMTg03JqkAf9Ky36G/odFqets1ASeqgOQTmXq3FVI6xPXa8 MN6f1jwftFfeG6cjJInXdWFMLKPPeR9laCICdbkmMHkg3ZUe68+mHxhcEIl/4Jqh77 YetTCs7S0wa/g== Message-ID: Date: Mon, 3 Jul 2023 19:16:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 From: Mikhail Tyutin Subject: [PATCH] Fix SEGFAULT on getting physical address of MMIO region. To: "qemu-devel@nongnu.org" CC: Dmitriy Solovev , , Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: T-Exch-05.corp.yadro.com (172.17.10.109) To T-EXCH-08.corp.yadro.com (172.17.11.58) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=89.207.88.248; envelope-from=m.tyutin@yadro.com; helo=mta-04.yadro.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yadro.com) (identity @yadro.com) X-ZM-MESSAGEID: 1688401099041100001 Content-Type: text/plain; charset="utf-8"; format="flowed" The fix is to clear TLB_INVALID_MASK bit in tlb_addr, as it happens in=20 other places e.g. load_helper(). Signed-off-by: Dmitriy Solovev Signed-off-by: Mikhail Tyutin --- accel/tcg/cputlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 5b51eff5a4..9045b6330a 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1708,7 +1708,7 @@ bool tlb_plugin_lookup(CPUState *cpu, vaddr addr,=20 int mmu_idx, uintptr_t index =3D tlb_index(env, mmu_idx, addr); uint64_t tlb_addr =3D is_store ? tlb_addr_write(tlbe) : tlbe->addr_re= ad; - if (likely(tlb_hit(tlb_addr, addr))) { + if (likely(tlb_hit(tlb_addr & ~TLB_INVALID_MASK, addr))) { /* We must have an iotlb entry for MMIO */ if (tlb_addr & TLB_MMIO) { CPUTLBEntryFull *full; --=20 2.34.1