1. Patchew
  2. QEMU
  3. View series

[PATCH] Add zh_TW Traditional Chinese translation

Peter Dave Hello posted 1 patch 1 week, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/adPv4goMCNmjeDRUK1LGCAHIZdOxvMoFAqlU1bCnvTCPsCTUFRQnOQnThBC3oIzU9IczdS6aw1vKLQ-w7Zk9CRo5FfvINiaInut._5FU4VwbeI=@peterdavehello.org
po/LINGUAS  |  1 +
po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 94 insertions(+)
create mode 100644 po/zh_TW.po
[PATCH] Add zh_TW Traditional Chinese translation
Posted by Peter Dave Hello 1 week, 6 days ago 
From: Peter Dave Hello <hsu@peterdavehello.org>
Date: Tue, 16 Apr 2024 00:43:29 +0800
Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation

This patch adds a basic zh_TW translation file for Taiwan Traditional
Chinese users.

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
---
 po/LINGUAS  |  1 +
 po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 94 insertions(+)
 create mode 100644 po/zh_TW.po

diff --git a/po/LINGUAS b/po/LINGUAS
index 9b33a36..08163e8 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -7,3 +7,4 @@ sv
 tr
 uk
 zh_CN
+zh_TW
diff --git a/po/zh_TW.po b/po/zh_TW.po
new file mode 100644
index 0000000..d25557e
--- /dev/null
+++ b/po/zh_TW.po
@@ -0,0 +1,93 @@
+# Chinese translations for PACKAGE package.
+# Copyright (C) 2024 THE PACKAGE'S COPYRIGHT HOLDER
+# This file is distributed under the same license as the PACKAGE package.
+# Peter Hsu <hsu@peterdavehello.org>, 2024.
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: PACKAGE VERSION\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2024-04-16 17:52+0800\n"
+"PO-Revision-Date: 2024-04-16 17:52+0800\n"
+"Last-Translator: Peter Hsu <hsu@peterdavehello.org>\n"
+"Language-Team: Chinese (traditional)\n"
+"Language: zh_TW\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=ASCII\n"
+"Content-Transfer-Encoding: 8bit\n"
+
+#: ui/gtk.c:231
+msgid " - Press Ctrl+Alt+G to release grab"
+msgstr " - 按下 Ctrl+Alt+G 以釋放鎖定"
+
+#: ui/gtk.c:235
+msgid " [Paused]"
+msgstr " [已暫停]"
+
+#: ui/gtk.c:2094
+msgid "_Pause"
+msgstr "暫停(_P)"
+
+#: ui/gtk.c:2100
+msgid "_Reset"
+msgstr "重設(_R)"
+
+#: ui/gtk.c:2103
+msgid "Power _Down"
+msgstr "關機(_D)"
+
+#: ui/gtk.c:2109
+msgid "_Quit"
+msgstr "結束(_Q)"
+
+#: ui/gtk.c:2239
+msgid "_Fullscreen"
+msgstr "全螢幕(_F)"
+
+#: ui/gtk.c:2242
+msgid "_Copy"
+msgstr "複製(_C)"
+
+#: ui/gtk.c:2256
+msgid "Zoom _In"
+msgstr "放大(_I)"
+
+#: ui/gtk.c:2265
+msgid "Zoom _Out"
+msgstr "縮小(_O)"
+
+#: ui/gtk.c:2272
+msgid "Best _Fit"
+msgstr "最佳尺寸(_F)"
+
+#: ui/gtk.c:2279
+msgid "Zoom To _Fit"
+msgstr "調整至最佳大小(_F)"
+
+#: ui/gtk.c:2285
+msgid "Grab On _Hover"
+msgstr "滑過時鎖定(_H)"
+
+#: ui/gtk.c:2288
+msgid "_Grab Input"
+msgstr "鎖定輸入(_G)"
+
+#: ui/gtk.c:2317
+msgid "Show _Tabs"
+msgstr "顯示分頁(_T)"
+
+#: ui/gtk.c:2320
+msgid "Detach Tab"
+msgstr "分離分頁"
+
+#: ui/gtk.c:2324
+msgid "Show Menubar"
+msgstr "顯示功能表列(_M)"
+
+#: ui/gtk.c:2346
+msgid "_Machine"
+msgstr "機器(_M)"
+
+#: ui/gtk.c:2351
+msgid "_View"
+msgstr "檢視(_V)"
-- 
2.25.1
Re: [PATCH] Add zh_TW Traditional Chinese translation
Posted by Zhao Liu 1 week, 6 days ago 
On Tue, Apr 16, 2024 at 11:31:24AM +0000, Peter Dave Hello wrote:
> Date: Tue, 16 Apr 2024 11:31:24 +0000
> From: Peter Dave Hello <hsu@peterdavehello.org>
> Subject: [PATCH] Add zh_TW Traditional Chinese translation
> 
> From: Peter Dave Hello <hsu@peterdavehello.org>
> Date: Tue, 16 Apr 2024 00:43:29 +0800
> Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
> 
> This patch adds a basic zh_TW translation file for Taiwan Traditional
> Chinese users.
> 
> Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
> ---
>  po/LINGUAS  |  1 +
>  po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 94 insertions(+)
>  create mode 100644 po/zh_TW.po
> 
> diff --git a/po/LINGUAS b/po/LINGUAS
> index 9b33a36..08163e8 100644
> --- a/po/LINGUAS
> +++ b/po/LINGUAS
> @@ -7,3 +7,4 @@ sv
>  tr
>  uk
>  zh_CN
> +zh_TW
> diff --git a/po/zh_TW.po b/po/zh_TW.po
> new file mode 100644
> index 0000000..d25557e
> --- /dev/null
> +++ b/po/zh_TW.po
> @@ -0,0 +1,93 @@
> +# Chinese translations for PACKAGE package.
> +# Copyright (C) 2024 THE PACKAGE'S COPYRIGHT HOLDER
> +# This file is distributed under the same license as the PACKAGE package.
> +# Peter Hsu <hsu@peterdavehello.org>, 2024.
> +#
> +msgid ""
> +msgstr ""
> +"Project-Id-Version: PACKAGE VERSION\n"

"Project-Id-Version: QEMU 9.1 \n"

(Now the target version should be v9.1.)

> +"Report-Msgid-Bugs-To: \n"

"Report-Msgid-Bugs-To: qemu-devel@nongnu.org\n"

> +"POT-Creation-Date: 2024-04-16 17:52+0800\n"
> +"PO-Revision-Date: 2024-04-16 17:52+0800\n"
> +"Last-Translator: Peter Hsu <hsu@peterdavehello.org>\n"
> +"Language-Team: Chinese (traditional)\n"
> +"Language: zh_TW\n"
> +"MIME-Version: 1.0\n"
> +"Content-Type: text/plain; charset=ASCII\n"
> +"Content-Transfer-Encoding: 8bit\n"
> +
> +#: ui/gtk.c:231

Referring to the support of other languages, the comment here can be
deleted. The lineno related comments in the following text can be
similarly deleted.

Regards,
Zhao
Re: [PATCH] Add zh_TW Traditional Chinese translation
Posted by Peter Maydell 1 week, 6 days ago 
On Tue, 16 Apr 2024 at 14:00, Peter Dave Hello <hsu@peterdavehello.org> wrote:
>
> From: Peter Dave Hello <hsu@peterdavehello.org>
> Date: Tue, 16 Apr 2024 00:43:29 +0800
> Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
>
> This patch adds a basic zh_TW translation file for Taiwan Traditional
> Chinese users.
>
> Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>

This name in your Signed-off-by line doesn't match the
name you use in the .po file...

> ---
>  po/LINGUAS  |  1 +
>  po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 94 insertions(+)
>  create mode 100644 po/zh_TW.po
>
> diff --git a/po/LINGUAS b/po/LINGUAS
> index 9b33a36..08163e8 100644
> --- a/po/LINGUAS
> +++ b/po/LINGUAS
> @@ -7,3 +7,4 @@ sv
>  tr
>  uk
>  zh_CN
> +zh_TW
> diff --git a/po/zh_TW.po b/po/zh_TW.po
> new file mode 100644
> index 0000000..d25557e
> --- /dev/null
> +++ b/po/zh_TW.po
> @@ -0,0 +1,93 @@
> +# Chinese translations for PACKAGE package.
> +# Copyright (C) 2024 THE PACKAGE'S COPYRIGHT HOLDER
> +# This file is distributed under the same license as the PACKAGE package.

Can you replace all these placeholder ALLCAPS items
with the right values, please?

> +# Peter Hsu <hsu@peterdavehello.org>, 2024.
> +#
> +msgid ""
> +msgstr ""
> +"Project-Id-Version: PACKAGE VERSION\n"

There's another one here.

> +"Report-Msgid-Bugs-To: \n"
> +"POT-Creation-Date: 2024-04-16 17:52+0800\n"
> +"PO-Revision-Date: 2024-04-16 17:52+0800\n"
> +"Last-Translator: Peter Hsu <hsu@peterdavehello.org>\n"
> +"Language-Team: Chinese (traditional)\n"
> +"Language: zh_TW\n"
> +"MIME-Version: 1.0\n"
> +"Content-Type: text/plain; charset=ASCII\n"
> +"Content-Transfer-Encoding: 8bit\n"

thanks
-- PMM
Re: [PATCH] Add zh_TW Traditional Chinese translation
Posted by Zhao Liu 1 week, 6 days ago 
Hi Peter,

On Tue, Apr 16, 2024 at 02:27:45PM +0100, Peter Maydell wrote:
> Date: Tue, 16 Apr 2024 14:27:45 +0100
> From: Peter Maydell <peter.maydell@linaro.org>
> Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
> 
> On Tue, 16 Apr 2024 at 14:00, Peter Dave Hello <hsu@peterdavehello.org> wrote:
> >
> > From: Peter Dave Hello <hsu@peterdavehello.org>
> > Date: Tue, 16 Apr 2024 00:43:29 +0800
> > Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
> >
> > This patch adds a basic zh_TW translation file for Taiwan Traditional
> > Chinese users.
> >
> > Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
> 
> This name in your Signed-off-by line doesn't match the
> name you use in the .po file...
> 
> > ---
> >  po/LINGUAS  |  1 +
> >  po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 94 insertions(+)
> >  create mode 100644 po/zh_TW.po
> >
> > diff --git a/po/LINGUAS b/po/LINGUAS
> > index 9b33a36..08163e8 100644
> > --- a/po/LINGUAS
> > +++ b/po/LINGUAS
> > @@ -7,3 +7,4 @@ sv
> >  tr
> >  uk
> >  zh_CN
> > +zh_TW
> > diff --git a/po/zh_TW.po b/po/zh_TW.po
> > new file mode 100644
> > index 0000000..d25557e
> > --- /dev/null
> > +++ b/po/zh_TW.po
> > @@ -0,0 +1,93 @@
> > +# Chinese translations for PACKAGE package.
> > +# Copyright (C) 2024 THE PACKAGE'S COPYRIGHT HOLDER
> > +# This file is distributed under the same license as the PACKAGE package.
> 
> Can you replace all these placeholder ALLCAPS items
> with the right values, please?
> 
> > +# Peter Hsu <hsu@peterdavehello.org>, 2024.
> > +#

Open source license is missing here.

And I checked the other .po files and found that none of them declare
the open source license, are they missing it? Or does this case default
to "GPL-2.0-or-later"?

Thanks,
Zhao
Re: [PATCH] Add zh_TW Traditional Chinese translation
Posted by Daniel P. Berrangé 1 week, 6 days ago 
On Wed, Apr 17, 2024 at 12:41:16AM +0800, Zhao Liu wrote:
> Hi Peter,
> 
> On Tue, Apr 16, 2024 at 02:27:45PM +0100, Peter Maydell wrote:
> > Date: Tue, 16 Apr 2024 14:27:45 +0100
> > From: Peter Maydell <peter.maydell@linaro.org>
> > Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
> > 
> > On Tue, 16 Apr 2024 at 14:00, Peter Dave Hello <hsu@peterdavehello.org> wrote:
> > >
> > > From: Peter Dave Hello <hsu@peterdavehello.org>
> > > Date: Tue, 16 Apr 2024 00:43:29 +0800
> > > Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
> > >
> > > This patch adds a basic zh_TW translation file for Taiwan Traditional
> > > Chinese users.
> > >
> > > Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
> > 
> > This name in your Signed-off-by line doesn't match the
> > name you use in the .po file...
> > 
> > > ---
> > >  po/LINGUAS  |  1 +
> > >  po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 94 insertions(+)
> > >  create mode 100644 po/zh_TW.po
> > >
> > > diff --git a/po/LINGUAS b/po/LINGUAS
> > > index 9b33a36..08163e8 100644
> > > --- a/po/LINGUAS
> > > +++ b/po/LINGUAS
> > > @@ -7,3 +7,4 @@ sv
> > >  tr
> > >  uk
> > >  zh_CN
> > > +zh_TW
> > > diff --git a/po/zh_TW.po b/po/zh_TW.po
> > > new file mode 100644
> > > index 0000000..d25557e
> > > --- /dev/null
> > > +++ b/po/zh_TW.po
> > > @@ -0,0 +1,93 @@
> > > +# Chinese translations for PACKAGE package.
> > > +# Copyright (C) 2024 THE PACKAGE'S COPYRIGHT HOLDER
> > > +# This file is distributed under the same license as the PACKAGE package.
> > 
> > Can you replace all these placeholder ALLCAPS items
> > with the right values, please?
> > 
> > > +# Peter Hsu <hsu@peterdavehello.org>, 2024.
> > > +#
> 
> Open source license is missing here.
> 
> And I checked the other .po files and found that none of them declare
> the open source license, are they missing it? Or does this case default
> to "GPL-2.0-or-later"?

Best practice is for every file to mention its license, ideally
using the "SPDX-Identifier"  tag syntax for new files.

If any file is missing a license header statement, then implicitly it
falls under the LICENSE file rules, which is GPL-2.0-or-later. 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH] Add zh_TW Traditional Chinese translation
Posted by Peter Dave Hello 1 week, 5 days ago 
Hi all,

Thank you all for the feedback. I've updated the patch to address most of the suggestions, but only the copyright part. I'm not sure how to deal with it. BTW, should I directly paste the revised patch below? Sorry that I'm not familiar with the process here. Thanks for your help again.

From: Peter Dave Hello <hsu@peterdavehello.org>
Date: Tue, 16 Apr 2024 00:43:29 +0800
Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation

This patch adds a basic zh_TW translation file for Taiwan Traditional
Chinese users.

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
---
 po/LINGUAS  |  1 +
 po/zh_TW.po | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 75 insertions(+)
 create mode 100644 po/zh_TW.po

diff --git a/po/LINGUAS b/po/LINGUAS
index 9b33a36..08163e8 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -7,3 +7,4 @@ sv
 tr
 uk
 zh_CN
+zh_TW
diff --git a/po/zh_TW.po b/po/zh_TW.po
new file mode 100644
index 0000000..e6d2c07
--- /dev/null
+++ b/po/zh_TW.po
@@ -0,0 +1,74 @@
+# Chinese translations for QEMU package.
+# Copyright (C) 2024 THE QEMU'S COPYRIGHT HOLDER
+# This file is distributed under the same license as the QEMU package.
+# Peter Dave Hello <hsu@peterdavehello.org>, 2024.
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: QEMU 9.1\n"
+"Report-Msgid-Bugs-To: qemu-devel@nongnu.org\n"
+"POT-Creation-Date: 2024-04-16 17:52+0800\n"
+"PO-Revision-Date: 2024-04-16 17:52+0800\n"
+"Last-Translator: Peter Dave Hello <hsu@peterdavehello.org>\n"
+"Language-Team: Chinese (traditional)\n"
+"Language: zh_TW\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+
+msgid " - Press Ctrl+Alt+G to release grab"
+msgstr " - 按下 Ctrl+Alt+G 以釋放鎖定"
+
+msgid " [Paused]"
+msgstr " [已暫停]"
+
+msgid "_Pause"
+msgstr "暫停(_P)"
+
+msgid "_Reset"
+msgstr "重設(_R)"
+
+msgid "Power _Down"
+msgstr "關機(_D)"
+
+msgid "_Quit"
+msgstr "結束(_Q)"
+
+msgid "_Fullscreen"
+msgstr "全螢幕(_F)"
+
+msgid "_Copy"
+msgstr "複製(_C)"
+
+msgid "Zoom _In"
+msgstr "放大(_I)"
+
+msgid "Zoom _Out"
+msgstr "縮小(_O)"
+
+msgid "Best _Fit"
+msgstr "最佳尺寸(_F)"
+
+msgid "Zoom To _Fit"
+msgstr "調整至最佳大小(_F)"
+
+msgid "Grab On _Hover"
+msgstr "滑過時鎖定(_H)"
+
+msgid "_Grab Input"
+msgstr "鎖定輸入(_G)"
+
+msgid "Show _Tabs"
+msgstr "顯示分頁(_T)"
+
+msgid "Detach Tab"
+msgstr "分離分頁"
+
+msgid "Show Menubar"
+msgstr "顯示功能表列(_M)"
+
+msgid "_Machine"
+msgstr "機器(_M)"
+
+msgid "_View"
+msgstr "檢視(_V)"
-- 
2.25.1

Best,
Peter


On Wednesday, April 17th, 2024 at AM 12:32, Daniel P. Berrangé <berrange@redhat.com> wrote:

> On Wed, Apr 17, 2024 at 12:41:16AM +0800, Zhao Liu wrote:
> 
> > Hi Peter,
> > 
> > On Tue, Apr 16, 2024 at 02:27:45PM +0100, Peter Maydell wrote:
> > 
> > > Date: Tue, 16 Apr 2024 14:27:45 +0100
> > > From: Peter Maydell peter.maydell@linaro.org
> > > Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
> > > 
> > > On Tue, 16 Apr 2024 at 14:00, Peter Dave Hello hsu@peterdavehello.org wrote:
> > > 
> > > > From: Peter Dave Hello hsu@peterdavehello.org
> > > > Date: Tue, 16 Apr 2024 00:43:29 +0800
> > > > Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
> > > > 
> > > > This patch adds a basic zh_TW translation file for Taiwan Traditional
> > > > Chinese users.
> > > > 
> > > > Signed-off-by: Peter Dave Hello hsu@peterdavehello.org
> > > 
> > > This name in your Signed-off-by line doesn't match the
> > > name you use in the .po file...
> > > 
> > > > ---
> > > > po/LINGUAS | 1 +
> > > > po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > > 2 files changed, 94 insertions(+)
> > > > create mode 100644 po/zh_TW.po
> > > > 
> > > > diff --git a/po/LINGUAS b/po/LINGUAS
> > > > index 9b33a36..08163e8 100644
> > > > --- a/po/LINGUAS
> > > > +++ b/po/LINGUAS
> > > > @@ -7,3 +7,4 @@ sv
> > > > tr
> > > > uk
> > > > zh_CN
> > > > +zh_TW
> > > > diff --git a/po/zh_TW.po b/po/zh_TW.po
> > > > new file mode 100644
> > > > index 0000000..d25557e
> > > > --- /dev/null
> > > > +++ b/po/zh_TW.po
> > > > @@ -0,0 +1,93 @@
> > > > +# Chinese translations for PACKAGE package.
> > > > +# Copyright (C) 2024 THE PACKAGE'S COPYRIGHT HOLDER
> > > > +# This file is distributed under the same license as the PACKAGE package.
> > > 
> > > Can you replace all these placeholder ALLCAPS items
> > > with the right values, please?
> > > 
> > > > +# Peter Hsu hsu@peterdavehello.org, 2024.
> > > > +#
> > 
> > Open source license is missing here.
> > 
> > And I checked the other .po files and found that none of them declare
> > the open source license, are they missing it? Or does this case default
> > to "GPL-2.0-or-later"?
> 
> 
> Best practice is for every file to mention its license, ideally
> using the "SPDX-Identifier" tag syntax for new files.
> 
> If any file is missing a license header statement, then implicitly it
> falls under the LICENSE file rules, which is GPL-2.0-or-later.
> 
> With regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [PATCH] Add zh_TW Traditional Chinese translation
Posted by Zhao Liu 1 week, 4 days ago 
Hi Perter HSU,

On Wed, Apr 17, 2024 at 01:07:17PM +0000, Peter Dave Hello wrote:
> Date: Wed, 17 Apr 2024 13:07:17 +0000
> From: Peter Dave Hello <hsu@peterdavehello.org>
> Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
> 
> Hi all,
> 
> Thank you all for the feedback. I've updated the patch to address most of the suggestions, but only the copyright part. I'm not sure how to deal with it. BTW, should I directly paste the revised patch below? Sorry that I'm not familiar with the process here. Thanks for your help again.

New patch should be sent separately to avoid replying directly to
previous mail thread. And the tag of the SUBJECT for your v2 patch needs
to be changed to "[PATCH v2]".

> From: Peter Dave Hello <hsu@peterdavehello.org>
> Date: Tue, 16 Apr 2024 00:43:29 +0800
> Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
> 
> This patch adds a basic zh_TW translation file for Taiwan Traditional
> Chinese users.
> 
> Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
> ---
>  po/LINGUAS  |  1 +
>  po/zh_TW.po | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 75 insertions(+)
>  create mode 100644 po/zh_TW.po
> 
> diff --git a/po/LINGUAS b/po/LINGUAS
> index 9b33a36..08163e8 100644
> --- a/po/LINGUAS
> +++ b/po/LINGUAS
> @@ -7,3 +7,4 @@ sv
>  tr
>  uk
>  zh_CN
> +zh_TW
> diff --git a/po/zh_TW.po b/po/zh_TW.po
> new file mode 100644
> index 0000000..e6d2c07
> --- /dev/null
> +++ b/po/zh_TW.po
> @@ -0,0 +1,74 @@
> +# Chinese translations for QEMU package.
> +# Copyright (C) 2024 THE QEMU'S COPYRIGHT HOLDER

Refer to this file /po/bg.po or any other source code of QEMU, copyright
belongs to you or your company.

> +# This file is distributed under the same license as the QEMU package.

You can declare the license by:
"SPDX-License-Identifier: GPL-2.0-or-later".

And put this license under the author line.

> +# Peter Dave Hello <hsu@peterdavehello.org>, 2024.
> +#

Others look good to me. Pls go ahead and respin your v2.

Thanks,
Zhao
Re: [PATCH] Add zh_TW Traditional Chinese translation
Posted by Peter Dave Hello 5 days, 23 hours ago 
Hi PMM, Zhao & Daniel,

Thank you for all your help; I wonder if the copyright can just belong to this project because the copyright to me personally in the open source world just to deal with somebody violets the license. Otherwise, I'm more copyleft. What do you think?

Best,
Peter


On Thursday, April 18th, 2024 at AM 10:08, Zhao Liu <zhao1.liu@intel.com> wrote:

> Hi Perter HSU,
>
> On Wed, Apr 17, 2024 at 01:07:17PM +0000, Peter Dave Hello wrote:
>
> > Date: Wed, 17 Apr 2024 13:07:17 +0000
> > From: Peter Dave Hello hsu@peterdavehello.org
> > Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation
> >
> > Hi all,
> >
> > Thank you all for the feedback. I've updated the patch to address most of the suggestions, but only the copyright part. I'm not sure how to deal with it. BTW, should I directly paste the revised patch below? Sorry that I'm not familiar with the process here. Thanks for your help again.
>
>
> New patch should be sent separately to avoid replying directly to
> previous mail thread. And the tag of the SUBJECT for your v2 patch needs
> to be changed to "[PATCH v2]".
>
> > From: Peter Dave Hello hsu@peterdavehello.org
> > Date: Tue, 16 Apr 2024 00:43:29 +0800
> > Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation
> >
> > This patch adds a basic zh_TW translation file for Taiwan Traditional
> > Chinese users.
> >
> > Signed-off-by: Peter Dave Hello hsu@peterdavehello.org
> > ---
> > po/LINGUAS | 1 +
> > po/zh_TW.po | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 75 insertions(+)
> > create mode 100644 po/zh_TW.po
> >
> > diff --git a/po/LINGUAS b/po/LINGUAS
> > index 9b33a36..08163e8 100644
> > --- a/po/LINGUAS
> > +++ b/po/LINGUAS
> > @@ -7,3 +7,4 @@ sv
> > tr
> > uk
> > zh_CN
> > +zh_TW
> > diff --git a/po/zh_TW.po b/po/zh_TW.po
> > new file mode 100644
> > index 0000000..e6d2c07
> > --- /dev/null
> > +++ b/po/zh_TW.po
> > @@ -0,0 +1,74 @@
> > +# Chinese translations for QEMU package.
> > +# Copyright (C) 2024 THE QEMU'S COPYRIGHT HOLDER
>
>
> Refer to this file /po/bg.po or any other source code of QEMU, copyright
> belongs to you or your company.
>
> > +# This file is distributed under the same license as the QEMU package.
>
>
> You can declare the license by:
> "SPDX-License-Identifier: GPL-2.0-or-later".
>
> And put this license under the author line.
>
> > +# Peter Dave Hello hsu@peterdavehello.org, 2024.
> > +#
>
>
> Others look good to me. Pls go ahead and respin your v2.
>
> Thanks,
> Zhao

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.