OK.  I wasn't sure if performance improvements would be considered new features or not.

Taylor


> -----Original Message-----
> From: Stefan Hajnoczi <stefanha@gmail.com>
> Sent: Thursday, November 10, 2022 7:07 PM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
> philmd@linaro.org; peter.maydell@linaro.org; Brian Cain
> <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>; stefanha@redhat.com
> Subject: Re: [PULL 00/11] Hexagon bug fixes and performance improvement
> 
> Hi Taylor,
> QEMU is frozen for the 7.2 release cycle. Only bug fixes can be merged as the
> tree is being stabilized. You can find the release schedule
> here:
> https://wiki.qemu.org/Planning/7.2
> 
> Please resend with only the bug fixes needed for the 7.2 release. Thanks!
> 
> Stefan

On Tue, 15 Nov 2022 at 11:16, Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> OK.  I wasn't sure if performance improvements would be considered new features or not.

No problem! If there is a performance regression in the upcoming
release, then fixes will be accepted. For example, if QEMU 7.1 was
fast but the upcoming QEMU 7.2 release is going to be slow then a
performance fix will be accepted to avoid a regression in 7.2.

On the other hand, if it's a fix for something that was already slow
in the last release (7.1), then it's less likely to be accepted during
freeze.

These are general guidelines and maintainers have a say in what gets
merged. In this case I looked at the pull request and I wasn't sure if
you had decided based on these guidelines or not. It helps when it's
clear from the commit message (or from the commit description in more
involved cases) that the commit fixes a bug or has some other
justification.

Thanks,
Stefan

> -----Original Message-----
> From: Stefan Hajnoczi <stefanha@gmail.com>
> Sent: Tuesday, November 15, 2022 10:52 AM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
> philmd@linaro.org; peter.maydell@linaro.org; Brian Cain
> <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>; stefanha@redhat.com
> Subject: Re: [PULL 00/11] Hexagon bug fixes and performance improvement
> 
> On Tue, 15 Nov 2022 at 11:16, Taylor Simpson <tsimpson@quicinc.com>
> wrote:
> >
> > OK.  I wasn't sure if performance improvements would be considered new
> features or not.
> 
> No problem! If there is a performance regression in the upcoming release,
> then fixes will be accepted. For example, if QEMU 7.1 was fast but the
> upcoming QEMU 7.2 release is going to be slow then a performance fix will
> be accepted to avoid a regression in 7.2.
> 
> On the other hand, if it's a fix for something that was already slow in the last
> release (7.1), then it's less likely to be accepted during freeze.

The performance improvements fall into this bucket.

> 
> These are general guidelines and maintainers have a say in what gets
> merged. In this case I looked at the pull request and I wasn't sure if you had
> decided based on these guidelines or not. It helps when it's clear from the
> commit message (or from the commit description in more involved cases)
> that the commit fixes a bug or has some other justification.

I'm the maintainer for the directories touched by these patches (target/hexagon and tests/tcg/hexagon), but I'll defer you as a more senior maintainer to decide not to merge if it is too risky at this stage.

Taylor
 

On Tue, Nov 15, 2022, 12:44 Taylor Simpson <tsimpson@quicinc.com> wrote:

>
>
> > -----Original Message-----
> > From: Stefan Hajnoczi <stefanha@gmail.com>
> > Sent: Tuesday, November 15, 2022 10:52 AM
> > To: Taylor Simpson <tsimpson@quicinc.com>
> > Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
> > philmd@linaro.org; peter.maydell@linaro.org; Brian Cain
> > <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> > <quic_mathbern@quicinc.com>; stefanha@redhat.com
> > Subject: Re: [PULL 00/11] Hexagon bug fixes and performance improvement
> >
> > On Tue, 15 Nov 2022 at 11:16, Taylor Simpson <tsimpson@quicinc.com>
> > wrote:
> > >
> > > OK.  I wasn't sure if performance improvements would be considered new
> > features or not.
> >
> > No problem! If there is a performance regression in the upcoming release,
> > then fixes will be accepted. For example, if QEMU 7.1 was fast but the
> > upcoming QEMU 7.2 release is going to be slow then a performance fix will
> > be accepted to avoid a regression in 7.2.
> >
> > On the other hand, if it's a fix for something that was already slow in
> the last
> > release (7.1), then it's less likely to be accepted during freeze.
>
> The performance improvements fall into this bucket.
>
> >
> > These are general guidelines and maintainers have a say in what gets
> > merged. In this case I looked at the pull request and I wasn't sure if
> you had
> > decided based on these guidelines or not. It helps when it's clear from
> the
> > commit message (or from the commit description in more involved cases)
> > that the commit fixes a bug or has some other justification.
>
> I'm the maintainer for the directories touched by these patches
> (target/hexagon and tests/tcg/hexagon), but I'll defer you as a more senior
> maintainer to decide not to merge if it is too risky at this stage.
>

Thanks!

Stefan


> Taylor
>
>
>