From nobody Sat May 18 06:04:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=intel.com); dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=2; a=rsa-sha256; t=1670487798; cv=pass; d=zohomail.com; s=zohoarc; b=aF/kuUFZ/JU+Lctfr8hIX/0jpaBl2w4UVArG7TtU4NhLv5rac2W+eCOdQv5Lu9+jGdBb6LUfHpHqtEZEHrLbT6VntmpQHyaXIzPQXl6lUAJ9GouKf/HYR7VkBMDhPCO3/S9gnblcU+QOM5v+KXoB1vTJGWEM0q4CbQEGcAE+00s= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670487798; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4y89vHnK25LtT99h5OZ5HdwOFUkGbvlifyUQ0yZQQOs=; b=QmH1Knwady2UhNZsp2+ph2R3hNwNF6AdrL3FowxTTQkW0uDmn9AxpJE7reECGPtly1ujB2vQ7a3X24gf3fpeoypz+b62QvDHVTS8uM7QsBXnVejJ7Llfe71FkAPA1cHlMBYebwkW80ApWejHHwLIf/nKG+4VSTHyoDA5dzj+TKA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=intel.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1670487798292581.3239261424186; Thu, 8 Dec 2022 00:23:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3CAx-0002nN-80; Thu, 08 Dec 2022 03:22:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3CAt-0002lg-Vr for qemu-devel@nongnu.org; Thu, 08 Dec 2022 03:22:36 -0500 Received: from mga09.intel.com ([134.134.136.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3CAq-0001Z0-Rl for qemu-devel@nongnu.org; Thu, 08 Dec 2022 03:22:35 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 00:22:20 -0800 Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 08 Dec 2022 00:22:20 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 8 Dec 2022 00:22:20 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 8 Dec 2022 00:22:20 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 8 Dec 2022 00:22:20 -0800 Received: from DM6PR11MB4090.namprd11.prod.outlook.com (2603:10b6:5:195::10) by DS7PR11MB5989.namprd11.prod.outlook.com (2603:10b6:8:70::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 08:22:18 +0000 Received: from DM6PR11MB4090.namprd11.prod.outlook.com ([fe80::caa8:f626:10c8:9ae2]) by DM6PR11MB4090.namprd11.prod.outlook.com ([fe80::caa8:f626:10c8:9ae2%2]) with mapi id 15.20.5880.014; Thu, 8 Dec 2022 08:22:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670487752; x=1702023752; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=4y89vHnK25LtT99h5OZ5HdwOFUkGbvlifyUQ0yZQQOs=; b=TkUZQIHXM/S1zXUTfFoMXJtxBKlm5/liNISCj44Hut6d8UpZyS0KRF93 THYkHBWyf3lKsK1SR6mt+cleiwpZbUKu5h7GJb6XfiI2xnoq+Lu59LOEQ LYJrs5P2cv28/OCSUGLD53FwDZzmDEtPpCy9uDCDwLIyob6WAXZ/EqinG MDkNGvSspcK6Fo5aR2IghasGPS/LcxEXfX/IZKuJx1llQsOYjkwq8Qp2Z JALT8f8FBiL6dx111J5CZIbTMQTJcob9NUoVPHNzMbc67buVcuO04lHtN ihoQGbk8iSCPnlwyYPhtFleeyLAYOq7WUgIQ0OpmRfAqN/pSLg70GDxWy Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="318250771" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="318250771" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="789212948" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="789212948" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CSAXkVGwzBP/vX4U1Ds0GF7or6OXGS+Od2O54Xq5vbtWUk3QpqThAZfZntPMU4icFbuem8pUv69u21Nu9MIc1uL47diRdbPDuCLmHK4Ngwo0iDll9tCf5j6vRJkgOpCoJ9suSsAfL4jsLHov7O7bMfAK7YFkTEalc3qWwHTRntI2XG5QT7NemiL83fs3r1D3ncFpNyK471/YHsmPn3DnWBqtKZU7zyGBx2jT+bB81jP9n8BJGQGiYTkiF5W/TxWsqi+7+AFBpe0t4pYMgv5FB+FeazKktAK65XFS6Rzick8+yIRvm1s36EqtRdwhmQHqfQ7QNiQciGGWVLkjXbGbaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4y89vHnK25LtT99h5OZ5HdwOFUkGbvlifyUQ0yZQQOs=; b=F0IJkWKwMT4V3U/cHGHoMlbyhwhlApSXYKhul8YbnWLpXWRP+9Lq2erf7LoUEMlDaSgqIajh4RNclaC9ESaSiU+/v6SDopJWp4/OT48LgvtPfoEBJwpwatFkgwoxptrJfZsj2oCdILob8ixjDMjeDZ9JNvqCx3YU7AdgmhG29nduo3zZTAgw7cUQxEWo8Mb3zT5EFA/Qs/saVxc4/dhelnj5qXar90Y6KKjPHkqofBHAHrXsdu61MqDHYVfzq94VgDeC5YWmyGkBaND6WwgbQPaxe153t+vFmsVWtfynVaF9G6E6KK6KXDXcQ+OiwlkwWwGlBpBwB9+LUNI0D6kXWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Wang, Wenchao" To: Paolo Bonzini , "qemu-devel@nongnu.org" CC: haxm-team Subject: RE: [PATCH] target/i386/hax: Add XCR0 support Thread-Topic: [PATCH] target/i386/hax: Add XCR0 support Thread-Index: AdkAvHco0a5CAnUYQy+c+kGSr8NH7wAFo4SAABncpzAB0e1YoAABn9+AAAAL14AAlBNfAA== Date: Thu, 8 Dec 2022 08:22:18 +0000 Message-ID: References: <4e35a2b6-12ca-e43c-6ee7-7090280c9341@linaro.org> <04484bf1-c6fc-d430-9939-474c0dab158f@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4090:EE_|DS7PR11MB5989:EE_ x-ms-office365-filtering-correlation-id: 652cb95b-6adf-41cd-f53b-08dad8f5523d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y+UwbgaTwiG14Xdbj7RPKf0uBf4EHADtTjiLWDhxx/+zfqy3toUYMppLJ6iXsF3SkODGf9HWTR8RoGAmGe+tfOS5ZmLmXLQLqHVjWMFXM1Dn+42vpP+I08W4ohQDMlgFISPNzbgpu2t40vkZKzDSi4EE5odsvMzYtNSKQYMsMuRgztH2cG7Z308ZloQLEksexXZaKAUS8MxHo7QFkoqEJovRttuQy30gpSq5Cj3agRBAuOECVAnfTT/nTmasgFfIbGJ9aGTKcKAbvliyv88TU7JWw8l3VzuymCfcfEr7v+ViHYPFiqMCS8qPNXhtUxigiaZ20RUl96nsPf0eFXvNTzkyhLcKTDswq6Kk8fxx22Jkg9tOkq5pYSeAhL5mH5iwnbZZXjzHhvuxhXkHec6MqlTDx6sGTOKv9iFIvFT0FeeXAkajpz8avC0t5MhFjH4h/eXAm90H1ccLZq/AppR6PXrA041A/3HZmo4on/vbug9P75KcMUKCNFZu6IYNAldYQelOQ473NtF6ScN5OaS6pmbAMxQaHjNOwJB2AoRuMQXcQwX8bbrCFoBofasJUM7EOG7/iELYaomkznf4ZRJ0Y1RLhK2szx0ACVSCUQgrrBhxrKoTGR/9n+w251V1s0qQzCWEjVJeJoVsLsPkpcbGmpiKS4WNpXgEksJnFhTctGbPMqcnFngQbV+Ji2DErankMr58Dufhuhh7Z9BqGegQxXazxxu7SxO4G48jvxc3Shs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4090.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(396003)(366004)(39860400002)(451199015)(38100700002)(122000001)(82960400001)(41300700001)(8936002)(38070700005)(4326008)(2906002)(5660300002)(83380400001)(66946007)(86362001)(33656002)(71200400001)(52536014)(66446008)(316002)(110136005)(966005)(478600001)(66476007)(66556008)(55016003)(9686003)(7696005)(76116006)(8676002)(6506007)(53546011)(64756008)(107886003)(26005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TStkcGdMdE5wVm1JSHdJVnVML01kOEduMkdrRnlwWHFhS2hqNjArZWYwSXdQ?= =?utf-8?B?WXZMOFlQVDY0Z0MyL0dpRElaZDBlNmNEdmdlMTg3VUJJVEVKVmJId0I3NHNi?= =?utf-8?B?Vk8vekdjaU9zUnk3QjZ5TnAvUkZpdzZpWjZ2RlFsbFBtUExSVSt4eTIzUjUr?= =?utf-8?B?dHNlNnk2UVpPcGVxK3JmTXBMNFJsMUVqRHp5THdHNnpDTXZxVVhZUFJwQ29s?= =?utf-8?B?eURMMmhmM1c5eGMzYys4bWtwRUNOOUlRY3dZZ09Jd29NaEVTeXlwTUh5S2Jr?= =?utf-8?B?WGtZdmZMWWJsaXR1UFpkU3orNDQ5UWZCSE5UN1UrWFFMMnNjdnphbnczaFkr?= =?utf-8?B?VEMyOUZOcXNoVVU3ZmlnN1NJMlVtc2E0ZjZHSzVEQUp0TWQrWitSUFFTQWFq?= =?utf-8?B?WmNBTFpINU4zcDBUa21SZWo1RWtId1lPZjJjVDVkWlF5NWorTUVYb1dRM3l2?= =?utf-8?B?SHlWN2t6Vi83RU1oT0RPcHpxdytPVFZrajJEbkZxZDRsZDBHRTFjbndvUHYr?= =?utf-8?B?WTVlcWVyVVZxbGt3YklMeE5aUFZobU8wVC9mUmIxMnhydEZKMEUvNXAxbXRw?= =?utf-8?B?NTA3RlRwYU1sYlBDRHh2ZHdpRHAyeWxJbW5sS2pOdEhodThyQVZNcU1WTUl2?= =?utf-8?B?N04rVGZhNmZDNitWU2tYYVFMcjh0RE1vSjBCeGxQbmpaSkVQUVNORStzYU5L?= =?utf-8?B?QmxEbFI1SGRJMVJTbUVEajhLcTh5SDhaQ2R0N3dBUmZPenhucXFBa2x5OFNr?= =?utf-8?B?TldmUTY2cG1LYTh1dkhrYUhuYXNOQkJWS3FPZjMwb1BDditObDZOWkZ5T3p4?= =?utf-8?B?K1JaelZUSmtPNXZHczhiR0FtK1dGaWswcFBid05OVEdpNXZrYTZjZVJpU0NM?= =?utf-8?B?L0JJY2xBOUtzczZLb3orRmVRU2hHQlFOWXExQkVvZ1hKblc3aTIvdnBZNHNs?= =?utf-8?B?VHBQbDQ2S2RFSk9VZjMxWHVUSjQxRkNLa1JvcklablhaU05tV2xnT0h6REli?= =?utf-8?B?R21xbC9wVlJIRFJ0R05va2htQ2pZNXFjS1JjeGpuUGFueWtaRERSZVA0cGV6?= =?utf-8?B?am1tOTJ2RWhFMXJTbDZVQUNKL24reUt2dTUzY1hYZzE5V1ZjKy9CRGQrRlJq?= =?utf-8?B?M3J3eDNQNk02bmUrbHh0UzhQcGdYMDlSZmpPYitOYUJabFdDTG1aYjR0M3Fi?= =?utf-8?B?MFJXYmFMVGVyM1BMb0RaUGczMGhnYXhJakVjeDZMSGRlbEt5bzlaNWtqc0lj?= =?utf-8?B?akpiSytsNlFESTd0RDFKOHBhSldibjlRYVljZ1p2aGNJUHZYc05hS1BzdS9Y?= =?utf-8?B?YWNxOFZ6aEJ5ek04Um84d1p4Y2NOd1lIMURZV2YxYW5DVjJ6c3RUQkpWdnhw?= =?utf-8?B?RzNtUlQ1SmlQb0RjRit5QmVTR0FCUmYxZytxV200N01BZTRraTFVcFI1bFF1?= =?utf-8?B?Si91aE9veloycDhpNExGOUErK1FUWS9XV3pOR2pNb25DYzdNUTZYelJGKytv?= =?utf-8?B?Q0RObVByUTM0NG5wOEpMb2FVUWdxbk5KK29welNYS3FmeHBaNC9xb2oveFp6?= =?utf-8?B?N3QzSW9mdy9SNEVYdnZXSFF2aUExV2RXYXJxZGFUU00xT3F6WGVRdlN1VlFZ?= =?utf-8?B?bmgvWlkwc2hVZi9RSTZEa2JjMGtMTjF5ay82WU9PaWRSSzVKSjF4YW80S094?= =?utf-8?B?K0c1cDlCYlZJNWJ2YWcvYVJlMXA4ZmxYTVdDTGVFWmduczVGOGFEM3d3Vmpy?= =?utf-8?B?NG0zWXcybVZ3Nm0wZUJqTjB0emxoejJkcVRwSzJUQWNaQU9lMW1HLzlXaG9V?= =?utf-8?B?R0hKdWtBdkliMkxaRWhzVjJUWEJwY1BWa0UzZ1NPNGJEZHZGVDJHZkNVdkFS?= =?utf-8?B?b0FXbFVRQmdYRm5FcklLSzBEZ0lnS2R3Ti8wWjJqVWYyUm8vaVhkak00ODVk?= =?utf-8?B?WmdQWnplT3kxL2o0eUphbDMrMjVraGh5c0xrRmQwVHRETzFoSjVoMFZHMDhX?= =?utf-8?B?MGtKRTRjQ1FZZXMrZFV2aWUxKzdHdVVmTUhpS0QzbS9ONVR4WVljQ0c3Q0Z5?= =?utf-8?B?NGxoRkhGbUlTeWk5c21XVU1CMGNiUkk3RXVvQWtvY09JODZMMGxBT0xjTys2?= =?utf-8?Q?E0xOtQ7pFGgjWzbv/fg+iBRBO?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4090.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 652cb95b-6adf-41cd-f53b-08dad8f5523d X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2022 08:22:18.4413 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HJf6+TcTKVufW/WlcjLoDY/gFLTu4i7D6zYNW/7tRfxoo9f+8dOkuAg5IB6CrGV0FSpXhSwWn79LjYJSg5JTNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5989 X-OriginatorOrg: intel.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.24; envelope-from=wenchao.wang@intel.com; helo=mga09.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1670487798856100001 Hi, Paolo, As HAXM v7.8.0 is released and it added XCR0 support, could you help to mer= ge this patch to add corresponding support into HAX user space of QEMU? The= patch has been attached below. Thanks. Best Regards, Wenchao Reviewed-by: Hang Yuan --------------------------------- From b1789f2523d06798b8883664bfa9a9df797bfccf Mon Sep 17 00:00:00 2001 From: Wenchao Wang Date: Fri, 25 Nov 2022 18:37:34 +0800 Subject: [PATCH] target/i386/hax: Add XCR0 support Introduce extended control register XCR0 to support XSAVE feature set. Note: This change requires at least HAXM v7.8.0 to support. Reviewed-by: Hang Yuan Signed-off-by: Wenchao Wang --- target/i386/hax/hax-interface.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/hax/hax-interface.h b/target/i386/hax/hax-interfac= e.h index 537ae084e9..1d13bb2380 100644 --- a/target/i386/hax/hax-interface.h +++ b/target/i386/hax/hax-interface.h @@ -201,6 +201,8 @@ struct vcpu_state_t { uint64_t _cr3; uint64_t _cr4; =20 + uint64_t _xcr0; + uint64_t _dr0; uint64_t _dr1; uint64_t _dr2; --=20 2.17.1 -----Original Message----- From: Wang, Wenchao=20 Sent: Monday, December 5, 2022 17:10 To: Philippe Mathieu-Daud=C3=A9 ; qemu-devel@nongnu.org Cc: haxm-team ; Paolo Bonzini Subject: RE: [PATCH] target/i386/hax: Add XCR0 support Thanks for Phillippe's reply. Hi, Paolo, Could you help to review the patch of HAX? If there is any concern about it= , feel free to discuss with me. Thanks a lot. Best Regards, Wenchao -----Original Message----- From: Philippe Mathieu-Daud=C3=A9 Sent: Monday, December 5, 2022 17:05 To: Wang, Wenchao ; qemu-devel@nongnu.org Cc: haxm-team ; Paolo Bonzini Subject: Re: [PATCH] target/i386/hax: Add XCR0 support Hi Wenchao, On 5/12/22 09:35, Wang, Wenchao wrote: > Hi, Philippe, >=20 > Do you agree with my opinion and is there any further process that I need= to follow to get this patch merged? Thanks a lot. I don't understand this part of HAXM enough, but per your explanation, your= change looks correct. I'll let Paolo decide :) Regards, Phil. > Best Regards, > Wenchao >=20 > -----Original Message----- > From: Wang, Wenchao > Sent: Monday, November 28, 2022 16:11 > To: Philippe Mathieu-Daud=C3=A9 ; qemu-devel@nongnu.org > Cc: haxm-team ; Paolo Bonzini=20 > > Subject: RE: [PATCH] target/i386/hax: Add XCR0 support >=20 > Hi, Philippe, >=20 > It is just the full patch. Currently, the implementation of HAXM is simpl= e, we did not synchronize the vCPU register for xcr0 from QEMU. HAXM will h= andle the xcr0 state within the kernel space, including initialization, upd= ate, etc. This patch adds the xcr0 variable for allocating extra 8-byte buf= fer occupation, which will be passed between QEMU and HAXM when hax_sync_vc= pu_state() is invoked. We have verified the patched QEMU and it can launch = all guest OSes. Thanks for your comments. >=20 >=20 > Best Regards, > Wenchao >=20 > -----Original Message----- > From: Philippe Mathieu-Daud=C3=A9 > Sent: Friday, November 25, 2022 21:37 > To: Wang, Wenchao ; qemu-devel@nongnu.org > Cc: haxm-team ; Paolo Bonzini=20 > > Subject: Re: [PATCH] target/i386/hax: Add XCR0 support >=20 > Hi, >=20 > On 25/11/22 13:18, Wang, Wenchao wrote: >> Hi, maintainers, >> >> As HAXM v7.8.0 is released and it added XCR0 support, could you help=20 >> to merge this patch to add corresponding support into HAX user space=20 >> of QEMU? The patch has been included in the attachment. Thanks. >=20 > See > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitt > ing-your-patches on how to send patches to a mailing list. >=20 >> >> Best Regards, >> >> Wenchao >> >> From b1789f2523d06798b8883664bfa9a9df797bfccf Mon Sep 17 00:00:00 >> 2001 >> >> From: Wenchao Wang >> >> Date: Fri, 25 Nov 2022 18:37:34 +0800 >> >> Subject: [PATCH] target/i386/hax: Add XCR0 support >> >> Introduce extended control register XCR0 to support XSAVE feature set. >> >> Note: This change requires at least HAXM v7.8.0 to support. >> >> Reviewed-by: Hang Yuan >> >> Signed-off-by: Wenchao Wang >> >> --- >> >> target/i386/hax/hax-interface.h | 2 ++ >> >> 1 file changed, 2 insertions(+) >> >> diff --git a/target/i386/hax/hax-interface.h=20 >> b/target/i386/hax/hax-interface.h >> >> index 537ae084e9..1d13bb2380 100644 >> >> --- a/target/i386/hax/hax-interface.h >> >> +++ b/target/i386/hax/hax-interface.h >> >> @@ -201,6 +201,8 @@ struct vcpu_state_t { >> >> =C2=A0=C2=A0=C2=A0=C2=A0 uint64_t _cr3; >> >> =C2=A0=C2=A0=C2=A0=C2=A0 uint64_t _cr4; >> >> +=C2=A0=C2=A0=C2=A0 uint64_t _xcr0; >> >> + >> >> =C2=A0=C2=A0=C2=A0=C2=A0 uint64_t _dr0; >> >> =C2=A0=C2=A0=C2=A0=C2=A0 uint64_t _dr1; >> >> =C2=A0=C2=A0=C2=A0=C2=A0 uint64_t _dr2; >> >> -- >> >> 2.17.1 >> >=20 > Is that the full patch? It is missing the register use in hax_sync_vcpu_r= egister()... >=20 > Regards, >=20 > Phil.