mmap(2) returns MAP_FAILED, not NULL, on failure

[Qemu-devel] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

Michael McConville posted 1 patch 6 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/A6478011-CD5E-4FDF-A212-6D9BB0E70028@mykolab.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

hw/i386/xen/xen-mapcache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

Posted by Michael McConville 6 years, 4 months ago

Signed-off-by: Michael McConville <mmcco@mykolab.com>
---
 hw/i386/xen/xen-mapcache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
index baab93b614..efa35dc6e0 100644
--- a/hw/i386/xen/xen-mapcache.c
+++ b/hw/i386/xen/xen-mapcache.c
@@ -199,7 +199,7 @@ static void xen_remap_bucket(MapCacheEntry *entry,
          */
         vaddr_base = mmap(vaddr, size, PROT_READ | PROT_WRITE,
                           MAP_ANON | MAP_SHARED, -1, 0);
-        if (vaddr_base == NULL) {
+        if (vaddr_base == MAP_FAILED) {
             perror("mmap");
             exit(-1);
         }
-- 
2.15.1

Re: [Qemu-devel] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

Posted by John Snow 6 years, 4 months ago


On 12/01/2017 01:31 PM, Michael McConville wrote:
> Signed-off-by: Michael McConville <mmcco@mykolab.com>
> ---
>  hw/i386/xen/xen-mapcache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
> index baab93b614..efa35dc6e0 100644
> --- a/hw/i386/xen/xen-mapcache.c
> +++ b/hw/i386/xen/xen-mapcache.c
> @@ -199,7 +199,7 @@ static void xen_remap_bucket(MapCacheEntry *entry,
>           */
>          vaddr_base = mmap(vaddr, size, PROT_READ | PROT_WRITE,
>                            MAP_ANON | MAP_SHARED, -1, 0);
> -        if (vaddr_base == NULL) {
> +        if (vaddr_base == MAP_FAILED) {
>              perror("mmap");
>              exit(-1);
>          }
> 

Reviewed-by: John Snow <jsnow@redhat.com>