From nobody Thu May 2 00:16:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 151853365426856.803984255729006; Tue, 13 Feb 2018 06:54:14 -0800 (PST) Received: from localhost ([::1]:41504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elbyH-0001dM-E9 for importer@patchew.org; Tue, 13 Feb 2018 09:54:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elZF8-0002um-QA for qemu-devel@nongnu.org; Tue, 13 Feb 2018 06:59:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elZF5-0005ok-Ie for qemu-devel@nongnu.org; Tue, 13 Feb 2018 06:59:26 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:54732) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elZF5-0005lM-Ca for qemu-devel@nongnu.org; Tue, 13 Feb 2018 06:59:23 -0500 Received: by mail-wm0-x243.google.com with SMTP id i186so15503794wmi.4 for ; Tue, 13 Feb 2018 03:59:22 -0800 (PST) Received: from [192.168.2.2] (ip503c37cc.speed.planet.nl. [80.60.55.204]) by smtp.gmail.com with ESMTPSA id l9sm5849903edi.34.2018.02.13.03.59.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 03:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=bdWC6mkyA1fbPZc43TZ7i3NNFuTizbubILRaMX0hSuM=; b=VQnVHYk2kWD72B4lkdgq+DDU9o2Nf+jcHVk1HRpSvVnCtyMvfD117Hf+jCQO6Osy/w Er6xF/xP+HJrE2B58+HoFg2bXdsiSAhazQN1Ze3ej24vwCqeia27WUMOgdKVFTL/c0XG 8DwI6h5glFz6CM+J59Ph0snbehvJRgxxzqVsazw9ruvHQaUeaUlKrq6OsaeyrLuwJ/Ug duGUTbyESDSjdtQmUMt6YTotrWqNgJ9fgRhqp+QblYpubmFDNyJqnso10cydcB9Ag6+r q/a3+PyramL3xj8wpSd29AfEZRCp+G/wSnXmld3RuuqIWNoZCyT6uzzw6eQWUGQRtg6J RYRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=bdWC6mkyA1fbPZc43TZ7i3NNFuTizbubILRaMX0hSuM=; b=lj8LGTpaloLkMDbbTKXW4NPgdJaNlLlzcMrhphLLpL9b+mVRmkKbX9JCWhljo840rz s4MH8Yw+fMgAXOlJjdl8Fj7g5T7Uutz1gw9lur2D2SnjfAyLdmWyyDCqvgxwGcYU7NgX 7TFMY90D1XHHPaw8CRF4dyx9F8OecG5A256KneVdZE2ZmN6dUV11EpWu654TAhwepTb7 LQYWXp3+EQVBS7N6wggO6l9zmtRN1YGQC63Unqt8h9SnPO5zwbr7q3wz5bncRUw+Fz10 6sgjnItI+EyNW8DJsR4cqu07KFrrcNkY4dltwVUpWyHbGuneG9snwNKKFLeNab2B/C9G A/NA== X-Gm-Message-State: APf1xPDWxhE+XLBf6tfd2fN51ko8Rvgt1nz7IUU+RgP55ueotoA12X7J 8P4DdkVJWSLcLRA0W1tVctY= X-Google-Smtp-Source: AH8x225OfY8msP82diRmolmSFsMo5ItsLzwsdaGWMlc1/tLx+rQ9vBx2UerDAnLv5vKVQ9p/qEpIog== X-Received: by 10.80.179.6 with SMTP id q6mr1794635edd.87.1518523162072; Tue, 13 Feb 2018 03:59:22 -0800 (PST) From: Dimitris Karagkasidis X-Google-Original-From: Dimitris Karagkasidis To: qemu-devel@nongnu.org Message-ID: <807b2724-7a5f-9d62-55aa-b5b3cf0c9503@gmail.com> Date: Tue, 13 Feb 2018 12:59:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 X-Mailman-Approved-At: Tue, 13 Feb 2018 09:48:24 -0500 Subject: [Qemu-devel] [PATCH] monitor.c: Fix infinite loop in monitor's auto-complete functionality X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The QEMU monitor enters an infinite loop when trying to auto-complete comma= nds that accept only optional parameters. The commands currently affected by th= is issue are 'info registers' and 'info mtree'. Signed-off-by: Dimitris Karagkasidis --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index f4992505b1..d8b7270d9b 100644 --- a/monitor.c +++ b/monitor.c @@ -3741,7 +3741,7 @@ static void monitor_find_completion_by_table(Monitor = *mon, } } str =3D args[nb_args - 1]; - while (*ptype =3D=3D '-' && ptype[1] !=3D '\0') { + while (*ptype =3D=3D '-' && ptype[2] !=3D '\0') { ptype =3D next_arg_type(ptype); } switch(*ptype) { --=20 2.14.1