i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel

[PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel

David Woodhouse posted 1 patch 9 months, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/782b63c1f9c41a6bfa771789cde4b45644b3a239.camel@infradead.org

Maintainers: David Woodhouse <dwmw2@infradead.org>, Paul Durrant <paul@xen.org>, Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>

target/i386/kvm/xen-emu.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel

Posted by David Woodhouse 9 months, 1 week ago

From: David Woodhouse <dwmw@amazon.co.uk>

XENFEAT_supervisor_mode_kernel shouldn't be set for HVM guests. It
confuses lscpu into thinking it's running in PVH mode.

No non-cosmetic effects have been observed so far.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
Only really cosmetic. Don't feel strongly about whether it makes 8.1.

 target/i386/kvm/xen-emu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c
index a8146115f0..b307c75713 100644
--- a/target/i386/kvm/xen-emu.c
+++ b/target/i386/kvm/xen-emu.c
@@ -267,7 +267,6 @@ static bool kvm_xen_hcall_xen_version(struct kvm_xen_exit *exit, X86CPU *cpu,
             fi.submap |= 1 << XENFEAT_writable_page_tables |
                          1 << XENFEAT_writable_descriptor_tables |
                          1 << XENFEAT_auto_translated_physmap |
-                         1 << XENFEAT_supervisor_mode_kernel |
                          1 << XENFEAT_hvm_callback_vector |
                          1 << XENFEAT_hvm_safe_pvclock |
                          1 << XENFEAT_hvm_pirqs;
-- 
2.34.1

Re: [PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel

Posted by Paul Durrant 9 months ago

On 08/08/2023 18:08, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
> 
> XENFEAT_supervisor_mode_kernel shouldn't be set for HVM guests. It
> confuses lscpu into thinking it's running in PVH mode.
> 
> No non-cosmetic effects have been observed so far.
> 
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
> Only really cosmetic. Don't feel strongly about whether it makes 8.1.
> 
>   target/i386/kvm/xen-emu.c | 1 -
>   1 file changed, 1 deletion(-)
> 

Reviewed-by: Paul Durrant <paul@xen.org>