qga/schema: fix documentation for GuestOSInfo

[Qemu-devel] [PATCH] qga/schema: fix documentation for GuestOSInfo

Tomáš Golembiovský posted 1 patch 5 years, 12 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/5570aff71297a26c09ba9b6cb3f88f583ff31057.1524247958.git.tgolembi@redhat.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test s390x passed

qga/qapi-schema.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] qga/schema: fix documentation for GuestOSInfo

Posted by Tomáš Golembiovský 5 years, 12 months ago

The documentation for kernel-version and kernel-release on Windows was
swapped.

Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
 qga/qapi-schema.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 17884c7c70..d3a686ba12 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -1168,10 +1168,10 @@
 #
 # @kernel-release:
 #     * POSIX: release field returned by uname(2)
-#     * Windows: version number of the OS
+#     * Windows: build number of the OS
 # @kernel-version:
 #     * POSIX: version field returned by uname(2)
-#     * Windows: build number of the OS
+#     * Windows: version number of the OS
 # @machine:
 #     * POSIX: machine field returned by uname(2)
 #     * Windows: one of x86, x86_64, arm, ia64
-- 
2.17.0

Re: [Qemu-devel] [PATCH] qga/schema: fix documentation for GuestOSInfo

Posted by Marc-André Lureau 5 years, 12 months ago

On Fri, Apr 20, 2018 at 8:12 PM, Tomáš Golembiovský <tgolembi@redhat.com> wrote:
> The documentation for kernel-version and kernel-release on Windows was
> swapped.
>
> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  qga/qapi-schema.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 17884c7c70..d3a686ba12 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -1168,10 +1168,10 @@
>  #
>  # @kernel-release:
>  #     * POSIX: release field returned by uname(2)
> -#     * Windows: version number of the OS
> +#     * Windows: build number of the OS
>  # @kernel-version:
>  #     * POSIX: version field returned by uname(2)
> -#     * Windows: build number of the OS
> +#     * Windows: version number of the OS
>  # @machine:
>  #     * POSIX: machine field returned by uname(2)
>  #     * Windows: one of x86, x86_64, arm, ia64
> --
> 2.17.0
>
>



-- 
Marc-André Lureau