* Dr. David Alan Gilbert (dave@treblig.org) wrote:
> A bunch of structs that are currently unused,
> found with a simple script and a bit of eyeballing.
>
> The only one I'm that suspicious of is the SPARC
> one, where the patch which removed the use is a bit
> confusing to me.
Copying in Trivial; I think there are 4 of these that
are still outstanding:
[PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame'
(Although cris is going)
[PATCH 3/7] linux-user: sparc: Remove unused struct 'target_mc_fq'
[PATCH 5/7] hw/arm/bcm2836: Remove unusued struct 'BCM283XClass'
[PATCH 7/7] net/can: Remove unused struct 'CanBusState'
Can Trivial pick these up please?
Dave
> Tested with a
> --target-list=ppc-softmmu,m68k-softmmu,x86_64-softmmu,arm-softmmu,aarch64-softmmu,cris-linux-user,i386-linux-user,sparc-linux-user
> and 'make check' on x86 linux.
>
> Dave
>
> Dr. David Alan Gilbert (7):
> linux-user: cris: Remove unused struct 'rt_signal_frame'
> linux-user: i386/signal: Remove unused fp structs
> linux-user: sparc: Remove unused struct 'target_mc_fq'
> hw/usb/dev-network: Remove unused struct 'rndis_config_parameter'
> hw/arm/bcm2836: Remove unusued struct 'BCM283XClass'
> target/ppc: Remove unused struct 'mmu_ctx_hash32'
> net/can: Remove unused struct 'CanBusState'
>
> hw/arm/bcm2836.c | 12 ------------
> hw/usb/dev-network.c | 8 --------
> linux-user/cris/signal.c | 8 --------
> linux-user/i386/signal.c | 10 ----------
> linux-user/sparc/signal.c | 5 -----
> net/can/can_host.c | 6 ------
> target/ppc/mmu-hash32.c | 6 ------
> 7 files changed, 55 deletions(-)
>
> --
> 2.45.0
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/