[v1] s390x/cpu_models: Misc cleanup on returned error code and local @err variables

[PATCH 0/6] s390x/cpu_models: Misc cleanup on returned error code and local @err variables

Zhao Liu posted 6 patches 2 weeks, 1 day ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240419065712.1225038-1-zhao1.liu@linux.intel.com

Maintainers: David Hildenbrand <david@redhat.com>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Ilya Leoshkevich <iii@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>

There is a newer version of this series

target/s390x/cpu_models.c        | 25 ++++++++++---------------
target/s390x/cpu_models.h        | 10 ++++++----
target/s390x/cpu_models_sysemu.c |  5 +----
target/s390x/kvm/kvm.c           | 28 +++++++++++++++-------------
4 files changed, 32 insertions(+), 36 deletions(-)

Expand all Fold all

[PATCH 0/6] s390x/cpu_models: Misc cleanup on returned error code and local @err variables

Posted by Zhao Liu 2 weeks, 1 day ago

From: Zhao Liu <zhao1.liu@intel.com>

Hi list,

This series is the followup of Thomas' suggestion in previous
ERRP_GUARD() cleanup[1]. And based on Thomas' thoughts, I tried to clean
up as many of the other related places (in s390x/cpu_models.c).

[1]: https://lore.kernel.org/qemu-devel/6e7eff95-cfd3-46f9-9937-7597b2e4f3ee@redhat.com/

Regards,
Zhao
---
Zhao Liu (6):
  target/s390x/cpu_model: Make check_compatibility() return boolean
  target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model()
  target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return
    boolean
  target/s390x/cpu_models: Drop local @err in get_max_cpu_model()
  target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return
    boolean
  target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model()

 target/s390x/cpu_models.c        | 25 ++++++++++---------------
 target/s390x/cpu_models.h        | 10 ++++++----
 target/s390x/cpu_models_sysemu.c |  5 +----
 target/s390x/kvm/kvm.c           | 28 +++++++++++++++-------------
 4 files changed, 32 insertions(+), 36 deletions(-)

-- 
2.34.1

Re: [PATCH 0/6] s390x/cpu_models: Misc cleanup on returned error code and local @err variables

Posted by Philippe Mathieu-Daudé 2 weeks, 1 day ago

On 19/4/24 08:57, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>


> ---
> Zhao Liu (6):
>    target/s390x/cpu_model: Make check_compatibility() return boolean
>    target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model()
>    target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return
>      boolean
>    target/s390x/cpu_models: Drop local @err in get_max_cpu_model()
>    target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return
>      boolean
>    target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model()

Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>