From nobody Thu May 16 15:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1712837373; cv=none; d=zohomail.com; s=zohoarc; b=EJmAcajVRYhYijBUQN2xBT7LR2t/aqjI4w/RttwNZG559dP2A4oBXku4ysY43lWW50b4SUElTFEk6NReSw2flKXzmJk2KERCpbHP8GucnqVPIoOMprgsNEvaTetJc1eg/lZh5Fhd/UXhRm7+wejSdBF9qL//dM9zFB30+one49Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712837373; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=opJ+WC0UhA7DXDKHCUJnEdNPmjLDNHndFdpnO7C6VtY=; b=jFLrHriPmpx/WxIUIkelEMaCmhny0yPJ3wGa1v4EVBbRvpa4Mp6orrgtkxHDxhKChtLH826uAeBqiXhCrIPgsnZnRyznYkMLKDiy6Y5tOg3UNrH9wYbfVbsMfSoUjfR8zl3H/sTRYLUerg7un1m0xzxOSd4HnkP5ea3AnLI8kGI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712837373150540.6126031656195; Thu, 11 Apr 2024 05:09:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rutEL-0003yA-AS; Thu, 11 Apr 2024 08:08:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rutEI-0003y2-Lr for qemu-devel@nongnu.org; Thu, 11 Apr 2024 08:08:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rutEF-0004wf-Gi for qemu-devel@nongnu.org; Thu, 11 Apr 2024 08:08:34 -0400 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-392-6aiQuQLSM1emyMk8ECKGUw-1; Thu, 11 Apr 2024 08:08:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EE2D1380621F; Thu, 11 Apr 2024 12:08:26 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.252]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E85D2166B36; Thu, 11 Apr 2024 12:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712837310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=opJ+WC0UhA7DXDKHCUJnEdNPmjLDNHndFdpnO7C6VtY=; b=Y3zVP76z+ZI6JlVxCGXHZBZDG7jl4b60LF9VI/eFGAE1fJrfhduCepfuXl13+/n5MtjFTt 0bU5CA2PTtS4MvCaadhY9QXmaRmFVaPj94UyyU9ZiXzqF+o9FVy+VbYSi7up4UM+WiFkpR qwaNMUMmFIIM6fSYEy6Ym3Ue7dtBSqY= X-MC-Unique: 6aiQuQLSM1emyMk8ECKGUw-1 From: Thomas Huth To: qemu-devel@nongnu.org, Brad Smith , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH for-9.0] meson.build: Disable -fzero-call-used-regs on OpenBSD Date: Thu, 11 Apr 2024 14:08:19 +0200 Message-ID: <20240411120819.56417-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.49, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1712837373721100001 Content-Type: text/plain; charset="utf-8" QEMU currently does not work on OpenBSD since the -fzero-call-used-regs option that we added to meson.build recently does not work with the "retguard" extension from OpenBSD's Clang. Thus let's disable the -fzero-call-used-regs here until there's a better solution available. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2278 Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Note: Given that we're close to the release, I think the host_os check is the best we can do ... the problem does not seem to trigger in all functions, only if certain registers are used by the compiler, so a more sophisticated check here seems to be too fragile to me right now. meson.build | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c9c3217ba4..91a0aa64c6 100644 --- a/meson.build +++ b/meson.build @@ -562,7 +562,11 @@ hardening_flags =3D [ # # NB: Clang 17 is broken and SEGVs # https://github.com/llvm/llvm-project/issues/75168 -if cc.compiles('extern struct { void (*cb)(void); } s; void f(void) { s.cb= (); }', +# +# NB2: This clashes with the "retguard" extension of OpenBSD's Clang +# https://gitlab.com/qemu-project/qemu/-/issues/2278 +if host_os !=3D 'openbsd' and \ + cc.compiles('extern struct { void (*cb)(void); } s; void f(void) { s.cb= (); }', name: '-fzero-call-used-regs=3Dused-gpr', args: ['-O2', '-fzero-call-used-regs=3Dused-gpr']) hardening_flags +=3D '-fzero-call-used-regs=3Dused-gpr' --=20 2.44.0