From nobody Sat May 18 19:24:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712050394525955.5091198023327; Tue, 2 Apr 2024 02:33:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rraVD-0005ms-5F; Tue, 02 Apr 2024 05:32:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rraV9-0005lq-IE; Tue, 02 Apr 2024 05:32:19 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rraV3-0003sh-OI; Tue, 02 Apr 2024 05:32:17 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id C62245B08A; Tue, 2 Apr 2024 12:33:40 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id C17A4A9346; Tue, 2 Apr 2024 12:31:57 +0300 (MSK) Received: (nullmailer pid 2931143 invoked by uid 1000); Tue, 02 Apr 2024 09:31:57 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Joonas Kankaala , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 1/4] usb-audio: Fix invalid values in AudioControl descriptors Date: Tue, 2 Apr 2024 12:31:54 +0300 Message-Id: <20240402093157.2931117-2-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240402093157.2931117-1-mjt@tls.msk.ru> References: <20240402093157.2931117-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1712050399755100005 From: Joonas Kankaala This fixes the invalid bInterfaceProtocol value 0x04 in the USB audio AudioControl descriptors. It should be zero. While Linux and Windows forgive this error, macOS 14 Sonoma does not. The usb-audio device does not appear in macOS sound settings even though the device is recognized and shows up in USB system information. According to the USB audio class specs 1.0-4.0, valid values are 0x00, 0x20, 0x30 and 0x40. (Note also that Linux prints the warning "unknown interface protocol 0x4, assuming v1", but then proceeds as if the value was zero.) This also fixes the invalid wTotalLength value in the multi-channel setup AudioControl interface header descriptor (used when multi=3Don and out.mixing-engine off). The combined length of all the descriptors there add up to 0x37, not 0x38. In Linux, "lsusb -D ..." displays incomplete descriptor information when this length is incorrect. Signed-off-by: Joonas Kankaala Reviewed-by: Volker R=C3=BCmelin Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/usb/dev-audio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c index d5ac1f8962..1897fff9e6 100644 --- a/hw/usb/dev-audio.c +++ b/hw/usb/dev-audio.c @@ -124,7 +124,6 @@ static const USBDescIface desc_iface[] =3D { .bNumEndpoints =3D 0, .bInterfaceClass =3D USB_CLASS_AUDIO, .bInterfaceSubClass =3D USB_SUBCLASS_AUDIO_CONTROL, - .bInterfaceProtocol =3D 0x04, .iInterface =3D STRING_USBAUDIO_CONTROL, .ndesc =3D 4, .descs =3D (USBDescOther[]) { @@ -282,7 +281,6 @@ static const USBDescIface desc_iface_multi[] =3D { .bNumEndpoints =3D 0, .bInterfaceClass =3D USB_CLASS_AUDIO, .bInterfaceSubClass =3D USB_SUBCLASS_AUDIO_CONTROL, - .bInterfaceProtocol =3D 0x04, .iInterface =3D STRING_USBAUDIO_CONTROL, .ndesc =3D 4, .descs =3D (USBDescOther[]) { @@ -293,7 +291,7 @@ static const USBDescIface desc_iface_multi[] =3D { USB_DT_CS_INTERFACE, /* u8 bDescriptorType */ DST_AC_HEADER, /* u8 bDescriptorSubtype= */ U16(0x0100), /* u16 bcdADC */ - U16(0x38), /* u16 wTotalLength */ + U16(0x37), /* u16 wTotalLength */ 0x01, /* u8 bInCollection */ 0x01, /* u8 baInterfaceNr */ } --=20 2.39.2 From nobody Sat May 18 19:24:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712050395823938.1344795587279; Tue, 2 Apr 2024 02:33:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rraVF-0005nt-5U; Tue, 02 Apr 2024 05:32:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rraVD-0005mw-B9; Tue, 02 Apr 2024 05:32:23 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rraVB-0004Eq-BJ; Tue, 02 Apr 2024 05:32:23 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id D418E5B08B; Tue, 2 Apr 2024 12:33:40 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id CF522A9347; Tue, 2 Apr 2024 12:31:57 +0300 (MSK) Received: (nullmailer pid 2931146 invoked by uid 1000); Tue, 02 Apr 2024 09:31:57 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 2/4] fpu/softfloat: Remove mention of TILE-Gx target Date: Tue, 2 Apr 2024 12:31:55 +0300 Message-Id: <20240402093157.2931117-3-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240402093157.2931117-1-mjt@tls.msk.ru> References: <20240402093157.2931117-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1712050399598100001 From: Philippe Mathieu-Daud=C3=A9 TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- fpu/softfloat-specialize.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc index 1610472cfc..1c85c48a73 100644 --- a/fpu/softfloat-specialize.c.inc +++ b/fpu/softfloat-specialize.c.inc @@ -152,7 +152,7 @@ static void parts64_default_nan(FloatParts64 *p, float_= status *status) /* * This case is true for Alpha, ARM, MIPS, OpenRISC, PPC, RISC-V, * S390, SH4, TriCore, and Xtensa. Our other supported targets, - * CRIS, Nios2, and Tile, do not have floating-point. + * CRIS and Nios2, do not have floating-point. */ if (snan_bit_is_one(status)) { /* set all bits other than msb */ --=20 2.39.2 From nobody Sat May 18 19:24:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712050424415787.0674513299548; Tue, 2 Apr 2024 02:33:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rraVe-0005sD-DH; Tue, 02 Apr 2024 05:32:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rraVR-0005rI-57; Tue, 02 Apr 2024 05:32:37 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rraVF-0004Mz-5t; Tue, 02 Apr 2024 05:32:36 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id EC2715B08C; Tue, 2 Apr 2024 12:33:40 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id DD977A9348; Tue, 2 Apr 2024 12:31:57 +0300 (MSK) Received: (nullmailer pid 2931149 invoked by uid 1000); Tue, 02 Apr 2024 09:31:57 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Stefan Weil via , Michael Tokarev Subject: [PULL 3/4] Fix some typos in documentation (found by codespell) Date: Tue, 2 Apr 2024 12:31:56 +0300 Message-Id: <20240402093157.2931117-4-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240402093157.2931117-1-mjt@tls.msk.ru> References: <20240402093157.2931117-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1712050425158100007 Content-Type: text/plain; charset="utf-8" From: Stefan Weil via Signed-off-by: Stefan Weil Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/devel/atomics.rst | 2 +- docs/devel/ci-jobs.rst.inc | 2 +- docs/devel/clocks.rst | 2 +- docs/system/i386/sgx.rst | 2 +- qapi/qom.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/devel/atomics.rst b/docs/devel/atomics.rst index ff9b5ee30c..b77c6e13e1 100644 --- a/docs/devel/atomics.rst +++ b/docs/devel/atomics.rst @@ -119,7 +119,7 @@ The only guarantees that you can rely upon in this case= are: ordinary accesses instead cause data races if they are concurrent with other accesses of which at least one is a write. In order to ensure thi= s, the compiler will not optimize accesses out of existence, create unsolic= ited - accesses, or perform other similar optimzations. + accesses, or perform other similar optimizations. =20 - acquire operations will appear to happen, with respect to the other components of the system, before all the LOAD or STORE operations diff --git a/docs/devel/ci-jobs.rst.inc b/docs/devel/ci-jobs.rst.inc index ec33e6ee2b..be06322279 100644 --- a/docs/devel/ci-jobs.rst.inc +++ b/docs/devel/ci-jobs.rst.inc @@ -115,7 +115,7 @@ CI pipeline. QEMU_JOB_SKIPPED ~~~~~~~~~~~~~~~~ =20 -The job is not reliably successsful in general, so is not +The job is not reliably successful in general, so is not currently suitable to be run by default. Ideally this should be a temporary marker until the problems can be addressed, or the job permanently removed. diff --git a/docs/devel/clocks.rst b/docs/devel/clocks.rst index b2d1148cdb..177ee1c90d 100644 --- a/docs/devel/clocks.rst +++ b/docs/devel/clocks.rst @@ -279,7 +279,7 @@ You can change the multiplier and divider of a clock at= runtime, so you can use this to model clock controller devices which have guest-programmable frequency multipliers or dividers. =20 -Similary to ``clock_set()``, ``clock_set_mul_div()`` returns ``true`` if +Similarly to ``clock_set()``, ``clock_set_mul_div()`` returns ``true`` if the clock state was modified; that is, if the multiplier or the diviser or both were changed by the call. =20 diff --git a/docs/system/i386/sgx.rst b/docs/system/i386/sgx.rst index 0f0a73f758..ab58b29392 100644 --- a/docs/system/i386/sgx.rst +++ b/docs/system/i386/sgx.rst @@ -6,7 +6,7 @@ Overview =20 Intel Software Guard eXtensions (SGX) is a set of instructions and mechani= sms for memory accesses in order to provide security accesses for sensitive -applications and data. SGX allows an application to use it's pariticular +applications and data. SGX allows an application to use its particular address space as an *enclave*, which is a protected area provides confiden= tiality and integrity even in the presence of privileged malware. Accesses to the enclave memory area from any software not resident in the enclave are prev= ented, diff --git a/qapi/qom.json b/qapi/qom.json index 8d4ca8ed92..85e6b4f84a 100644 --- a/qapi/qom.json +++ b/qapi/qom.json @@ -802,7 +802,7 @@ # # @fd: file descriptor name previously passed via 'getfd' command, # which represents a pre-opened /dev/iommu. This allows the -# iommufd object to be shared accross several subsystems (VFIO, +# iommufd object to be shared across several subsystems (VFIO, # VDPA, ...), and the file descriptor to be shared with other # process, e.g. DPDK. (default: QEMU opens /dev/iommu by itself) # --=20 2.39.2 From nobody Sat May 18 19:24:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712050435475500.33146506224966; Tue, 2 Apr 2024 02:33:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rraVg-0005u6-OU; Tue, 02 Apr 2024 05:32:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rraVY-0005s0-Hn; Tue, 02 Apr 2024 05:32:46 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rraVH-0004PG-BV; Tue, 02 Apr 2024 05:32:40 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 063925B08D; Tue, 2 Apr 2024 12:33:41 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 0189AA9349; Tue, 2 Apr 2024 12:31:58 +0300 (MSK) Received: (nullmailer pid 2931152 invoked by uid 1000); Tue, 02 Apr 2024 09:31:57 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Dayu Liu , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 4/4] hmp: Add help information for watchdog action: inject-nmi Date: Tue, 2 Apr 2024 12:31:57 +0300 Message-Id: <20240402093157.2931117-5-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240402093157.2931117-1-mjt@tls.msk.ru> References: <20240402093157.2931117-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1712050437614100003 Content-Type: text/plain; charset="utf-8" From: Dayu Liu virsh qemu-monitor-command --hmp help information of watchdog_action missing inject-nmi which already supported in Commit 795dc6e4 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2247 Signed-off-by: Dayu Liu Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev [Mjt: decode and word-wrap commit message and add Resolves: tag] --- hmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 17b5ea839d..2e2a3bcf98 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1412,7 +1412,7 @@ ERST { .name =3D "watchdog_action", .args_type =3D "action:s", - .params =3D "[reset|shutdown|poweroff|pause|debug|none]", + .params =3D "[reset|shutdown|poweroff|pause|debug|none|inject-= nmi]", .help =3D "change watchdog action", .cmd =3D hmp_watchdog_action, .command_completion =3D watchdog_action_completion, --=20 2.39.2