From nobody Wed May 15 18:40:06 2024 Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC4CEAC7 for ; Tue, 2 Apr 2024 00:17:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712017066; cv=none; b=LdHjsJufycW/9t+9LohbDP8ne6ApljZASL9Dm518t6xQjM5Zh3aYxeoOI2vmam29Rya2OlzI468I+ro7+Gx8nP5MQpBl6lHsDx0+prNDpWaJckFlyW7+JL0I9t4uLKQAKkTeLERaUWisUMLf0gfAtJHDjpCXBm921wDSvClnV8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712017066; c=relaxed/simple; bh=vXOLrurzWw91h7eYCw90ZLDHh+I4uNd31lHySo7hGYw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TMX2AT1sBMSJCYo3R+YkalV4z2ZVJy9rcnQn67TQiqlC1S/bQ1iZ2PqMFmCKPozcwBtM3QkycorLhCTNSdxSd+b0qzCfMycAw4iEOSK8RZYS1HqGTehNT44RHG5QO2E9pNjZucvjn7mMZiz/087o1eJoh9nnS/ckUodk+bbSgnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=Nfd3Tfkm; arc=none smtp.client-ip=209.85.217.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="Nfd3Tfkm" Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-4766e56ccccso1744372137.0 for ; Mon, 01 Apr 2024 17:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1712017063; x=1712621863; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nM2K0D/X61aNkdsdtPeKZ1y9TeOUsh6nA3RvZQfcaBY=; b=Nfd3Tfkm2/65kewYUQ4RHVUeH/I/YRMTnOTxB1AbadPlz3KP166fCe99/jg0SPD5uL tkiypICy6t2Efl9iN5rwnzHqm5QiG0SZ64+YexNzbj2RsfIB1LQUtYH6r89/tebB9+3P jWNVbtxJzXBBVfUx4QYrbv4rIQAIP0QAutmWxz81KK6Y8tn0s4UtuVL6qe47QofjgYWg xWHKlH01GUis9x9vjLxfRWfkfym2bP/Xe8Ya5oltWh5tKm0++M2HJjq/88DfEdyA5STk mi7gf2lErHjspC/YtFpN+B9rWirCywmtX3RqBg1W0TI8zWTbXu6OF1Ee6s5r+9FWmlUn /k4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712017063; x=1712621863; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nM2K0D/X61aNkdsdtPeKZ1y9TeOUsh6nA3RvZQfcaBY=; b=WTi2BL8wl16l2dKB5yOnr+1qmOZ49SqBk8Lw7dnc4C4romv//j3pr2QJOoXWR09p3H Pv3CbDsk8FwtAkEaYaNA5FPHCPhALP8nj8OCNd2qOEffyn2YrAOTD+7PmlR5r0ikmoGt qO06JreWKQnLZcJ3qdowrNwlSUMYqfjkHEwYVdGShBD1SmIwP58oGUoTJnPJ2wBM0M4G gV5ttIPIbcyJyjOxsmbYYVYHZMzva1UtAWZp+4pzPsM8e0bgza0gDe0myrmk1J6/eRfg dUpkBAdkPbojWiIikQQToL1c1cRbf9Dc70UrYPpaHxZJRv6waVhErALcsXP4Sp8IPZ3o 7amA== X-Forwarded-Encrypted: i=1; AJvYcCUs3iQSGvvxUX7hMa/6MKA4LWJ/5yaB7USHyxgm+SE5RrZKloMzrq6ichc0DobIac4Rfx+19CFUDaiDSCkvl5VYKZhkYlYYaVaJK39p X-Gm-Message-State: AOJu0YygS8J6KKDo0bzNywSMPsfQY8awNe9vsyZv/E12gNoNnGD4iXBx 5sRTaWIkNv42FDUsWDpKbEKdUolSSbYvDNMreQmEpdsrUeQhtT4xt9gZ/YWrGl0= X-Google-Smtp-Source: AGHT+IFKAc3hYgC4iDc8epxfwQKN8USKmAQhU8ZxSXJUvVeCt1lZzEZqTAGJQdv/3QSxwj+j4d4QMw== X-Received: by 2002:a05:6102:4a11:b0:478:52cc:fc42 with SMTP id jw17-20020a0561024a1100b0047852ccfc42mr8638750vsb.10.1712017063419; Mon, 01 Apr 2024 17:17:43 -0700 (PDT) Received: from n231-228-171.byted.org ([130.44.212.125]) by smtp.gmail.com with ESMTPSA id e10-20020a0562141d0a00b00698f9771822sm3013112qvd.83.2024.04.01.17.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 17:17:43 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , "SeongJae Park" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org Subject: [PATCH v10 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types Date: Tue, 2 Apr 2024 00:17:37 +0000 Message-Id: <20240402001739.2521623-2-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240402001739.2521623-1-horenchuang@bytedance.com> References: <20240402001739.2521623-1-horenchuang@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang Reviewed-by: "Huang, Ying" --- drivers/dax/kmem.c | 20 ++------------------ include/linux/memory-tiers.h | 13 +++++++++++++ mm/memory-tiers.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 18 deletions(-) diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index 42ee360cf4e3..01399e5b53b2 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -55,21 +55,10 @@ static LIST_HEAD(kmem_memory_types); =20 static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) { - bool found =3D false; struct memory_dev_type *mtype; =20 mutex_lock(&kmem_memory_type_lock); - list_for_each_entry(mtype, &kmem_memory_types, list) { - if (mtype->adistance =3D=3D adist) { - found =3D true; - break; - } - } - if (!found) { - mtype =3D alloc_memory_type(adist); - if (!IS_ERR(mtype)) - list_add(&mtype->list, &kmem_memory_types); - } + mtype =3D mt_find_alloc_memory_type(adist, &kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); =20 return mtype; @@ -77,13 +66,8 @@ static struct memory_dev_type *kmem_find_alloc_memory_ty= pe(int adist) =20 static void kmem_put_memory_types(void) { - struct memory_dev_type *mtype, *mtn; - mutex_lock(&kmem_memory_type_lock); - list_for_each_entry_safe(mtype, mtn, &kmem_memory_types, list) { - list_del(&mtype->list); - put_memory_type(mtype); - } + mt_put_memory_types(&kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); } =20 diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h index 69e781900082..a44c03c2ba3a 100644 --- a/include/linux/memory-tiers.h +++ b/include/linux/memory-tiers.h @@ -48,6 +48,9 @@ int mt_calc_adistance(int node, int *adist); int mt_set_default_dram_perf(int nid, struct access_coordinate *perf, const char *source); int mt_perf_to_adistance(struct access_coordinate *perf, int *adist); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types); +void mt_put_memory_types(struct list_head *memory_types); #ifdef CONFIG_MIGRATION int next_demotion_node(int node); void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets); @@ -136,5 +139,15 @@ static inline int mt_perf_to_adistance(struct access_c= oordinate *perf, int *adis { return -EIO; } + +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_h= ead *memory_types) +{ + return NULL; +} + +void mt_put_memory_types(struct list_head *memory_types) +{ + +} #endif /* CONFIG_NUMA */ #endif /* _LINUX_MEMORY_TIERS_H */ diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 0537664620e5..974af10cfdd8 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -623,6 +623,38 @@ void clear_node_memory_type(int node, struct memory_de= v_type *memtype) } EXPORT_SYMBOL_GPL(clear_node_memory_type); =20 +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_h= ead *memory_types) +{ + bool found =3D false; + struct memory_dev_type *mtype; + + list_for_each_entry(mtype, memory_types, list) { + if (mtype->adistance =3D=3D adist) { + found =3D true; + break; + } + } + if (!found) { + mtype =3D alloc_memory_type(adist); + if (!IS_ERR(mtype)) + list_add(&mtype->list, memory_types); + } + + return mtype; +} +EXPORT_SYMBOL_GPL(mt_find_alloc_memory_type); + +void mt_put_memory_types(struct list_head *memory_types) +{ + struct memory_dev_type *mtype, *mtn; + + list_for_each_entry_safe(mtype, mtn, memory_types, list) { + list_del(&mtype->list); + put_memory_type(mtype); + } +} +EXPORT_SYMBOL_GPL(mt_put_memory_types); + static void dump_hmem_attrs(struct access_coordinate *coord, const char *p= refix) { pr_info( --=20 Ho-Ren (Jack) Chuang From nobody Wed May 15 18:40:06 2024 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01663DDD2 for ; Tue, 2 Apr 2024 00:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712017068; cv=none; b=rMw/0VjweOGQa1KbWv5OGGCfFrkC4Rpg4etl2eZUefOI4tspBvFVs2szlUHyMz5CNeYfDCVu/ts4Oceqd4byvlsvhQmqfirZm1OQLGqHvzjfaMkoj9SCiiy1qNeIP4i+DhyCriaglrmw+mitvKEESMTa45XeT2Hir6H9b2ry+tI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712017068; c=relaxed/simple; bh=iJW9SJHyneSYmEGyeWzEpCU4A7K7euTYpJk6Xq1gIfM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ESzNVUDN6xDBEOCmkdE77HDKnEFCfWEKqv/hRvt9ZSyewTNEmumwZFc4C9NHaa3hetzh5Kki0YxcIAQWF0tMLoh4HUtSn9I3LBsh768vjt8iv3vSLBpqBKeKLXQlgWLvgherhBMhJhK6U1mHfNM4H25/r/dXlzxaFDrHUfy56u8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=DGVTCGf4; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="DGVTCGf4" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4317fbb669dso20827901cf.1 for ; Mon, 01 Apr 2024 17:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1712017065; x=1712621865; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PZYYFgVRrQCyHvtBEuYH7h6o9TH4NNMhZD/5GyRy63w=; b=DGVTCGf4WN9bW7zXZ/zYba5d5tkgeNUyhxJJGfQQetzghmzht/9p+otEIDS7TvCajp dMw3KUPV9nASw9nOUdC6CFQlHFE6rKmK/riRj91C1JpcCMfScaJabQ/QTzZAgNw+TF9g Yp5XtSYnwuuzG9rxxSFJ/6QSEF4p+64orqyXpYlyWzHt57/Xc9OzZp1SMq0+9D/F9OOc LNR6ywl8zWjWFKq6eFjVgR6Z7+TwbrGcnpJ52PcwP1WZo3VbQb6RYaSrijIKRXYmG68t L0WBgKgLnMppSodwcsdi9DZZENhbn5OpkqtMIfvqhi69DEhS550KQBlxjkQEv7VqBAuU cXZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712017065; x=1712621865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PZYYFgVRrQCyHvtBEuYH7h6o9TH4NNMhZD/5GyRy63w=; b=ComO47Oh5aSusbIksCsAZVhOJKeO5RllBo97C2NPb0PcC7kjSV3vNATB+TW7r+Nl/v eMM7prQ7Nre54ysmNb9/m4shh57UYqoxYA5cOAGVEdhqAio6URcqsy3xUEJLrXu/Zy+W bv77gcr65GKaseSpCRNcD9JfKU3pVnuvdg5DOMxoiBqGKaSDIseIEy7nFcrn1nz4ULVr 0Dk65ONFWtcJRmZO1r4L3hViAvRc7x2R+HvcSPTkPKwOFu0fiL4uPBVSyy1RdPntHl0W KgdZW7r8wMcIUV5LpJw43llsMm11J5TvNbfuKtBNS8jhzJel42/bLjlfwUc00Eqi3SDM hCrg== X-Forwarded-Encrypted: i=1; AJvYcCU41RBoNRQymOwMS+USGjDM9n6U+yX9g95/tUkAsE/a5FajIWom3aQZhjSrnO0JMqO5Wppmi+C2tHBrXpt3qOV10ZtdTa6bQ/dzNwIK X-Gm-Message-State: AOJu0Yy5lDopQmFyFzy1ZzS4O5YR9D8FCePyGenfkZ/lrqM65TJt1kqq Mw5wqusgEaTq2U8r5Gadti1p3SQkVMu5ns4Ywe0u3xujqAcSHtWnnCe8wXEw/+s= X-Google-Smtp-Source: AGHT+IH0dKZtlTit1GSkvLXp6F0jF1c0z74lQPxxIbr4JWCWw37kSgbA6kdWs7YXSpceE6HdVzmoDA== X-Received: by 2002:ad4:4c46:0:b0:699:184a:9315 with SMTP id cs6-20020ad44c46000000b00699184a9315mr358028qvb.62.1712017064933; Mon, 01 Apr 2024 17:17:44 -0700 (PDT) Received: from n231-228-171.byted.org ([130.44.212.125]) by smtp.gmail.com with ESMTPSA id e10-20020a0562141d0a00b00698f9771822sm3013112qvd.83.2024.04.01.17.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 17:17:44 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , "SeongJae Park" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org, Hao Xiang Subject: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info Date: Tue, 2 Apr 2024 00:17:38 +0000 Message-Id: <20240402001739.2521623-3-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240402001739.2521623-1-horenchuang@bytedance.com> References: <20240402001739.2521623-1-horenchuang@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current implementation treats emulated memory devices, such as CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory (E820_TYPE_RAM). However, these emulated devices have different characteristics than traditional DRAM, making it important to distinguish them. Thus, we modify the tiered memory initialization process to introduce a delay specifically for CPUless NUMA nodes. This delay ensures that the memory tier initialization for these nodes is deferred until HMAT information is obtained during the boot process. Finally, demotion tables are recalculated at the end. * late_initcall(memory_tier_late_init); Some device drivers may have initialized memory tiers between `memory_tier_init()` and `memory_tier_late_init()`, potentially bringing online memory nodes and configuring memory tiers. They should be excluded in the late init. * Handle cases where there is no HMAT when creating memory tiers There is a scenario where a CPUless node does not provide HMAT information. If no HMAT is specified, it falls back to using the default DRAM tier. * Introduce another new lock `default_dram_perf_lock` for adist calculation In the current implementation, iterating through CPUlist nodes requires holding the `memory_tier_lock`. However, `mt_calc_adistance()` will end up trying to acquire the same lock, leading to a potential deadlock. Therefore, we propose introducing a standalone `default_dram_perf_lock` to protect `default_dram_perf_*`. This approach not only avoids deadlock but also prevents holding a large lock simultaneously. * Upgrade `set_node_memory_tier` to support additional cases, including default DRAM, late CPUless, and hot-plugged initializations. To cover hot-plugged memory nodes, `mt_calc_adistance()` and `mt_find_alloc_memory_type()` are moved into `set_node_memory_tier()` to handle cases where memtype is not initialized and where HMAT information is available. * Introduce `default_memory_types` for those memory types that are not initialized by device drivers. Because late initialized memory and default DRAM memory need to be managed, a default memory type is created for storing all memory types that are not initialized by device drivers and as a fallback. Signed-off-by: Ho-Ren (Jack) Chuang Signed-off-by: Hao Xiang Reviewed-by: "Huang, Ying" --- include/linux/memory-tiers.h | 5 +- mm/memory-tiers.c | 95 +++++++++++++++++++++++++++++------- 2 files changed, 81 insertions(+), 19 deletions(-) diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h index a44c03c2ba3a..16769552a338 100644 --- a/include/linux/memory-tiers.h +++ b/include/linux/memory-tiers.h @@ -140,12 +140,13 @@ static inline int mt_perf_to_adistance(struct access_= coordinate *perf, int *adis return -EIO; } =20 -struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_h= ead *memory_types) +static inline struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types) { return NULL; } =20 -void mt_put_memory_types(struct list_head *memory_types) +static inline void mt_put_memory_types(struct list_head *memory_types) { =20 } diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 974af10cfdd8..44fa10980d37 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -36,6 +36,11 @@ struct node_memory_type_map { =20 static DEFINE_MUTEX(memory_tier_lock); static LIST_HEAD(memory_tiers); +/* + * The list is used to store all memory types that are not created + * by a device driver. + */ +static LIST_HEAD(default_memory_types); static struct node_memory_type_map node_memory_types[MAX_NUMNODES]; struct memory_dev_type *default_dram_type; =20 @@ -108,6 +113,8 @@ static struct demotion_nodes *node_demotion __read_most= ly; =20 static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); =20 +/* The lock is used to protect `default_dram_perf*` info and nid. */ +static DEFINE_MUTEX(default_dram_perf_lock); static bool default_dram_perf_error; static struct access_coordinate default_dram_perf; static int default_dram_perf_ref_nid =3D NUMA_NO_NODE; @@ -505,7 +512,8 @@ static inline void __init_node_memory_type(int node, st= ruct memory_dev_type *mem static struct memory_tier *set_node_memory_tier(int node) { struct memory_tier *memtier; - struct memory_dev_type *memtype; + struct memory_dev_type *mtype =3D default_dram_type; + int adist =3D MEMTIER_ADISTANCE_DRAM; pg_data_t *pgdat =3D NODE_DATA(node); =20 =20 @@ -514,11 +522,20 @@ static struct memory_tier *set_node_memory_tier(int n= ode) if (!node_state(node, N_MEMORY)) return ERR_PTR(-EINVAL); =20 - __init_node_memory_type(node, default_dram_type); + mt_calc_adistance(node, &adist); + if (node_memory_types[node].memtype =3D=3D NULL) { + mtype =3D mt_find_alloc_memory_type(adist, &default_memory_types); + if (IS_ERR(mtype)) { + mtype =3D default_dram_type; + pr_info("Failed to allocate a memory type. Fall back.\n"); + } + } + + __init_node_memory_type(node, mtype); =20 - memtype =3D node_memory_types[node].memtype; - node_set(node, memtype->nodes); - memtier =3D find_create_memory_tier(memtype); + mtype =3D node_memory_types[node].memtype; + node_set(node, mtype->nodes); + memtier =3D find_create_memory_tier(mtype); if (!IS_ERR(memtier)) rcu_assign_pointer(pgdat->memtier, memtier); return memtier; @@ -655,6 +672,33 @@ void mt_put_memory_types(struct list_head *memory_type= s) } EXPORT_SYMBOL_GPL(mt_put_memory_types); =20 +/* + * This is invoked via `late_initcall()` to initialize memory tiers for + * CPU-less memory nodes after driver initialization, which is + * expected to provide `adistance` algorithms. + */ +static int __init memory_tier_late_init(void) +{ + int nid; + + mutex_lock(&memory_tier_lock); + for_each_node_state(nid, N_MEMORY) + if (node_memory_types[nid].memtype =3D=3D NULL) + /* + * Some device drivers may have initialized memory tiers + * between `memory_tier_init()` and `memory_tier_late_init()`, + * potentially bringing online memory nodes and + * configuring memory tiers. Exclude them here. + */ + set_node_memory_tier(nid); + + establish_demotion_targets(); + mutex_unlock(&memory_tier_lock); + + return 0; +} +late_initcall(memory_tier_late_init); + static void dump_hmem_attrs(struct access_coordinate *coord, const char *p= refix) { pr_info( @@ -668,7 +712,7 @@ int mt_set_default_dram_perf(int nid, struct access_coo= rdinate *perf, { int rc =3D 0; =20 - mutex_lock(&memory_tier_lock); + mutex_lock(&default_dram_perf_lock); if (default_dram_perf_error) { rc =3D -EIO; goto out; @@ -716,23 +760,30 @@ int mt_set_default_dram_perf(int nid, struct access_c= oordinate *perf, } =20 out: - mutex_unlock(&memory_tier_lock); + mutex_unlock(&default_dram_perf_lock); return rc; } =20 int mt_perf_to_adistance(struct access_coordinate *perf, int *adist) { - if (default_dram_perf_error) - return -EIO; + int rc =3D 0; =20 - if (default_dram_perf_ref_nid =3D=3D NUMA_NO_NODE) - return -ENOENT; + mutex_lock(&default_dram_perf_lock); + if (default_dram_perf_error) { + rc =3D -EIO; + goto out; + } =20 if (perf->read_latency + perf->write_latency =3D=3D 0 || - perf->read_bandwidth + perf->write_bandwidth =3D=3D 0) - return -EINVAL; + perf->read_bandwidth + perf->write_bandwidth =3D=3D 0) { + rc =3D -EINVAL; + goto out; + } =20 - mutex_lock(&memory_tier_lock); + if (default_dram_perf_ref_nid =3D=3D NUMA_NO_NODE) { + rc =3D -ENOENT; + goto out; + } /* * The abstract distance of a memory node is in direct proportion to * its memory latency (read + write) and inversely proportional to its @@ -745,9 +796,10 @@ int mt_perf_to_adistance(struct access_coordinate *per= f, int *adist) (default_dram_perf.read_latency + default_dram_perf.write_latency) * (default_dram_perf.read_bandwidth + default_dram_perf.write_bandwidth) / (perf->read_bandwidth + perf->write_bandwidth); - mutex_unlock(&memory_tier_lock); =20 - return 0; +out: + mutex_unlock(&default_dram_perf_lock); + return rc; } EXPORT_SYMBOL_GPL(mt_perf_to_adistance); =20 @@ -858,7 +910,8 @@ static int __init memory_tier_init(void) * For now we can have 4 faster memory tiers with smaller adistance * than default DRAM tier. */ - default_dram_type =3D alloc_memory_type(MEMTIER_ADISTANCE_DRAM); + default_dram_type =3D mt_find_alloc_memory_type(MEMTIER_ADISTANCE_DRAM, + &default_memory_types); if (IS_ERR(default_dram_type)) panic("%s() failed to allocate default DRAM tier\n", __func__); =20 @@ -868,6 +921,14 @@ static int __init memory_tier_init(void) * types assigned. */ for_each_node_state(node, N_MEMORY) { + if (!node_state(node, N_CPU)) + /* + * Defer memory tier initialization on CPUless numa nodes. + * These will be initialized after firmware and devices are + * initialized. + */ + continue; + memtier =3D set_node_memory_tier(node); if (IS_ERR(memtier)) /* --=20 Ho-Ren (Jack) Chuang