From nobody Wed May 15 05:31:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1711539199; cv=none; d=zohomail.com; s=zohoarc; b=WsJTmPuNQyFzoXcIGuy9zYwvyrKsJoI+z7kgpAhS++AANAWniiWpJR5rJP3jdVevvwZJ37Q3JFTGSYXQYzjSE2kfFS1FuwVvTqSdedA04luuOyhcCaKEks7jk+xUr98aUEGLNwoaLoB8YoXdx+bSkjIdNlzRpjlglnG0kXczNZc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1711539199; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O9WVLG6dxOqRK8Ot1bOUEB8silJFdst5eAZrIaxhtBk=; b=Oai0woNDW4TuUm/jYcm/Ub/byivxAloS71TolpGq1hepFCzbubOkCM+hwGr2Cm9jnkiWir5r/4GhvvZ5paxoJjGqeIvwlJruAfoxIGWPglQ1nI1vKN435+cFnpRw7gSBQmoajeDQ+DP+eI4v+yPWtmHkpSBqXkyvBZ4N6HRgpHU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17115391991961010.5026199641103; Wed, 27 Mar 2024 04:33:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpRW8-0006Lk-DD; Wed, 27 Mar 2024 07:32:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpRW7-0006LZ-8z for qemu-devel@nongnu.org; Wed, 27 Mar 2024 07:32:27 -0400 Received: from mgamail.intel.com ([192.198.163.9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpRW4-0000eq-Bu for qemu-devel@nongnu.org; Wed, 27 Mar 2024 07:32:26 -0400 Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 04:32:21 -0700 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.36]) by fmviesa009.fm.intel.com with ESMTP; 27 Mar 2024 04:32:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711539145; x=1743075145; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=VLCDtnrRT1O3HvbiUBardQSY/S+PhjGzXYwBEypmBWo=; b=kMrEty1/cAC7npSRwC1V+6r3iAJgXi/HzV79sJNLSwIxKR2pjxWtnAoj CVcbdOYvFztcu5gXu0n3QCRkG7YP7suBsrm/n2ZhrZFY7xe+HLE0+1Vm2 SOEbcCq3PZbbwHaRfdlfFjNpon9m9+m7emh0NGn0lSJSi25TC94UNyq4m +YcMCPOW12KSio1uN1yNd2SmS2FUgvMdt7Hshal8H3upI4oTpLNe6cbz7 Oyi8S+inyYGoCvzQwIW+jv2HJCn1VFm3olvwp64It/83rI8ONpCL5T0vL qk1NgR2t6bJGX30VtinSw/KUZ5wxD8NLUJdKRJSfGPv3k6VkeM7WABRYT Q==; X-CSE-ConnectionGUID: P9J8im2iT7q0qy3PEIKqTA== X-CSE-MsgGUID: MgnpZGy/Svi9o05OCv4wlA== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="17362971" X-IronPort-AV: E=Sophos;i="6.07,158,1708416000"; d="scan'208";a="17362971" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,158,1708416000"; d="scan'208";a="16323444" From: Zhao Liu To: Markus Armbruster Cc: qemu-devel@nongnu.org, Zhao Liu Subject: [RFC] util/error-report: Add "error: " prefix for error-level report Date: Wed, 27 Mar 2024 19:46:09 +0800 Message-Id: <20240327114609.3858483-1-zhao1.liu@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=192.198.163.9; envelope-from=zhao1.liu@linux.intel.com; helo=mgamail.intel.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1711539201180100009 Content-Type: text/plain; charset="utf-8" From: Zhao Liu When vreport() was introduced, there was no prefix for error-level (REPORT_TYPE_ERROR) report. The original reason is "To maintain compatibility we don't add anything here" as Alistair said in his RFC v3 series [1]. This was done in the context of inheriting the original error_report() interface without the prefix style. And it was also useful to have a means of error handling, such as exit(), when error occurs, so that the error message - the most serious level - can be noticed by the user. Nowadays, however, error_report() and its variants have a tendency to be "abused": it is used a lot just for the sake of logging something more noticeable than the "warn" or "info" level, in the absence of appropriate error handling logic. But, in the use case above, due to the lack of a prefix, it is in fact less informative to the user than warn_report()/info_report() (with "warn:" or "info: " prfix), which does not match its highest level. Therefore, add "error: " prefix for error-level report. [1]: https://lore.kernel.org/qemu-devel/87r2xuay5h.fsf@dusky.pond.sub.org/#t Signed-off-by: Zhao Liu --- util/error-report.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/error-report.c b/util/error-report.c index 6e44a5573217..e981c0b032f0 100644 --- a/util/error-report.c +++ b/util/error-report.c @@ -213,6 +213,7 @@ static void vreport(report_type type, const char *fmt, = va_list ap) =20 switch (type) { case REPORT_TYPE_ERROR: + error_printf("error: "); break; case REPORT_TYPE_WARNING: error_printf("warning: "); --=20 2.34.1