target/hppa: Clear psw_n for BE on use_nullify_skip path

[PATCH for-9.0] target/hppa: Clear psw_n for BE on use_nullify_skip path

Posted by Richard Henderson 1 month ago

Along this path we have already skipped the insn to be
nullified, so the subsequent insn should be executed.

Cc: qemu-stable@nongnu.org
Reported-by: Sven Schnelle <svens@stackframe.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/hppa/translate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 143818c2d9..8a1a8bc3aa 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -3948,6 +3948,7 @@ static bool trans_be(DisasContext *ctx, arg_be *a)
         copy_iaoq_entry(ctx, cpu_iaoq_b, -1, tmp);
         tcg_gen_mov_i64(cpu_iasq_f, new_spc);
         tcg_gen_mov_i64(cpu_iasq_b, cpu_iasq_f);
+        nullify_set(ctx, 0);
     } else {
         copy_iaoq_entry(ctx, cpu_iaoq_f, ctx->iaoq_b, cpu_iaoq_b);
         if (ctx->iaoq_b == -1) {
-- 
2.34.1

Re: [PATCH for-9.0] target/hppa: Clear psw_n for BE on use_nullify_skip path

Posted by Philippe Mathieu-Daudé 1 month ago

On 26/3/24 19:35, Richard Henderson wrote:
> Along this path we have already skipped the insn to be
> nullified, so the subsequent insn should be executed.
> 
> Cc: qemu-stable@nongnu.org
> Reported-by: Sven Schnelle <svens@stackframe.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/hppa/translate.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH for-9.0] target/hppa: Clear psw_n for BE on use_nullify_skip path

Posted by Sven Schnelle 1 month ago

Richard Henderson <richard.henderson@linaro.org> writes:

> Along this path we have already skipped the insn to be
> nullified, so the subsequent insn should be executed.
>
> Cc: qemu-stable@nongnu.org
> Reported-by: Sven Schnelle <svens@stackframe.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/hppa/translate.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index 143818c2d9..8a1a8bc3aa 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -3948,6 +3948,7 @@ static bool trans_be(DisasContext *ctx, arg_be *a)
>          copy_iaoq_entry(ctx, cpu_iaoq_b, -1, tmp);
>          tcg_gen_mov_i64(cpu_iasq_f, new_spc);
>          tcg_gen_mov_i64(cpu_iasq_b, cpu_iasq_f);
> +        nullify_set(ctx, 0);
>      } else {
>          copy_iaoq_entry(ctx, cpu_iaoq_f, ctx->iaoq_b, cpu_iaoq_b);
>          if (ctx->iaoq_b == -1) {

Tested-by: Sven Schnelle <svens@stackframe.org>