From nobody Wed May 15 06:21:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1711456041; cv=none; d=zohomail.com; s=zohoarc; b=fd3feVwciLJHFB2Bvb/G6qT3ZMq4HMf8yZ+BZIj1tV5UEA9Evow0tgnvPb4xDTZftdyHg6UkrVz4dXh0KQ0fYLNfJgaW2040gH02t+LCuOpIM6rSnDPS7QjZqJzMyyVqkaq8NPBA4Ryslw9rLPYlYhev5hBjfwoJdwmPBsPK4Bw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1711456041; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jz8PWpI1IuNnh6LtWXjgSr2RQfXSnKpaJzhP2OUz2bs=; b=VVKyug4Zka6t9ban0W+kKNLjpfZWEyc5l61UZ/GEFLyASLCYkYsEtw31JElOJy5Z9COSEyXPpd/e6abWe8i6U2XLwtG4W5DUNLFcSiduRpxZOnQavozRg/MxplhtJRETrE+oiipvg0dFqoHtXQd3CgHuwcgboTlBsJC4oPzioDk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1711456041923631.7993509134056; Tue, 26 Mar 2024 05:27:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rp5t7-0001pa-5E; Tue, 26 Mar 2024 08:26:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rp5t3-0001oy-V2 for qemu-devel@nongnu.org; Tue, 26 Mar 2024 08:26:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rp5t2-0006zQ-7A for qemu-devel@nongnu.org; Tue, 26 Mar 2024 08:26:41 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-SxgEV9AENn2o0V80UuTYPw-1; Tue, 26 Mar 2024 08:26:35 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 835AA101CC70; Tue, 26 Mar 2024 12:26:34 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq2.redhat.com (dell-r430-03.lab.eng.brq2.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 745E42166B35; Tue, 26 Mar 2024 12:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711455998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jz8PWpI1IuNnh6LtWXjgSr2RQfXSnKpaJzhP2OUz2bs=; b=cltYzshxL4/KNbySyZfclO+27VpJw8omDYgdtsSn2UrfiE1u2+tIyZF1lhchjxHlOPHFM+ gsBE3TOAIn1QA8FINwP9+Wb+mhDsekPksikiCO0+VyEH+udcVpR4gdYHPioPqsKXgDW8eB 3n7arTTOYPT5JdTu90cxL6hTS4vZTWo= X-MC-Unique: SxgEV9AENn2o0V80UuTYPw-1 From: Igor Mammedov To: qemu-devel@nongnu.org Cc: anisinha@redhat.com, mst@redhat.com, laurent@vivier.eu, qemu-trivial@nongnu.org, Michael Tokarev , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH trivial for-9.0] smbios: add stub for smbios_get_table_legacy() Date: Tue, 26 Mar 2024 13:26:30 +0100 Message-ID: <20240326122630.85989-1-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.088, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1711456043729100001 QEMU build fails with hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy' when it's built with only 'microvm' enabled i.e. with config patch +++ b/configs/devices/i386-softmmu/default.mak @@ -26,7 +26,7 @@ # Boards: # -CONFIG_ISAPC=3Dy -CONFIG_I440FX=3Dy -CONFIG_Q35=3Dy +CONFIG_ISAPC=3Dn +CONFIG_I440FX=3Dn +CONFIG_Q35=3Dn it happens because I've fogotten/lost smbios_get_table_legacy() stub. Fix it by adding missing stub as Philippe suggested. Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine" Reported-by: Michael Tokarev Singned-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Igor Mammedov Reviewed-by: Michael Tokarev Tested-by: Philippe Mathieu-Daud=C3=A9 --- Compile tested only. While it's fixing bug for off-tree usecase with non-upstream config, it's trivial enough to go into 9.0 if time frame allows. Benefit of it going into 9.0 is that folks who play with minimal builds won't have to carry the patch in their tree. hw/smbios/smbios_legacy_stub.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/smbios/smbios_legacy_stub.c b/hw/smbios/smbios_legacy_stub.c index f29b15316c..7d593dca98 100644 --- a/hw/smbios/smbios_legacy_stub.c +++ b/hw/smbios/smbios_legacy_stub.c @@ -13,3 +13,8 @@ void smbios_add_usr_blob_size(size_t size) { } + +uint8_t *smbios_get_table_legacy(size_t *length, Error **errp) +{ + g_assert_not_reached(); +} --=20 2.43.0