[v1] pc_q35: remove unnecessary m->alias assignment

[PATCH] pc_q35: remove unnecessary m->alias assignment

Paolo Bonzini posted 1 patch 1 month, 1 week ago

Diff against v2
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240325135906.1372946-1-pbonzini@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

There is a newer version of this series

hw/i386/pc_q35.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] pc_q35: remove unnecessary m->alias assignment

Posted by Paolo Bonzini 1 month, 1 week ago

The assignment is already inherited from pc-q35-8.2. -s
---
 hw/i386/pc_q35.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index b5922b44afa..c7bc8a2041f 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -393,7 +393,6 @@ static void pc_q35_8_1_machine_options(MachineClass *m)
 {
     PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
     pc_q35_8_2_machine_options(m);
-    m->alias = NULL;
     pcmc->broken_32bit_mem_addr_check = true;
     compat_props_add(m->compat_props, hw_compat_8_1, hw_compat_8_1_len);
     compat_props_add(m->compat_props, pc_compat_8_1, pc_compat_8_1_len);
-- 
2.44.0

Re: [PATCH] pc_q35: remove unnecessary m->alias assignment

Posted by Peter Maydell 1 month, 1 week ago

On Mon, 25 Mar 2024 at 13:59, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The assignment is already inherited from pc-q35-8.2. -s

Missing signed-off-by and a stray "-s" in the commit message :-)

-- PMM

Re: [PATCH] pc_q35: remove unnecessary m->alias assignment

Posted by Paolo Bonzini 1 month, 1 week ago

On Mon, Mar 25, 2024 at 3:02 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 25 Mar 2024 at 13:59, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > The assignment is already inherited from pc-q35-8.2. -s
>
> Missing signed-off-by and a stray "-s" in the commit message :-)

You can probably guess that the two are related. :)

Paolo