[v2] hw/clock: Propagate clock changes when STM32L4X5 MUX is updated

[PATCH-for-9.0? v2 0/8] hw/clock: Propagate clock changes when STM32L4X5 MUX is updated

Philippe Mathieu-Daudé posted 8 patches 1 month, 1 week ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240325133259.57235-1-philmd@linaro.org

Maintainers: Luc Michel <luc@lmichel.fr>, Damien Hedde <damien.hedde@dahe.fr>, "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, Subbaraya Sundeep <sundeep.lkml@gmail.com>, Alistair Francis <alistair@alistair23.me>, Felipe Balbi <balbi@kernel.org>, Alexandre Iooss <erdnaxe@crans.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Arnaud Minier <arnaud.minier@telecom-paris.fr>, "Inès Varhol" <ines.varhol@telecom-paris.fr>

There is a newer version of this series

docs/devel/clocks.rst      |  6 +++++-
include/hw/clock.h         | 21 +++++++++++---------
hw/arm/aspeed.c            |  2 +-
hw/arm/fby35.c             |  2 +-
hw/arm/mps2-tz.c           |  4 ++--
hw/arm/mps2.c              |  4 ++--
hw/arm/mps3r.c             |  2 +-
hw/arm/msf2-soc.c          |  2 +-
hw/arm/msf2-som.c          |  2 +-
hw/arm/musca.c             |  4 ++--
hw/arm/netduino2.c         |  2 +-
hw/arm/netduinoplus2.c     |  2 +-
hw/arm/nrf51_soc.c         |  2 +-
hw/arm/olimex-stm32-h405.c |  2 +-
hw/arm/stellaris.c         |  2 +-
hw/arm/stm32f100_soc.c     |  2 +-
hw/arm/stm32f205_soc.c     |  2 +-
hw/arm/stm32f405_soc.c     |  2 +-
hw/arm/stm32vldiscovery.c  |  2 +-
hw/arm/xilinx_zynq.c       |  2 +-
hw/char/cadence_uart.c     |  4 ++--
hw/core/clock.c            | 19 +++++++++++++++----
hw/misc/bcm2835_cprman.c   |  2 +-
hw/misc/stm32l4x5_rcc.c    |  9 +++++++--
hw/misc/zynq_slcr.c        | 39 +++++++++++++++++++++++++-------------
25 files changed, 89 insertions(+), 53 deletions(-)

Expand all Fold all

[PATCH-for-9.0? v2 0/8] hw/clock: Propagate clock changes when STM32L4X5 MUX is updated

Posted by Philippe Mathieu-Daudé 1 month, 1 week ago

Since v1:
- Rework API to only propagate when both clock_set
  and clock_set_mul_div modified the clock params
  (Peter & Luc).
- Use that in zynq_slcr.

Per https://www.qemu.org/docs/master/devel/clocks.html#clock-multiplier-and-divider-settings:

  Note that clock_set_mul_div() does not automatically call
  clock_propagate(). If you make a runtime change to the
  multiplier or divider you must call clock_propagate() yourself.

Fix what we forgot to do that in recent commit ec7d83acbd
("hw/misc/stm32l4x5_rcc: Add an internal clock multiplexer object")

Arnaud Minier (1):
  hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock

Philippe Mathieu-Daudé (7):
  hw/clock: Have clock_set_mul_div() return early when nothing to change
  hw/clock: Pass optional &bool argument to clock_set()
  hw/clock: Pass optional &bool argument to clock_set_ns()
  hw/clock: Pass optional &bool argument to clock_set_hz()
  hw/clock: Pass optional &bool argument to clock_set_mul_div()
  hw/misc/stm32l4x5_rcc: Inline clock_update() in clock_mux_update()
  hw/misc/zynq_slcr: Only propagate clock changes when necessary

 docs/devel/clocks.rst      |  6 +++++-
 include/hw/clock.h         | 21 +++++++++++---------
 hw/arm/aspeed.c            |  2 +-
 hw/arm/fby35.c             |  2 +-
 hw/arm/mps2-tz.c           |  4 ++--
 hw/arm/mps2.c              |  4 ++--
 hw/arm/mps3r.c             |  2 +-
 hw/arm/msf2-soc.c          |  2 +-
 hw/arm/msf2-som.c          |  2 +-
 hw/arm/musca.c             |  4 ++--
 hw/arm/netduino2.c         |  2 +-
 hw/arm/netduinoplus2.c     |  2 +-
 hw/arm/nrf51_soc.c         |  2 +-
 hw/arm/olimex-stm32-h405.c |  2 +-
 hw/arm/stellaris.c         |  2 +-
 hw/arm/stm32f100_soc.c     |  2 +-
 hw/arm/stm32f205_soc.c     |  2 +-
 hw/arm/stm32f405_soc.c     |  2 +-
 hw/arm/stm32vldiscovery.c  |  2 +-
 hw/arm/xilinx_zynq.c       |  2 +-
 hw/char/cadence_uart.c     |  4 ++--
 hw/core/clock.c            | 19 +++++++++++++++----
 hw/misc/bcm2835_cprman.c   |  2 +-
 hw/misc/stm32l4x5_rcc.c    |  9 +++++++--
 hw/misc/zynq_slcr.c        | 39 +++++++++++++++++++++++++-------------
 25 files changed, 89 insertions(+), 53 deletions(-)

-- 
2.41.0