From nobody Tue May 14 15:46:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1711124173; cv=none; d=zohomail.com; s=zohoarc; b=dgXAN+w3rpQNYqEMMPf4HlXxKFE2jBa2PxafvVx4ZmgPZIZp6zee3yrlqgcbndiKe0BfAe0QpXgSMkrtO9ZytCVFToYRY8gIaXAXKUqS0bprjazXTdgsMnoMvLaZggeaLKqOAYPiilXFnCHBoGW2RXrQc5yd3JFNEKiQNH0CuaA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1711124173; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=M3jectw/kExol21Tl/VOhcbnait7BaHf+x9145daJsc=; b=DnRGXPW2B2iHPb/G1C5iQnNpBhm6rMAg8RuL0pvWQGS5gwOyrFK1N373H7mqzJqt4LI6CbPtjBnY05dS/fehSYmSONuGMkrgQo0cnpeQdHEuTy6mbf8CSxd1v+frRD6k/xvRVirNae7RxbwhTvUeHXwAgazYRbIOgCRFIVYzC10= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1711124173414374.83982806388804; Fri, 22 Mar 2024 09:16:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rnhXh-0000fX-TS; Fri, 22 Mar 2024 12:14:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnhXg-0000f9-Ak for qemu-devel@nongnu.org; Fri, 22 Mar 2024 12:14:52 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rnhXe-0000oT-U8 for qemu-devel@nongnu.org; Fri, 22 Mar 2024 12:14:52 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4147f659353so648445e9.3 for ; Fri, 22 Mar 2024 09:14:50 -0700 (PDT) Received: from m1x-phil.lan ([176.176.178.251]) by smtp.gmail.com with ESMTPSA id j8-20020a05600c1c0800b004146bcdde06sm3530094wms.6.2024.03.22.09.14.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 22 Mar 2024 09:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711124089; x=1711728889; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M3jectw/kExol21Tl/VOhcbnait7BaHf+x9145daJsc=; b=pABTf919d9+eW0pdvw9yCl9wg1eJD/xtdWDH+WhEf7Gz+ykAH68Pj3pWqmwzSG5NUY p1OzkP42tXwKipPZivi/P/rmbuEeRhRKr4x6lTWlNnT93ZiVhM+u/ZANW5OW8cQQTLwl sMvobVBQ925x6aq28lpYgC4Evas+kqMLTPSROxQ37qHNARFU1BpOE8bfAkFtFSM8Ee92 DVHgnxde+RA+xQouxccekHde+aqbKqv5+XQmvf/9/SvEaGKommVBNSaZw6dEzxAMjYE4 G/oZYi6XtJPOBEynIkD/I6YCMNXmU5Fb1024MvtICTQ476MbTQzXFpSYLGNE1oplZ/O1 5UVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711124089; x=1711728889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M3jectw/kExol21Tl/VOhcbnait7BaHf+x9145daJsc=; b=tWujU4YU5ilvsZ2KDmgRhWpVQTPNpkF4ngewID/N1DECxhOC6dPrpKNWZmkfuf9Q4S fBahfh1Q6D/X9EMsQSbBovc3A0kcZ0+XeBKDzPP/9nQTC1R4xjgSm/KP84o157/b7vxe aEiLsdpqs277f6dhRrIBx6GjPdriRPcQkbcVTF6iJD1FG3/iyWDBFZKrNgcx7DouZV3a l2DoL7X8hHgliR+4PI+H27yXJMRMWIkS/TOhdOMxjf/qUv/+APJAcFSBXF+z2aRJFeBK eedYNGnU9yarijDVPK6se5jbYKYxRP6K9KzumceWm+QAcmP4uMoiDU/5qS5Q5uHduK9s yOhw== X-Gm-Message-State: AOJu0YzSeU7ikIKPrKLKV2W8wohsBSbFbnqlrhATywdy8LPsyQ5Bm6Wm Uizl0nJlGinI/QFqNKHnWx3ePoze38puHK3GvC+72KV+Qg/1nmh7zCWmp0I/YuKgRCNnWqWV5+3 9 X-Google-Smtp-Source: AGHT+IHnzpEOVwPDsBW32NjuihDhDnLtCe0iw73ewhehZA9lITU/6L8eY957zXmL0DGUCSwgDESxUw== X-Received: by 2002:a05:600c:5617:b0:413:315f:9e8d with SMTP id jr23-20020a05600c561700b00413315f9e8dmr1991336wmb.18.1711124089140; Fri, 22 Mar 2024 09:14:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Anton Johansson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Peter Maydell Subject: [PATCH-for-9.1 v2 1/3] gdbstub: Simplify #ifdef'ry in helpers.h Date: Fri, 22 Mar 2024 17:14:37 +0100 Message-ID: <20240322161439.6448-2-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240322161439.6448-1-philmd@linaro.org> References: <20240322161439.6448-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1711124174659100007 Slightly simplify by checking NEED_CPU_H definition in header. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/gdbstub/helpers.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h index c573aef2dc..53e88d807c 100644 --- a/include/gdbstub/helpers.h +++ b/include/gdbstub/helpers.h @@ -12,7 +12,10 @@ #ifndef _GDBSTUB_HELPERS_H_ #define _GDBSTUB_HELPERS_H_ =20 -#ifdef NEED_CPU_H +#ifndef NEED_CPU_H +#error "gdbstub helpers should only be included by target specific code" +#endif + #include "cpu.h" =20 /* @@ -96,8 +99,4 @@ static inline uint8_t *gdb_get_reg_ptr(GByteArray *buf, i= nt len) #define ldtul_p(addr) ldl_p(addr) #endif =20 -#else -#error "gdbstub helpers should only be included by target specific code" -#endif - #endif /* _GDBSTUB_HELPERS_H_ */ --=20 2.41.0 From nobody Tue May 14 15:46:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1711124185; cv=none; d=zohomail.com; s=zohoarc; b=iLdexLcRT9urt222K9IzbnwmvmXqH8V6KwVq8apM6u5aMuUly8B05iMYRmOTZz8eA2Nu3+lxKmj5UdK4FNtsXxJITzP+Vax/wRIlsWH825rcUqK7dG3xzwe+EnhLPG46LKG+XKQ74u5xdo15WfprLsIrn0EUAqcxbEIFPLq2TsM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1711124185; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nWERvWbaYA8U7fTdf/uiT9QJ6qMAGAYtIIOsHDWn7CE=; b=RxEmHh1QGGoIYPWRNWliabpvjT5lWPMlHXU9VnZ3gPL8vUA3Ahy55O4XPKgs8hxvhf/a4NMXxPxwTHNWzqiPJwvLptmzU0aC9QoIanAQ6mQoCdr0yqZnaNwr3VqCx8DI8eZHf0DGV+Sv/Qd1QAQbussUXwjRHMhZCfA70PtHdyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1711124185428382.7473650886835; Fri, 22 Mar 2024 09:16:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rnhY8-0000zF-DT; Fri, 22 Mar 2024 12:15:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnhXy-0000tM-UM for qemu-devel@nongnu.org; Fri, 22 Mar 2024 12:15:14 -0400 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rnhXr-0000p3-52 for qemu-devel@nongnu.org; Fri, 22 Mar 2024 12:15:08 -0400 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2d4886a1cb4so31544701fa.0 for ; Fri, 22 Mar 2024 09:14:57 -0700 (PDT) Received: from m1x-phil.lan ([176.176.178.251]) by smtp.gmail.com with ESMTPSA id he11-20020a05600c540b00b004147cfe50e2sm1824710wmb.2.2024.03.22.09.14.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 22 Mar 2024 09:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711124095; x=1711728895; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nWERvWbaYA8U7fTdf/uiT9QJ6qMAGAYtIIOsHDWn7CE=; b=qR+dr51WAAf3QVHR9pEZEy0YpdMSuSJrCgtAkckqiQyWkWM0r0rzcb0cKx4h+Bc+xC 4rY2Bp9E3Fo9P3uPy1Otkvzy9f12C0yW11NsCWsAeeI7KjzWMBxkrBxN6mE5bAxFr2nO moFWmfWBlE+0ztkLYVZIHn2524MmJZc5KPbqnKVSoCnACeERHi7VBt8aPTS0/dK39/4R lVePo5s0VVW2iNVxfZGKvLhIUmJw5C836EvhC9EmXG3a1/SdgLX2FbyDwqKgHJKNaTjk KhaCTT0rnKy8ed8V2sxzf2GXLyDe0fo7awWD6ZWiAXKpOy43hROFw0LqMZFU7pRamjP9 Ozog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711124095; x=1711728895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nWERvWbaYA8U7fTdf/uiT9QJ6qMAGAYtIIOsHDWn7CE=; b=iR+369vZIo9eOUw2pKbcQHmz8cmSSe+kywngBX9EnSUW7pR0Av2DjDVgzxhXYafLLw l8bpMVgcqZuGBe4ZHu0tKwk5PAae/1CvBRJwzgX6mYBova5uXmZdxJnS5tDRSZlEmg// 6oLK+qGt2EZStMyphxN9/2qfqN6lBrl/ShwsRPPKqLLUA5Co1pB8X1fTt0Fk3q/L+Gcr oAKCiOksJ3H3DQAIYbWofCnbsT1uuTld4+4KGLxnpEV30MlHvS+yEPhNehapvKJhQLO9 THEXfLtqiEcSqrdro1P4Emds4sglaaxaEPFGdMra3hqP6W9Ure+bFI78NDje70JZ9QrF lYGw== X-Gm-Message-State: AOJu0YwaFTpNKNkCVE6hcYUCDui2D7I6jPs9NXKZUwkv9pKD8OmMKutr 60kr7Y3ZSdkq7XjdnaeMvdzi2raZWQR5Mtypw/e3UcpsNBqDeyav6Om1pysas0csXPxqsVhHVof 6 X-Google-Smtp-Source: AGHT+IGFKaVbKf31VATWjTGdq0ZObqLxjTDJ8xODl4fNGzZ922tI8v36pANqcGwSv9NcRuux+xfNmw== X-Received: by 2002:a2e:97c7:0:b0:2d4:25df:b8eb with SMTP id m7-20020a2e97c7000000b002d425dfb8ebmr2410707ljj.41.1711124095391; Fri, 22 Mar 2024 09:14:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Anton Johansson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Peter Maydell Subject: [PATCH-for-9.1 v2 2/3] hw/core: Remove check on NEED_CPU_H in tcg-cpu-ops.h Date: Fri, 22 Mar 2024 17:14:38 +0100 Message-ID: <20240322161439.6448-3-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240322161439.6448-1-philmd@linaro.org> References: <20240322161439.6448-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::22f; envelope-from=philmd@linaro.org; helo=mail-lj1-x22f.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1711124186583100007 Commit fd3f7d24d4 ("include/hw/core: Remove i386 conditional on fake_user_interrupt") remove the need to check on NEED_CPU_H. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/hw/core/tcg-cpu-ops.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h index bf8ff8e3ee..dc1f16a977 100644 --- a/include/hw/core/tcg-cpu-ops.h +++ b/include/hw/core/tcg-cpu-ops.h @@ -49,7 +49,6 @@ struct TCGCPUOps { /** @debug_excp_handler: Callback for handling debug exceptions */ void (*debug_excp_handler)(CPUState *cpu); =20 -#ifdef NEED_CPU_H #ifdef CONFIG_USER_ONLY /** * @fake_user_interrupt: Callback for 'fake exception' handling. @@ -174,8 +173,6 @@ struct TCGCPUOps { */ bool (*need_replay_interrupt)(int interrupt_request); #endif /* !CONFIG_USER_ONLY */ -#endif /* NEED_CPU_H */ - }; =20 #if defined(CONFIG_USER_ONLY) --=20 2.41.0 From nobody Tue May 14 15:46:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1711124128; cv=none; d=zohomail.com; s=zohoarc; b=KFCyFdf7kxkzo8Gthh4s2JQrDykHRuaE/tZK7QEcqgzj8h2NWh9KrM/tinBTOofdQdeDFUS2Zlr+mQf2ia6z1ywMven0HCF0er/7UJATYdLh3Nu2/WMti3l2k80LoM3PB8XOAwpM+nPk/u94bjQ2usLvBR6WuVn+/PNbtDiqz8w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1711124128; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s1qPut0NhGBzfRg42Qh5UyiazOmzOKukv5I7c5rLwvg=; b=e64vCq70BAKSpeIH1f1x+48gpVLBWdk7lwgnbjbH6VKVxpDoKsHbRBFpsLM3ASLTyYXD/hCg9HARslFScCwFtOIV7XCGmdOHK+LgvCTYpw4VplMOD2hbFtoEmfvpJjDPDTiMF/K55AHo/Vu/b9CgootDS+GgKCuTVhVzAhcFGvg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1711124128852600.1746624665886; Fri, 22 Mar 2024 09:15:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.696997.1088301 (Exim 4.92) (envelope-from ) id 1rnhXv-0000CC-T7; Fri, 22 Mar 2024 16:15:07 +0000 Received: by outflank-mailman (output) from mailman id 696997.1088301; Fri, 22 Mar 2024 16:15:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rnhXv-0000C5-QI; Fri, 22 Mar 2024 16:15:07 +0000 Received: by outflank-mailman (input) for mailman id 696997; Fri, 22 Mar 2024 16:15:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rnhXt-0000BC-VF for xen-devel@lists.xenproject.org; Fri, 22 Mar 2024 16:15:06 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 574b3679-e867-11ee-a1ee-f123f15fe8a2; Fri, 22 Mar 2024 17:15:04 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3416a975840so1408112f8f.0 for ; Fri, 22 Mar 2024 09:15:04 -0700 (PDT) Received: from m1x-phil.lan ([176.176.178.251]) by smtp.gmail.com with ESMTPSA id b7-20020a056000054700b0033e7b05edf3sm2383822wrf.44.2024.03.22.09.15.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 22 Mar 2024 09:15:03 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 574b3679-e867-11ee-a1ee-f123f15fe8a2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711124103; x=1711728903; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s1qPut0NhGBzfRg42Qh5UyiazOmzOKukv5I7c5rLwvg=; b=cXoV4nw8TbI/81kie5ql3vsPMtH6m+2wX1UAqjkhuBTG4PMT0aNUKULt3utT4igec7 IqNxX3FWMzYVDOhbEcuQmk1SE8pRBIce5By9XBBsGRQIR6fEcGDSvMeLZDwSE+UTS145 bUE5K4t1z3dMq6JfiZ9mwtSP1CZ8053qrtoQZ5P2v6fMueVshWjiI0kbQ+y4PpkoLbln Va+GSmCdSVSUNLJ9cmhLCM9JjpxM1jDX//sqXZrWbrojMg1jg80xhx1vV0feSYQSHP4t DE+V2RxlZBp6JLXybXs0x3TBw3EMT6KOd/njHTANrpumaQMwBf+4ZykhYB1J6bQHdau+ SfKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711124103; x=1711728903; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s1qPut0NhGBzfRg42Qh5UyiazOmzOKukv5I7c5rLwvg=; b=UOHwChUEjhn3ShqkYhAgh7ok6nNk8tvkV2XFLzLrHefz6q0AHsiSzyo/XUrs9vUenA f++mzuSxC4lBkw9GB/AFsHOmj8Ib4GHX/9gVzISC3cTAs9fH9RQOGo+wfLGQvPG1yaWn LmLXEJQ8xAEFMGZBdNJ9PQKtiWRyI6RqUCNl+NB7Rt7XKRD2rB+gTKpNdpocORLUfVZX swdPKDyU4EhMUoc0Vp1QlT6UIwMZVhNU9oJyE8+xe6JLHdPh6yuuBmdHacdC+aecf3SZ 0HwyuZjepRS62PAw1dLa5PZhLQNdjUFfjsk5pO8GEjXIBRo5xvuWEzK8GRlaDLZVjkBG IR7g== X-Forwarded-Encrypted: i=1; AJvYcCVKvT2uhNXMJr7ywFgEg933UpVGzwQ8FmpddXIg+1iUQfZvzm10FKEeBZrlS1swR+r2dbZdmrEbYPe62G0QVjq/ShadAXsoxIR8NfkLkuA= X-Gm-Message-State: AOJu0Yw/a5SvuIzFmm5nTaBG4u2T1n6thxd/mH6aGlLgfewBd79Q/gi8 J7+h1afdi3l4UL+YPgCZHpNACO/dgBRUB88J1hWunGhK04AqVW96AatISstjrAM= X-Google-Smtp-Source: AGHT+IHlt+ox/CID64UUSwzrMDTeHUJbOcdvrgQZGJkSECtfnfLaNH6boam/8ucRh2a5UcSqVNTFgQ== X-Received: by 2002:a05:6000:51:b0:33e:a1e3:87b3 with SMTP id k17-20020a056000005100b0033ea1e387b3mr1779324wrx.41.1711124103530; Fri, 22 Mar 2024 09:15:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Anton Johansson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Peter Maydell , Peter Xu , David Hildenbrand , Eduardo Habkost , Marcel Apfelbaum , Yanan Wang , Cameron Esfahani , Roman Bolshakov , Reinoud Zandijk , Sunil Muthuswamy , Stefano Stabellini , Anthony Perard , Paul Durrant , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , kvm@vger.kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH-for-9.1 v2 3/3] exec: Rename NEED_CPU_H -> COMPILING_PER_TARGET Date: Fri, 22 Mar 2024 17:14:39 +0100 Message-ID: <20240322161439.6448-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240322161439.6448-1-philmd@linaro.org> References: <20240322161439.6448-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1711124130511100001 'NEED_CPU_H' guard target-specific code; it is defined by meson altogether with the 'CONFIG_TARGET' definition. Rename NEED_CPU_H as COMPILING_PER_TARGET to clarify its meaning. Mechanical change running: $ sed -i s/NEED_CPU_H/COMPILING_PER_TARGET/g $(git grep -l NEED_CPU_H) then manually add a /* COMPILING_PER_TARGET */ comment after the '#endif' when the block is large. Inspired-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- meson.build | 4 ++-- include/exec/cpu-defs.h | 2 +- include/exec/helper-head.h | 4 ++-- include/exec/memop.h | 4 ++-- include/exec/memory.h | 4 ++-- include/exec/tswap.h | 4 ++-- include/gdbstub/helpers.h | 2 +- include/hw/core/cpu.h | 4 ++-- include/qemu/osdep.h | 2 +- include/sysemu/hvf.h | 8 ++++---- include/sysemu/kvm.h | 6 +++--- include/sysemu/nvmm.h | 4 ++-- include/sysemu/whpx.h | 4 ++-- include/sysemu/xen.h | 4 ++-- target/arm/kvm-consts.h | 4 ++-- scripts/analyze-inclusions | 6 +++--- 16 files changed, 33 insertions(+), 33 deletions(-) diff --git a/meson.build b/meson.build index b375248a76..f13ad52f5f 100644 --- a/meson.build +++ b/meson.build @@ -3637,7 +3637,7 @@ foreach d, list : target_modules if target.endswith('-softmmu') config_target =3D config_target_mak[target] target_inc =3D [include_directories('target' / config_target['TA= RGET_BASE_ARCH'])] - c_args =3D ['-DNEED_CPU_H', + c_args =3D ['-DCOMPILING_PER_TARGET', '-DCONFIG_TARGET=3D"@0@-config-target.h"'.format(targe= t), '-DCONFIG_DEVICES=3D"@0@-config-devices.h"'.format(tar= get)] target_module_ss =3D module_ss.apply(config_target, strict: fals= e) @@ -3820,7 +3820,7 @@ foreach target : target_dirs target_base_arch =3D config_target['TARGET_BASE_ARCH'] arch_srcs =3D [config_target_h[target]] arch_deps =3D [] - c_args =3D ['-DNEED_CPU_H', + c_args =3D ['-DCOMPILING_PER_TARGET', '-DCONFIG_TARGET=3D"@0@-config-target.h"'.format(target), '-DCONFIG_DEVICES=3D"@0@-config-devices.h"'.format(target)] link_args =3D emulator_link_args diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h index 3915438b83..0dbef3010c 100644 --- a/include/exec/cpu-defs.h +++ b/include/exec/cpu-defs.h @@ -19,7 +19,7 @@ #ifndef CPU_DEFS_H #define CPU_DEFS_H =20 -#ifndef NEED_CPU_H +#ifndef COMPILING_PER_TARGET #error cpu.h included from common code #endif =20 diff --git a/include/exec/helper-head.h b/include/exec/helper-head.h index 28ceab0a46..5ef467a79d 100644 --- a/include/exec/helper-head.h +++ b/include/exec/helper-head.h @@ -43,7 +43,7 @@ #define dh_ctype_noreturn G_NORETURN void #define dh_ctype(t) dh_ctype_##t =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET # ifdef TARGET_LONG_BITS # if TARGET_LONG_BITS =3D=3D 32 # define dh_alias_tl i32 @@ -54,7 +54,7 @@ # endif # endif # define dh_ctype_tl target_ulong -#endif +#endif /* COMPILING_PER_TARGET */ =20 /* We can't use glue() here because it falls foul of C preprocessor recursive expansion rules. */ diff --git a/include/exec/memop.h b/include/exec/memop.h index a86dc6743a..06417ff361 100644 --- a/include/exec/memop.h +++ b/include/exec/memop.h @@ -35,7 +35,7 @@ typedef enum MemOp { MO_LE =3D 0, MO_BE =3D MO_BSWAP, #endif -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET #if TARGET_BIG_ENDIAN MO_TE =3D MO_BE, #else @@ -135,7 +135,7 @@ typedef enum MemOp { MO_BESL =3D MO_BE | MO_SL, MO_BESQ =3D MO_BE | MO_SQ, =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET MO_TEUW =3D MO_TE | MO_UW, MO_TEUL =3D MO_TE | MO_UL, MO_TEUQ =3D MO_TE | MO_UQ, diff --git a/include/exec/memory.h b/include/exec/memory.h index 8626a355b3..bb51e90fe1 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -3087,7 +3087,7 @@ address_space_write_cached(MemoryRegionCache *cache, = hwaddr addr, MemTxResult address_space_set(AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs); =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET /* enum device_endian to MemOp. */ static inline MemOp devend_memop(enum device_endian end) { @@ -3105,7 +3105,7 @@ static inline MemOp devend_memop(enum device_endian e= nd) return (end =3D=3D non_host_endianness) ? MO_BSWAP : 0; #endif } -#endif +#endif /* COMPILING_PER_TARGET */ =20 /* * Inhibit technologies that require discarding of pages in RAM blocks, e.= g., diff --git a/include/exec/tswap.h b/include/exec/tswap.h index 68944a880b..5089cd6a4c 100644 --- a/include/exec/tswap.h +++ b/include/exec/tswap.h @@ -15,11 +15,11 @@ * If we're in target-specific code, we can hard-code the swapping * condition, otherwise we have to do (slower) run-time checks. */ -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET #define target_needs_bswap() (HOST_BIG_ENDIAN !=3D TARGET_BIG_ENDIAN) #else #define target_needs_bswap() (target_words_bigendian() !=3D HOST_BIG_ENDI= AN) -#endif +#endif /* COMPILING_PER_TARGET */ =20 static inline uint16_t tswap16(uint16_t s) { diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h index 53e88d807c..6277a858a1 100644 --- a/include/gdbstub/helpers.h +++ b/include/gdbstub/helpers.h @@ -12,7 +12,7 @@ #ifndef _GDBSTUB_HELPERS_H_ #define _GDBSTUB_HELPERS_H_ =20 -#ifndef NEED_CPU_H +#ifndef COMPILING_PER_TARGET #error "gdbstub helpers should only be included by target specific code" #endif =20 diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index ec14f74ce5..7f037b158e 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1182,7 +1182,7 @@ bool target_words_bigendian(void); =20 const char *target_name(void); =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET =20 #ifndef CONFIG_USER_ONLY =20 @@ -1197,7 +1197,7 @@ extern const VMStateDescription vmstate_cpu_common; } #endif /* !CONFIG_USER_ONLY */ =20 -#endif /* NEED_CPU_H */ +#endif /* COMPILING_PER_TARGET */ =20 #define UNASSIGNED_CPU_INDEX -1 #define UNASSIGNED_CLUSTER_INDEX -1 diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index c7053cdc2b..f61edcfdc2 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -32,7 +32,7 @@ #endif =20 #include "config-host.h" -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET #include CONFIG_TARGET #else #include "exec/poison.h" diff --git a/include/sysemu/hvf.h b/include/sysemu/hvf.h index 4a7c6af3a5..730f927f03 100644 --- a/include/sysemu/hvf.h +++ b/include/sysemu/hvf.h @@ -16,7 +16,7 @@ #include "qemu/accel.h" #include "qom/object.h" =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET #include "cpu.h" =20 #ifdef CONFIG_HVF @@ -26,7 +26,7 @@ extern bool hvf_allowed; #define hvf_enabled() 0 #endif /* !CONFIG_HVF */ =20 -#endif /* NEED_CPU_H */ +#endif /* COMPILING_PER_TARGET */ =20 #define TYPE_HVF_ACCEL ACCEL_CLASS_NAME("hvf") =20 @@ -34,7 +34,7 @@ typedef struct HVFState HVFState; DECLARE_INSTANCE_CHECKER(HVFState, HVF_STATE, TYPE_HVF_ACCEL) =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET struct hvf_sw_breakpoint { vaddr pc; vaddr saved_insn; @@ -66,6 +66,6 @@ void hvf_arch_update_guest_debug(CPUState *cpu); * Return whether the guest supports debugging. */ bool hvf_arch_supports_guest_debug(void); -#endif /* NEED_CPU_H */ +#endif /* COMPILING_PER_TARGET */ =20 #endif diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index fad9a7e8ff..c618a59ba6 100644 --- a/include/sysemu/kvm.h +++ b/include/sysemu/kvm.h @@ -20,7 +20,7 @@ #include "qemu/accel.h" #include "qom/object.h" =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET # ifdef CONFIG_KVM # include # define CONFIG_KVM_IS_POSSIBLE @@ -210,7 +210,7 @@ bool kvm_arm_supports_user_irq(void); int kvm_on_sigbus_vcpu(CPUState *cpu, int code, void *addr); int kvm_on_sigbus(int code, void *addr); =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET #include "cpu.h" =20 void kvm_flush_coalesced_mmio_buffer(void); @@ -435,7 +435,7 @@ void kvm_set_sigmask_len(KVMState *s, unsigned int sigm= ask_len); int kvm_physical_memory_addr_from_host(KVMState *s, void *ram_addr, hwaddr *phys_addr); =20 -#endif /* NEED_CPU_H */ +#endif /* COMPILING_PER_TARGET */ =20 void kvm_cpu_synchronize_state(CPUState *cpu); =20 diff --git a/include/sysemu/nvmm.h b/include/sysemu/nvmm.h index be7bc9a62d..6971ddb3a5 100644 --- a/include/sysemu/nvmm.h +++ b/include/sysemu/nvmm.h @@ -12,7 +12,7 @@ #ifndef QEMU_NVMM_H #define QEMU_NVMM_H =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET =20 #ifdef CONFIG_NVMM =20 @@ -24,6 +24,6 @@ int nvmm_enabled(void); =20 #endif /* CONFIG_NVMM */ =20 -#endif /* NEED_CPU_H */ +#endif /* COMPILING_PER_TARGET */ =20 #endif /* QEMU_NVMM_H */ diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h index 781ca5b2b6..00ff409b68 100644 --- a/include/sysemu/whpx.h +++ b/include/sysemu/whpx.h @@ -15,7 +15,7 @@ #ifndef QEMU_WHPX_H #define QEMU_WHPX_H =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET =20 #ifdef CONFIG_WHPX =20 @@ -29,6 +29,6 @@ bool whpx_apic_in_platform(void); =20 #endif /* CONFIG_WHPX */ =20 -#endif /* NEED_CPU_H */ +#endif /* COMPILING_PER_TARGET */ =20 #endif /* QEMU_WHPX_H */ diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h index a9f591f26d..754ec2e6cb 100644 --- a/include/sysemu/xen.h +++ b/include/sysemu/xen.h @@ -16,13 +16,13 @@ =20 #include "exec/cpu-common.h" =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET # ifdef CONFIG_XEN # define CONFIG_XEN_IS_POSSIBLE # endif #else # define CONFIG_XEN_IS_POSSIBLE -#endif +#endif /* COMPILING_PER_TARGET */ =20 #ifdef CONFIG_XEN_IS_POSSIBLE =20 diff --git a/target/arm/kvm-consts.h b/target/arm/kvm-consts.h index 7c6adc14f6..c44d23dbe7 100644 --- a/target/arm/kvm-consts.h +++ b/target/arm/kvm-consts.h @@ -14,13 +14,13 @@ #ifndef ARM_KVM_CONSTS_H #define ARM_KVM_CONSTS_H =20 -#ifdef NEED_CPU_H +#ifdef COMPILING_PER_TARGET #ifdef CONFIG_KVM #include #include #define MISMATCH_CHECK(X, Y) QEMU_BUILD_BUG_ON(X !=3D Y) #endif -#endif +#endif /* COMPILING_PER_TARGET */ =20 #ifndef MISMATCH_CHECK #define MISMATCH_CHECK(X, Y) QEMU_BUILD_BUG_ON(0) diff --git a/scripts/analyze-inclusions b/scripts/analyze-inclusions index 45c821de32..b6280f25c8 100644 --- a/scripts/analyze-inclusions +++ b/scripts/analyze-inclusions @@ -92,7 +92,7 @@ echo trace/generated-tracers.h: analyze -include ../include/qemu/osdep.h trace/generated-tracers.h =20 echo target/i386/cpu.h: -analyze -DNEED_CPU_H -I../target/i386 -Ii386-softmmu -include ../include/q= emu/osdep.h ../target/i386/cpu.h +analyze -DCOMPILING_PER_TARGET -I../target/i386 -Ii386-softmmu -include ..= /include/qemu/osdep.h ../target/i386/cpu.h =20 -echo hw/hw.h + NEED_CPU_H: -analyze -DNEED_CPU_H -I../target/i386 -Ii386-softmmu -include ../include/q= emu/osdep.h ../include/hw/hw.h +echo hw/hw.h + COMPILING_PER_TARGET: +analyze -DCOMPILING_PER_TARGET -I../target/i386 -Ii386-softmmu -include ..= /include/qemu/osdep.h ../include/hw/hw.h --=20 2.41.0