From nobody Fri May 10 04:53:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710355897; cv=none; d=zohomail.com; s=zohoarc; b=O2OxxXs6UWv+uOCTyus3y3eR0eGmuSF1GEbUtIiGHU3rYHh46l0XqyyKjniBggYUUS8+LJ1EDen51gQ3NxHRc4NRwp9/vVwHuxUua9X50uzbX8WaSorRbdZqx8hDqXI/2uH3crB1zA/i8V+nMUX161mi/lv6ZxAsHXqqInfqxr4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710355897; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cA2TT9vWbQLNZEplCJtFv+ktuA7SvmljLFLbMp9Tj4w=; b=as7KrIH3wxw+Za+8jMQ3eiCWd/mmpUDFNZtgH89Jat11SM/D7gOPFket4YqJz+6f6kykOk4PY5MM6QKzbA8BEdyLcNUPSDdZtspGBmQngLQKHFIedaTu/WwJlabghjE9Hhu0D2fbyyP+gtg+xre7261Drt6Y+l6q1ydRjp+o+gg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171035589758131.788946803677277; Wed, 13 Mar 2024 11:51:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkTgL-0001aR-JU; Wed, 13 Mar 2024 14:50:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkTgB-0001ZQ-0a for qemu-devel@nongnu.org; Wed, 13 Mar 2024 14:50:19 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkTg5-00048E-W3 for qemu-devel@nongnu.org; Wed, 13 Mar 2024 14:50:15 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-5131316693cso261196e87.0 for ; Wed, 13 Mar 2024 11:50:13 -0700 (PDT) Received: from m1x-phil.lan ([176.176.182.179]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b004130378fb77sm3129692wmq.6.2024.03.13.11.50.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 13 Mar 2024 11:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710355812; x=1710960612; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cA2TT9vWbQLNZEplCJtFv+ktuA7SvmljLFLbMp9Tj4w=; b=D9XA2JeYuliooNtIgl5agwclxJ73pP6GWAj7N62L51Y83gjC+XJuMl9aaTG/zH9dpA 2mJqkh+EybJEjtF3/ZGYuOs75lSjMDuRMZAUqnKnd4+BvtkstOOm/fUQP5X6C4BEfylc 6iSFn1fmTayyFiiP3GEluxtxSkssp1W70gV9Fijvqdu++3BxTKTJ77giMSJrFwmBHwf+ fIQomMs+kifyc4hyRVBGCM++NtSL9D2wt+nsCkQds2/nttIuRPfIdUoObD1vJPdqvkOo KYF4JdcBhohz0Yx/ZszIqOnJ3PbtMfjBPlr2fpa0YrE1YBpa0+mDz2wnB1AMkxYKi9zq 2L2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710355812; x=1710960612; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cA2TT9vWbQLNZEplCJtFv+ktuA7SvmljLFLbMp9Tj4w=; b=uebUbYQuIfi1nIhxu3LzF23Gi5ubL1hTs5Hk0DgjAhGXOGECIeyjP5fGGejSu9rzfu FKxcFCuM+/lPmRFwQPD8EYkJxBQeHJOJBxf/Pd61Plc1qam0U+F6uMalCPsQ1z79ZyBz S5/LSuJoU8TDyp2fT653dUxILLQ2cP8aA8FjJsZgwspZUQ++N6cmJZmO8Dh/pxD0zgv6 Qs5EI7yiSCCA24NH7qZx9kMBV3IONx3PkvRM8twbXdPtGEmckNIojJbSA9rTnG4avHr3 4RatvkqDLbC4RdwhWRJKssrJyE9vwtp+jlxZKo2Mp318LTrfLKC4c5m/MpmrVYE58P51 M6Pg== X-Gm-Message-State: AOJu0YzpP7CN4CZfayh8iDUsoaOysPE3NV2k79e8bqVfeWibVOQDLtv6 2uBEp9PJ44BEXMKF5XGbMNIdKzDuWwAs83Pjf2ov/q00WJNktbYZDaV/BCbxKJQAQlQ6qIyiu25 r X-Google-Smtp-Source: AGHT+IErD8+wsDFyofiAR17/n/Vx51vdGnap+p5x0vXw6nHzFuP2CiGJWNaob7zogYFn+3muVuph5A== X-Received: by 2002:a05:6512:3b12:b0:513:2329:4308 with SMTP id f18-20020a0565123b1200b0051323294308mr6796012lfv.14.1710355811959; Wed, 13 Mar 2024 11:50:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , John Snow , Alexander Graf , Eric Auger , qemu-block@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Cameron Esfahani , Roman Bolshakov , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0 1/4] hw/arm/smmu: Avoid using inlined functions with external linkage again Date: Wed, 13 Mar 2024 19:49:51 +0100 Message-ID: <20240313184954.42513-2-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240313184954.42513-1-philmd@linaro.org> References: <20240313184954.42513-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=philmd@linaro.org; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710355899197100002 Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using inlined functions with external linkage"): None of our code base require / use inlined functions with external linkage. Some places use internal inlining in the hot path. These two functions are certainly not in any hot path and don't justify any inlining, so these are likely oversights rather than intentional. Fix: C compiler for the host machine: clang (clang 15.0.0 "Apple clang version= 15.0.0 (clang-1500.3.9.4)") ... hw/arm/smmu-common.c:203:43: error: static function 'smmu_hash_remove_by_= vmid' is used in an inline function with external linkage [-Werror,-Wstatic-in-inl= ine] g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid, &vmid= ); ^ include/hw/arm/smmu-common.h:197:1: note: use 'static' to give inline fun= ction 'smmu_iotlb_inv_vmid' internal linkage void smmu_iotlb_inv_vmid(SMMUState *s, uint16_t vmid); ^ static hw/arm/smmu-common.c:139:17: note: 'smmu_hash_remove_by_vmid' declared he= re static gboolean smmu_hash_remove_by_vmid(gpointer key, gpointer value, ^ Fixes: ccc3ee3871 ("hw/arm/smmuv3: Add CMDs related to stage-2") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/smmu-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c index 4caedb4998..c4b540656c 100644 --- a/hw/arm/smmu-common.c +++ b/hw/arm/smmu-common.c @@ -197,7 +197,7 @@ void smmu_iotlb_inv_asid(SMMUState *s, uint16_t asid) g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_asid, &asid); } =20 -inline void smmu_iotlb_inv_vmid(SMMUState *s, uint16_t vmid) +void smmu_iotlb_inv_vmid(SMMUState *s, uint16_t vmid) { trace_smmu_iotlb_inv_vmid(vmid); g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid, &vmid); --=20 2.41.0 From nobody Fri May 10 04:53:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710355897; cv=none; d=zohomail.com; s=zohoarc; b=dq6yBuH2xhe4Tjl/97fJ42nb+n6L12JWhaR3ca98u2OFX1YRxAZZ2MMKGr6Pd6pKbe2tiNkMnQ8Ct9ChttX6xElyC1OtUPDybrdfm4lUwCYmTQ86TAVESSXtqRQpkXCjT7EaXj17wEnJZqvYGGPOzpgA2ZeyF0BB2UnANl5K4Ww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710355897; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=c2tKyqNq18mnQFUnvgOLAQJ9bujVYus/vlpKAdDFa/k=; b=OEw7ytzCHz0HTskVksl71+ZLGiM9yvh7x06RqU0JrSbQ4KvhZgoRvtVcYhO5+4MDKZ1iROUqV/o22OPrHJfjy+iwWwsYZ0ADtH1OWKBydJIrbPJBmM8y58la+ZaBm3iL5ysfkjHxmuuBUM52gT9xBHQCEDldjVebagK7w8tqWeg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17103558979558.558608546091932; Wed, 13 Mar 2024 11:51:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkTgT-0001bw-K7; Wed, 13 Mar 2024 14:50:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkTgK-0001aQ-G9 for qemu-devel@nongnu.org; Wed, 13 Mar 2024 14:50:29 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkTgH-0004DB-S2 for qemu-devel@nongnu.org; Wed, 13 Mar 2024 14:50:28 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-412e784060cso8085975e9.1 for ; Wed, 13 Mar 2024 11:50:25 -0700 (PDT) Received: from m1x-phil.lan ([176.176.182.179]) by smtp.gmail.com with ESMTPSA id a17-20020adffad1000000b0033dc7e50488sm12209454wrs.96.2024.03.13.11.50.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 13 Mar 2024 11:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710355824; x=1710960624; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c2tKyqNq18mnQFUnvgOLAQJ9bujVYus/vlpKAdDFa/k=; b=qXOIyT2NKkSKe4DIfdACtVnqJ9uMMjDKOuPwOwBCK75YZBCWhnlFxr3hsHAepZv97I gaPb2S/eFRwgNbh1b0TRphUSbb3ZxkWDbxDO/3w+E+ZkmdASXsA8HWeSXtfN3MopESp9 EndtKzXCMQdS+bBcQv2+iMIJyrzyZriDBaFsg888c/SbYI7kdA5pcuTxcgdC7QrLmLDV 2GAaupfrujvMiC25THscTIZmIna/wt/0hQfztgweGmPN5BZylAgpzbBgZFm7TN+CXosR b3jg+72+SFlpauidtZFhnNdH4/84wA2iUS4aQMMMF0WNndHhYYU+hd30NyRD+R7Yjj5p 0gXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710355824; x=1710960624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c2tKyqNq18mnQFUnvgOLAQJ9bujVYus/vlpKAdDFa/k=; b=exSVyeSDjh/uQ3DIvXEvE5c7OjmW9CxFQasT5xOxiXK7kUS9CP4qx1PZCoWHIUVrkc ov15aESfzWFpBfajkrPx+Fh0+nMA7jhj82ZoGIl2a/HZbLcwrIFj4VFtQtYP4x22Tkct WMjb42VTObjyLVKARL9AVBbb0HVIJGrAk5TMYGXM9GsfMYerrnKUPsAsVmAp92BjY3jG tGEPTJkEw29qNJQlBruxYTpfLDtaVDtD43DdNxpCaQKCXhm6PdevcGNOiVidvW9H9UcA g2Aghi+Ee15JznCHwquWwl9FqJ2pjV2UR5DpIUsVDDaNi7W8W9Zm0pu2t5aniMcV3Rh3 J3FQ== X-Gm-Message-State: AOJu0YwvYfh5ns8H3jDVNv2SgQTb4jf4jT8w6NXDe/lPWaIQmjV7kmaX ZlauNnJeM6NJ9ShE7n9Y0yHE4pfYeKBZqCb0GCetVdFInH+KmrrtFnWw7PiPDeXGZOVp39ZpUVO q X-Google-Smtp-Source: AGHT+IGRjNXSm6URsefntlBe5NG/XXhkPOjK0qhUt5MTYFzxGv/n1fZSwckPI1B9i5sIM+IUbgCmGg== X-Received: by 2002:adf:cd10:0:b0:33e:b787:5beb with SMTP id w16-20020adfcd10000000b0033eb7875bebmr2237803wrm.0.1710355823908; Wed, 13 Mar 2024 11:50:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , John Snow , Alexander Graf , Eric Auger , qemu-block@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Cameron Esfahani , Roman Bolshakov , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0 2/4] accel/hvf: Un-inline hvf_arch_supports_guest_debug() Date: Wed, 13 Mar 2024 19:49:52 +0100 Message-ID: <20240313184954.42513-3-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240313184954.42513-1-philmd@linaro.org> References: <20240313184954.42513-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710355899178100001 See previous commit and commit 9de9fa5cf2 ("Avoid using inlined functions with external linkage") for rationale. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 2 +- target/i386/hvf/hvf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index e5f0f60093..65a5601804 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2246,7 +2246,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) hvf_arch_set_traps(); } =20 -inline bool hvf_arch_supports_guest_debug(void) +bool hvf_arch_supports_guest_debug(void) { return true; } diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 11ffdd4c69..1ed8ed5154 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -708,7 +708,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) { } =20 -inline bool hvf_arch_supports_guest_debug(void) +bool hvf_arch_supports_guest_debug(void) { return false; } --=20 2.41.0 From nobody Fri May 10 04:53:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710355886; cv=none; d=zohomail.com; s=zohoarc; b=MUjWHI4rQwgK+B8JsqnSj47vW5vg3I4nlF+mh3H7K4pk1M8Ib4wErGn+bWxuqCDjW8BbKU1ej1Ie9EaN0a5BdtQGx3B5U2Ki5HVr8gWvoNZQ6a6qS1c/PMpxm/K0wxCBtZ3+psTDTogx80cJMZKS/EzZ2KKmoq9KLhnPGc3DqX4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710355886; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=X17Ya2bvpA+4v4TFaE60WLvpjjO6zpu/JP88j5/yX/w=; b=HIYPMZju3uFHmRP0fojhV926NvQ8vKsR/pvzpiGEnoiwRjprOthINOGUEjPc1HAFri00TmIkGI9J1JtAxHX/GqedCyYnLG7F7Lmw0uvyk2ZOKYz8Ewh1oQadCwtyI8TVJ0l+ad8dfK9TErVKRlvl0VDPWTeW/j6RrglpF3lt7RE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17103558867731011.085715528401; Wed, 13 Mar 2024 11:51:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkTgV-0001dw-TB; Wed, 13 Mar 2024 14:50:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkTgR-0001br-BG for qemu-devel@nongnu.org; Wed, 13 Mar 2024 14:50:35 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkTgO-0004FI-Uc for qemu-devel@nongnu.org; Wed, 13 Mar 2024 14:50:35 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-413eb7cf7dfso1645725e9.0 for ; Wed, 13 Mar 2024 11:50:32 -0700 (PDT) Received: from m1x-phil.lan ([176.176.182.179]) by smtp.gmail.com with ESMTPSA id fj14-20020a05600c0c8e00b00413385ec7e6sm3088148wmb.47.2024.03.13.11.50.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 13 Mar 2024 11:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710355831; x=1710960631; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X17Ya2bvpA+4v4TFaE60WLvpjjO6zpu/JP88j5/yX/w=; b=f9EtNz/ZHx+4BCXzeEHkXEpAhnaN8ZnZyFxpL5FjMAdnfsbQ/1Of/RbL9xShaJUS5F yULqqs6v5sOFcH77Ogc+/+BcentQA1brFuEVqO0jZSaI/w8BWyiNaePKU6m+6lyC+4SG eBUJlmYMULvB5pCyz/ZXFFOnWBOpT+yGUZqMiR97+gMTTYUpsmxgxgavA+bixsaOhJEZ 6c+xmKvmEQj8NFBWccqKjFfWjAN5d+WU8VBrg6khXE2W5ZCRIGRVKf96Z4nxiMiWHRfG kWtMAJBh8s60PS/HxeeN/NQhV/2UQil+32yGgpCrq7U3twnBCvqxrubLvuRQWmJeIt6z Cb3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710355831; x=1710960631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X17Ya2bvpA+4v4TFaE60WLvpjjO6zpu/JP88j5/yX/w=; b=rXXYulfN0XlJEmOTpUD9lj9MJvQgaE0qRLjGbJzjrFoHkwB1yWpp8y5GZn/v1XTe9h XYum2YyPZezdWhYxIQ7XtqoN1WOmwR6pjbfx+MimGy0jMDwWx2k/HPbooBlGeZ5IRerA 5PoKUUWcPgjnmW/EtLUDswRN4rPnydXlwivwiI+8JFrKUDewfR1PfHy0s33mb2SFacaZ RMQPlsO/dWPolurB2jEGUo/MIEEk5e2ScAw66cE5wSBkxBqQLEafOEp0zEoa3WcyOoeq oYSPP2LWWLljt/n0xy4vKrd5POCA22tG4mWWB6vt6JykLJ6BWroGH6LBdLnX4rPz0jDG A/0w== X-Gm-Message-State: AOJu0Yw2zEvY6BxKgqYP72EkwA1BfPqHcfbyViaeGh1ym7NJUwz5oiLZ uB0ghkkGy9QPs2asfXYTP1sRkVSt7+/92Lb+9kaUVeQOE3OI8lVfpoHuoWalfEq+Qk78nrsvzsz z X-Google-Smtp-Source: AGHT+IGsvzdgN7ucAIoiomxDKoaZWax6gBU734zZCqWs/3xAkyQ7rw8GWiUctzeOxTFbc1yXyiTzdA== X-Received: by 2002:a05:600c:1910:b0:413:1ee4:692e with SMTP id j16-20020a05600c191000b004131ee4692emr631218wmq.9.1710355831312; Wed, 13 Mar 2024 11:50:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , John Snow , Alexander Graf , Eric Auger , qemu-block@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Cameron Esfahani , Roman Bolshakov , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0 3/4] qtest/libqos: Un-inline size_to_prdtl() Date: Wed, 13 Mar 2024 19:49:53 +0100 Message-ID: <20240313184954.42513-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240313184954.42513-1-philmd@linaro.org> References: <20240313184954.42513-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710355887387100001 See previous commit and commit 9de9fa5cf2 ("Avoid using inlined functions with external linkage") for rationale. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/libqos/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/libqos/ahci.c b/tests/qtest/libqos/ahci.c index a2c94c6e06..135b23ffd9 100644 --- a/tests/qtest/libqos/ahci.c +++ b/tests/qtest/libqos/ahci.c @@ -662,7 +662,7 @@ unsigned ahci_pick_cmd(AHCIQState *ahci, uint8_t port) g_assert_not_reached(); } =20 -inline unsigned size_to_prdtl(unsigned bytes, unsigned bytes_per_prd) +unsigned size_to_prdtl(unsigned bytes, unsigned bytes_per_prd) { /* Each PRD can describe up to 4MiB */ g_assert_cmphex(bytes_per_prd, <=3D, 4096 * 1024); --=20 2.41.0 From nobody Fri May 10 04:53:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710355902; cv=none; d=zohomail.com; s=zohoarc; b=hYUbqZJMgwU0q71qUPKSB4yHohMU1fBnt7/iuIuUqJUYJ/tZUYstr4sSh7fWeDPKpeHaGhWX7QwTwAB3RtTJilnx71+2c6IzFgDs86CPpMC1o+AenHaIDh5XsVQQaDAoskExlcxLGAup+bR4iBWOyiL8xmr8Q+Mr4O/XZNaX4Xk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710355902; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FWk3AJvtwG4+M7tAK6vUDxEOFolgTz5/lAeIi0nhTag=; b=BFSItA1CxYpsvPTdYHAGOMgs9dLAVamilVBSexAMd/ATxdaMx/xRsaFEeH2jyP1a3iRJW6n9tb1EV1EQU+rrfLCOqKOmH4MVi+6MyAxlYjdItvpRJgTOcUlyFkhcCS5RyacB+exgI73skQ2ns+HEn1QXP7ILz6MiwaEzrjJfn3w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710355902851883.5201352052569; Wed, 13 Mar 2024 11:51:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkTge-0001pH-1f; Wed, 13 Mar 2024 14:50:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkTga-0001ig-N0 for qemu-devel@nongnu.org; Wed, 13 Mar 2024 14:50:46 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkTgX-0004GK-Ku for qemu-devel@nongnu.org; Wed, 13 Mar 2024 14:50:44 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-41324a16c9eso1120705e9.0 for ; Wed, 13 Mar 2024 11:50:40 -0700 (PDT) Received: from m1x-phil.lan ([176.176.182.179]) by smtp.gmail.com with ESMTPSA id w10-20020a5d680a000000b0033e0dd83be1sm12254046wru.91.2024.03.13.11.50.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 13 Mar 2024 11:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710355839; x=1710960639; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FWk3AJvtwG4+M7tAK6vUDxEOFolgTz5/lAeIi0nhTag=; b=WQBs14mQmdx4bWTKOZGi9MDsZizypAaGwIHTJrn0xyQQpGx0vrHjbD6XQUOPwtkjMN 0egPfX+B8/3uwQOa+qWavGBdcJOzruXY5qDHb2rcolYYWZUzsJ+5J6E2C3yzliMEZ8E4 Ggo6vzpmH/1QtMYM5QX7Kv7IB75HKMw+Ko0sHZsNLz6TPepKty0CKyL2mzWfZKF2fIB1 CJj57Su3NiaztYBuqQlg7IxyACSk9fszeWEb5n09s+X4HWuqk1EpP0UUfMtWNigGPGbw TgNlFfYlXuR2wiw4TBEHilHlnpVtinR6Q/GKai8+DUhqEojxT67Xm2a9au2Qum7/OLji E0Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710355839; x=1710960639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FWk3AJvtwG4+M7tAK6vUDxEOFolgTz5/lAeIi0nhTag=; b=DAZ4ko60CgnsB+L7dvNEUk9yvV5zF2syTbcz3HkgLeBaB6GnlqWcXyjKYYcuEZHk/7 GiQV3hSB7BVwhldJql/UO6nGGp+uPNoXkbrdelyq7/875KG6Su1pmVBUPLvumu3BIrTv AMUEv1GvYDHXBn5DCw2KhcRFcAhJwrP+3Nc0ZO4Xk3KZer79ENRWZjsAnbvqroLOI/Q2 XgDNbMaGyBDevvHqRXyN4bopI94PJlCAWnuGIqlD1cbwPlYOzFviFi95HBKeDzNDX76r qpaDWnFlj5twX0tsMNwtBW1d+ahidvGOC78qm/y3eBW2ORGzqGvK1Jl0eCL6afvJDLNq 48Xw== X-Gm-Message-State: AOJu0Yx6WVM4t0e5/1WOSj5yJlHd7qM0bapV2EZfloq8qjEmbGVKcaWO 01HVI8FsaWNhtBRIoT6+nLmIBBbGIuaZcvm8SIPeTOs0GBX5UUKG/1UvPJqosrruPOKCW944DCT 2 X-Google-Smtp-Source: AGHT+IHVCvYGdXOqSvhG0TkqF8/nwJckNMnZ5dORAkrkWJrRClth+omh0ZGW0c16mbE21+ad/grISA== X-Received: by 2002:a05:600c:1f94:b0:412:ea32:e7b0 with SMTP id je20-20020a05600c1f9400b00412ea32e7b0mr540827wmb.40.1710355838743; Wed, 13 Mar 2024 11:50:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , John Snow , Alexander Graf , Eric Auger , qemu-block@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Cameron Esfahani , Roman Bolshakov , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0 4/4] meson: Enable -Wstatic-in-inline Date: Wed, 13 Mar 2024 19:49:54 +0100 Message-ID: <20240313184954.42513-5-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240313184954.42513-1-philmd@linaro.org> References: <20240313184954.42513-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710355903279100001 Compilers are clever enough to inline code when necessary. The only case we accept an inline function is static in header (we use C, not C++). Add the -Wstatic-in-inline CPPFLAG to prevent public and inline function to be added in the code base. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index b375248a76..f57397aa53 100644 --- a/meson.build +++ b/meson.build @@ -591,6 +591,7 @@ warn_flags =3D [ '-Wold-style-definition', '-Wredundant-decls', '-Wshadow=3Dlocal', + '-Wstatic-in-inline', '-Wstrict-prototypes', '-Wtype-limits', '-Wundef', --=20 2.41.0