[v4] backup: discard-source parameter

[PATCH v4 0/5] backup: discard-source parameter

Vladimir Sementsov-Ogievskiy posted 5 patches 1 month, 2 weeks ago

Diff against v1 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240313152822.626493-1-vsementsov@yandex-team.ru

Maintainers: John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Wen Congyang <wencongyang2@huawei.com>, Xie Changlong <xiechanglong.d@gmail.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

block/backup.c                                |   5 +-
block/block-copy.c                            |  12 +-
block/copy-before-write.c                     |  39 ++++-
block/copy-before-write.h                     |   1 +
block/replication.c                           |   4 +-
blockdev.c                                    |   2 +-
include/block/block-common.h                  |   2 +
include/block/block-copy.h                    |   2 +
include/block/block_int-global-state.h        |   2 +-
qapi/block-core.json                          |   4 +
tests/qemu-iotests/257.out                    | 112 ++++++-------
.../qemu-iotests/tests/backup-discard-source  | 152 ++++++++++++++++++
.../tests/backup-discard-source.out           |   5 +
13 files changed, 272 insertions(+), 70 deletions(-)
create mode 100755 tests/qemu-iotests/tests/backup-discard-source
create mode 100644 tests/qemu-iotests/tests/backup-discard-source.out

Expand all Fold all

[PATCH v4 0/5] backup: discard-source parameter

Posted by Vladimir Sementsov-Ogievskiy 1 month, 2 weeks ago

Hi all! The main patch is 04, please look at it for description and
diagram.

v4: add t-b by Fiona
    add r-b by Fiona to 02-05 (patch 01 still lack an r-b)
    05: fix copyrights and subject in the test
    04: since 9.0 --> since 9.1 (we missed a soft freeze for 9.0)

Vladimir Sementsov-Ogievskiy (5):
  block/copy-before-write: fix permission
  block/copy-before-write: support unligned snapshot-discard
  block/copy-before-write: create block_copy bitmap in filter node
  qapi: blockdev-backup: add discard-source parameter
  iotests: add backup-discard-source

 block/backup.c                                |   5 +-
 block/block-copy.c                            |  12 +-
 block/copy-before-write.c                     |  39 ++++-
 block/copy-before-write.h                     |   1 +
 block/replication.c                           |   4 +-
 blockdev.c                                    |   2 +-
 include/block/block-common.h                  |   2 +
 include/block/block-copy.h                    |   2 +
 include/block/block_int-global-state.h        |   2 +-
 qapi/block-core.json                          |   4 +
 tests/qemu-iotests/257.out                    | 112 ++++++-------
 .../qemu-iotests/tests/backup-discard-source  | 152 ++++++++++++++++++
 .../tests/backup-discard-source.out           |   5 +
 13 files changed, 272 insertions(+), 70 deletions(-)
 create mode 100755 tests/qemu-iotests/tests/backup-discard-source
 create mode 100644 tests/qemu-iotests/tests/backup-discard-source.out

-- 
2.34.1

Re: [PATCH v4 0/5] backup: discard-source parameter

Posted by Vladimir Sementsov-Ogievskiy 3 weeks, 1 day ago

On 13.03.24 18:28, Vladimir Sementsov-Ogievskiy wrote:
> Hi all! The main patch is 04, please look at it for description and
> diagram.
> 
> v4: add t-b by Fiona
>      add r-b by Fiona to 02-05 (patch 01 still lack an r-b)
>      05: fix copyrights and subject in the test
>      04: since 9.0 --> since 9.1 (we missed a soft freeze for 9.0)
> 
> Vladimir Sementsov-Ogievskiy (5):
>    block/copy-before-write: fix permission
>    block/copy-before-write: support unligned snapshot-discard
>    block/copy-before-write: create block_copy bitmap in filter node
>    qapi: blockdev-backup: add discard-source parameter
>    iotests: add backup-discard-source
> 
>   block/backup.c                                |   5 +-
>   block/block-copy.c                            |  12 +-
>   block/copy-before-write.c                     |  39 ++++-
>   block/copy-before-write.h                     |   1 +
>   block/replication.c                           |   4 +-
>   blockdev.c                                    |   2 +-
>   include/block/block-common.h                  |   2 +
>   include/block/block-copy.h                    |   2 +
>   include/block/block_int-global-state.h        |   2 +-
>   qapi/block-core.json                          |   4 +
>   tests/qemu-iotests/257.out                    | 112 ++++++-------
>   .../qemu-iotests/tests/backup-discard-source  | 152 ++++++++++++++++++
>   .../tests/backup-discard-source.out           |   5 +
>   13 files changed, 272 insertions(+), 70 deletions(-)
>   create mode 100755 tests/qemu-iotests/tests/backup-discard-source
>   create mode 100644 tests/qemu-iotests/tests/backup-discard-source.out
> 


Thanks for review, applied to my block branch.

(r-b to 01 is still appreciated, I will not pull this until 9.1 tree opened)

-- 
Best regards,
Vladimir