[PATCH v2 0/9] Clean up .new decode and scripts

Taylor Simpson posted 9 patches 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240307032327.4799-1-ltaylorsimpson@gmail.com
Maintainers: Brian Cain <bcain@quicinc.com>, Alessandro Di Federico <ale@rev.ng>, Anton Johansson <anjo@rev.ng>
target/hexagon/insn.h                   |   5 +-
target/hexagon/opcodes.h                |   4 -
target/hexagon/decode.c                 |  50 ++--------
target/hexagon/mmvec/decode_ext_mmvec.c |  30 ++----
target/hexagon/opcodes.c                |  35 -------
tests/tcg/hexagon/hvx_misc.c            |  16 ++-
target/hexagon/README                   |   2 -
target/hexagon/gen_analyze_funcs.py     |  21 +---
target/hexagon/gen_helper_funcs.py      |  21 +---
target/hexagon/gen_helper_protos.py     |  21 +---
target/hexagon/gen_idef_parser_funcs.py |   5 +-
target/hexagon/gen_op_attribs.py        |   5 +-
target/hexagon/gen_op_regs.py           | 125 ------------------------
target/hexagon/gen_opcodes_def.py       |   4 +-
target/hexagon/gen_printinsn.py         |   5 +-
target/hexagon/gen_shortcode.py         |  63 ------------
target/hexagon/gen_tcg_func_table.py    |   5 +-
target/hexagon/gen_tcg_funcs.py         |  21 +---
target/hexagon/gen_trans_funcs.py       |  26 ++++-
target/hexagon/hex_common.py            |  49 +++++++---
target/hexagon/meson.build              |  55 ++++-------
21 files changed, 122 insertions(+), 446 deletions(-)
delete mode 100755 target/hexagon/gen_op_regs.py
delete mode 100755 target/hexagon/gen_shortcode.py
[PATCH v2 0/9] Clean up .new decode and scripts
Posted by Taylor Simpson 2 months ago
During .new decode, there are several places where strchr is used.
We remove these by generating the values that are needed.

Once we have generated the proper values, we no longer need
op_regs_generated.h.inc.  We remove the script that generates it as
well as the code in meson.build

We also remove the script and meson.build code that creates
shortcode_generated.h.inc.  The data structure that includes it is
not used.

We remove hex_common.read_attribs_file.  The Python data structures built
during this step are not used.

**** Changes in v2 ****
Address feedback from Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Mark Philippe's Reviewed-by on patch 01
Update example comment in gen_trans_funcs.py



Taylor Simpson (9):
  Hexagon (target/hexagon) Add is_old/is_new to Register class
  Hexagon (target/hexagon) Mark new_read_idx in trans functions
  Hexagon (target/hexagon) Mark dest_idx in trans functions
  Hexagon (target/hexagon) Mark has_pred_dest in trans functions
  Hexagon (tests/tcg/hexagon) Test HVX .new read from high half of pair
  Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc
  Hexagon (target/hexagon) Remove gen_op_regs.py
  Hexagon (target/hexagon) Remove gen_shortcode.py
  Hexagon (target/hexagon) Remove hex_common.read_attribs_file

 target/hexagon/insn.h                   |   5 +-
 target/hexagon/opcodes.h                |   4 -
 target/hexagon/decode.c                 |  50 ++--------
 target/hexagon/mmvec/decode_ext_mmvec.c |  30 ++----
 target/hexagon/opcodes.c                |  35 -------
 tests/tcg/hexagon/hvx_misc.c            |  16 ++-
 target/hexagon/README                   |   2 -
 target/hexagon/gen_analyze_funcs.py     |  21 +---
 target/hexagon/gen_helper_funcs.py      |  21 +---
 target/hexagon/gen_helper_protos.py     |  21 +---
 target/hexagon/gen_idef_parser_funcs.py |   5 +-
 target/hexagon/gen_op_attribs.py        |   5 +-
 target/hexagon/gen_op_regs.py           | 125 ------------------------
 target/hexagon/gen_opcodes_def.py       |   4 +-
 target/hexagon/gen_printinsn.py         |   5 +-
 target/hexagon/gen_shortcode.py         |  63 ------------
 target/hexagon/gen_tcg_func_table.py    |   5 +-
 target/hexagon/gen_tcg_funcs.py         |  21 +---
 target/hexagon/gen_trans_funcs.py       |  26 ++++-
 target/hexagon/hex_common.py            |  49 +++++++---
 target/hexagon/meson.build              |  55 ++++-------
 21 files changed, 122 insertions(+), 446 deletions(-)
 delete mode 100755 target/hexagon/gen_op_regs.py
 delete mode 100755 target/hexagon/gen_shortcode.py

-- 
2.34.1