tap: Use g_spawn_sync() and g_spawn_check_wait_status()

[PATCH 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

Akihiko Odaki posted 2 patches 4 months, 4 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231219-glib-v1-0-1b040d286b91@daynix.com

Maintainers: Jason Wang <jasowang@redhat.com>

include/glib-compat.h |  2 ++
net/tap.c             | 52 ++++++++++++++++++++++-----------------------------
2 files changed, 24 insertions(+), 30 deletions(-)

Expand all Fold all

[PATCH 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

Posted by Akihiko Odaki 4 months, 4 weeks ago

g_spawn_sync() gives an informative message if it fails to execute
the script instead of reporting exiting status 1.

g_spawn_check_wait_status() also gives an message easier to understand
than the raw value returned by waitpid().

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Akihiko Odaki (2):
      glib-compat: Define g_spawn_check_wait_status()
      tap: Use g_spawn_sync() and g_spawn_check_wait_status()

 include/glib-compat.h |  2 ++
 net/tap.c             | 52 ++++++++++++++++++++++-----------------------------
 2 files changed, 24 insertions(+), 30 deletions(-)
---
base-commit: 9c74490bff6c8886a922008d0c9ce6cae70dd17e
change-id: 20231219-glib-034a34bb05d8

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>

Re: [PATCH 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

Posted by Jason Wang 1 month, 2 weeks ago

On Tue, Dec 19, 2023 at 7:59 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> g_spawn_sync() gives an informative message if it fails to execute
> the script instead of reporting exiting status 1.
>
> g_spawn_check_wait_status() also gives an message easier to understand
> than the raw value returned by waitpid().
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Akihiko Odaki (2):
>       glib-compat: Define g_spawn_check_wait_status()
>       tap: Use g_spawn_sync() and g_spawn_check_wait_status()
>
>  include/glib-compat.h |  2 ++
>  net/tap.c             | 52 ++++++++++++++++++++++-----------------------------
>  2 files changed, 24 insertions(+), 30 deletions(-)
> ---
> base-commit: 9c74490bff6c8886a922008d0c9ce6cae70dd17e
> change-id: 20231219-glib-034a34bb05d8
>
> Best regards,
> --
> Akihiko Odaki <akihiko.odaki@daynix.com>

I've queued this for 9.1

Thanks

>