[PATCH v2 0/6] arm/stellaris: convert gamepad input device to qdev

Peter Maydell posted 6 patches 6 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231030114802.3671871-1-peter.maydell@linaro.org
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>
include/hw/input/gamepad.h           |  18 -----
include/hw/input/stellaris_gamepad.h |  36 ++++++++++
include/hw/qdev-properties.h         |   3 +
hw/arm/stellaris.c                   |  34 ++++++---
hw/core/qdev-properties.c            |  21 ++++++
hw/input/stellaris_gamepad.c         | 102 +++++++++++++++++++++++++++
hw/input/stellaris_input.c           |  93 ------------------------
hw/arm/Kconfig                       |   2 +-
hw/input/Kconfig                     |   2 +-
hw/input/meson.build                 |   2 +-
10 files changed, 190 insertions(+), 123 deletions(-)
delete mode 100644 include/hw/input/gamepad.h
create mode 100644 include/hw/input/stellaris_gamepad.h
create mode 100644 hw/input/stellaris_gamepad.c
delete mode 100644 hw/input/stellaris_input.c
[PATCH v2 0/6] arm/stellaris: convert gamepad input device to qdev
Posted by Peter Maydell 6 months, 3 weeks ago
This patchseries converts the stellaris board's gamepad input device
to qdev. This isn't a very important bit of conversion (I was just
looking for a small tail-end-of-the-week task), but it does reduce by
one the number of users of a couple of legacy APIs: vmstate_register()
and qemu_add_kbd_event_handler().

All patches reviewed and tested; changes v1->v2 are minor only:
 * bump migration version number and mention migration break
   in commit message
 * drop unneeded private/public comment lines
 * make QemuInputHandler struct const

I've included Kevin's qdev_prop_set_array() patch here, and will
take this via target-arm.next if it doesn't get in via another
route first.

thanks
-- PMM

Kevin Wolf (1):
  qdev: Add qdev_prop_set_array()

Peter Maydell (5):
  hw/input/stellaris_input: Rename to stellaris_gamepad
  hw/input/stellaris_gamepad: Rename structs to our usual convention
  hw/input/stellaris_gamepad: Remove StellarisGamepadButton struct
  hw/input/stellaris_input: Convert to qdev
  hw/input/stellaris_gamepad: Convert to qemu_input_handler_register()

 include/hw/input/gamepad.h           |  18 -----
 include/hw/input/stellaris_gamepad.h |  36 ++++++++++
 include/hw/qdev-properties.h         |   3 +
 hw/arm/stellaris.c                   |  34 ++++++---
 hw/core/qdev-properties.c            |  21 ++++++
 hw/input/stellaris_gamepad.c         | 102 +++++++++++++++++++++++++++
 hw/input/stellaris_input.c           |  93 ------------------------
 hw/arm/Kconfig                       |   2 +-
 hw/input/Kconfig                     |   2 +-
 hw/input/meson.build                 |   2 +-
 10 files changed, 190 insertions(+), 123 deletions(-)
 delete mode 100644 include/hw/input/gamepad.h
 create mode 100644 include/hw/input/stellaris_gamepad.h
 create mode 100644 hw/input/stellaris_gamepad.c
 delete mode 100644 hw/input/stellaris_input.c

-- 
2.34.1