[PATCH] ARM: Use normal types

Juan Quintela posted 1 patch 6 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231017131344.19676-1-quintela@redhat.com
Maintainers: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>
bsd-user/arm/target_arch_reg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ARM: Use normal types
Posted by Juan Quintela 6 months, 2 weeks ago
A bit of history from Warner:

This has been that way the bsd-user sources were reorganized in
2015. I can find no good reason in the FreeBSD sources to do
this (we've been transitioning from the pre-standardized BSD
convention of u_intXX_t -> uintXX_t for 25 years now it seems). I
don't see any old or ancient usage as far back as I looked why they'd
be different. Up through FreeBSD 12.x, this was u_int32_t (for all of
them), but they switched to __uint32_t in FreeBSD 13 to avoid
namespace pollution.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by:  Warner Losh <imp@bsdimp.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>

---

It looks this got lost on previous release
---
 bsd-user/arm/target_arch_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsd-user/arm/target_arch_reg.h b/bsd-user/arm/target_arch_reg.h
index 070fa24da1..5f1eea4291 100644
--- a/bsd-user/arm/target_arch_reg.h
+++ b/bsd-user/arm/target_arch_reg.h
@@ -32,7 +32,7 @@ typedef struct target_reg {
 typedef struct target_fp_reg {
     uint32_t        fp_exponent;
     uint32_t        fp_mantissa_hi;
-    u_int32_t       fp_mantissa_lo;
+    uint32_t       fp_mantissa_lo;
 } target_fp_reg_t;
 
 typedef struct target_fpreg {
-- 
2.41.0