[v3] coverity fixes

[PATCH v3 0/6] coverity fixes

Vladimir Sementsov-Ogievskiy posted 6 patches 6 months, 2 weeks ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231017125941.810461-1-vsementsov@yandex-team.ru

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Peter Xu <peterx@redhat.com>, Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Daniel P. Berrangé" <berrange@redhat.com>

block/nvme.c               |  7 ++++---
hw/core/loader.c           |  2 +-
hw/i386/intel_iommu.c      | 23 ++++++++++++++++++++---
hw/rtc/mc146818rtc.c       |  2 +-
io/channel-socket.c        |  5 +++++
util/filemonitor-inotify.c | 25 +++++++++++++++++--------
6 files changed, 48 insertions(+), 16 deletions(-)

Expand all Fold all

[PATCH v3 0/6] coverity fixes

Posted by Vladimir Sementsov-Ogievskiy 6 months, 2 weeks ago

v3: rebase on master (two patches dropped, as already merged)
    add r-b marks

v2:
01: add explanations, new assert and avoid extra assignment
    add CIDs [thx to Paolo]
02: add explanation, improve wording
04,07: s/{0}/{}
06,08: improve wording

Hi! Here are some improvements to handle issues found by Coverity (not
public Coverity site, so there are no CIDs).


Vladimir Sementsov-Ogievskiy (6):
  hw/i386/intel_iommu: vtd_slpte_nonzero_rsvd(): assert no overflow
  util/filemonitor-inotify: qemu_file_monitor_watch(): assert no
    overflow
  mc146818rtc: rtc_set_time(): initialize tm to zeroes
  block/nvme: nvme_process_completion() fix bound for cid
  hw/core/loader: gunzip(): initialize z_stream
  io/channel-socket: qio_channel_socket_flush(): improve msg validation

 block/nvme.c               |  7 ++++---
 hw/core/loader.c           |  2 +-
 hw/i386/intel_iommu.c      | 23 ++++++++++++++++++++---
 hw/rtc/mc146818rtc.c       |  2 +-
 io/channel-socket.c        |  5 +++++
 util/filemonitor-inotify.c | 25 +++++++++++++++++--------
 6 files changed, 48 insertions(+), 16 deletions(-)

-- 
2.34.1

Re: [PATCH v3 0/6] coverity fixes

Posted by Peter Maydell 5 months, 4 weeks ago

On Tue, 17 Oct 2023 at 13:59, Vladimir Sementsov-Ogievskiy
<vsementsov@yandex-team.ru> wrote:
>
> v3: rebase on master (two patches dropped, as already merged)
>     add r-b marks
>
> v2:
> 01: add explanations, new assert and avoid extra assignment
>     add CIDs [thx to Paolo]
> 02: add explanation, improve wording
> 04,07: s/{0}/{}
> 06,08: improve wording
>
> Hi! Here are some improvements to handle issues found by Coverity (not
> public Coverity site, so there are no CIDs).
>

Looks like nobody picked this up, and they all got reviewed,
so I'm going to apply it via the target-arm.next tree.

thanks
-- PMM