[PATCH] tests/vm: netbsd: install dtc

Paolo Bonzini posted 1 patch 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231013153027.800327-1-pbonzini@redhat.com
Maintainers: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Reinoud Zandijk <reinoud@netbsd.org>, Ryo ONODERA <ryoon@netbsd.org>
tests/vm/netbsd | 3 +++
1 file changed, 3 insertions(+)
[PATCH] tests/vm: netbsd: install dtc
Posted by Paolo Bonzini 7 months ago
Install dtc as it is now a mandatory external dependency in order to build QEMU.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/vm/netbsd | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index 939dc1b22a1..3ef1ec2d9cc 100755
--- a/tests/vm/netbsd
+++ b/tests/vm/netbsd
@@ -40,6 +40,9 @@ class NetBSDVM(basevm.BaseVM):
         "gsed",
         "gettext-tools",
 
+        # libs: basic
+        "dtc",
+
         # libs: crypto
         "gnutls",
 
-- 
2.41.0
Re: [PATCH] tests/vm: netbsd: install dtc
Posted by Thomas Huth 7 months ago
On 13/10/2023 17.30, Paolo Bonzini wrote:
> Install dtc as it is now a mandatory external dependency in order to build QEMU.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   tests/vm/netbsd | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> index 939dc1b22a1..3ef1ec2d9cc 100755
> --- a/tests/vm/netbsd
> +++ b/tests/vm/netbsd
> @@ -40,6 +40,9 @@ class NetBSDVM(basevm.BaseVM):
>           "gsed",
>           "gettext-tools",
>   
> +        # libs: basic
> +        "dtc",
> +
>           # libs: crypto
>           "gnutls",
>   

Does this work for you? When I run "make vm-build-netbsd", I'm still getting 
a failure:

76 packages to install:
   git-base-2.41.0nb1 pkgconf-1.9.5 xz-5.4.3 python310-3.10.12 
py310-expat-3.10.12nb1 ninja-build-1.11.1
   bash-5.2.15 gmake-4.4.1 gsed-4.9nb1 gettext-tools-0.21.1 dtc-1.7.0 
gnutls-3.8.0nb3 jpeg-9e png-1.6.39
   capstone-4.0.2 SDL2-2.26.5nb1 gtk3+-3.24.38 zstd-1.5.5 libslirp-4.7.0nb1 
pcre2-10.42 curl-8.1.2
   libuuid-2.32.1nb1 libffi-3.4.4 gettext-lib-0.21.1 p11-kit-0.24.1 nettle-3.9.1
   mozilla-rootcerts-1.0.20230505 libtasn1-4.19.0 libcfg+-0.7.0 gmp-6.2.1nb3 
wayland-protocols-1.31nb1
   wayland-1.21.0nb2 libxkbcommon-1.5.0nb1 libsamplerate-0.2.2nb4 
shared-mime-info-2.2nb2 pango-1.50.12nb1
   libcups-2.4.6nb1 libXft-2.3.8 hicolor-icon-theme-0.17nb1 glib2-2.74.6nb1 
gdk-pixbuf2-2.42.10nb2
   fribidi-1.0.13 freetype2-2.13.0nb1 fontconfig-2.14.2nb1 
cairo-gobject-1.16.0nb7 cairo-1.16.0nb9 atk-2.38.0
   at-spi2-atk-2.38.0nb1 lz4-1.9.4 nghttp2-1.54.0 libidn2-2.3.4 
readline-8.2nb2 libsndfile-1.2.0nb2
   fftw-3.3.10nb1 libxslt-1.1.38 libepoll-shim-0.0.20230411 
at-spi2-core-2.40.3nb2 lzo-2.10 brotli-1.0.9
   tiff-4.5.1nb1 libpaper-2.1.0nb2 dbus-1.14.6 harfbuzz-7.3.0 
graphite2-1.3.14nb1 libunistring-1.1
   libxml2-2.10.4nb1 libgcrypt-1.10.2 mpg123-1.31.3 libvorbis-1.3.7 
libopus-1.4 libogg-1.3.5nb1 lame-3.100nb5
   flac-1.4.2 jbigkit-2.1nb1 xmlcatmgr-2.2nb1 libgpg-error-1.47
[...]
installing dtc-1.7.0...
[...]
The Meson build system
Version: 0.63.3
Source dir: /home/qemu/qemu-test.Li0spd/src
Build dir: /home/qemu/qemu-test.Li0spd/build
Build type: native build
Project name: qemu
Project version: 8.1.50
C compiler for the host machine: cc -m64 -mcx16 (gcc 7.5.0 "cc (nb4 
20200810) 7.5.0")
C linker for the host machine: cc -m64 -mcx16 ld.bfd 2.31.1
[...]
Run-time dependency capstone found: YES 4.0.2
Library fdt found: NO
Initialized empty Git repository in 
/home/qemu/qemu-test.Li0spd/src/subprojects/dtc/.git/
fatal: unable to access 'https://gitlab.com/qemu-project/dtc.git/': SSL 
certificate problem: unable to get local issuer certificate

../src/meson.build:3076:4: ERROR: Git command failed: ['/usr/pkg/bin/git', 
'fetch', '--depth', '1', 'origin', 'b6910bec11614980a21e46fbccc35934b671bd81']

A full log can be found at 
/home/qemu/qemu-test.Li0spd/build/meson-logs/meson-log.txt

ERROR: meson setup failed

... so though the NetBSD people finally upgraded their dtc to a usable 
level, our meson.build seems to be unable to detect it?

  Thomas
Re: [PATCH] tests/vm: netbsd: install dtc
Posted by Daniel P. Berrangé 7 months ago
On Mon, Oct 16, 2023 at 11:00:14AM +0200, Thomas Huth wrote:
> On 13/10/2023 17.30, Paolo Bonzini wrote:
> > Install dtc as it is now a mandatory external dependency in order to build QEMU.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >   tests/vm/netbsd | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> > index 939dc1b22a1..3ef1ec2d9cc 100755
> > --- a/tests/vm/netbsd
> > +++ b/tests/vm/netbsd
> > @@ -40,6 +40,9 @@ class NetBSDVM(basevm.BaseVM):
> >           "gsed",
> >           "gettext-tools",
> > +        # libs: basic
> > +        "dtc",
> > +
> >           # libs: crypto
> >           "gnutls",
> 
> Does this work for you? When I run "make vm-build-netbsd", I'm still getting
> a failure:
> 
> 76 packages to install:
>   git-base-2.41.0nb1 pkgconf-1.9.5 xz-5.4.3 python310-3.10.12
> py310-expat-3.10.12nb1 ninja-build-1.11.1
>   bash-5.2.15 gmake-4.4.1 gsed-4.9nb1 gettext-tools-0.21.1 dtc-1.7.0
> gnutls-3.8.0nb3 jpeg-9e png-1.6.39
>   capstone-4.0.2 SDL2-2.26.5nb1 gtk3+-3.24.38 zstd-1.5.5 libslirp-4.7.0nb1
> pcre2-10.42 curl-8.1.2
>   libuuid-2.32.1nb1 libffi-3.4.4 gettext-lib-0.21.1 p11-kit-0.24.1 nettle-3.9.1
>   mozilla-rootcerts-1.0.20230505 libtasn1-4.19.0 libcfg+-0.7.0 gmp-6.2.1nb3
> wayland-protocols-1.31nb1
>   wayland-1.21.0nb2 libxkbcommon-1.5.0nb1 libsamplerate-0.2.2nb4
> shared-mime-info-2.2nb2 pango-1.50.12nb1
>   libcups-2.4.6nb1 libXft-2.3.8 hicolor-icon-theme-0.17nb1 glib2-2.74.6nb1
> gdk-pixbuf2-2.42.10nb2
>   fribidi-1.0.13 freetype2-2.13.0nb1 fontconfig-2.14.2nb1
> cairo-gobject-1.16.0nb7 cairo-1.16.0nb9 atk-2.38.0
>   at-spi2-atk-2.38.0nb1 lz4-1.9.4 nghttp2-1.54.0 libidn2-2.3.4
> readline-8.2nb2 libsndfile-1.2.0nb2
>   fftw-3.3.10nb1 libxslt-1.1.38 libepoll-shim-0.0.20230411
> at-spi2-core-2.40.3nb2 lzo-2.10 brotli-1.0.9
>   tiff-4.5.1nb1 libpaper-2.1.0nb2 dbus-1.14.6 harfbuzz-7.3.0
> graphite2-1.3.14nb1 libunistring-1.1
>   libxml2-2.10.4nb1 libgcrypt-1.10.2 mpg123-1.31.3 libvorbis-1.3.7
> libopus-1.4 libogg-1.3.5nb1 lame-3.100nb5
>   flac-1.4.2 jbigkit-2.1nb1 xmlcatmgr-2.2nb1 libgpg-error-1.47
> [...]
> installing dtc-1.7.0...
> [...]
> The Meson build system
> Version: 0.63.3
> Source dir: /home/qemu/qemu-test.Li0spd/src
> Build dir: /home/qemu/qemu-test.Li0spd/build
> Build type: native build
> Project name: qemu
> Project version: 8.1.50
> C compiler for the host machine: cc -m64 -mcx16 (gcc 7.5.0 "cc (nb4
> 20200810) 7.5.0")
> C linker for the host machine: cc -m64 -mcx16 ld.bfd 2.31.1
> [...]
> Run-time dependency capstone found: YES 4.0.2
> Library fdt found: NO
> Initialized empty Git repository in
> /home/qemu/qemu-test.Li0spd/src/subprojects/dtc/.git/
> fatal: unable to access 'https://gitlab.com/qemu-project/dtc.git/': SSL
> certificate problem: unable to get local issuer certificate
> 
> ../src/meson.build:3076:4: ERROR: Git command failed: ['/usr/pkg/bin/git',
> 'fetch', '--depth', '1', 'origin',
> 'b6910bec11614980a21e46fbccc35934b671bd81']
> 
> A full log can be found at
> /home/qemu/qemu-test.Li0spd/build/meson-logs/meson-log.txt
> 
> ERROR: meson setup failed
> 
> ... so though the NetBSD people finally upgraded their dtc to a usable
> level, our meson.build seems to be unable to detect it?

They claim to have version 1.7.0

  https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/sysutils/dtc/index.html

and we claim to want 1.5.0, so should be OK.

Suggests that our detection, or test compilation is failing. The
meson-log.txt might have more info, if you can access that ?


Also separately it appears we're missing the public CA cert bundle,
so we should not see a cert error from gitlab.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH] tests/vm: netbsd: install dtc
Posted by Thomas Huth 7 months ago
On 16/10/2023 11.06, Daniel P. Berrangé wrote:
> On Mon, Oct 16, 2023 at 11:00:14AM +0200, Thomas Huth wrote:
>> On 13/10/2023 17.30, Paolo Bonzini wrote:
>>> Install dtc as it is now a mandatory external dependency in order to build QEMU.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>    tests/vm/netbsd | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
>>> index 939dc1b22a1..3ef1ec2d9cc 100755
>>> --- a/tests/vm/netbsd
>>> +++ b/tests/vm/netbsd
>>> @@ -40,6 +40,9 @@ class NetBSDVM(basevm.BaseVM):
>>>            "gsed",
>>>            "gettext-tools",
>>> +        # libs: basic
>>> +        "dtc",
>>> +
>>>            # libs: crypto
>>>            "gnutls",
>>
>> Does this work for you? When I run "make vm-build-netbsd", I'm still getting
>> a failure:
>>
>> 76 packages to install:
>>    git-base-2.41.0nb1 pkgconf-1.9.5 xz-5.4.3 python310-3.10.12
>> py310-expat-3.10.12nb1 ninja-build-1.11.1
>>    bash-5.2.15 gmake-4.4.1 gsed-4.9nb1 gettext-tools-0.21.1 dtc-1.7.0
>> gnutls-3.8.0nb3 jpeg-9e png-1.6.39
>>    capstone-4.0.2 SDL2-2.26.5nb1 gtk3+-3.24.38 zstd-1.5.5 libslirp-4.7.0nb1
>> pcre2-10.42 curl-8.1.2
>>    libuuid-2.32.1nb1 libffi-3.4.4 gettext-lib-0.21.1 p11-kit-0.24.1 nettle-3.9.1
>>    mozilla-rootcerts-1.0.20230505 libtasn1-4.19.0 libcfg+-0.7.0 gmp-6.2.1nb3
>> wayland-protocols-1.31nb1
>>    wayland-1.21.0nb2 libxkbcommon-1.5.0nb1 libsamplerate-0.2.2nb4
>> shared-mime-info-2.2nb2 pango-1.50.12nb1
>>    libcups-2.4.6nb1 libXft-2.3.8 hicolor-icon-theme-0.17nb1 glib2-2.74.6nb1
>> gdk-pixbuf2-2.42.10nb2
>>    fribidi-1.0.13 freetype2-2.13.0nb1 fontconfig-2.14.2nb1
>> cairo-gobject-1.16.0nb7 cairo-1.16.0nb9 atk-2.38.0
>>    at-spi2-atk-2.38.0nb1 lz4-1.9.4 nghttp2-1.54.0 libidn2-2.3.4
>> readline-8.2nb2 libsndfile-1.2.0nb2
>>    fftw-3.3.10nb1 libxslt-1.1.38 libepoll-shim-0.0.20230411
>> at-spi2-core-2.40.3nb2 lzo-2.10 brotli-1.0.9
>>    tiff-4.5.1nb1 libpaper-2.1.0nb2 dbus-1.14.6 harfbuzz-7.3.0
>> graphite2-1.3.14nb1 libunistring-1.1
>>    libxml2-2.10.4nb1 libgcrypt-1.10.2 mpg123-1.31.3 libvorbis-1.3.7
>> libopus-1.4 libogg-1.3.5nb1 lame-3.100nb5
>>    flac-1.4.2 jbigkit-2.1nb1 xmlcatmgr-2.2nb1 libgpg-error-1.47
>> [...]
>> installing dtc-1.7.0...
>> [...]
>> The Meson build system
>> Version: 0.63.3
>> Source dir: /home/qemu/qemu-test.Li0spd/src
>> Build dir: /home/qemu/qemu-test.Li0spd/build
>> Build type: native build
>> Project name: qemu
>> Project version: 8.1.50
>> C compiler for the host machine: cc -m64 -mcx16 (gcc 7.5.0 "cc (nb4
>> 20200810) 7.5.0")
>> C linker for the host machine: cc -m64 -mcx16 ld.bfd 2.31.1
>> [...]
>> Run-time dependency capstone found: YES 4.0.2
>> Library fdt found: NO
>> Initialized empty Git repository in
>> /home/qemu/qemu-test.Li0spd/src/subprojects/dtc/.git/
>> fatal: unable to access 'https://gitlab.com/qemu-project/dtc.git/': SSL
>> certificate problem: unable to get local issuer certificate
>>
>> ../src/meson.build:3076:4: ERROR: Git command failed: ['/usr/pkg/bin/git',
>> 'fetch', '--depth', '1', 'origin',
>> 'b6910bec11614980a21e46fbccc35934b671bd81']
>>
>> A full log can be found at
>> /home/qemu/qemu-test.Li0spd/build/meson-logs/meson-log.txt
>>
>> ERROR: meson setup failed
>>
>> ... so though the NetBSD people finally upgraded their dtc to a usable
>> level, our meson.build seems to be unable to detect it?
> 
> They claim to have version 1.7.0
> 
>    https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/sysutils/dtc/index.html
> 
> and we claim to want 1.5.0, so should be OK.
> 
> Suggests that our detection, or test compilation is failing. The
> meson-log.txt might have more info, if you can access that ?

Look like libfdt is installed there in an unusual location?
I can make it work with this patch on top:

diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index fdf8064cef..2ccc7f2cdd 100755
--- a/tests/vm/netbsd
+++ b/tests/vm/netbsd
@@ -69,8 +69,9 @@ class NetBSDVM(basevm.BaseVM):
          cd $(mktemp -d /home/qemu/qemu-test.XXXXXX);
          mkdir src build; cd src;
          tar -xf /dev/rld1a;
-        cd ../build
-        ../src/configure --disable-opengl {configure_opts};
+        cd ../build;
+        ../src/configure --disable-opengl --extra-ldflags=-L/usr/pkg/lib \
+                         --extra-cflags=-I/usr/pkg/include {configure_opts};
          gmake --output-sync -j{jobs} {target} {verbose};
      """
      poweroff = "/sbin/poweroff"

Could you add that to your patch, Paolo?

  Thanks,
   Thomas


Re: [PATCH] tests/vm: netbsd: install dtc
Posted by Paolo Bonzini 7 months ago
On Mon, Oct 16, 2023 at 11:21 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 16/10/2023 11.06, Daniel P. Berrangé wrote:
> > On Mon, Oct 16, 2023 at 11:00:14AM +0200, Thomas Huth wrote:
> >> On 13/10/2023 17.30, Paolo Bonzini wrote:
> >>> Install dtc as it is now a mandatory external dependency in order to build QEMU.
> >>>
> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>> ---
> >>>    tests/vm/netbsd | 3 +++
> >>>    1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> >>> index 939dc1b22a1..3ef1ec2d9cc 100755
> >>> --- a/tests/vm/netbsd
> >>> +++ b/tests/vm/netbsd
> >>> @@ -40,6 +40,9 @@ class NetBSDVM(basevm.BaseVM):
> >>>            "gsed",
> >>>            "gettext-tools",
> >>> +        # libs: basic
> >>> +        "dtc",
> >>> +
> >>>            # libs: crypto
> >>>            "gnutls",
> >>
> >> Does this work for you? When I run "make vm-build-netbsd", I'm still getting
> >> a failure:
> >>
> >> 76 packages to install:
> >>    git-base-2.41.0nb1 pkgconf-1.9.5 xz-5.4.3 python310-3.10.12
> >> py310-expat-3.10.12nb1 ninja-build-1.11.1
> >>    bash-5.2.15 gmake-4.4.1 gsed-4.9nb1 gettext-tools-0.21.1 dtc-1.7.0
> >> gnutls-3.8.0nb3 jpeg-9e png-1.6.39
> >>    capstone-4.0.2 SDL2-2.26.5nb1 gtk3+-3.24.38 zstd-1.5.5 libslirp-4.7.0nb1
> >> pcre2-10.42 curl-8.1.2
> >>    libuuid-2.32.1nb1 libffi-3.4.4 gettext-lib-0.21.1 p11-kit-0.24.1 nettle-3.9.1
> >>    mozilla-rootcerts-1.0.20230505 libtasn1-4.19.0 libcfg+-0.7.0 gmp-6.2.1nb3
> >> wayland-protocols-1.31nb1
> >>    wayland-1.21.0nb2 libxkbcommon-1.5.0nb1 libsamplerate-0.2.2nb4
> >> shared-mime-info-2.2nb2 pango-1.50.12nb1
> >>    libcups-2.4.6nb1 libXft-2.3.8 hicolor-icon-theme-0.17nb1 glib2-2.74.6nb1
> >> gdk-pixbuf2-2.42.10nb2
> >>    fribidi-1.0.13 freetype2-2.13.0nb1 fontconfig-2.14.2nb1
> >> cairo-gobject-1.16.0nb7 cairo-1.16.0nb9 atk-2.38.0
> >>    at-spi2-atk-2.38.0nb1 lz4-1.9.4 nghttp2-1.54.0 libidn2-2.3.4
> >> readline-8.2nb2 libsndfile-1.2.0nb2
> >>    fftw-3.3.10nb1 libxslt-1.1.38 libepoll-shim-0.0.20230411
> >> at-spi2-core-2.40.3nb2 lzo-2.10 brotli-1.0.9
> >>    tiff-4.5.1nb1 libpaper-2.1.0nb2 dbus-1.14.6 harfbuzz-7.3.0
> >> graphite2-1.3.14nb1 libunistring-1.1
> >>    libxml2-2.10.4nb1 libgcrypt-1.10.2 mpg123-1.31.3 libvorbis-1.3.7
> >> libopus-1.4 libogg-1.3.5nb1 lame-3.100nb5
> >>    flac-1.4.2 jbigkit-2.1nb1 xmlcatmgr-2.2nb1 libgpg-error-1.47
> >> [...]
> >> installing dtc-1.7.0...
> >> [...]
> >> The Meson build system
> >> Version: 0.63.3
> >> Source dir: /home/qemu/qemu-test.Li0spd/src
> >> Build dir: /home/qemu/qemu-test.Li0spd/build
> >> Build type: native build
> >> Project name: qemu
> >> Project version: 8.1.50
> >> C compiler for the host machine: cc -m64 -mcx16 (gcc 7.5.0 "cc (nb4
> >> 20200810) 7.5.0")
> >> C linker for the host machine: cc -m64 -mcx16 ld.bfd 2.31.1
> >> [...]
> >> Run-time dependency capstone found: YES 4.0.2
> >> Library fdt found: NO
> >> Initialized empty Git repository in
> >> /home/qemu/qemu-test.Li0spd/src/subprojects/dtc/.git/
> >> fatal: unable to access 'https://gitlab.com/qemu-project/dtc.git/': SSL
> >> certificate problem: unable to get local issuer certificate
> >>
> >> ../src/meson.build:3076:4: ERROR: Git command failed: ['/usr/pkg/bin/git',
> >> 'fetch', '--depth', '1', 'origin',
> >> 'b6910bec11614980a21e46fbccc35934b671bd81']
> >>
> >> A full log can be found at
> >> /home/qemu/qemu-test.Li0spd/build/meson-logs/meson-log.txt
> >>
> >> ERROR: meson setup failed
> >>
> >> ... so though the NetBSD people finally upgraded their dtc to a usable
> >> level, our meson.build seems to be unable to detect it?
> >
> > They claim to have version 1.7.0
> >
> >    https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/sysutils/dtc/index.html
> >
> > and we claim to want 1.5.0, so should be OK.
> >
> > Suggests that our detection, or test compilation is failing. The
> > meson-log.txt might have more info, if you can access that ?
>
> Look like libfdt is installed there in an unusual location?

Indeed, and it looks like it's intentional; from https://pkgin.net/,
for example:

> Invoke the configure script, for example:
>
> $ ./configure --prefix=/usr/pkg --with-libraries=/usr/pkg/lib --with-includes=/usr/pkg/include
>
> And finally build the binary:
>
> $ make

Paolo
Re: [PATCH] tests/vm: netbsd: install dtc
Posted by Daniel P. Berrangé 7 months ago
On Mon, Oct 16, 2023 at 10:06:11AM +0100, Daniel P. Berrangé wrote:
> On Mon, Oct 16, 2023 at 11:00:14AM +0200, Thomas Huth wrote:
> > On 13/10/2023 17.30, Paolo Bonzini wrote:
> > > Install dtc as it is now a mandatory external dependency in order to build QEMU.
> > > 
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > ---
> > >   tests/vm/netbsd | 3 +++
> > >   1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> > > index 939dc1b22a1..3ef1ec2d9cc 100755
> > > --- a/tests/vm/netbsd
> > > +++ b/tests/vm/netbsd
> > > @@ -40,6 +40,9 @@ class NetBSDVM(basevm.BaseVM):
> > >           "gsed",
> > >           "gettext-tools",
> > > +        # libs: basic
> > > +        "dtc",
> > > +
> > >           # libs: crypto
> > >           "gnutls",
> > 
> > Does this work for you? When I run "make vm-build-netbsd", I'm still getting
> > a failure:

snip

> > Library fdt found: NO
> > Initialized empty Git repository in
> > /home/qemu/qemu-test.Li0spd/src/subprojects/dtc/.git/
> > fatal: unable to access 'https://gitlab.com/qemu-project/dtc.git/': SSL
> > certificate problem: unable to get local issuer certificate
> > 
> > ../src/meson.build:3076:4: ERROR: Git command failed: ['/usr/pkg/bin/git',
> > 'fetch', '--depth', '1', 'origin',
> > 'b6910bec11614980a21e46fbccc35934b671bd81']
> > 
> > A full log can be found at
> > /home/qemu/qemu-test.Li0spd/build/meson-logs/meson-log.txt
> > 
> > ERROR: meson setup failed
> > 
> > ... so though the NetBSD people finally upgraded their dtc to a usable
> > level, our meson.build seems to be unable to detect it?
> 
> They claim to have version 1.7.0
> 
>   https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/sysutils/dtc/index.html
> 
> and we claim to want 1.5.0, so should be OK.
> 
> Suggests that our detection, or test compilation is failing. The
> meson-log.txt might have more info, if you can access that ?
> 
> 
> Also separately it appears we're missing the public CA cert bundle,
> so we should not see a cert error from gitlab.

The latter is presumably solvable with this:

  https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/security/ca-certificates/index.html


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH] tests/vm: netbsd: install dtc
Posted by Philippe Mathieu-Daudé 7 months ago
On 13/10/23 17:30, Paolo Bonzini wrote:
> Install dtc as it is now a mandatory external dependency in order to build QEMU.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   tests/vm/netbsd | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>