cpus: Remove unused smp_cores/smp_threads declarations

[PATCH] cpus: Remove unused smp_cores/smp_threads declarations

Philippe Mathieu-Daudé posted 1 patch 7 months, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231009090952.48207-1-philmd@linaro.org

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>

include/sysemu/cpus.h | 7 -------
1 file changed, 7 deletions(-)

Expand all Fold all

[PATCH] cpus: Remove unused smp_cores/smp_threads declarations

Posted by Philippe Mathieu-Daudé 7 months, 1 week ago

Commit a5e0b33119 ("vl.c: Replace smp global variables
with smp machine properties") removed the last uses of
the smp_cores / smp_threads variables but forgot to
remove their declarations. Do it now.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/sysemu/cpus.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h
index 0535a4c68a..b4a566cfe7 100644
--- a/include/sysemu/cpus.h
+++ b/include/sysemu/cpus.h
@@ -50,11 +50,4 @@ void cpu_synchronize_all_post_reset(void);
 void cpu_synchronize_all_post_init(void);
 void cpu_synchronize_all_pre_loadvm(void);
 
-#ifndef CONFIG_USER_ONLY
-/* vl.c */
-/* *-user doesn't have configurable SMP topology */
-extern int smp_cores;
-extern int smp_threads;
-#endif
-
 #endif
-- 
2.41.0

Re: [PATCH] cpus: Remove unused smp_cores/smp_threads declarations

Posted by Michael Tokarev 7 months, 1 week ago

09.10.2023 12:09, Philippe Mathieu-Daudé:
> Commit a5e0b33119 ("vl.c: Replace smp global variables
> with smp machine properties") removed the last uses of
> the smp_cores / smp_threads variables but forgot to
> remove their declarations. Do it now.

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

Applied to my trivial-patches branch.

/mjt

> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/sysemu/cpus.h | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h
> index 0535a4c68a..b4a566cfe7 100644
> --- a/include/sysemu/cpus.h
> +++ b/include/sysemu/cpus.h
> @@ -50,11 +50,4 @@ void cpu_synchronize_all_post_reset(void);
>   void cpu_synchronize_all_post_init(void);
>   void cpu_synchronize_all_pre_loadvm(void);
>   
> -#ifndef CONFIG_USER_ONLY
> -/* vl.c */
> -/* *-user doesn't have configurable SMP topology */
> -extern int smp_cores;
> -extern int smp_threads;
> -#endif
> -
>   #endif