From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

Implement RAMFB migration, and add properties to enable it only on >= 8.2
machines, + a few related cleanups.

thanks

v5:
- add missing VMSTATE_END_OF_LIST
- changed ramfb=off & x-mig=on user config error to a warning
- add r-b tags

v4: (Laszlo review and suggestions)
- change migrate_needed() to assert(ramfb_exists)
- rename vfio_display_needed() to vfio_display_migration_needed(),
  update the condition and associated comment
- move the ramfb-migrate option check and add a check for ramfb=on
- add a stub to fix compilation on some architectures

v3:
- add a "x-" prefix to properties, as they are not meant for users.
- RAMFB now exports a ramfb_vmstate for actual devices to include
- VFIOPCIDevice now has a VFIODisplay optional subsection whenever ramfb
  migration is required (untested)

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1859424

Marc-André Lureau (3):
  ramfb: add migration support
  ramfb-standalone: add migration support
  hw/vfio: add ramfb migration support

 hw/vfio/pci.h                 |  3 +++
 include/hw/display/ramfb.h    |  4 ++++
 hw/core/machine.c             |  2 ++
 hw/display/ramfb-standalone.c | 27 +++++++++++++++++++++
 hw/display/ramfb.c            | 19 +++++++++++++++
 hw/vfio/display.c             | 21 +++++++++++++++++
 hw/vfio/pci.c                 | 44 +++++++++++++++++++++++++++++++++++
 stubs/ramfb.c                 |  2 ++
 8 files changed, 122 insertions(+)

-- 
2.41.0

Hello,

On 10/9/23 08:32, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> Implement RAMFB migration, and add properties to enable it only on >= 8.2
> machines, + a few related cleanups.

Should this series go in vfio-next ?

Thanks,

C.

> 
> thanks
> 
> v5:
> - add missing VMSTATE_END_OF_LIST
> - changed ramfb=off & x-mig=on user config error to a warning
> - add r-b tags
> 
> v4: (Laszlo review and suggestions)
> - change migrate_needed() to assert(ramfb_exists)
> - rename vfio_display_needed() to vfio_display_migration_needed(),
>    update the condition and associated comment
> - move the ramfb-migrate option check and add a check for ramfb=on
> - add a stub to fix compilation on some architectures
> 
> v3:
> - add a "x-" prefix to properties, as they are not meant for users.
> - RAMFB now exports a ramfb_vmstate for actual devices to include
> - VFIOPCIDevice now has a VFIODisplay optional subsection whenever ramfb
>    migration is required (untested)
> 
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1859424
> 
> Marc-André Lureau (3):
>    ramfb: add migration support
>    ramfb-standalone: add migration support
>    hw/vfio: add ramfb migration support
> 
>   hw/vfio/pci.h                 |  3 +++
>   include/hw/display/ramfb.h    |  4 ++++
>   hw/core/machine.c             |  2 ++
>   hw/display/ramfb-standalone.c | 27 +++++++++++++++++++++
>   hw/display/ramfb.c            | 19 +++++++++++++++
>   hw/vfio/display.c             | 21 +++++++++++++++++
>   hw/vfio/pci.c                 | 44 +++++++++++++++++++++++++++++++++++
>   stubs/ramfb.c                 |  2 ++
>   8 files changed, 122 insertions(+)
> 

Hi

On Tue, Oct 10, 2023 at 4:49 PM Cédric Le Goater <clg@redhat.com> wrote:
>
> Hello,
>
> On 10/9/23 08:32, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Hi,
> >
> > Implement RAMFB migration, and add properties to enable it only on >= 8.2
> > machines, + a few related cleanups.
>
> Should this series go in vfio-next ?
>

That's a good option for me.

thanks

-- 
Marc-André Lureau

On 10/10/23 15:46, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Oct 10, 2023 at 4:49 PM Cédric Le Goater <clg@redhat.com> wrote:
>>
>> Hello,
>>
>> On 10/9/23 08:32, marcandre.lureau@redhat.com wrote:
>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>
>>> Hi,
>>>
>>> Implement RAMFB migration, and add properties to enable it only on >= 8.2
>>> machines, + a few related cleanups.
>>
>> Should this series go in vfio-next ?
>>
> 
> That's a good option for me.

Gerd, fine with you ?

Thanks,

C.

On Wed, Oct 11, 2023 at 07:09:19PM +0200, Cédric Le Goater wrote:
> On 10/10/23 15:46, Marc-André Lureau wrote:
> > Hi
> > 
> > On Tue, Oct 10, 2023 at 4:49 PM Cédric Le Goater <clg@redhat.com> wrote:
> > > 
> > > Hello,
> > > 
> > > On 10/9/23 08:32, marcandre.lureau@redhat.com wrote:
> > > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > > 
> > > > Hi,
> > > > 
> > > > Implement RAMFB migration, and add properties to enable it only on >= 8.2
> > > > machines, + a few related cleanups.
> > > 
> > > Should this series go in vfio-next ?
> > > 
> > 
> > That's a good option for me.
> 
> Gerd, fine with you ?

Yes.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd

On 10/12/23 11:18, Gerd Hoffmann wrote:
> On Wed, Oct 11, 2023 at 07:09:19PM +0200, Cédric Le Goater wrote:
>> On 10/10/23 15:46, Marc-André Lureau wrote:
>>> Hi
>>>
>>> On Tue, Oct 10, 2023 at 4:49 PM Cédric Le Goater <clg@redhat.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> On 10/9/23 08:32, marcandre.lureau@redhat.com wrote:
>>>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>>>
>>>>> Hi,
>>>>>
>>>>> Implement RAMFB migration, and add properties to enable it only on >= 8.2
>>>>> machines, + a few related cleanups.
>>>>
>>>> Should this series go in vfio-next ?
>>>>
>>>
>>> That's a good option for me.
>>
>> Gerd, fine with you ?
> 
> Yes.
> 
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>



Thanks,

Applied to vfio-next.


C.