[PATCH v3 0/3] hexagon: GETPC() fixes, shadowing fixes

Brian Cain posted 3 patches 6 months, 4 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231008220945.983643-1-bcain@quicinc.com
Maintainers: Brian Cain <bcain@quicinc.com>
target/hexagon/genptr.c                 | 56 ++++++++---------
target/hexagon/genptr.h                 | 18 +++---
target/hexagon/imported/alu.idef        |  6 +-
target/hexagon/macros.h                 | 19 +++---
target/hexagon/mmvec/macros.h           |  2 +-
target/hexagon/mmvec/system_ext_mmvec.c |  4 +-
target/hexagon/mmvec/system_ext_mmvec.h |  2 +-
target/hexagon/op_helper.c              | 84 ++++++++++---------------
target/hexagon/op_helper.h              |  9 ---
target/hexagon/translate.c              | 10 +--
10 files changed, 90 insertions(+), 120 deletions(-)
[PATCH v3 0/3] hexagon: GETPC() fixes, shadowing fixes
Posted by Brian Cain 6 months, 4 weeks ago
Changes since v2:
    - rebased, suggested by Markus
        - s/cpu_env/tcg_env/
        - For local shadows: s/tcg_env/tcg_env_/

Brian Cain (2):
  target/hexagon: fix some occurrences of -Wshadow=local
  target/hexagon: avoid shadowing globals

Matheus Tavares Bernardino (1):
  target/hexagon: move GETPC() calls to top level helpers

 target/hexagon/genptr.c                 | 56 ++++++++---------
 target/hexagon/genptr.h                 | 18 +++---
 target/hexagon/imported/alu.idef        |  6 +-
 target/hexagon/macros.h                 | 19 +++---
 target/hexagon/mmvec/macros.h           |  2 +-
 target/hexagon/mmvec/system_ext_mmvec.c |  4 +-
 target/hexagon/mmvec/system_ext_mmvec.h |  2 +-
 target/hexagon/op_helper.c              | 84 ++++++++++---------------
 target/hexagon/op_helper.h              |  9 ---
 target/hexagon/translate.c              | 10 +--
 10 files changed, 90 insertions(+), 120 deletions(-)

-- 
2.25.1

Re: [PATCH v3 0/3] hexagon: GETPC() fixes, shadowing fixes
Posted by Markus Armbruster 6 months, 4 weeks ago
I applied this series to my shadow-next in my public Git repository at
https://repo.or.cz/qemu/armbru.git.  I don't intend to include it in
pull requests, because it does more than just fix -Wshadow issues.
Don't think that'll be a problem.

Thanks!