From nobody Sat May 18 14:09:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1696594132; cv=none; d=zohomail.com; s=zohoarc; b=bZB3aau7+/6gEgzHNfK7V4iNv6znc45JsToSsaEaAXdtk4Ryd1Gx4XLOwTeGGfJFjOU6gMRs83MnZvVNBaJyVxFcbE5zO3GarUySd1ML4/p3lsYiY4dlLIdNPASFQXtcBU8fMr83j8LYjEaDQ0jimdzARgM1BmP/1TdZtr0btk4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696594132; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=a2K/+pzxjEif0f90GXAXVbfTZ7ejU3iGPBuVbj4FO9M=; b=T6uu9I54IxP8c/l0gCmt2YHGUVComXCQJE5q/d5hXPq3pnFKOWOpPRk0mdtgWJRiqwuHl0khngicGo8S2e8WX1nTNUVVzepx8VGAHR4svBZxOlAM6kCtL+MwAi9P3vWm6jFvIlx2RskizG3PXFKCKgEEPQwEEnke0PXqk5hPhYk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696594132898809.7856186587737; Fri, 6 Oct 2023 05:08:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qojdG-00061I-ME; Fri, 06 Oct 2023 08:08:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qojdF-0005z7-85 for qemu-devel@nongnu.org; Fri, 06 Oct 2023 08:08:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qojdD-0000Ay-Jq for qemu-devel@nongnu.org; Fri, 06 Oct 2023 08:08:36 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-31-W7xTujt0MlWweaUjGr6XTA-1; Fri, 06 Oct 2023 08:08:21 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E1A9C101AA6D; Fri, 6 Oct 2023 12:08:20 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.195.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 03CC22156711; Fri, 6 Oct 2023 12:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696594113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=a2K/+pzxjEif0f90GXAXVbfTZ7ejU3iGPBuVbj4FO9M=; b=T12KDtSMCxo+ixFYtazW3fE9DGNCzAgd9y+iQATNKwHa4kBOP8e/6CuGuH20Ip2n/PaqbP DA86MsP26kBxq/EipOPOiK8o4T64pvstf4CHiISzioDcP5+DNEvD1XddKgT3JBiLaKV+2B AbjuToXQFlbi438EHLtoSRk+0pzdwgQ= X-MC-Unique: W7xTujt0MlWweaUjGr6XTA-1 From: Thomas Huth To: qemu-devel@nongnu.org, Xie Yongji Cc: qemu-trivial@nongnu.org, Markus Armbruster Subject: [PATCH] libvduse: Fix compiler warning with -Wshadow=local Date: Fri, 6 Oct 2023 14:08:19 +0200 Message-ID: <20231006120819.480792-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1696594133704100001 Content-Type: text/plain; charset="utf-8" No need to declare a new variable with the same name here, we can simple re-use the one from the top of the function. With this change, the file now compiles fine with -Wshadow=3Dlocal. Signed-off-by: Thomas Huth Reviewed-by: Xie Yongji --- subprojects/libvduse/libvduse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvduse/libvduse.c b/subprojects/libvduse/libvdus= e.c index 377959a0b4..21ffbb5b8d 100644 --- a/subprojects/libvduse/libvduse.c +++ b/subprojects/libvduse/libvduse.c @@ -1031,7 +1031,7 @@ int vduse_dev_handler(VduseDev *dev) /* The iova will be updated by iova_to_va() later, so just remove = it */ vduse_iova_remove_region(dev, req.iova.start, req.iova.last); for (i =3D 0; i < dev->num_queues; i++) { - VduseVirtq *vq =3D &dev->vqs[i]; + vq =3D &dev->vqs[i]; if (vq->ready) { if (vduse_queue_update_vring(vq, vq->vring.desc_addr, vq->vring.avail_addr, --=20 2.41.0