From nobody Sat May 18 12:47:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1696569165; cv=none; d=zohomail.com; s=zohoarc; b=fJ3u2kYT7mTY1gBk55LuItJw8jo2klPf8TQW4uEfHUPfp9KkaNQOJ/zmSOnqUW4wSC6TfrbTt+iWnuQkmoTvfD/PFVmi/zDW9MmnMsmOP+6Eksco6gjflWh0nUmeK+AT5Xempf9lV5YTyakkdwJSCu9DfNwAc5erZWX/C8s7hrA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696569165; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:Message-Id:Reply-To:To; bh=XNY5obo1lFRY1rzOM4EOFb12ZSNj3/8ms3FBcaRflBM=; b=JIYpsDN2rqNcOudUeb5HltpynNz3lYOXbZ/Sw1YawMALlEZriYWME3dRUnAefOR/btMR9MVdztaj+/fAVk3cDWm1ktWSihLs9UYDN0zrIr0p98aYCe16x7ZlFrYp6Q9v8n0gyPUBaghS5UEwuJN4bYDnCIPD9IYOK5k6wsUNX40= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696569165663354.3922141579052; Thu, 5 Oct 2023 22:12:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qod7k-0006L7-V3; Fri, 06 Oct 2023 01:11:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qod7j-0006Ip-7J for qemu-devel@nongnu.org; Fri, 06 Oct 2023 01:11:39 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qod7g-0003md-9H for qemu-devel@nongnu.org; Fri, 06 Oct 2023 01:11:38 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-692a885f129so1456205b3a.0 for ; Thu, 05 Oct 2023 22:11:35 -0700 (PDT) Received: from localhost ([2400:4050:a840:1e00:78d2:b862:10a7:d486]) by smtp.gmail.com with UTF8SMTPSA id je12-20020a170903264c00b001c74876f018sm2765782plb.18.2023.10.05.22.11.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 22:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1696569094; x=1697173894; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XNY5obo1lFRY1rzOM4EOFb12ZSNj3/8ms3FBcaRflBM=; b=rgncR7yomLvNjudP7oAHqzgjuzDxjZNfeUf48oz1uFZGDZQcBF8MMnb8cdPy2SXNcG eYV7EavFokG0QmUcVqAI3j9xvk509zvCrOITokHME/TtijB86+i9Pk11Isec9x8kyKX3 65EusaJ3rFkb5wHLTiMfgTy+T91RU5eA5Kn6r0crFcDF2XsgwfSJkBSvcXceaEeQ4lth uiVc1w1ZflgsXYpMNZPsr6yExofwgppEK2K8EG63JqFY/u+WM5nvbM6JopwE+qtUMBlp f561MiK+g/OblFnCyGnXWQ6zMWhxVc+2iczm34RjcrGpWNgdIGomhnttUWRfOvEP70Xj YL5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696569094; x=1697173894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XNY5obo1lFRY1rzOM4EOFb12ZSNj3/8ms3FBcaRflBM=; b=IDUvUGLGBM4hSh7bLlEHT2FVTnRmXD0R5+6LtgI+pBwz/1frR1zDgdj7miuJHbfX5F 5g6/Voipi/EnjIpgWIDmPdrChNzAYPgJg8OdCP8vml5z3tp2FboB408ggseRDur8YF6D VDPpUbpz9XbEXlqdvpwP0oRzZiauT3hiIcB/CHWMIwIgB2TuMDTp/mF164iaHzMqTKJg tX28TBDcX1CIlq1LpG9FEzRy6DCaZkNSWJo4igVWCPCZ/vZeUqssPIA3GIfItmkL7Q2U 6lD7jMnx2sXWY4NuYKs6x7jUxIBacLL7Lvp/6x7iqkI8QEvT7gVn17DqSWBu7wo67KLz OfEg== X-Gm-Message-State: AOJu0Yx2lpTK8vriw3XsGpNCBj4MVDRs0sAeHeY2jkwt7kbc0265r9ON dLMmJUEdgQ9NDFPpOw5NITeuzQ== X-Google-Smtp-Source: AGHT+IFNj98Wvv8nqMfMxMGWxi75GPaVxxJkJ/LSdE9WNy5dLVN6WAxo1CyXZ+K5J2qtqlmPbTpZSA== X-Received: by 2002:a05:6a20:7f96:b0:131:b3fa:eaaa with SMTP id d22-20020a056a207f9600b00131b3faeaaamr8371535pzj.61.1696569094350; Thu, 05 Oct 2023 22:11:34 -0700 (PDT) From: Akihiko Odaki To: Cc: Akihiko Odaki , Jason Wang , Stefan Weil , qemu-devel@nongnu.org (open list:All patches CC here) Subject: [PATCH] tap-win32: Remove unnecessary stubs Date: Fri, 6 Oct 2023 14:11:26 +0900 Message-ID: <20231006051127.5429-1-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::42b; envelope-from=akihiko.odaki@daynix.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1696569167866100007 Content-Type: text/plain; charset="utf-8" Some of them are only necessary for POSIX systems. The others are assigned to function pointers in NetClientInfo that can actually be NULL. Signed-off-by: Akihiko Odaki --- net/tap-win32.c | 54 ------------------------------------------------- 1 file changed, 54 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index f327d62ab0..7edbd71633 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -707,70 +707,16 @@ static void tap_win32_send(void *opaque) } } =20 -static bool tap_has_ufo(NetClientState *nc) -{ - return false; -} - -static bool tap_has_vnet_hdr(NetClientState *nc) -{ - return false; -} - -int tap_probe_vnet_hdr_len(int fd, int len) -{ - return 0; -} - -void tap_fd_set_vnet_hdr_len(int fd, int len) -{ -} - -int tap_fd_set_vnet_le(int fd, int is_le) -{ - return -EINVAL; -} - -int tap_fd_set_vnet_be(int fd, int is_be) -{ - return -EINVAL; -} - -static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr) -{ -} - -static void tap_set_offload(NetClientState *nc, int csum, int tso4, - int tso6, int ecn, int ufo) -{ -} - struct vhost_net *tap_get_vhost_net(NetClientState *nc) { return NULL; } =20 -static bool tap_has_vnet_hdr_len(NetClientState *nc, int len) -{ - return false; -} - -static void tap_set_vnet_hdr_len(NetClientState *nc, int len) -{ - abort(); -} - static NetClientInfo net_tap_win32_info =3D { .type =3D NET_CLIENT_DRIVER_TAP, .size =3D sizeof(TAPState), .receive =3D tap_receive, .cleanup =3D tap_cleanup, - .has_ufo =3D tap_has_ufo, - .has_vnet_hdr =3D tap_has_vnet_hdr, - .has_vnet_hdr_len =3D tap_has_vnet_hdr_len, - .using_vnet_hdr =3D tap_using_vnet_hdr, - .set_offload =3D tap_set_offload, - .set_vnet_hdr_len =3D tap_set_vnet_hdr_len, }; =20 static int tap_win32_init(NetClientState *peer, const char *model, --=20 2.42.0