From nobody Sat May 18 15:49:42 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1696540342; cv=none; d=zohomail.com; s=zohoarc; b=QkZaolLPiNx2cfSat1H7M2GHUqTBAL/1nla5ZgPcR4ueg6T3HwCMbGUnHD+w8JK6R9dq9oFpAGhUD+NBCodY5XS2/Xtr3P/BiOVJIC1DiAADGDBmS7LHNXboAIBCJzYvqpBBjZN2moL0eCx06VGPlHJFtWo0lZiy05xn649Y9lU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696540342; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lwu3eN0Rpykt3SD/z0yvog3s4BNg5OcSN1ci1NjJI20=; b=V4EToHjFyroBt6kIo0ShvZX4DK7QiYSwF2IiGg4+JTr3xmoQkzoRAWoIrq19yq5xGm99pN0h5fkh+SCVvg2E0133bOx2jMWl8UcxiU4cxUDU0sHcNfNsmUDYuyYfvLs4A9/+d9awcxvrnGAjCrt8bpcuFdMJkdtrwZC7htQhQaY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696540342372940.4831563822507; Thu, 5 Oct 2023 14:12:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoVdH-0004Zr-Aw; Thu, 05 Oct 2023 17:11:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoVdF-0004YE-69; Thu, 05 Oct 2023 17:11:41 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoVdC-0005hy-26; Thu, 05 Oct 2023 17:11:40 -0400 Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 395KKZr1017939; Thu, 5 Oct 2023 21:11:08 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tj43d1g3b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 21:11:07 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 395KugRW025087; Thu, 5 Oct 2023 21:11:06 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3texd0496p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 21:11:06 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 395LB5Oo63570340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Oct 2023 21:11:05 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 805BA58059; Thu, 5 Oct 2023 21:11:05 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 72FE258061; Thu, 5 Oct 2023 21:11:05 +0000 (GMT) Received: from mamboa4.aus.stglabs.ibm.com (unknown [9.3.84.87]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Thu, 5 Oct 2023 21:11:05 +0000 (GMT) Received: from mamboa4.aus.stglabs.ibm.com (localhost [127.0.0.1]) by mamboa4.aus.stglabs.ibm.com (Postfix) with ESMTPS id A1B0616A0848; Thu, 5 Oct 2023 16:11:04 -0500 (CDT) Received: (from mglenn@localhost) by mamboa4.aus.stglabs.ibm.com (8.15.2/8.15.2/Submit) id 395LB37Q3609625; Thu, 5 Oct 2023 16:11:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=lwu3eN0Rpykt3SD/z0yvog3s4BNg5OcSN1ci1NjJI20=; b=shFhpRKOQDvVH/tt1NrLrhZfUnx9xSqGN98Uogdj4tTSltIWiX9SvyJVjLskVHUs9Gi/ 2l6wIjMTXx5uj8mdY2BXD9Yi6WRi1hnhKRgw8HQ2ZYlkTk2aX519zbdg0xpJnjP02cgz cO42ZgC2zEamwFt/I3Zdjrr2bIsasREqZbqac0X46DbJ7vrInOmz7XMJHyHYFinurDBC Opvm2WlMqGj7MDhDpK/6UYhAUBkAiRpp5KT/klIQommhIOWrsbbkSgDFvBJSkFRujHWz jV55oljSmP5I46Uohawod9uXcOjZIo/JIluZD82lzbRVsCuaW4H/d2bgGRk464uP8QA2 ZA== From: Glenn Miles To: qemu-devel@nongnu.org Cc: Glenn Miles , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , andrew@codeconstruct.com.au, Joel Stanley Subject: [PATCH v2] misc/pca9552: Fix for pca9552 not getting reset Date: Thu, 5 Oct 2023 16:10:46 -0500 Message-Id: <20231005211046.3609577-1-milesg@linux.vnet.ibm.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: kmHr3jzMgs6_0LPyleF9upy2lHInkDzB X-Proofpoint-ORIG-GUID: kmHr3jzMgs6_0LPyleF9upy2lHInkDzB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-05_15,2023-10-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 clxscore=1015 mlxlogscore=999 spamscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 impostorscore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310050160 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=148.163.158.5; envelope-from=mglenn@mamboa4.aus.stglabs.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1696540343567100001 Content-Type: text/plain; charset="utf-8" Testing of the pca9552 device on the powernv platform showed that the reset method was not being called when an instance of the device was realized. This was causing the INPUT0/INPUT1 POR values to be incorrect. Fixed by overriding the parent pca955x_realize method with a new pca9552_realize method which first calls the parent pca955x_realize method followed by the pca9552_reset function. Signed-off-by: Glenn Miles --- hw/misc/pca9552.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c index fff19e369a..bc12dced7f 100644 --- a/hw/misc/pca9552.c +++ b/hw/misc/pca9552.c @@ -384,6 +384,12 @@ static void pca955x_realize(DeviceState *dev, Error **= errp) qdev_init_gpio_out(dev, s->gpio, k->pin_count); } =20 +static void pca9552_realize(DeviceState *dev, Error **errp) +{ + pca955x_realize(dev, errp); + pca9552_reset(dev); +} + static Property pca955x_properties[] =3D { DEFINE_PROP_STRING("description", PCA955xState, description), DEFINE_PROP_END_OF_LIST(), @@ -416,7 +422,7 @@ static void pca9552_class_init(ObjectClass *oc, void *d= ata) DeviceClass *dc =3D DEVICE_CLASS(oc); PCA955xClass *pc =3D PCA955X_CLASS(oc); =20 - dc->reset =3D pca9552_reset; + dc->realize =3D pca9552_realize; dc->vmsd =3D &pca9552_vmstate; pc->max_reg =3D PCA9552_LS3; pc->pin_count =3D 16; --=20 2.31.1