From nobody Sat May 18 16:17:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1696538597; cv=none; d=zohomail.com; s=zohoarc; b=Kg0QYLqCRi3h7qvo89a03P9OqhjsOylukKD7WBQdJDU+FK7b++0xuleSZxg9hJr04xXLEaEPJ0yRms+XCl33UEN9mcNDOPD3dBZSgPP92ZXOA7EnoKNRTPPqjdgFwncsfBytZp2RjNeYRxl9/xAjMrSbzDN7FpSbpNmlAtoyEqs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696538597; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qBTyIjkX0FsTY0uSX1euWarZaz2rnIXwWz2NVHKjHdA=; b=kyArAIoITb3lhQjr++cxm21AieAjLyppgW/F96oXB2kyl4czVFxXZjUpjTiSEEd6u1HzYX4A+Ehb1lLrZ0OYtiIlM0TkHzWzMJ1fW16OOP2YN3Cbq0Ixfx3RxAD479/M4AtlYkQr6ZPOTYqqHJzL9sAlCKdgecxpd/ckzSNNhRk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696538597257690.9466371526155; Thu, 5 Oct 2023 13:43:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoVBc-0004XR-1N; Thu, 05 Oct 2023 16:43:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoVBY-0004RG-21 for qemu-devel@nongnu.org; Thu, 05 Oct 2023 16:43:05 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoVBW-0006Se-F2 for qemu-devel@nongnu.org; Thu, 05 Oct 2023 16:43:03 -0400 Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 395KYNlq020124; Thu, 5 Oct 2023 20:42:33 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tj438gbgp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 20:42:32 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 395KKsOh007437; Thu, 5 Oct 2023 20:42:32 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3teygmbaag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 20:42:32 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 395KgV0i21824216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Oct 2023 20:42:31 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B4A15806B; Thu, 5 Oct 2023 20:42:31 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8AFA358069; Thu, 5 Oct 2023 20:42:31 +0000 (GMT) Received: from mamboa4.aus.stglabs.ibm.com (unknown [9.3.84.87]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTPS; Thu, 5 Oct 2023 20:42:31 +0000 (GMT) Received: from mamboa4.aus.stglabs.ibm.com (localhost [127.0.0.1]) by mamboa4.aus.stglabs.ibm.com (Postfix) with ESMTPS id 0A3EC16A0848; Thu, 5 Oct 2023 15:42:31 -0500 (CDT) Received: (from mglenn@localhost) by mamboa4.aus.stglabs.ibm.com (8.15.2/8.15.2/Submit) id 395KgUVc3523027; Thu, 5 Oct 2023 15:42:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=qBTyIjkX0FsTY0uSX1euWarZaz2rnIXwWz2NVHKjHdA=; b=YCb1epPQkNsFaCPcJ+U4skHnJeslcQ6T/jWCRYTf2f8EeG00OLYEyq32KvQoWoTMSwyT VX8f7vRamg9yQ5/cfLzp3jGCFq6yjhTeCiGfjiu5dLZHkR3Z4GGTQy85B+dSch546iGU dnM7iX4OgsYXOs+qojColrtGKSY3rsho7qzbdKMdUP2FAyKr7oRJ7XLHXPARtpdF5k3A fEJwYqjf3M2SYEF5cpzj3npDA8Sm3EMeR2MZDE4haVKEycvMPfgTRMxFhN/enuA12CC5 bOaXGt+59KcmT0IMBtkMd7AF7nHK8rX1vUYf6NGcqRtwRJZRxsFALcgYvjuOa2zNVexl aw== From: Glenn Miles To: qemu-devel@nongnu.org Cc: Glenn Miles , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , andrew@codeconstruct.com.au, Joel Stanley Subject: [PATCH] misc/pca9552: Fix for pca9552 not getting reset Date: Thu, 5 Oct 2023 15:42:26 -0500 Message-Id: <20231005204226.3522978-1-milesg@linux.vnet.ibm.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: FTW6Xi2ZC-RLBRWD0VS8NW3z8OKTedXy X-Proofpoint-ORIG-GUID: FTW6Xi2ZC-RLBRWD0VS8NW3z8OKTedXy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-05_15,2023-10-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310050157 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=148.163.158.5; envelope-from=mglenn@mamboa4.aus.stglabs.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1696538598830100001 Content-Type: text/plain; charset="utf-8" Testing of the pca9552 device on the powernv platform showed that the reset method was not being called when an instance of the device was realized. This was causing the INPUT0/INPUT1 POR values to be incorrect. Fixed by calling pca9552_reset from within the pca9552_realize method. Signed-off-by: Glenn Miles --- hw/misc/pca9552.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c index f28b5ecd7e..4e198af137 100644 --- a/hw/misc/pca9552.c +++ b/hw/misc/pca9552.c @@ -418,6 +418,12 @@ static void pca955x_realize(DeviceState *dev, Error **= errp) qdev_init_gpio_in(dev, pca955x_gpio_in_handler, k->pin_count); } =20 +static void pca9552_realize(DeviceState *dev, Error **errp) +{ + pca955x_realize(dev, errp); + pca9552_reset(dev); +} + static Property pca955x_properties[] =3D { DEFINE_PROP_STRING("description", PCA955xState, description), DEFINE_PROP_END_OF_LIST(), @@ -450,7 +456,7 @@ static void pca9552_class_init(ObjectClass *oc, void *d= ata) DeviceClass *dc =3D DEVICE_CLASS(oc); PCA955xClass *pc =3D PCA955X_CLASS(oc); =20 - dc->reset =3D pca9552_reset; + dc->realize =3D pca9552_realize; dc->vmsd =3D &pca9552_vmstate; pc->max_reg =3D PCA9552_LS3; pc->pin_count =3D 16; --=20 2.31.1