From nobody Mon May 20 19:42:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1696498268; cv=none; d=zohomail.com; s=zohoarc; b=IYDZk0jvOh8ti19ShUaDeXk6zUqsxZ8NiHkGX3JsUq3YQCh9X4QNCQMKUbwuL0U+oSaFIHZNSOZm0ELnUN7BUPiU6BeoqMjyDHpfeTDAC2ngX60okWY7XB+xkOvCzkd6kc2YFe+RGjBn/hcIFsukvUiUwuPh+Nfba0jkYzVY9uA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696498268; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zpIP28cEqxYdagHQ8Cy7MX2T3ULympF8csjZDoMQXhw=; b=Tu5hO+t0iHyfBWBpoAYx8fWIzoxhkog/2JaSNblpg0PQcaRdq/V1K3vHQG0M7vtcRvDbjFwbAnvJLLRycuNR5jqAT/63r5afFjHKgjzDN4MDEZvw8NtKeybICci90ckIdYwpUL3cTUrheMWkJZi77YDnOB/2ea8UhwTKRFBhJVU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696498268174926.5028528959687; Thu, 5 Oct 2023 02:31:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoKgB-0007zI-Ic; Thu, 05 Oct 2023 05:29:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKg3-0007x5-VM for qemu-devel@nongnu.org; Thu, 05 Oct 2023 05:29:52 -0400 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKg0-0005PY-3U for qemu-devel@nongnu.org; Thu, 05 Oct 2023 05:29:51 -0400 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:750a:0:640:e46:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id E9A3A63686; Thu, 5 Oct 2023 12:29:41 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6b8:b081:b584::1:2f]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id RTUHmS4OouQ0-fEc7I1Vw; Thu, 05 Oct 2023 12:29:41 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1696498181; bh=zpIP28cEqxYdagHQ8Cy7MX2T3ULympF8csjZDoMQXhw=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=paCwgKGkVgd+7W9SfBz0njL5iSh/CNHK1qO/7EuDWmZNIlltJzjuhmwoOYlODjsjV AqUi+BZ9vwMQLCMq9RxxR8yWjKCxm5H6zmJACLhFG64Zd/6hB2xznKThJ+RwQkW72z tnKgyoMsPVjCh1BiGqY1iojrAuqQiR6Q2zT9kzWk= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Cc: armbru@redhat.com, eblake@redhat.com, eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, philmd@linaro.org, den-plotnikov@yandex-team.ru, vsementsov@yandex-team.ru, yc-core@yandex-team.ru Subject: [PATCH v8 1/4] qapi/qdev.json: unite DEVICE_* event data into single structure Date: Thu, 5 Oct 2023 12:29:23 +0300 Message-Id: <20231005092926.56231-2-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231005092926.56231-1-vsementsov@yandex-team.ru> References: <20231005092926.56231-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1696498269834100003 Content-Type: text/plain; charset="utf-8" DEVICE_DELETED and DEVICE_UNPLUG_GUEST_ERROR has equal data, let's refactor it to one structure. That also helps to add new events consistently. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/qdev.json | 43 +++++++++++++++++++++++++++++++------------ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/qapi/qdev.json b/qapi/qdev.json index 6bc5a733b8..2899fac837 100644 --- a/qapi/qdev.json +++ b/qapi/qdev.json @@ -116,6 +116,35 @@ ## { 'command': 'device_del', 'data': {'id': 'str'} } =20 +## +# @DeviceAndPath: +# +# In events we designate devices by both their ID (if the device has +# one) and QOM path. +# +# @device: the device's ID if it has one +# +# @path: the device's QOM path +# +# Since: 8.2 +## + +# Rationale +# +# Why we need ID? User specify ID in device_add command and in +# command line and expects same identifier in the event data. +# +# Why we need QOM path? Some devices don't have ID and we still want +# to emit events for them. +# +# So, we have a bit of redundancy, as QOM path for device that has +# ID is always /machine/peripheral/ID. But that's hard to change +# keeping both simple interface for most users and universality for +# the generic case. + +{ 'struct': 'DeviceAndPath', + 'data': { '*device': 'str', 'path': 'str' } } + ## # @DEVICE_DELETED: # @@ -124,10 +153,6 @@ # ID. Device removal can be initiated by the guest or by HMP/QMP # commands. # -# @device: the device's ID if it has one -# -# @path: the device's QOM path -# # Since: 1.5 # # Example: @@ -137,8 +162,7 @@ # "path": "/machine/peripheral/virtio-net-pci-0" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } ## -{ 'event': 'DEVICE_DELETED', - 'data': { '*device': 'str', 'path': 'str' } } +{ 'event': 'DEVICE_DELETED', 'data': 'DeviceAndPath' } =20 ## # @DEVICE_UNPLUG_GUEST_ERROR: @@ -146,10 +170,6 @@ # Emitted when a device hot unplug fails due to a guest reported # error. # -# @device: the device's ID if it has one -# -# @path: the device's QOM path -# # Since: 6.2 # # Example: @@ -159,5 +179,4 @@ # "path": "/machine/peripheral/core1" }, # "timestamp": { "seconds": 1615570772, "microseconds": 202844 } } ## -{ 'event': 'DEVICE_UNPLUG_GUEST_ERROR', - 'data': { '*device': 'str', 'path': 'str' } } +{ 'event': 'DEVICE_UNPLUG_GUEST_ERROR', 'data': 'DeviceAndPath' } --=20 2.34.1 From nobody Mon May 20 19:42:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1696498289; cv=none; d=zohomail.com; s=zohoarc; b=Zxaqmk5he44hWUHabDJ5BCTUt9dm8D5A5KQ3JDhlRpRFYsthyrZeFZTKEA0UTle0A3uToBr6cSuNDf9rNtit7+gGjVSwf8lv2MwxBCgO1D8fzvi/pL6B6yV1/8dsjSw2jn1mulzzwUnVJNcs6ebXXbTiFmr06a8eASmS45GvARA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696498289; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vjyNM5rgBbETNO58wKwSpPlBHifoQMdKu7WETHb7c/8=; b=dxRmwQx9HhTTa08YvRWCyp2wvGPCyc3PGTpiPd9KzCbv/d7nZgl9C1RKvEDglRR64XnyU0yvbZFttwwMfH2U31oDzp5ad/ugD6KN7uncAUd55MdsvbHpmsgLH6bKgw8EJsDpkepYnwqrAKTC3ZbUmK85t5VOVPpjX7hlqukvVzo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696498289008843.6062176091068; Thu, 5 Oct 2023 02:31:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoKg9-0007yn-VO; Thu, 05 Oct 2023 05:29:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKg4-0007xA-Sp for qemu-devel@nongnu.org; Thu, 05 Oct 2023 05:29:54 -0400 Received: from forwardcorp1c.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKfz-0005Pe-U9 for qemu-devel@nongnu.org; Thu, 05 Oct 2023 05:29:52 -0400 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:750a:0:640:e46:0]) by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id 2708962313; Thu, 5 Oct 2023 12:29:43 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6b8:b081:b584::1:2f]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id RTUHmS4OouQ0-op8czaXV; Thu, 05 Oct 2023 12:29:42 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1696498182; bh=vjyNM5rgBbETNO58wKwSpPlBHifoQMdKu7WETHb7c/8=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=BvM+gm2fixKeqNSTOhz5lpZIDrqJwe89YguEVrMDvsomQOemWtAOAUVDF8/KacU6U 4RTg0J1EhMl7bsBKiSB4V7RJ8O0MQX9z8Oj2AyEIzyxZsZeatd1ohK7J7bQ7M7EC95 wCdzzKMhoVCBvi+nC3yIiA9Bt41Ltc5/uD0ij6fg= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Cc: armbru@redhat.com, eblake@redhat.com, eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, philmd@linaro.org, den-plotnikov@yandex-team.ru, vsementsov@yandex-team.ru, yc-core@yandex-team.ru Subject: [PATCH v8 2/4] qapi: add DEVICE_ON and query-hotplug infrastructure Date: Thu, 5 Oct 2023 12:29:24 +0300 Message-Id: <20231005092926.56231-3-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231005092926.56231-1-vsementsov@yandex-team.ru> References: <20231005092926.56231-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1696498290577100003 Content-Type: text/plain; charset="utf-8" We have DEVICE_DELETED event, that signals that device_del command is actually completed. But we don't have a counter-part for device_add. Still it's sensible for SHPC and PCIe-native hotplug, as there are time when the device in some intermediate state. Let's add an event that say that the device is finally powered on, power indicator is on and everything is OK for next manipulation on that device. Motivations: 1. To be sure that device is "accepted" by guest. Guest may ignore hotplugged device for some reason (for example during OS booting). Management wants to catch this and handle the problem, instead of silent assume that everything is OK. So, if we don't get the event by some timeout, we can report an error, try to unplug/plug the disk again or do some other things to handle the problem. 2. The device can't be removed (by blockdev-del) while power indicator of hotplug controller is blinking (QEMU reports "guest is busy (power indicator blinking)"). So, management should avoid removing the device until it gets the DEVICE_ON event. (Probably, better solution for this point is to automatically postpone deletion until power indicator stops blinking) 3. Also, management tool may make a GUI visualization of power indicator with help of this event. New query-hotplug command in additon to "device-on" state also provides SHPC/PCIe-native specific hotplug controller properties (like leds) that may help to determine real state of hotplug controller. That may help to get additional information for further debugging when DEVICE_ON / DEVICE_DELETED not come in time as expected. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/core/hotplug.c | 12 ++++ include/hw/hotplug.h | 11 ++++ include/hw/qdev-core.h | 7 +++ include/monitor/qdev.h | 2 + qapi/qdev.json | 135 +++++++++++++++++++++++++++++++++++++++++ softmmu/qdev-monitor.c | 41 +++++++++++++ 6 files changed, 208 insertions(+) diff --git a/hw/core/hotplug.c b/hw/core/hotplug.c index 17ac986685..9651fe7c85 100644 --- a/hw/core/hotplug.c +++ b/hw/core/hotplug.c @@ -57,6 +57,18 @@ void hotplug_handler_unplug(HotplugHandler *plug_handler, } } =20 +HotplugInfo *hotplug_handler_get_state(HotplugHandler *plug_handler, + DeviceState *plugged_dev, Error **e= rrp) +{ + HotplugHandlerClass *hdc =3D HOTPLUG_HANDLER_GET_CLASS(plug_handler); + + if (hdc->get_hotplug_state) { + return hdc->get_hotplug_state(plug_handler, plugged_dev, errp); + } + + return NULL; +} + static const TypeInfo hotplug_handler_info =3D { .name =3D TYPE_HOTPLUG_HANDLER, .parent =3D TYPE_INTERFACE, diff --git a/include/hw/hotplug.h b/include/hw/hotplug.h index a9840ed485..23c57a0967 100644 --- a/include/hw/hotplug.h +++ b/include/hw/hotplug.h @@ -13,6 +13,7 @@ #define HOTPLUG_H =20 #include "qom/object.h" +#include "qapi/qapi-types-qdev.h" =20 #define TYPE_HOTPLUG_HANDLER "hotplug-handler" =20 @@ -60,6 +61,8 @@ struct HotplugHandlerClass { hotplug_fn unplug_request; hotplug_fn unplug; bool (*is_hotpluggable_bus)(HotplugHandler *plug_handler, BusState *bu= s); + HotplugInfo *(*get_hotplug_state)(HotplugHandler *plug_handler, + DeviceState *plugged_dev, Error **er= rp); }; =20 /** @@ -96,4 +99,12 @@ void hotplug_handler_unplug_request(HotplugHandler *plug= _handler, void hotplug_handler_unplug(HotplugHandler *plug_handler, DeviceState *plugged_dev, Error **errp); + +/** + * hotplug_handler_get_state: + * + * Calls #HotplugHandlerClass.get_hotplug_state callback of @plug_handler. + */ +HotplugInfo *hotplug_handler_get_state(HotplugHandler *plug_handler, + DeviceState *plugged_dev, Error **e= rrp); #endif diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 151d968238..a27ef2eb24 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -229,6 +229,13 @@ struct DeviceState { * @realized: has device been realized? */ bool realized; + + /** + * @device_on_event_sent: When true means that DEVICE_ON event was alr= eady + * sent. + */ + bool device_on_event_sent; + /** * @pending_deleted_event: track pending deletion events during unplug */ diff --git a/include/monitor/qdev.h b/include/monitor/qdev.h index 1d57bf6577..c1c8798e89 100644 --- a/include/monitor/qdev.h +++ b/include/monitor/qdev.h @@ -36,4 +36,6 @@ DeviceState *qdev_device_add_from_qdict(const QDict *opts, */ const char *qdev_set_id(DeviceState *dev, char *id, Error **errp); =20 +void qdev_hotplug_device_on_event(DeviceState *dev); + #endif diff --git a/qapi/qdev.json b/qapi/qdev.json index 2899fac837..fa80694735 100644 --- a/qapi/qdev.json +++ b/qapi/qdev.json @@ -180,3 +180,138 @@ # "timestamp": { "seconds": 1615570772, "microseconds": 202844 } } ## { 'event': 'DEVICE_UNPLUG_GUEST_ERROR', 'data': 'DeviceAndPath' } + +## +# @LedStatus: +# +# @on: LED is on. +# +# @blinking: LED is blinking. +# +# @off: LED is off. +# +# Since: 8.2 +## +{ 'enum': 'LedStatus', + 'data': [ 'on', 'blinking', 'off' ] } + +## +# @HotplugSHPCSlotState: +# +# Standard Hot-Plug Controller slot state. +# +# @power-only: Slot is powered on, but neither clock nor bus are +# connected. +# +# @enabled: Slot is powered on, clock and bus are connected, and the +# card is fully functional from a hardware standpoint. +# +# @disabled: Slot is disabled, card is safe to be removed. +# +# Since: 8.2 +## +{ 'enum': 'HotplugSHPCSlotState', + 'data': [ 'power-only', 'enabled', 'disabled' ] } + +## +# @HotplugSHPCState: +# +# Standard Hot Plug Controller state. +# +# @slot-state: The slot state field of SHPC Slot Status structure. +# +# Since: 8.2 +## +{ 'struct': 'HotplugSHPCState', + 'data': { '*slot-state': 'HotplugSHPCSlotState' } } + +## +# @HotplugPCIeNativeState: +# +# PCIe Native hotplug slot state. +# +# @power-on: PCIe Power Controller Control of Slot Control Register. +# True means Power On (Power Controller Control bit is 0), False +# means Power Off (Power Controller Control bit is 1). +# +# Since: 8.2 +## +{ 'struct': 'HotplugPCIeNativeState', + 'data': { '*power-on': 'bool' } } + +## +# @HotplugType: +# +# Type of hotplug controller / provider. +# +# @shpc: PCI Standard Hot-plug Controller +# +# @pcie-native: PCIe Native hotplug +# +# TODO: add @acpi type +# +# Since: 8.2 +## +{ 'enum': 'HotplugType', + 'data': ['shpc', 'pcie-native'] } + +## +# @HotplugInfo: +# +# Hotplug slot state. +# +# @type: type of the hotplug +# +# @bus: The QOM path of the parent bus where device is plugged into. +# +# @addr: The bus address for hotplugged device if applicable. +# +# @child: the hotplugged device +# +# @device-on: Device is powered-on by guest. This state changes at +# most once for the device and corresponds to DEVICE_ON event. +# +# @power-led: Power indicator. When power LED is on the device is +# ready and accepted by guest. When it is off, device is safe to +# remove. It is blinking while hot plug or unplug is in progress. +# +# @attention-led: The attention LED is normally off. It is on to +# signal a problem. Blinking is for helping users to locate the +# slot. +# +# Single: 8.2 +## +{ 'union': 'HotplugInfo', + 'base': { 'type': 'HotplugType', + 'bus': 'DeviceAndPath', + '*addr': 'str', + 'child': 'DeviceAndPath', + 'device-on': 'bool', + '*power-led': 'LedStatus', + '*attention-led': 'LedStatus'}, + 'discriminator': 'type', + 'data': { 'shpc': 'HotplugSHPCState', + 'pcie-native': 'HotplugPCIeNativeState' } } + +## +# @x-query-hotplug: +# +# Query the state of hotplug controller. +# +# @id: the device's ID or QOM path +# +# Since: 8.2 +## +{ 'command': 'x-query-hotplug', + 'data': { 'id': 'str' }, + 'returns': 'HotplugInfo' } + +## +# @X_DEVICE_ON: +# +# Emitted whenever the device insertion completion is acknowledged by +# the guest. For now only emitted for SHPC and PCIe-native hotplug. +# +# Since: 8.2 +## +{ 'event': 'X_DEVICE_ON', 'data': 'DeviceAndPath' } diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index 74f4e41338..483da40cb9 100644 --- a/softmmu/qdev-monitor.c +++ b/softmmu/qdev-monitor.c @@ -25,6 +25,7 @@ #include "sysemu/arch_init.h" #include "qapi/error.h" #include "qapi/qapi-commands-qdev.h" +#include "qapi/qapi-events-qdev.h" #include "qapi/qmp/dispatch.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qerror.h" @@ -956,6 +957,36 @@ void qmp_device_del(const char *id, Error **errp) } } =20 +HotplugInfo *qmp_x_query_hotplug(const char *id, Error **errp) +{ + DeviceState *dev =3D find_device_state(id, errp); + HotplugHandler *hotplug_ctrl; + + if (!dev) { + return NULL; + } + + if (dev->parent_bus && !qbus_is_hotpluggable(dev->parent_bus)) { + error_setg(errp, QERR_BUS_NO_HOTPLUG, dev->parent_bus->name); + return NULL; + } + + if (!DEVICE_GET_CLASS(dev)->hotpluggable) { + error_setg(errp, QERR_DEVICE_NO_HOTPLUG, + object_get_typename(OBJECT(dev))); + return NULL; + } + + hotplug_ctrl =3D qdev_get_hotplug_handler(dev); + /* + * hotpluggable device MUST have HotplugHandler, if it doesn't + * then something is very wrong with it. + */ + g_assert(hotplug_ctrl); + + return hotplug_handler_get_state(hotplug_ctrl, dev, errp); +} + void hmp_device_add(Monitor *mon, const QDict *qdict) { Error *err =3D NULL; @@ -1146,3 +1177,13 @@ bool qmp_command_available(const QmpCommand *cmd, Er= ror **errp) } return true; } + +void qdev_hotplug_device_on_event(DeviceState *dev) +{ + if (dev->device_on_event_sent) { + return; + } + + dev->device_on_event_sent =3D true; + qapi_event_send_x_device_on(dev->id, dev->canonical_path); +} --=20 2.34.1 From nobody Mon May 20 19:42:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1696498243; cv=none; d=zohomail.com; s=zohoarc; b=erhoYftlzL0ykf1iMwLSYtgw6LBl4uDRzjSHNtLjSMebFhzb7VVWKJhfkueoITbA7xz3HmYT26NHxzeYENQ/iMmJYFlkCyL5IWdDfOfABwPc70jpndWMT4u5/kT89zkdxZhW1dpJUIvRu6er9kX4cVavpWf5mfJn6vt94BubRpo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696498243; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sVWlS1/0qcLIlddVWR4IuZohwprYsqi9fOTE72G0Smk=; b=K0Y2urVUboeqguPn05Z5qXNqxutCqueaJLgcIoJTc7Bt7AY/cCiLa6NUw4OL1xL7UgL0IPjDNAm60Ogtd8xFzYEJwwLIPZLbkqQ1H22asLNqIlhLpPlekDen4wgswwvitkYgDQLoi8MJHfH6rEgFi81zM9MnrecCv01k5YG/rSU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696498243776705.0178048090826; Thu, 5 Oct 2023 02:30:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoKg9-0007ye-PL; Thu, 05 Oct 2023 05:29:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKg4-0007xB-TB for qemu-devel@nongnu.org; Thu, 05 Oct 2023 05:29:54 -0400 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKfz-0005Pm-TS for qemu-devel@nongnu.org; Thu, 05 Oct 2023 05:29:52 -0400 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:750a:0:640:e46:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 4FAE5605FD; Thu, 5 Oct 2023 12:29:44 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6b8:b081:b584::1:2f]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id RTUHmS4OouQ0-s8z5Z42t; Thu, 05 Oct 2023 12:29:43 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1696498183; bh=sVWlS1/0qcLIlddVWR4IuZohwprYsqi9fOTE72G0Smk=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=LO1KWpvHclMS7bV5pFiWjJ+rqYqiSFWQX3+ZsfCg8Q2U7YWbWk0dCPPHC3a2QYyei 3Y14kB5v9OhYvVXDiOL6BDQ1dUIu2knh0sJaHef2OXQgxq+IHaTTQ/QVquLxlz1tNP IFsqh36mYiQB4/h+Vi/MWauw11RHgSxUCCj7QREU= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Cc: armbru@redhat.com, eblake@redhat.com, eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, philmd@linaro.org, den-plotnikov@yandex-team.ru, vsementsov@yandex-team.ru, yc-core@yandex-team.ru Subject: [PATCH v8 3/4] shpc: implement DEVICE_ON event and query-hotplug Date: Thu, 5 Oct 2023 12:29:25 +0300 Message-Id: <20231005092926.56231-4-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231005092926.56231-1-vsementsov@yandex-team.ru> References: <20231005092926.56231-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1696498245337100001 Content-Type: text/plain; charset="utf-8" For PCIe and SHPC hotplug it's important to track led indicators and "device-on" status. At this step, implement the prepared infrastructure in SHPC. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/pci-bridge/pci_bridge_dev.c | 14 ++++++ hw/pci-bridge/pcie_pci_bridge.c | 1 + hw/pci/shpc.c | 86 +++++++++++++++++++++++++++++++++ include/hw/pci/pci_bridge.h | 2 + include/hw/pci/shpc.h | 2 + include/monitor/qdev.h | 4 ++ softmmu/qdev-monitor.c | 17 +++++++ 7 files changed, 126 insertions(+) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index 4b2696ea7f..69ffe93e2a 100644 --- a/hw/pci-bridge/pci_bridge_dev.c +++ b/hw/pci-bridge/pci_bridge_dev.c @@ -241,6 +241,19 @@ void pci_bridge_dev_unplug_request_cb(HotplugHandler *= hotplug_dev, shpc_device_unplug_request_cb(hotplug_dev, dev, errp); } =20 +HotplugInfo *pci_bridge_dev_get_hotplug_state(HotplugHandler *hotplug_dev, + DeviceState *dev, Error **er= rp) +{ + PCIDevice *pci_hotplug_dev =3D PCI_DEVICE(hotplug_dev); + + if (!shpc_present(pci_hotplug_dev)) { + error_setg(errp, "standard hotplug controller has been disabled fo= r " + "this %s", object_get_typename(OBJECT(hotplug_dev))); + return NULL; + } + return shpc_get_hotplug_state(hotplug_dev, dev, errp); +} + static void pci_bridge_dev_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -261,6 +274,7 @@ static void pci_bridge_dev_class_init(ObjectClass *klas= s, void *data) hc->plug =3D pci_bridge_dev_plug_cb; hc->unplug =3D pci_bridge_dev_unplug_cb; hc->unplug_request =3D pci_bridge_dev_unplug_request_cb; + hc->get_hotplug_state =3D pci_bridge_dev_get_hotplug_state; } =20 static const TypeInfo pci_bridge_dev_info =3D { diff --git a/hw/pci-bridge/pcie_pci_bridge.c b/hw/pci-bridge/pcie_pci_bridg= e.c index 2301b2ca0b..959b536303 100644 --- a/hw/pci-bridge/pcie_pci_bridge.c +++ b/hw/pci-bridge/pcie_pci_bridge.c @@ -157,6 +157,7 @@ static void pcie_pci_bridge_class_init(ObjectClass *kla= ss, void *data) hc->plug =3D pci_bridge_dev_plug_cb; hc->unplug =3D pci_bridge_dev_unplug_cb; hc->unplug_request =3D pci_bridge_dev_unplug_request_cb; + hc->get_hotplug_state =3D pci_bridge_dev_get_hotplug_state; } =20 static const TypeInfo pcie_pci_bridge_info =3D { diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c index df7f370111..0cd44150e5 100644 --- a/hw/pci/shpc.c +++ b/hw/pci/shpc.c @@ -8,6 +8,9 @@ #include "hw/pci/pci.h" #include "hw/pci/pci_bus.h" #include "hw/pci/msi.h" +#include "qapi/qapi-types-qdev.h" +#include "qapi/qapi-events-qdev.h" +#include "monitor/qdev.h" =20 /* TODO: model power only and disabled slot states. */ /* TODO: handle SERR and wakeups */ @@ -123,6 +126,39 @@ #define SHPC_PCI_TO_IDX(pci_slot) ((pci_slot) - 1) #define SHPC_IDX_TO_PHYSICAL(slot) ((slot) + 1) =20 +static char *shpc_idx_to_pci_addr(int slot) +{ + return g_strdup_printf("%d", SHPC_IDX_TO_PCI(slot)); +} + +static LedStatus shpc_led_state_to_qapi(uint8_t value) +{ + switch (value) { + case SHPC_LED_ON: + return LED_STATUS_ON; + case SHPC_LED_BLINK: + return LED_STATUS_BLINKING; + case SHPC_LED_OFF: + return LED_STATUS_OFF; + default: + abort(); + } +} + +static HotplugSHPCSlotState shpc_slot_state_to_qapi(uint8_t value) +{ + switch (value) { + case SHPC_STATE_PWRONLY: + return HOTPLUGSHPC_SLOT_STATE_POWER_ONLY; + case SHPC_STATE_ENABLED: + return HOTPLUGSHPC_SLOT_STATE_ENABLED; + case SHPC_STATE_DISABLED: + return HOTPLUGSHPC_SLOT_STATE_DISABLED; + default: + abort(); + } +} + static uint8_t shpc_get_status(SHPCDevice *shpc, int slot, uint16_t msk) { uint8_t *status =3D shpc->config + SHPC_SLOT_STATUS(slot); @@ -263,14 +299,23 @@ static bool shpc_slot_is_off(uint8_t state, uint8_t p= ower, uint8_t attn) return state =3D=3D SHPC_STATE_DISABLED && power =3D=3D SHPC_LED_OFF; } =20 +static bool shpc_slot_is_on(uint8_t state, uint8_t power, uint8_t attn) +{ + return state =3D=3D SHPC_STATE_ENABLED && power =3D=3D SHPC_LED_ON && + attn =3D=3D SHPC_LED_OFF; +} + static void shpc_slot_command(PCIDevice *d, uint8_t target, uint8_t state, uint8_t power, uint8_t attn) { SHPCDevice *shpc =3D d->shpc; int slot =3D SHPC_LOGICAL_TO_IDX(target); + int pci_slot =3D SHPC_IDX_TO_PCI(slot); uint8_t old_state =3D shpc_get_status(shpc, slot, SHPC_SLOT_STATE_MASK= ); uint8_t old_power =3D shpc_get_status(shpc, slot, SHPC_SLOT_PWR_LED_MA= SK); uint8_t old_attn =3D shpc_get_status(shpc, slot, SHPC_SLOT_ATTN_LED_MA= SK); + DeviceState *child_dev =3D + DEVICE(shpc->sec_bus->devices[PCI_DEVFN(pci_slot, 0)]); =20 if (target < SHPC_CMD_TRGT_MIN || slot >=3D shpc->nslots) { shpc_invalid_command(shpc); @@ -313,6 +358,12 @@ static void shpc_slot_command(PCIDevice *d, uint8_t ta= rget, SHPC_SLOT_EVENT_MRL | SHPC_SLOT_EVENT_PRESENCE; } + + if (!shpc_slot_is_on(old_state, old_power, old_attn) && + shpc_slot_is_on(state, power, attn) && child_dev) + { + qdev_hotplug_device_on_event(child_dev); + } } =20 static void shpc_command(PCIDevice *d) @@ -713,6 +764,41 @@ void shpc_cap_write_config(PCIDevice *d, uint32_t addr= , uint32_t val, int l) shpc_cap_update_dword(d); } =20 +HotplugInfo *shpc_get_hotplug_state(HotplugHandler *hotplug_dev, + DeviceState *dev, Error **errp) +{ + PCIDevice *pci_hotplug_dev =3D PCI_DEVICE(hotplug_dev); + SHPCDevice *shpc =3D pci_hotplug_dev->shpc; + int slot; + uint8_t state, power, attn; + HotplugInfo *res; + + if (!shpc_device_get_slot(PCI_DEVICE(dev), &slot, shpc, errp)) { + return NULL; + } + + state =3D shpc_get_status(shpc, slot, SHPC_SLOT_STATE_MASK); + power =3D shpc_get_status(shpc, slot, SHPC_SLOT_PWR_LED_MASK); + attn =3D shpc_get_status(shpc, slot, SHPC_SLOT_ATTN_LED_MASK); + + res =3D g_new(HotplugInfo, 1); + *res =3D (HotplugInfo) { + .bus =3D qdev_new_device_and_path(DEVICE(pci_hotplug_dev)), + .addr =3D shpc_idx_to_pci_addr(slot), + .child =3D qdev_new_device_and_path(dev), + .type =3D HOTPLUG_TYPE_SHPC, + .device_on =3D dev->device_on_event_sent, + .has_power_led =3D true, + .power_led =3D shpc_led_state_to_qapi(power), + .has_attention_led =3D true, + .attention_led =3D shpc_led_state_to_qapi(attn), + .u.shpc.has_slot_state =3D true, + .u.shpc.slot_state =3D shpc_slot_state_to_qapi(state), + }; + + return res; +} + static int shpc_save(QEMUFile *f, void *pv, size_t size, const VMStateField *field, JSONWriter *vmdesc) { diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h index ea54a81a15..2756c64953 100644 --- a/include/hw/pci/pci_bridge.h +++ b/include/hw/pci/pci_bridge.h @@ -139,6 +139,8 @@ void pci_bridge_dev_unplug_cb(HotplugHandler *hotplug_d= ev, DeviceState *dev, Error **errp); void pci_bridge_dev_unplug_request_cb(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp); +HotplugInfo *pci_bridge_dev_get_hotplug_state(HotplugHandler *hotplug_dev, + DeviceState *dev, Error **er= rp); =20 /* * before qdev initialization(qdev_init()), this function sets bus_name and diff --git a/include/hw/pci/shpc.h b/include/hw/pci/shpc.h index 89c7a3b7fa..bf722ce65d 100644 --- a/include/hw/pci/shpc.h +++ b/include/hw/pci/shpc.h @@ -51,6 +51,8 @@ void shpc_device_unplug_cb(HotplugHandler *hotplug_dev, D= eviceState *dev, Error **errp); void shpc_device_unplug_request_cb(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp); +HotplugInfo *shpc_get_hotplug_state(HotplugHandler *hotplug_dev, + DeviceState *dev, Error **errp); =20 extern VMStateInfo shpc_vmstate_info; #define SHPC_VMSTATE(_field, _type, _test) \ diff --git a/include/monitor/qdev.h b/include/monitor/qdev.h index c1c8798e89..949a3672cb 100644 --- a/include/monitor/qdev.h +++ b/include/monitor/qdev.h @@ -1,6 +1,8 @@ #ifndef MONITOR_QDEV_H #define MONITOR_QDEV_H =20 +#include "qapi/qapi-types-qdev.h" + /*** monitor commands ***/ =20 void hmp_info_qtree(Monitor *mon, const QDict *qdict); @@ -38,4 +40,6 @@ const char *qdev_set_id(DeviceState *dev, char *id, Error= **errp); =20 void qdev_hotplug_device_on_event(DeviceState *dev); =20 +DeviceAndPath *qdev_new_device_and_path(DeviceState *dev); + #endif diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index 483da40cb9..19c31446d8 100644 --- a/softmmu/qdev-monitor.c +++ b/softmmu/qdev-monitor.c @@ -1178,6 +1178,23 @@ bool qmp_command_available(const QmpCommand *cmd, Er= ror **errp) return true; } =20 +DeviceAndPath *qdev_new_device_and_path(DeviceState *dev) +{ + DeviceAndPath *res; + + if (!dev) { + return NULL; + } + + res =3D g_new(DeviceAndPath, 1); + *res =3D (DeviceAndPath) { + .device =3D g_strdup(dev->id), + .path =3D g_strdup(dev->canonical_path), + }; + + return res; +} + void qdev_hotplug_device_on_event(DeviceState *dev) { if (dev->device_on_event_sent) { --=20 2.34.1 From nobody Mon May 20 19:42:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1696498299; cv=none; d=zohomail.com; s=zohoarc; b=Y/ulpMTFLf4KDjYl5tPp4G3zOUQ8Xpw9QhRoOUSMVQeLHfXgSq9cu40/ckK2keh1Luf7VrO0l1tkN3dQM1fKkG8/O7O7RoAL3W2VunzKuneOuQNzACUW0VGkaM/Igfe08GbIxt3VDJE4QPz19p//GX8ou/KG2c4M+50T6Ly40js= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696498299; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1Ekdq811+EjFXBZpXGP43m0dc5f59sGIEcHN1J9mM0M=; b=KSkKDIGp3GFp9laRKl/ubMm3gC0uzXgcPXQFDve6dhKTYRFCU0XDnYZy6ReNoW1vOIUe9/IJEkwkbGUEl7Ik/qtsD84KdVI+wB9u6ZCcOI9o/7V2OEJj9583Bf4jXDJJf5SGM5k973L5jzNpOtBtpCmK+zwqMEfqDVgQNK/yVMI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16964982996516.154811530580105; Thu, 5 Oct 2023 02:31:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoKgA-0007yr-27; Thu, 05 Oct 2023 05:29:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKg2-0007wr-UN for qemu-devel@nongnu.org; Thu, 05 Oct 2023 05:29:52 -0400 Received: from forwardcorp1c.mail.yandex.net ([2a02:6b8:c03:500:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoKfz-0005Px-TS for qemu-devel@nongnu.org; Thu, 05 Oct 2023 05:29:50 -0400 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:750a:0:640:e46:0]) by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id 55ABE622D6; Thu, 5 Oct 2023 12:29:45 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6b8:b081:b584::1:2f]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id RTUHmS4OouQ0-ieHHcxQo; Thu, 05 Oct 2023 12:29:44 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1696498184; bh=1Ekdq811+EjFXBZpXGP43m0dc5f59sGIEcHN1J9mM0M=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=bUu+CqIEbQFQJado5EI3SL3nvZ/UjU4d7WD4jTOFA7avfztiKx4v5GgxJ7pZpRuiv D8jzLoqOf/CD959K/TGZqG+5kZdJ1fWdvNbdw6H2yXDvQZBU2Z5ObfshJoB0bfh+m9 KZnwJJaUFmaJkOS5aUxx8G/8HPhkkCfj8MGNfYbM= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Cc: armbru@redhat.com, eblake@redhat.com, eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, philmd@linaro.org, den-plotnikov@yandex-team.ru, vsementsov@yandex-team.ru, yc-core@yandex-team.ru Subject: [PATCH v8 4/4] pcie: implement DEVICE_ON event and query-hotplug Date: Thu, 5 Oct 2023 12:29:26 +0300 Message-Id: <20231005092926.56231-5-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231005092926.56231-1-vsementsov@yandex-team.ru> References: <20231005092926.56231-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c03:500:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1696498300768100001 Content-Type: text/plain; charset="utf-8" For PCIe and SHPC hotplug it's important to track led indicators and "device-on" status. At this step implement the prepared infrastructure in PCIe. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/pci/pcie.c | 83 +++++++++++++++++++++++++++++++++++++++++++ hw/pci/pcie_port.c | 1 + include/hw/pci/pcie.h | 2 ++ 3 files changed, 86 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 6db0cf69cd..8b5c163c25 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -19,7 +19,10 @@ */ =20 #include "qemu/osdep.h" + +#include "monitor/qdev.h" #include "qapi/error.h" +#include "qapi/qapi-events-qdev.h" #include "hw/pci/pci_bridge.h" #include "hw/pci/pcie.h" #include "hw/pci/msix.h" @@ -45,6 +48,30 @@ static bool pcie_sltctl_powered_off(uint16_t sltctl) && (sltctl & PCI_EXP_SLTCTL_PIC) =3D=3D PCI_EXP_SLTCTL_PWR_IND_OFF; } =20 +static bool pcie_sltctl_powered_on(uint16_t sltctl) +{ + return (sltctl & PCI_EXP_SLTCTL_PCC) =3D=3D PCI_EXP_SLTCTL_PWR_ON && + (sltctl & PCI_EXP_SLTCTL_PIC) =3D=3D PCI_EXP_SLTCTL_PWR_IND_ON && + (sltctl & PCI_EXP_SLTCTL_AIC) =3D=3D PCI_EXP_SLTCTL_ATTN_IND_OFF; +} + +static LedStatus pcie_led_state_to_qapi(uint16_t value) +{ + switch (value) { + case PCI_EXP_SLTCTL_PWR_IND_ON: + case PCI_EXP_SLTCTL_ATTN_IND_ON: + return LED_STATUS_ON; + case PCI_EXP_SLTCTL_PWR_IND_BLINK: + case PCI_EXP_SLTCTL_ATTN_IND_BLINK: + return LED_STATUS_BLINKING; + case PCI_EXP_SLTCTL_PWR_IND_OFF: + case PCI_EXP_SLTCTL_ATTN_IND_OFF: + return LED_STATUS_OFF; + default: + abort(); + } +} + /*************************************************************************= ** * pci express capability helper functions */ @@ -735,6 +762,28 @@ void pcie_cap_slot_get(PCIDevice *dev, uint16_t *slt_c= tl, uint16_t *slt_sta) *slt_sta =3D pci_get_word(exp_cap + PCI_EXP_SLTSTA); } =20 +static void find_child_fn(PCIBus *bus, PCIDevice *dev, void *opaque) +{ + PCIDevice **child =3D opaque; + + if (!*child) { + *child =3D dev; + } +} + +/* + * Returns the plugged device or first function of multifunction plugged d= evice + */ +static PCIDevice *pcie_cap_slot_find_child(PCIDevice *dev) +{ + PCIBus *sec_bus =3D pci_bridge_get_sec_bus(PCI_BRIDGE(dev)); + PCIDevice *child =3D NULL; + + pci_for_each_device(sec_bus, pci_bus_num(sec_bus), find_child_fn, &chi= ld); + + return child; +} + void pcie_cap_slot_write_config(PCIDevice *dev, uint16_t old_slt_ctl, uint16_t old_slt_sta, uint32_t addr, uint32_t val, int len) @@ -742,6 +791,7 @@ void pcie_cap_slot_write_config(PCIDevice *dev, uint32_t pos =3D dev->exp.exp_cap; uint8_t *exp_cap =3D dev->config + pos; uint16_t sltsta =3D pci_get_word(exp_cap + PCI_EXP_SLTSTA); + DeviceState *child_dev =3D DEVICE(pcie_cap_slot_find_child(dev)); =20 if (ranges_overlap(addr, len, pos + PCI_EXP_SLTSTA, 2)) { /* @@ -779,6 +829,12 @@ void pcie_cap_slot_write_config(PCIDevice *dev, sltsta); } =20 + if ((sltsta & PCI_EXP_SLTSTA_PDS) && pcie_sltctl_powered_on(val) && + !pcie_sltctl_powered_on(old_slt_ctl) && child_dev) + { + qdev_hotplug_device_on_event(child_dev); + } + /* * If the slot is populated, power indicator is off and power * controller is off, it is safe to detach the devices. @@ -1113,3 +1169,30 @@ void pcie_acs_reset(PCIDevice *dev) pci_set_word(dev->config + dev->exp.acs_cap + PCI_ACS_CTRL, 0); } } + +HotplugInfo *pcie_cap_slot_get_hotplug_state(HotplugHandler *hotplug_dev, + DeviceState *dev, Error **err= p) +{ + PCIDevice *hotplug_pdev =3D PCI_DEVICE(hotplug_dev); + uint8_t *exp_cap =3D hotplug_pdev->config + hotplug_pdev->exp.exp_cap; + uint16_t sltctl =3D pci_get_word(exp_cap + PCI_EXP_SLTCTL); + uint16_t power_led =3D sltctl & PCI_EXP_SLTCTL_PIC; + uint16_t attn_led =3D sltctl & PCI_EXP_SLTCTL_AIC; + uint16_t pcc =3D sltctl & PCI_EXP_SLTCTL_PCC; + HotplugInfo *res =3D g_new(HotplugInfo, 1); + + *res =3D (HotplugInfo) { + .type =3D HOTPLUG_TYPE_PCIE_NATIVE, + .bus =3D qdev_new_device_and_path(DEVICE(hotplug_pdev)), + .child =3D qdev_new_device_and_path(dev), + .device_on =3D dev->device_on_event_sent, + .has_power_led =3D true, + .power_led =3D pcie_led_state_to_qapi(power_led), + .has_attention_led =3D true, + .attention_led =3D pcie_led_state_to_qapi(attn_led), + .u.pcie_native.has_power_on =3D true, + .u.pcie_native.power_on =3D pcc =3D=3D PCI_EXP_SLTCTL_PWR_ON, + }; + + return res; +} diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c index 20ff2b39e8..91e53c269c 100644 --- a/hw/pci/pcie_port.c +++ b/hw/pci/pcie_port.c @@ -234,6 +234,7 @@ static void pcie_slot_class_init(ObjectClass *oc, void = *data) hc->unplug =3D pcie_cap_slot_unplug_cb; hc->unplug_request =3D pcie_cap_slot_unplug_request_cb; hc->is_hotpluggable_bus =3D pcie_slot_is_hotpluggbale_bus; + hc->get_hotplug_state =3D pcie_cap_slot_get_hotplug_state; } =20 static const TypeInfo pcie_slot_type_info =3D { diff --git a/include/hw/pci/pcie.h b/include/hw/pci/pcie.h index 11f5a91bbb..01fb9e163c 100644 --- a/include/hw/pci/pcie.h +++ b/include/hw/pci/pcie.h @@ -147,4 +147,6 @@ void pcie_cap_slot_unplug_cb(HotplugHandler *hotplug_de= v, DeviceState *dev, Error **errp); void pcie_cap_slot_unplug_request_cb(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp); +HotplugInfo *pcie_cap_slot_get_hotplug_state(HotplugHandler *hotplug_dev, + DeviceState *dev, Error **err= p); #endif /* QEMU_PCIE_H */ --=20 2.34.1