[v1] Python patches

[PULL 0/9] Python patches

John Snow posted 9 patches 7 months ago

Diff against v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v2 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231004194613.2900323-1-jsnow@redhat.com

Maintainers: John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Beraldo Leal <bleal@redhat.com>, Ani Sinha <anisinha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Eric Blake <eblake@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

There is a newer version of this series

python/qemu/machine/console_socket.py      | 29 ++++++++---
python/qemu/machine/machine.py             | 58 +++++++++++++---------
python/qemu/machine/qtest.py               | 54 +++++++++++++++-----
python/qemu/qmp/protocol.py                |  1 -
python/setup.cfg                           |  3 +-
tests/avocado/acpi-bits.py                 |  5 +-
tests/avocado/avocado_qemu/__init__.py     |  2 +-
tests/avocado/machine_aspeed.py            |  5 +-
tests/docker/dockerfiles/python.docker     |  6 ++-
tests/qemu-iotests/iotests.py              |  2 +-
tests/qemu-iotests/tests/copy-before-write |  3 +-
tests/qemu-iotests/tests/nbd-multiconn     |  4 +-
12 files changed, 114 insertions(+), 58 deletions(-)

Expand all Fold all

[PULL 0/9] Python patches

Posted by John Snow 7 months ago

The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0:

  Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400)

are available in the Git repository at:

  https://gitlab.com/jsnow/qemu.git tags/python-pull-request

for you to fetch changes up to 4d7a663cbe8343e884b88e44bd88d37dd0a470e5:

  Python: test Python 3.12 (2023-10-04 15:19:00 -0400)

----------------------------------------------------------------
Python pullreq

Buffering improvements for qemu machine, minor changes to support the
newly released Python 3.12

----------------------------------------------------------------

John Snow (9):
  Python/iotests: Add type hint for nbd module
  python/machine: move socket setup out of _base_args property
  python/machine: close sock_pair in cleanup path
  python/console_socket: accept existing FD in initializer
  python/machine: use socketpair() for console connections
  python/machine: use socketpair() for qtest connection
  python/machine: remove unused sock_dir argument
  python/qmp: remove Server.wait_closed() call for Python 3.12
  Python: test Python 3.12

 python/qemu/machine/console_socket.py      | 29 ++++++++---
 python/qemu/machine/machine.py             | 58 +++++++++++++---------
 python/qemu/machine/qtest.py               | 54 +++++++++++++++-----
 python/qemu/qmp/protocol.py                |  1 -
 python/setup.cfg                           |  3 +-
 tests/avocado/acpi-bits.py                 |  5 +-
 tests/avocado/avocado_qemu/__init__.py     |  2 +-
 tests/avocado/machine_aspeed.py            |  5 +-
 tests/docker/dockerfiles/python.docker     |  6 ++-
 tests/qemu-iotests/iotests.py              |  2 +-
 tests/qemu-iotests/tests/copy-before-write |  3 +-
 tests/qemu-iotests/tests/nbd-multiconn     |  4 +-
 12 files changed, 114 insertions(+), 58 deletions(-)

-- 
2.41.0

Re: [PULL 0/9] Python patches

Posted by Philippe Mathieu-Daudé 7 months ago

Hi John,

On 4/10/23 21:46, John Snow wrote:
> The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0:
> 
>    Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/jsnow/qemu.git tags/python-pull-request
> 
> for you to fetch changes up to 4d7a663cbe8343e884b88e44bd88d37dd0a470e5:
> 
>    Python: test Python 3.12 (2023-10-04 15:19:00 -0400)
> 
> ----------------------------------------------------------------
> Python pullreq
> 
> Buffering improvements for qemu machine, minor changes to support the
> newly released Python 3.12
> 
> ----------------------------------------------------------------
> 
> John Snow (9):
>    Python/iotests: Add type hint for nbd module
>    python/machine: move socket setup out of _base_args property
>    python/machine: close sock_pair in cleanup path
>    python/console_socket: accept existing FD in initializer
>    python/machine: use socketpair() for console connections
>    python/machine: use socketpair() for qtest connection
>    python/machine: remove unused sock_dir argument
>    python/qmp: remove Server.wait_closed() call for Python 3.12
>    Python: test Python 3.12

Is that a pull request or a patch series to be reviewed?

Re: [PULL 0/9] Python patches

Posted by Stefan Hajnoczi 7 months ago

On Thu, 5 Oct 2023 at 00:49, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Hi John,
>
> On 4/10/23 21:46, John Snow wrote:
> > The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0:
> >
> >    Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400)
> >
> > are available in the Git repository at:
> >
> >    https://gitlab.com/jsnow/qemu.git tags/python-pull-request
> >
> > for you to fetch changes up to 4d7a663cbe8343e884b88e44bd88d37dd0a470e5:
> >
> >    Python: test Python 3.12 (2023-10-04 15:19:00 -0400)
> >
> > ----------------------------------------------------------------
> > Python pullreq
> >
> > Buffering improvements for qemu machine, minor changes to support the
> > newly released Python 3.12
> >
> > ----------------------------------------------------------------
> >
> > John Snow (9):
> >    Python/iotests: Add type hint for nbd module
> >    python/machine: move socket setup out of _base_args property
> >    python/machine: close sock_pair in cleanup path
> >    python/console_socket: accept existing FD in initializer
> >    python/machine: use socketpair() for console connections
> >    python/machine: use socketpair() for qtest connection
> >    python/machine: remove unused sock_dir argument
> >    python/qmp: remove Server.wait_closed() call for Python 3.12
> >    Python: test Python 3.12
>
> Is that a pull request or a patch series to be reviewed?

Strange, some of the patches have Reviewed-by tags but others do not.
I could not find a "Add type hint for nbd module" patch on the mailing
list before this pull request, so I guess it hasn't been reviewed.

I'll hold off from merging this series for now.

John: Please make sure all patches have been on the mailing list for
review before sending a pull request.

Stefan

Re: [PULL 0/9] Python patches

Posted by John Snow 7 months ago

On Thu, Oct 5, 2023, 9:00 AM Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Thu, 5 Oct 2023 at 00:49, Philippe Mathieu-Daudé <philmd@linaro.org>
> wrote:
> >
> > Hi John,
> >
> > On 4/10/23 21:46, John Snow wrote:
> > > The following changes since commit
> da1034094d375afe9e3d8ec8980550ea0f06f7e0:
> > >
> > >    Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into
> staging (2023-10-03 07:43:44 -0400)
> > >
> > > are available in the Git repository at:
> > >
> > >    https://gitlab.com/jsnow/qemu.git tags/python-pull-request
> > >
> > > for you to fetch changes up to
> 4d7a663cbe8343e884b88e44bd88d37dd0a470e5:
> > >
> > >    Python: test Python 3.12 (2023-10-04 15:19:00 -0400)
> > >
> > > ----------------------------------------------------------------
> > > Python pullreq
> > >
> > > Buffering improvements for qemu machine, minor changes to support the
> > > newly released Python 3.12
> > >
> > > ----------------------------------------------------------------
> > >
> > > John Snow (9):
> > >    Python/iotests: Add type hint for nbd module
> > >    python/machine: move socket setup out of _base_args property
> > >    python/machine: close sock_pair in cleanup path
> > >    python/console_socket: accept existing FD in initializer
> > >    python/machine: use socketpair() for console connections
> > >    python/machine: use socketpair() for qtest connection
> > >    python/machine: remove unused sock_dir argument
> > >    python/qmp: remove Server.wait_closed() call for Python 3.12
> > >    Python: test Python 3.12
> >
> > Is that a pull request or a patch series to be reviewed?
>
> Strange, some of the patches have Reviewed-by tags but others do not.
> I could not find a "Add type hint for nbd module" patch on the mailing
> list before this pull request, so I guess it hasn't been reviewed.
>
> I'll hold off from merging this series for now.
>
> John: Please make sure all patches have been on the mailing list for
> review before sending a pull request.
>
> Stefan
>

Okey Dokey.

--js