linux-user/hppa: Fix struct target_sigcontext layout

[PATCH] linux-user/hppa: Fix struct target_sigcontext layout

Richard Henderson posted 1 patch 7 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230930212742.586468-1-richard.henderson@linaro.org

Maintainers: Laurent Vivier <laurent@vivier.eu>

linux-user/hppa/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] linux-user/hppa: Fix struct target_sigcontext layout

Posted by Richard Henderson 7 months ago

Use abi_ullong not uint64_t so that the alignment of the field
and therefore the layout of the struct is correct.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/hppa/signal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/hppa/signal.c b/linux-user/hppa/signal.c
index bda6e54655..ec5f5412d1 100644
--- a/linux-user/hppa/signal.c
+++ b/linux-user/hppa/signal.c
@@ -25,7 +25,7 @@
 struct target_sigcontext {
     abi_ulong sc_flags;
     abi_ulong sc_gr[32];
-    uint64_t sc_fr[32];
+    abi_ullong sc_fr[32];
     abi_ulong sc_iasq[2];
     abi_ulong sc_iaoq[2];
     abi_ulong sc_sar;
-- 
2.34.1

Re: [PATCH] linux-user/hppa: Fix struct target_sigcontext layout

Posted by Philippe Mathieu-Daudé 7 months ago

On 30/9/23 23:27, Richard Henderson wrote:
> Use abi_ullong not uint64_t so that the alignment of the field
> and therefore the layout of the struct is correct.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   linux-user/hppa/signal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>