1. Patchew
  2. QEMU
  3. View series

[PATCH] MAINTAINERS: Add entry for rdma migration

Peter Xu posted 1 patch 7 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230925133441.265455-1-peterx@redhat.com
MAINTAINERS | 5 +++++
1 file changed, 5 insertions(+)
[PATCH] MAINTAINERS: Add entry for rdma migration
Posted by Peter Xu 7 months, 1 week ago 
It's not obvious to many that RDMA migration is in Odd Fixes stage for a
long time.  Add an explicit sub entry for it (besides migration, which
already covers the rdma files) to be clear on that, meanwhile add Zhijian
as Reviewer, so Zhijian can see the patches and review when he still has
the bandwidth.

Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
Cc: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 355b1960ce..f6b21da753 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3217,6 +3217,11 @@ F: qapi/migration.json
 F: tests/migration/
 F: util/userfaultfd.c
 
+RDMA Migration
+R: Li Zhijian <lizhijian@fujitsu.com>
+S: Odd Fixes
+F: migration/rdma*
+
 Migration dirty limit and dirty page rate
 M: Hyman Huang <yong.huang@smartx.com>
 S: Maintained
-- 
2.41.0
Re: [PATCH] MAINTAINERS: Add entry for rdma migration
Posted by Zhijian Li (Fujitsu) 7 months, 1 week ago 

On 25/09/2023 21:34, Peter Xu wrote:
> It's not obvious to many that RDMA migration is in Odd Fixes stage for a
> long time.  Add an explicit sub entry for it (besides migration, which
> already covers the rdma files) to be clear on that, meanwhile add Zhijian
> as Reviewer, so Zhijian can see the patches and review when he still has
> the bandwidth.


Feel free to add my Acked tag. thanks.

Acked-by: Li Zhijian <lizhijian@fujitsu.com>


> 
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   MAINTAINERS | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 355b1960ce..f6b21da753 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3217,6 +3217,11 @@ F: qapi/migration.json
>   F: tests/migration/
>   F: util/userfaultfd.c
>   
> +RDMA Migration
> +R: Li Zhijian <lizhijian@fujitsu.com>
> +S: Odd Fixes
> +F: migration/rdma*
> +>   Migration dirty limit and dirty page rate
>   M: Hyman Huang <yong.huang@smartx.com>
>   S: Maintained
Re: [PATCH] MAINTAINERS: Add entry for rdma migration
Posted by Markus Armbruster 7 months, 1 week ago 
Peter Xu <peterx@redhat.com> writes:

> It's not obvious to many that RDMA migration is in Odd Fixes stage for a
> long time.  Add an explicit sub entry for it (besides migration, which
> already covers the rdma files) to be clear on that, meanwhile add Zhijian
> as Reviewer, so Zhijian can see the patches and review when he still has
> the bandwidth.
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  MAINTAINERS | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 355b1960ce..f6b21da753 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3217,6 +3217,11 @@ F: qapi/migration.json
>  F: tests/migration/
>  F: util/userfaultfd.c
>  
> +RDMA Migration
> +R: Li Zhijian <lizhijian@fujitsu.com>
> +S: Odd Fixes
> +F: migration/rdma*
> +
>  Migration dirty limit and dirty page rate
>  M: Hyman Huang <yong.huang@smartx.com>
>  S: Maintained

Hmm...

    $ scripts/get_maintainer.pl --status -f migration/rdma.cLi Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
    Juan Quintela <quintela@redhat.com> (maintainer:Migration)
    Peter Xu <peterx@redhat.com> (reviewer:Migration)
    Leonardo Bras <leobras@redhat.com> (reviewer:Migration)
    qemu-devel@nongnu.org (open list:All patches CC here)
    Odd Fixes
    Maintained

Contradictory status.  Do we care?

To avoid, try something like the appended patch.  With that one:

    $ scripts/get_maintainer.pl --status -f migration/rdma.c
    Juan Quintela <quintela@redhat.com> (odd fixer:RDMA Migration)
    Li Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
    Peter Xu <peterx@redhat.com> (reviewer:RDMA Migration)
    Leonardo Bras <leobras@redhat.com> (reviewer:RDMA Migration)
    qemu-devel@nongnu.org (open list:All patches CC here)
    Odd Fixes


diff --git a/MAINTAINERS b/MAINTAINERS
index 355b1960ce..3e80857eab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3216,6 +3216,15 @@ F: docs/devel/migration.rst
 F: qapi/migration.json
 F: tests/migration/
 F: util/userfaultfd.c
+X: migration/rdma*
+
+RDMA Migration
+M: Juan Quintela <quintela@redhat.com>
+R: Li Zhijian <lizhijian@fujitsu.com>
+R: Peter Xu <peterx@redhat.com>
+R: Leonardo Bras <leobras@redhat.com>
+S: Odd Fixes
+F: migration/rdma*
 
 Migration dirty limit and dirty page rate
 M: Hyman Huang <yong.huang@smartx.com>
Re: [PATCH] MAINTAINERS: Add entry for rdma migration
Posted by Peter Xu 7 months, 1 week ago 
On Mon, Sep 25, 2023 at 03:55:08PM +0200, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
> > It's not obvious to many that RDMA migration is in Odd Fixes stage for a
> > long time.  Add an explicit sub entry for it (besides migration, which
> > already covers the rdma files) to be clear on that, meanwhile add Zhijian
> > as Reviewer, so Zhijian can see the patches and review when he still has
> > the bandwidth.
> >
> > Cc: Daniel P. Berrangé <berrange@redhat.com>
> > Cc: Juan Quintela <quintela@redhat.com>
> > Cc: Markus Armbruster <armbru@redhat.com>
> > Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
> > Cc: Fabiano Rosas <farosas@suse.de>
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  MAINTAINERS | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 355b1960ce..f6b21da753 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3217,6 +3217,11 @@ F: qapi/migration.json
> >  F: tests/migration/
> >  F: util/userfaultfd.c
> >  
> > +RDMA Migration
> > +R: Li Zhijian <lizhijian@fujitsu.com>
> > +S: Odd Fixes
> > +F: migration/rdma*
> > +
> >  Migration dirty limit and dirty page rate
> >  M: Hyman Huang <yong.huang@smartx.com>
> >  S: Maintained
> 
> Hmm...
> 
>     $ scripts/get_maintainer.pl --status -f migration/rdma.cLi Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
>     Juan Quintela <quintela@redhat.com> (maintainer:Migration)
>     Peter Xu <peterx@redhat.com> (reviewer:Migration)
>     Leonardo Bras <leobras@redhat.com> (reviewer:Migration)
>     qemu-devel@nongnu.org (open list:All patches CC here)
>     Odd Fixes
>     Maintained
> 
> Contradictory status.  Do we care?

Not a problem to me, but if you or anyone thinks that's better, please feel
free to post another patch to replace this one with Zhijian's ACK attached.

> 
> To avoid, try something like the appended patch.  With that one:
> 
>     $ scripts/get_maintainer.pl --status -f migration/rdma.c
>     Juan Quintela <quintela@redhat.com> (odd fixer:RDMA Migration)
>     Li Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
>     Peter Xu <peterx@redhat.com> (reviewer:RDMA Migration)
>     Leonardo Bras <leobras@redhat.com> (reviewer:RDMA Migration)
>     qemu-devel@nongnu.org (open list:All patches CC here)
>     Odd Fixes
> 
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 355b1960ce..3e80857eab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3216,6 +3216,15 @@ F: docs/devel/migration.rst
>  F: qapi/migration.json
>  F: tests/migration/
>  F: util/userfaultfd.c
> +X: migration/rdma*
> +
> +RDMA Migration
> +M: Juan Quintela <quintela@redhat.com>
> +R: Li Zhijian <lizhijian@fujitsu.com>
> +R: Peter Xu <peterx@redhat.com>
> +R: Leonardo Bras <leobras@redhat.com>
> +S: Odd Fixes
> +F: migration/rdma*

It's slightly a pity we need to copy the lines, and I think this may not be
the only place where we have >1 entries pointing to the same file.

>  
>  Migration dirty limit and dirty page rate
>  M: Hyman Huang <yong.huang@smartx.com>
> 

Thanks,

-- 
Peter Xu
Re: [PATCH] MAINTAINERS: Add entry for rdma migration
Posted by Juan Quintela 7 months ago 
Peter Xu <peterx@redhat.com> wrote:
> On Mon, Sep 25, 2023 at 03:55:08PM +0200, Markus Armbruster wrote:
>> Peter Xu <peterx@redhat.com> writes:
>> 
>> > It's not obvious to many that RDMA migration is in Odd Fixes stage for a
>> > long time.  Add an explicit sub entry for it (besides migration, which
>> > already covers the rdma files) to be clear on that, meanwhile add Zhijian
>> > as Reviewer, so Zhijian can see the patches and review when he still has
>> > the bandwidth.
>> >
>> > Cc: Daniel P. Berrangé <berrange@redhat.com>
>> > Cc: Juan Quintela <quintela@redhat.com>
>> > Cc: Markus Armbruster <armbru@redhat.com>
>> > Cc: Zhijian Li (Fujitsu) <lizhijian@fujitsu.com>
>> > Cc: Fabiano Rosas <farosas@suse.de>
>> > Signed-off-by: Peter Xu <peterx@redhat.com>
>> > ---
>> >  MAINTAINERS | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 355b1960ce..f6b21da753 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -3217,6 +3217,11 @@ F: qapi/migration.json
>> >  F: tests/migration/
>> >  F: util/userfaultfd.c
>> >  
>> > +RDMA Migration
>> > +R: Li Zhijian <lizhijian@fujitsu.com>
>> > +S: Odd Fixes
>> > +F: migration/rdma*
>> > +
>> >  Migration dirty limit and dirty page rate
>> >  M: Hyman Huang <yong.huang@smartx.com>
>> >  S: Maintained
>> 
>> Hmm...
>> 
>>     $ scripts/get_maintainer.pl --status -f migration/rdma.cLi Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
>>     Juan Quintela <quintela@redhat.com> (maintainer:Migration)
>>     Peter Xu <peterx@redhat.com> (reviewer:Migration)
>>     Leonardo Bras <leobras@redhat.com> (reviewer:Migration)
>>     qemu-devel@nongnu.org (open list:All patches CC here)
>>     Odd Fixes
>>     Maintained
>> 
>> Contradictory status.  Do we care?
>
> Not a problem to me, but if you or anyone thinks that's better, please feel
> free to post another patch to replace this one with Zhijian's ACK attached.

Sending Markus version with Zhijian ACK.

>> 
>> To avoid, try something like the appended patch.  With that one:
>> 
>>     $ scripts/get_maintainer.pl --status -f migration/rdma.c
>>     Juan Quintela <quintela@redhat.com> (odd fixer:RDMA Migration)
>>     Li Zhijian <lizhijian@fujitsu.com> (reviewer:RDMA Migration)
>>     Peter Xu <peterx@redhat.com> (reviewer:RDMA Migration)
>>     Leonardo Bras <leobras@redhat.com> (reviewer:RDMA Migration)
>>     qemu-devel@nongnu.org (open list:All patches CC here)
>>     Odd Fixes
>> 
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 355b1960ce..3e80857eab 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3216,6 +3216,15 @@ F: docs/devel/migration.rst
>>  F: qapi/migration.json
>>  F: tests/migration/
>>  F: util/userfaultfd.c
>> +X: migration/rdma*
>> +
>> +RDMA Migration
>> +M: Juan Quintela <quintela@redhat.com>
>> +R: Li Zhijian <lizhijian@fujitsu.com>
>> +R: Peter Xu <peterx@redhat.com>
>> +R: Leonardo Bras <leobras@redhat.com>
>> +S: Odd Fixes
>> +F: migration/rdma*
>
> It's slightly a pity we need to copy the lines, and I think this may not be
> the only place where we have >1 entries pointing to the same file.
>
>>  
>>  Migration dirty limit and dirty page rate
>>  M: Hyman Huang <yong.huang@smartx.com>
>> 
>
> Thanks,

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.