From nobody Fri May 17 10:44:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694797447; cv=none; d=zohomail.com; s=zohoarc; b=CaBOgJeUCEZYWkM+xMwo0vm0ccV0jyHKwsjkU+qsxl4kRCmAOAG3DhJElLRqlnXN3zwaVzggYiOTTEnS8FdyTtLXkN1YrXb7++eDX4p1JNA0WFxBPk89cV2xaQVK5YVyE6MaM1AE6booJGvCTsdcH9OtnfPWi6Em+bdMWs2eMMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694797447; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eQoKD0v/MJbC2dn6qKI2zAWglL+DKTBVL1qR/JTyEzA=; b=Ia90zAmZmg8ok2JneF2aIkavHTLgl3AW/m2abA/D/HCRMHe+/matWVQskEmz0VLRvhQKENA2TE555hTpl69i/DkYiqhAMD08R6YgUsAhRZTUB+igByaJ3ypVy6hmFcDZ3HabjqXbpj/kUiaPMv0TIdNQZk/0pKIdHWfCGri1W84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1694797447809909.8170590782674; Fri, 15 Sep 2023 10:04:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhCEE-0007XX-Gr; Fri, 15 Sep 2023 13:03:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhCE9-0007Ow-Kg for qemu-devel@nongnu.org; Fri, 15 Sep 2023 13:03:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhCE7-0000Zv-Pu for qemu-devel@nongnu.org; Fri, 15 Sep 2023 13:03:32 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-497-cOCspbmENkGy2BzjKTP1jw-1; Fri, 15 Sep 2023 13:03:27 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 09B06811E86; Fri, 15 Sep 2023 17:03:27 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD9B428FB; Fri, 15 Sep 2023 17:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694797410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eQoKD0v/MJbC2dn6qKI2zAWglL+DKTBVL1qR/JTyEzA=; b=AZvXueu5aTeDP78YG+d7jQjtOxS5FD5/VCTVfdjhLatl7Z7jok+AfJJ3BADCO6Hp1Z1ziD 34hYAkJWhnXxl1aU+NHWMzQ2wfHz5MXnflbhMJDWjvChFsNaT+WeJfBh8rShlbKtUe+X2I 1LK51eR3TT69o+nXfF5CDLUfVpBowD8= X-MC-Unique: cOCspbmENkGy2BzjKTP1jw-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Hawkins Jiawei , si-wei.liu@oracle.com, Jason Wang , Lei Yang Subject: [PATCH 1/3] vdpa net: fix error message setting virtio status Date: Fri, 15 Sep 2023 19:03:20 +0200 Message-Id: <20230915170322.3076956-2-eperezma@redhat.com> In-Reply-To: <20230915170322.3076956-1-eperezma@redhat.com> References: <20230915170322.3076956-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694797450032100003 It incorrectly prints "error setting features", probably because a copy paste miss. Reported-by: Peter Maydell Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 34202ca009..9845e2db9c 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -1293,7 +1293,7 @@ static int vhost_vdpa_probe_cvq_isolation(int device_= fd, uint64_t features, =20 r =3D ioctl(device_fd, VHOST_VDPA_SET_STATUS, &status); if (unlikely(r)) { - error_setg_errno(errp, -r, "Cannot set device features"); + error_setg_errno(errp, -r, "Cannot set status"); goto out; } =20 --=20 2.39.3 From nobody Fri May 17 10:44:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694797438; cv=none; d=zohomail.com; s=zohoarc; b=GR2hGigmpG0X9pAp+vnoyT/zevCMH3UmQ2+nj6AmwW277QOgfZsBU8/JYt2unJ8rwK39XPj21msuBWjeJ8prEmWUeDDv49CNJ4wLsYDFeoc0DBA9VpCeorzXTd/aunrn/dNJyh6K/veWvJABlVJZPotLFdPouJH32YGr0ln3YRQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694797438; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=21LxQ7qH/Wj87Y6MLf49kyWUzZwR+qRER/cq0yZgCrQ=; b=MlvlAJlhfUgWs2QpAwLOTpsGbg9UC6gELa0QVFkDdUbF+u0S6j0dUjgEK2fTacde2vQCnRY4/CXyBWI1/0lAdbD+A5CYlEW/uacb8szBoECCPoZMo24cv/QFM3FYY0B5TTM2Ibzc3tgB//TQTsW2LGAaZx50TiLanUNG11qTZqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16947974380911005.7815780232409; Fri, 15 Sep 2023 10:03:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhCED-0007UJ-Oc; Fri, 15 Sep 2023 13:03:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhCEB-0007Qz-Ba for qemu-devel@nongnu.org; Fri, 15 Sep 2023 13:03:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhCE9-0000a8-Cf for qemu-devel@nongnu.org; Fri, 15 Sep 2023 13:03:34 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-694-gaiprnVhMl-a6w58Hpn0og-1; Fri, 15 Sep 2023 13:03:28 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67735858F1B; Fri, 15 Sep 2023 17:03:28 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4893B28FB; Fri, 15 Sep 2023 17:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694797412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=21LxQ7qH/Wj87Y6MLf49kyWUzZwR+qRER/cq0yZgCrQ=; b=cZPAcG7q8G2v5ELWPlHWuMNT/VMFi/iO+FDlWGP2LCJK5fhu8L+Mm5p36oniTCveWq/4ut 1A24RH3jvP/znzD0Sm/+kXysZNJtwSBjeLtYQ2vGLc6HCQ3tgx7YRahgKODVMfA0G0P64r 9pk4tqdie501BxfljLSCTMBFLcHTU5E= X-MC-Unique: gaiprnVhMl-a6w58Hpn0og-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Hawkins Jiawei , si-wei.liu@oracle.com, Jason Wang , Lei Yang Subject: [PATCH 2/3] vdpa net: stop probing if cannot set features Date: Fri, 15 Sep 2023 19:03:21 +0200 Message-Id: <20230915170322.3076956-3-eperezma@redhat.com> In-Reply-To: <20230915170322.3076956-1-eperezma@redhat.com> References: <20230915170322.3076956-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694797440418100003 Otherwise it continues the CVQ isolation probing. Reported-by: Peter Maydell Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 9845e2db9c..51d8144070 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -1289,6 +1289,7 @@ static int vhost_vdpa_probe_cvq_isolation(int device_= fd, uint64_t features, r =3D ioctl(device_fd, VHOST_SET_FEATURES, &features); if (unlikely(r)) { error_setg_errno(errp, errno, "Cannot set features"); + goto out; } =20 r =3D ioctl(device_fd, VHOST_VDPA_SET_STATUS, &status); --=20 2.39.3 From nobody Fri May 17 10:44:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694797451; cv=none; d=zohomail.com; s=zohoarc; b=A4nc+1U1d+/xxXZ9LoQEb9a9SCDuEH1a/kBNlmzpBfKCPRwGAfunIGlDeYl2wdWvD/G6hDtQ5r5fbcpsLf4+jU5IUAKmPMcha/wWTbi1qw+R4nFgro/U225pkp9oPPQV97xFGlVVC+tCzXxK435ejkgwXwQfgCBcsnQEmPpr00w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694797451; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VmVRSRSAHQO60KH1ReIR3Iv78Lf0S/KPjRrS5RCKBQs=; b=hoALQB+e+9rvTNbSpPwrfrjvai2LoT8Wck/23mb5eUm0c1Vnz9r+vsYuX0E6ptPBDJf+Ommy7euJ1F46J7caA+5CFFSzcYkgwlu7nz224amlX7mBZ7UGfSp2QLcaN7Snv6KN58qEBphj0Ce+qBFAremipf/rxZuQIqgsZRR223E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1694797451837539.375892036342; Fri, 15 Sep 2023 10:04:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhCEE-0007XE-EC; Fri, 15 Sep 2023 13:03:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhCEB-0007R0-Ic for qemu-devel@nongnu.org; Fri, 15 Sep 2023 13:03:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhCEA-0000bL-47 for qemu-devel@nongnu.org; Fri, 15 Sep 2023 13:03:35 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-ruxyvtK-MzqJxJ2TAZbfrA-1; Fri, 15 Sep 2023 13:03:30 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C3CA3858F19; Fri, 15 Sep 2023 17:03:29 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5B33167F8; Fri, 15 Sep 2023 17:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694797413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VmVRSRSAHQO60KH1ReIR3Iv78Lf0S/KPjRrS5RCKBQs=; b=FY6870OzYp/dc5974NqXPyj3JCVKVw1rd/DbqvQJAHhNvKcvBOLxAK92y+EfctisaxjVbU CZay3ffYJQzy6yfWhQ6xrC91Zbj4ecyX3oVyCyGTSAbcgf8M4tjrsj8rpWRYxTDcRu68IE o9p3Iyt8jjoeZPy7J6tlcZFrktdJ724= X-MC-Unique: ruxyvtK-MzqJxJ2TAZbfrA-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Hawkins Jiawei , si-wei.liu@oracle.com, Jason Wang , Lei Yang Subject: [PATCH 3/3] vdpa net: follow VirtIO initialization properly at cvq isolation probing Date: Fri, 15 Sep 2023 19:03:22 +0200 Message-Id: <20230915170322.3076956-4-eperezma@redhat.com> In-Reply-To: <20230915170322.3076956-1-eperezma@redhat.com> References: <20230915170322.3076956-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694797454041100003 This patch solves a few issues. The most obvious is that the feature set was done previous to ACKNOWLEDGE | DRIVER status bit set. Current vdpa devices are permissive with this, but it is better to follow the standard. Signed-off-by: Eugenio P=C3=A9rez --- net/vhost-vdpa.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 51d8144070..4b30325977 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -1270,8 +1270,7 @@ static int vhost_vdpa_probe_cvq_isolation(int device_= fd, uint64_t features, uint64_t backend_features; int64_t cvq_group; uint8_t status =3D VIRTIO_CONFIG_S_ACKNOWLEDGE | - VIRTIO_CONFIG_S_DRIVER | - VIRTIO_CONFIG_S_FEATURES_OK; + VIRTIO_CONFIG_S_DRIVER; int r; =20 ERRP_GUARD(); @@ -1286,15 +1285,22 @@ static int vhost_vdpa_probe_cvq_isolation(int devic= e_fd, uint64_t features, return 0; } =20 + r =3D ioctl(device_fd, VHOST_VDPA_SET_STATUS, &status); + if (unlikely(r)) { + error_setg_errno(errp, -r, "Cannot set device status"); + goto out; + } + r =3D ioctl(device_fd, VHOST_SET_FEATURES, &features); if (unlikely(r)) { - error_setg_errno(errp, errno, "Cannot set features"); + error_setg_errno(errp, -r, "Cannot set features"); goto out; } =20 + status |=3D VIRTIO_CONFIG_S_FEATURES_OK; r =3D ioctl(device_fd, VHOST_VDPA_SET_STATUS, &status); if (unlikely(r)) { - error_setg_errno(errp, -r, "Cannot set status"); + error_setg_errno(errp, -r, "Cannot set device status"); goto out; } =20 --=20 2.39.3