[v2] hw/mips/jazz: Rework the NIC init code

[PATCH v2 0/2] hw/mips/jazz: Rework the NIC init code

Thomas Huth posted 2 patches 8 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230913160922.355640-1-thuth@redhat.com

Maintainers: "Hervé Poussineau" <hpoussin@reactos.org>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>

hw/mips/jazz.c | 81 ++++++++++++++++++++++++--------------------------
1 file changed, 39 insertions(+), 42 deletions(-)

Expand all Fold all

[PATCH v2 0/2] hw/mips/jazz: Rework the NIC init code

Posted by Thomas Huth 8 months ago

The NIC init code of the jazz machines is rather cumbersome, with
a for-loop around it that is always left after the first iteration.
This patch series reworks this a little bit to make the code more
readable and shorter.

v2:
- Dropped the first patch from v1 since it has been solved
  differently by the patch "trivial: Simplify the spots that
  use TARGET_BIG_ENDIAN as a numeric value" recently
- Rebased the code on top of that RARGET_BIG_ENDIAN change

Thomas Huth (2):
  hw/mips/jazz: Move the NIC init code into a separate function
  hw/mips/jazz: Simplify the NIC setup code

 hw/mips/jazz.c | 81 ++++++++++++++++++++++++--------------------------
 1 file changed, 39 insertions(+), 42 deletions(-)

-- 
2.41.0

Re: [PATCH v2 0/2] hw/mips/jazz: Rework the NIC init code

Posted by Philippe Mathieu-Daudé 8 months ago

On 13/9/23 18:09, Thomas Huth wrote:

> Thomas Huth (2):
>    hw/mips/jazz: Move the NIC init code into a separate function
>    hw/mips/jazz: Simplify the NIC setup code

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>