hw/intc/pnv_xive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
As reported by Coverity, "idx << xive->pc_shift" is evaluated using
32-bit arithmetic, and then used in a context expecting a "uint64_t".
Add a uint64_t cast.
Fixes: Coverity CID 1519049
Fixes: b68147b7a5bf ("ppc/xive: Add support for the PC MMIOs")
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/intc/pnv_xive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c
index 9b10e905195a..a36b3bf08c92 100644
--- a/hw/intc/pnv_xive.c
+++ b/hw/intc/pnv_xive.c
@@ -210,7 +210,7 @@ static uint64_t pnv_xive_vst_addr_remote(PnvXive *xive, uint32_t type,
return 0;
}
- remote_addr |= idx << xive->pc_shift;
+ remote_addr |= ((uint64_t) idx) << xive->pc_shift;
vst_addr = address_space_ldq_be(&address_space_memory, remote_addr,
MEMTXATTRS_UNSPECIFIED, &result);
--
2.41.0
On Wed, 13 Sept 2023 at 06:57, Cédric Le Goater <clg@kaod.org> wrote: > > As reported by Coverity, "idx << xive->pc_shift" is evaluated using > 32-bit arithmetic, and then used in a context expecting a "uint64_t". > Add a uint64_t cast. > > Fixes: Coverity CID 1519049 > Fixes: b68147b7a5bf ("ppc/xive: Add support for the PC MMIOs") > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- > hw/intc/pnv_xive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c > index 9b10e905195a..a36b3bf08c92 100644 > --- a/hw/intc/pnv_xive.c > +++ b/hw/intc/pnv_xive.c > @@ -210,7 +210,7 @@ static uint64_t pnv_xive_vst_addr_remote(PnvXive *xive, uint32_t type, > return 0; > } > > - remote_addr |= idx << xive->pc_shift; > + remote_addr |= ((uint64_t) idx) << xive->pc_shift; Nit: our coding style doesn't want a space after the '(uint64_t)'. thanks -- PMM
On 13/09/2023 07:56, Cédric Le Goater wrote: > As reported by Coverity, "idx << xive->pc_shift" is evaluated using > 32-bit arithmetic, and then used in a context expecting a "uint64_t". > Add a uint64_t cast. > > Fixes: Coverity CID 1519049 > Fixes: b68147b7a5bf ("ppc/xive: Add support for the PC MMIOs") > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com> > hw/intc/pnv_xive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c > index 9b10e905195a..a36b3bf08c92 100644 > --- a/hw/intc/pnv_xive.c > +++ b/hw/intc/pnv_xive.c > @@ -210,7 +210,7 @@ static uint64_t pnv_xive_vst_addr_remote(PnvXive *xive, uint32_t type, > return 0; > } > > - remote_addr |= idx << xive->pc_shift; > + remote_addr |= ((uint64_t) idx) << xive->pc_shift; > > vst_addr = address_space_ldq_be(&address_space_memory, remote_addr, > MEMTXATTRS_UNSPECIFIED, &result);
On 13/9/23 07:56, Cédric Le Goater wrote: > As reported by Coverity, "idx << xive->pc_shift" is evaluated using > 32-bit arithmetic, and then used in a context expecting a "uint64_t". > Add a uint64_t cast. > > Fixes: Coverity CID 1519049 > Fixes: b68147b7a5bf ("ppc/xive: Add support for the PC MMIOs") > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- > hw/intc/pnv_xive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
© 2016 - 2024 Red Hat, Inc.