.gitlab-ci.d/cirrus.yml | 4 +++- .gitlab-ci.d/cirrus/build.yml | 2 ++ tests/qtest/libqtest.c | 7 +++++++ tests/qtest/microbit-test.c | 2 ++ 4 files changed, 14 insertions(+), 1 deletion(-)
This addresses https://gitlab.com/qemu-project/qemu/-/issues/1882 Which turned out to be a genuine flaw which we missed during merge as the patch hitting master co-incided with the FreeBSD CI job having an temporary outage due to changed release image version. Daniel P. Berrangé (4): microbit: add missing qtest_quit() call qtest: kill orphaned qtest QEMU processes on FreeBSD gitlab: make Cirrus CI timeout explicit gitlab: make Cirrus CI jobs gating .gitlab-ci.d/cirrus.yml | 4 +++- .gitlab-ci.d/cirrus/build.yml | 2 ++ tests/qtest/libqtest.c | 7 +++++++ tests/qtest/microbit-test.c | 2 ++ 4 files changed, 14 insertions(+), 1 deletion(-) -- 2.41.0
On 12/09/2023 20.41, Daniel P. Berrangé wrote: > This addresses > > https://gitlab.com/qemu-project/qemu/-/issues/1882 > > Which turned out to be a genuine flaw which we missed during merge > as the patch hitting master co-incided with the FreeBSD CI job > having an temporary outage due to changed release image version. > > Daniel P. Berrangé (4): > microbit: add missing qtest_quit() call > qtest: kill orphaned qtest QEMU processes on FreeBSD > gitlab: make Cirrus CI timeout explicit > gitlab: make Cirrus CI jobs gating > > .gitlab-ci.d/cirrus.yml | 4 +++- > .gitlab-ci.d/cirrus/build.yml | 2 ++ > tests/qtest/libqtest.c | 7 +++++++ > tests/qtest/microbit-test.c | 2 ++ > 4 files changed, 14 insertions(+), 1 deletion(-) > Series Reviewed-by: Thomas Huth <thuth@redhat.com> Alex, will you pick these up or shall I take them for my next PR? Or Stefan, do you want to apply these directly as a CI fix? Thomas
Thomas Huth <thuth@redhat.com> writes: > On 12/09/2023 20.41, Daniel P. Berrangé wrote: >> This addresses >> https://gitlab.com/qemu-project/qemu/-/issues/1882 >> Which turned out to be a genuine flaw which we missed during merge >> as the patch hitting master co-incided with the FreeBSD CI job >> having an temporary outage due to changed release image version. >> Daniel P. Berrangé (4): >> microbit: add missing qtest_quit() call >> qtest: kill orphaned qtest QEMU processes on FreeBSD >> gitlab: make Cirrus CI timeout explicit >> gitlab: make Cirrus CI jobs gating >> .gitlab-ci.d/cirrus.yml | 4 +++- >> .gitlab-ci.d/cirrus/build.yml | 2 ++ >> tests/qtest/libqtest.c | 7 +++++++ >> tests/qtest/microbit-test.c | 2 ++ >> 4 files changed, 14 insertions(+), 1 deletion(-) >> > > Series > Reviewed-by: Thomas Huth <thuth@redhat.com> > > Alex, will you pick these up or shall I take them for my next PR? Queued to testing/next, thanks. Do you have a patch to disable the borked avacado tests? Or maybe I should just include Philippe's fix? > Or Stefan, do you want to apply these directly as a CI fix? > > Thomas -- Alex Bennée Virtualisation Tech Lead @ Linaro
On 13/09/2023 10.48, Alex Bennée wrote: > > Thomas Huth <thuth@redhat.com> writes: > >> On 12/09/2023 20.41, Daniel P. Berrangé wrote: >>> This addresses >>> https://gitlab.com/qemu-project/qemu/-/issues/1882 >>> Which turned out to be a genuine flaw which we missed during merge >>> as the patch hitting master co-incided with the FreeBSD CI job >>> having an temporary outage due to changed release image version. >>> Daniel P. Berrangé (4): >>> microbit: add missing qtest_quit() call >>> qtest: kill orphaned qtest QEMU processes on FreeBSD >>> gitlab: make Cirrus CI timeout explicit >>> gitlab: make Cirrus CI jobs gating >>> .gitlab-ci.d/cirrus.yml | 4 +++- >>> .gitlab-ci.d/cirrus/build.yml | 2 ++ >>> tests/qtest/libqtest.c | 7 +++++++ >>> tests/qtest/microbit-test.c | 2 ++ >>> 4 files changed, 14 insertions(+), 1 deletion(-) >>> >> >> Series >> Reviewed-by: Thomas Huth <thuth@redhat.com> >> >> Alex, will you pick these up or shall I take them for my next PR? > > Queued to testing/next, thanks. > > Do you have a patch to disable the borked avacado tests? Or maybe I > should just include Philippe's fix? I thought that Philippe mentioned that he wanted to provide a patch that disables the broken tests? Thomas
On 13/9/23 11:02, Thomas Huth wrote: > On 13/09/2023 10.48, Alex Bennée wrote: >> >> Thomas Huth <thuth@redhat.com> writes: >> >>> On 12/09/2023 20.41, Daniel P. Berrangé wrote: >>>> This addresses >>>> https://gitlab.com/qemu-project/qemu/-/issues/1882 >>>> Which turned out to be a genuine flaw which we missed during merge >>>> as the patch hitting master co-incided with the FreeBSD CI job >>>> having an temporary outage due to changed release image version. >>>> Daniel P. Berrangé (4): >>>> microbit: add missing qtest_quit() call >>>> qtest: kill orphaned qtest QEMU processes on FreeBSD >>>> gitlab: make Cirrus CI timeout explicit >>>> gitlab: make Cirrus CI jobs gating >>>> .gitlab-ci.d/cirrus.yml | 4 +++- >>>> .gitlab-ci.d/cirrus/build.yml | 2 ++ >>>> tests/qtest/libqtest.c | 7 +++++++ >>>> tests/qtest/microbit-test.c | 2 ++ >>>> 4 files changed, 14 insertions(+), 1 deletion(-) >>>> >>> >>> Series >>> Reviewed-by: Thomas Huth <thuth@redhat.com> >>> >>> Alex, will you pick these up or shall I take them for my next PR? >> >> Queued to testing/next, thanks. >> >> Do you have a patch to disable the borked avacado tests? Or maybe I >> should just include Philippe's fix? As we discussed with Richard yesterday, the fix is not correct. > I thought that Philippe mentioned that he wanted to provide a patch that > disables the broken tests? Yes, I'm still discussing a bit more on the other thread: https://lore.kernel.org/all/4e335f86-d075-4cc0-af5a-9dca9b3bf261@linaro.org/
On Wed, Sep 13, 2023 at 09:48:34AM +0100, Alex Bennée wrote: > > Thomas Huth <thuth@redhat.com> writes: > > > On 12/09/2023 20.41, Daniel P. Berrangé wrote: > >> This addresses > >> https://gitlab.com/qemu-project/qemu/-/issues/1882 > >> Which turned out to be a genuine flaw which we missed during merge > >> as the patch hitting master co-incided with the FreeBSD CI job > >> having an temporary outage due to changed release image version. > >> Daniel P. Berrangé (4): > >> microbit: add missing qtest_quit() call > >> qtest: kill orphaned qtest QEMU processes on FreeBSD > >> gitlab: make Cirrus CI timeout explicit > >> gitlab: make Cirrus CI jobs gating > >> .gitlab-ci.d/cirrus.yml | 4 +++- > >> .gitlab-ci.d/cirrus/build.yml | 2 ++ > >> tests/qtest/libqtest.c | 7 +++++++ > >> tests/qtest/microbit-test.c | 2 ++ > >> 4 files changed, 14 insertions(+), 1 deletion(-) > >> > > > > Series > > Reviewed-by: Thomas Huth <thuth@redhat.com> > > > > Alex, will you pick these up or shall I take them for my next PR? > > Queued to testing/next, thanks. > > Do you have a patch to disable the borked avacado tests? Or maybe I > should just include Philippe's fix? Not at this time. My hope was that this patch might address at least some of the broken tests: https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg02797.html but I ran out of time to test that yesterday. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Tue, 12 Sept 2023 at 14:41, Daniel P. Berrangé <berrange@redhat.com> wrote: > > This addresses > > https://gitlab.com/qemu-project/qemu/-/issues/1882 > > Which turned out to be a genuine flaw which we missed during merge > as the patch hitting master co-incided with the FreeBSD CI job > having an temporary outage due to changed release image version. > > Daniel P. Berrangé (4): > microbit: add missing qtest_quit() call > qtest: kill orphaned qtest QEMU processes on FreeBSD > gitlab: make Cirrus CI timeout explicit > gitlab: make Cirrus CI jobs gating > > .gitlab-ci.d/cirrus.yml | 4 +++- > .gitlab-ci.d/cirrus/build.yml | 2 ++ > tests/qtest/libqtest.c | 7 +++++++ > tests/qtest/microbit-test.c | 2 ++ > 4 files changed, 14 insertions(+), 1 deletion(-) Thank you! Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
© 2016 - 2024 Red Hat, Inc.